{"id":2222229,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222229/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260410230300.135631-3-carlos.bilbao@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.2/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260410230300.135631-3-carlos.bilbao@kernel.org>","list_archive_url":null,"date":"2026-04-10T23:03:00","name":"[v2,2/2] misc: pci_endpoint_test: remove dead BAR read before doorbell trigger","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"289bc0f4267a0b3d8b939698b10c6d07b6acd944","submitter":{"id":93050,"url":"http://patchwork.ozlabs.org/api/1.2/people/93050/?format=json","name":"Carlos Bilbao (Lambda)","email":"carlos.bilbao@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260410230300.135631-3-carlos.bilbao@kernel.org/mbox/","series":[{"id":499514,"url":"http://patchwork.ozlabs.org/api/1.2/series/499514/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=499514","date":"2026-04-10T23:02:59","name":"misc: pci_endpoint_test: doorbell BAR validation fixes","version":2,"mbox":"http://patchwork.ozlabs.org/series/499514/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222229/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222229/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n <linux-pci+bounces-52358-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=AoW3/9Cf;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52358-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"AoW3/9Cf\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fssnd1NQsz1yCx\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 09:04:37 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 451C23057D52\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 23:03:10 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 30C2A378831;\n\tFri, 10 Apr 2026 23:03:08 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E2EE3783CB;\n\tFri, 10 Apr 2026 23:03:07 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 708B6C2BCB0;\n\tFri, 10 Apr 2026 23:03:07 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775862188; cv=none;\n b=k66NTRZEnbW7etCSRvIlFAwuSjC8FqAdrfaqYTChP3XJDIUE826L6DbrHdDfE2qMfIIediUq6fwpa0JBkdDbEF8or1cVXpY7U8kDAEhNws5KpZVac7aY3jUyq7XJNQosnP0Kq2RUyhSEPhJFnC9SE4mipKtc7avkM5VafKuC2KA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775862188; c=relaxed/simple;\n\tbh=orC38s5pXuBhm6Fdof8xYniPptfpMYASy/IAuLznHD8=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=TjBzlLw5TalQ1tSO3WaylHIr40Ldj0hOxOJUsqH+Bl1CeygL/Q0LvUhoFQj7mhtQnhRdSgptE5mlbrOzH9HEQUemxys0p5LMjmUPYJn750SmP+ylRazZBxBfzB0nvZBFlnFUflBxUAEUO7fYqwtCkLeDQ5eR04KoAkYeTblRUzQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=AoW3/9Cf; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775862187;\n\tbh=orC38s5pXuBhm6Fdof8xYniPptfpMYASy/IAuLznHD8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AoW3/9CfYhYw/9oq+RGMcs9vWeKqw4E7p0tWAMCzHyc8zk0moKGBCW48iG0+bZav9\n\t 8FsLCm0SoCk0dcZmQAb050QRJCkt5MI/4Idq7OrgYvv3EsK7xf7+A6UQghu5xCZtVq\n\t WARvgWdr8BoeK0Fl/DT2dexx8PT4tVyelhKzC2m46NsmkJzfiWTIPTsSNmNlGqko7i\n\t pfqkEuzzTdo7K9VqHhmLEH9ZM7G7bys4aXXYCjCC8Jpcn5BubHUXvQkjsK8Eo/G0aJ\n\t 7E0pZLCJwtwsv3A/K9cKSYoRk0C2zRvpZncFJSI0xsfU4SZw7MmbmrQ2rKJvu2TvSz\n\t mQ+1fJoazRHiw==","From":"\"Carlos Bilbao (Lambda)\" <carlos.bilbao@kernel.org>","To":"mani@kernel.org,\n\tkwilczynski@kernel.org,\n\tkishon@kernel.org,\n\tden@valinux.co.jp","Cc":"arnd@arndb.de,\n\tgregkh@linuxfoundation.org,\n\tlinux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tbilbao@vt.edu,\n\tCarlos Bilbao <carlos.bilbao@kernel.org>","Subject":"[PATCH v2 2/2] misc: pci_endpoint_test: remove dead BAR read before\n doorbell trigger","Date":"Fri, 10 Apr 2026 16:03:00 -0700","Message-ID":"<20260410230300.135631-3-carlos.bilbao@kernel.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260410230300.135631-1-carlos.bilbao@kernel.org>","References":"<20260410230300.135631-1-carlos.bilbao@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Carlos Bilbao <carlos.bilbao@kernel.org>\n\nThe assignment before the writel sequence is dead code (bar is\nunconditionally overwritten by the re-read immediately after) so remove the\ncall entirely.\n\nNote that the DB_BAR register is a plain value written by the endpoint\nfirmware; reading it carries no side effect.\n\nSigned-off-by: Carlos Bilbao (Lambda) <carlos.bilbao@kernel.org>\nReviewed-by: Koichiro Den <den@valinux.co.jp>\n---\n drivers/misc/pci_endpoint_test.c | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c\nindex 0d0b430de0e8..7affab786ae4 100644\n--- a/drivers/misc/pci_endpoint_test.c\n+++ b/drivers/misc/pci_endpoint_test.c\n@@ -1081,7 +1081,6 @@ static int pci_endpoint_test_doorbell(struct pci_endpoint_test *test)\n \n \tdata = pci_endpoint_test_readl(test, PCI_ENDPOINT_TEST_DB_DATA);\n \taddr = pci_endpoint_test_readl(test, PCI_ENDPOINT_TEST_DB_OFFSET);\n-\tbar = pci_endpoint_test_readl(test, PCI_ENDPOINT_TEST_DB_BAR);\n \n \tpci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_TYPE, irq_type);\n \tpci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_NUMBER, 1);\n","prefixes":["v2","2/2"]}