{"id":2221851,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221851/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260410120318.187521447@kernel.org/","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/1.2/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260410120318.187521447@kernel.org>","list_archive_url":null,"date":"2026-04-10T12:19:12","name":"[09/38] iommu/vt-d: Use sched_clock() instead of get_cycles()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f59b608f4a2e6723b88c96c72e39b6b1a207985f","submitter":{"id":92397,"url":"http://patchwork.ozlabs.org/api/1.2/people/92397/?format=json","name":"Thomas Gleixner","email":"tglx@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260410120318.187521447@kernel.org/mbox/","series":[{"id":499451,"url":"http://patchwork.ozlabs.org/api/1.2/series/499451/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/list/?series=499451","date":"2026-04-10T12:18:27","name":"treewide: Cleanup LATCH, CLOCK_TICK_RATE and get_cycles() [ab]use","version":1,"mbox":"http://patchwork.ozlabs.org/series/499451/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221851/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221851/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=pacXAmHL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=4p0j=cj=vger.kernel.org=linux-ext4+bounces-15744-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c15:e001:75::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=pacXAmHL;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15744-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"pacXAmHL\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsbdh4pDZz1yGb\n\tfor ; Fri, 10 Apr 2026 22:26:48 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fsbdh4CXcz4wLx\n\tfor ; Fri, 10 Apr 2026 22:26:48 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fsbdh46JBz4wTD; Fri, 10 Apr 2026 22:26:48 +1000 (AEST)","from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fsbdd0Pftz4wLx\n\tfor ; Fri, 10 Apr 2026 22:26:45 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 09FB7306A486\n\tfor ; Fri, 10 Apr 2026 12:20:41 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id CED893CE49F;\n\tFri, 10 Apr 2026 12:19:15 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F9463BFE40;\n\tFri, 10 Apr 2026 12:19:15 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 8BE3EC2BC87;\n\tFri, 10 Apr 2026 12:19:14 +0000 (UTC)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775824008; cv=pass;\n\tb=VEpkgVkAf6iAbD+EXOzZz9rIb5SPTCVeae5RJiG3FwheqnXleJaEvOc2E+eSW8YgFZP6q8kkpX7XvUoG0eAdAQMtLn9QBrFDRD0eDiBvwmi608Tdt3sxFTxU4s20hte0rkmAo3Ve15G83WrTl+47NFV5TlTZCcdwwOJ6J+qaRINOOIt6G3YeBmvhk44zjluolBqy2rLVgo0bLEZqVU456vls+sPNenvVogi6tq9fxUCWAEIKRjqGhsVYd6vPabw1lDZcKn7bu6iNAEhU0y857lp9an9CQldvMglGKLxLSjbyVJE2gzbt/NP7SNWhxcF5ydqyAWxT5jOuKW8Nc2n9sg==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775823555; cv=none;\n b=UPss8nVAuMTAN3pnwUYX6yCZ7+jJvr73arfBZPYO+xfwireSSUjyXhJH5TGQ2piRT0WZ92UY7H4aQYrc7Qc8Cit5Y9Q5MA5vJJm9sY507ms2K6bYHWG+JcnaZWwfSTv1kk9NrryoJL3WAkgfkOi6yy0gieHgOqbowiG02E8toGI="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775824008; c=relaxed/relaxed;\n\tbh=P2IEyAEzLrLcDKf1D+hPXmSP/5CZZgHCZVdt+e9rGY8=;\n\th=Date:Message-ID:From:To:Cc:Subject:References:MIME-Version:\n\t Content-Type;\n b=jCMhgF7epMSxKGZoWKsCGC8URhzXnufWWC7B8izzc00iy0V3SR66AsLslpbEdDtNNAHVVtFVtaMPcbWEtUWfDINF4cYv9lSZqr0epBzwOnT3jpNcmrulFn+3eZ8vh3NDo6GUn5yiVcJW2KqcKzntkZIfq+PdyYa48lLGn8G56h+TBpbtIFde0k90aI3MMI1Eyg1WU0J+E4NYVeevB0WQD84X1/aAeyHvlkufOK7I0B6LLzpH4Vvdw8uj2e9dg8YLLSW5GpsybTWxIpMmzyCr+4nxlJW60NZSyL9w6OWU1F6CdxPKBWYiUrAtsxbeguw4wPPHcWK018OO4fOItz/AtQ==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775823555; c=relaxed/simple;\n\tbh=qtG4jYoFMBUH8Rv5LkkLsBrvbBwuDbTX1269QfkLCzw=;\n\th=Date:Message-ID:From:To:Cc:Subject:References:MIME-Version:\n\t Content-Type;\n b=NuZWGs7c9F/nxYYh4xjAHr15mr+jzC5d2SbzM+zhw7jfOaF+82PzmSsSMf8h9ydKzttuf868rQzsgbwMXH/vxT5bnYS7OCppCwbArnZR/UoKblIV+tH7WwMhHqTjeR08UbE5jTwi+0XeOJrDD2f626jOLL4+5inCrBf4sWCCJtE="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=pacXAmHL; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15744-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=pacXAmHL; arc=none smtp.client-ip=10.30.226.201"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775823555;\n\tbh=qtG4jYoFMBUH8Rv5LkkLsBrvbBwuDbTX1269QfkLCzw=;\n\th=Date:From:To:Cc:Subject:References:From;\n\tb=pacXAmHLAMseTev4RAQUAZDfRzJFeJXjwMW3x14w8vUm7ybikBbtslQQu96s/8Sq0\n\t a3pcIexn/gzfbwI2qYLuXSTx/gSXbmVwhuUFKfTY31pSFVH71nhoebkIPAnwJfmArK\n\t tPmJiCD8oWRaoY6EByg0L3DGpV75oKKW/C5lmUUCoaSznEsjUHpS9yyQByZ5hUlH3x\n\t P8NYw39byMTR2ebfPveTfvTFbDgwqYFvegEj7/kJQbjlvVeppRrN8YtOduabfxNT6E\n\t Yw4oV6JDjGSLEpWghPJGJFmnCci2PXJh9wjpVWvhGUbODkplfUDbeuEJIVIN1zibiF\n\t mC2OEaJT1jHhg==","Date":"Fri, 10 Apr 2026 14:19:12 +0200","Message-ID":"<20260410120318.187521447@kernel.org>","User-Agent":"quilt/0.68","From":"Thomas Gleixner ","To":"LKML ","Cc":"x86@kernel.org,\n Lu Baolu ,\n iommu@lists.linux.dev,\n Arnd Bergmann ,\n Michael Grzeschik ,\n netdev@vger.kernel.org,\n linux-wireless@vger.kernel.org,\n Herbert Xu ,\n linux-crypto@vger.kernel.org,\n Vlastimil Babka ,\n linux-mm@kvack.org,\n David Woodhouse ,\n Bernie Thompson ,\n linux-fbdev@vger.kernel.org,\n \"Theodore Tso\" ,\n linux-ext4@vger.kernel.org,\n Andrew Morton ,\n Uladzislau Rezki ,\n Marco Elver ,\n Dmitry Vyukov ,\n kasan-dev@googlegroups.com,\n Andrey Ryabinin ,\n Thomas Sailer ,\n linux-hams@vger.kernel.org,\n \"Jason A. Donenfeld\" ,\n Richard Henderson ,\n linux-alpha@vger.kernel.org,\n Russell King ,\n linux-arm-kernel@lists.infradead.org,\n Catalin Marinas ,\n Huacai Chen ,\n loongarch@lists.linux.dev,\n Geert Uytterhoeven ,\n linux-m68k@lists.linux-m68k.org,\n Dinh Nguyen ,\n Jonas Bonn ,\n linux-openrisc@vger.kernel.org,\n Helge Deller ,\n linux-parisc@vger.kernel.org,\n Michael Ellerman ,\n linuxppc-dev@lists.ozlabs.org,\n Paul Walmsley ,\n linux-riscv@lists.infradead.org,\n Heiko Carstens ,\n linux-s390@vger.kernel.org,\n \"David S. Miller\" ,\n sparclinux@vger.kernel.org","Subject":"[patch 09/38] iommu/vt-d: Use sched_clock() instead of get_cycles()","References":"<20260410120044.031381086@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"},"content":"Calculating the timeout from get_cycles() is a historical leftover without\nany functional requirement.\n\nUse ktime_get() instead.\n\nSigned-off-by: Thomas Gleixner \nCc: x86@kernel.org\nCc: Lu Baolu \nCc: iommu@lists.linux.dev\n---\n arch/x86/include/asm/iommu.h | 3 ---\n drivers/iommu/intel/dmar.c | 4 ++--\n drivers/iommu/intel/iommu.h | 8 ++++++--\n 3 files changed, 8 insertions(+), 7 deletions(-)","diff":"--- a/arch/x86/include/asm/iommu.h\n+++ b/arch/x86/include/asm/iommu.h\n@@ -18,9 +18,6 @@ extern bool x86_swiotlb_enable;\n #define x86_swiotlb_enable false\n #endif\n \n-/* 10 seconds */\n-#define DMAR_OPERATION_TIMEOUT ((cycles_t) tsc_khz*10*1000)\n-\n static inline int __init\n arch_rmrr_sanity_check(struct acpi_dmar_reserved_memory *rmrr)\n {\n--- a/drivers/iommu/intel/dmar.c\n+++ b/drivers/iommu/intel/dmar.c\n@@ -1606,9 +1606,9 @@ void qi_flush_pasid_cache(struct intel_i\n */\n void dmar_disable_qi(struct intel_iommu *iommu)\n {\n+\tktime_t start_time = ktime_get();\n \tunsigned long flags;\n \tu32 sts;\n-\tcycles_t start_time = get_cycles();\n \n \tif (!ecap_qis(iommu->ecap))\n \t\treturn;\n@@ -1624,7 +1624,7 @@ void dmar_disable_qi(struct intel_iommu\n \t */\n \twhile ((readl(iommu->reg + DMAR_IQT_REG) !=\n \t\treadl(iommu->reg + DMAR_IQH_REG)) &&\n-\t\t(DMAR_OPERATION_TIMEOUT > (get_cycles() - start_time)))\n+\t (DMAR_OPERATION_TIMEOUT > (ktime_get() - start_time)))\n \t\tcpu_relax();\n \n \tiommu->gcmd &= ~DMA_GCMD_QIE;\n--- a/drivers/iommu/intel/iommu.h\n+++ b/drivers/iommu/intel/iommu.h\n@@ -23,6 +23,7 @@\n #include \n #include \n #include \n+#include \n #include \n \n #include \n@@ -360,14 +361,17 @@\n /* PERFINTRSTS_REG */\n #define DMA_PERFINTRSTS_PIS\t((u32)1)\n \n+#define DMAR_OPERATION_TIMEOUT (((ktime_t)10) * NSEC_PER_SEC)\n+\n #define IOMMU_WAIT_OP(iommu, offset, op, cond, sts)\t\t\t\\\n do {\t\t\t\t\t\t\t\t\t\\\n-\tcycles_t start_time = get_cycles();\t\t\t\t\\\n+\tktime_t start_time = ktime_get();\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n \twhile (1) {\t\t\t\t\t\t\t\\\n \t\tsts = op(iommu->reg + offset);\t\t\t\t\\\n \t\tif (cond)\t\t\t\t\t\t\\\n \t\t\tbreak;\t\t\t\t\t\t\\\n-\t\tif (DMAR_OPERATION_TIMEOUT < (get_cycles() - start_time))\\\n+\t\tif (DMAR_OPERATION_TIMEOUT < (ktime_get() - start_time))\\\n \t\t\tpanic(\"DMAR hardware is malfunctioning\\n\");\t\\\n \t\tcpu_relax();\t\t\t\t\t\t\\\n \t}\t\t\t\t\t\t\t\t\\\n","prefixes":["09/38"]}