{"id":2221847,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221847/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260410120318.320727701@kernel.org/","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/1.2/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260410120318.320727701@kernel.org>","list_archive_url":null,"date":"2026-04-10T12:19:21","name":"[11/38] misc: sgi-gru: Remove get_cycles() [ab]use","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"10eec9b6f1f651211a03c914eb332f085db94ead","submitter":{"id":92397,"url":"http://patchwork.ozlabs.org/api/1.2/people/92397/?format=json","name":"Thomas Gleixner","email":"tglx@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260410120318.320727701@kernel.org/mbox/","series":[{"id":499451,"url":"http://patchwork.ozlabs.org/api/1.2/series/499451/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/list/?series=499451","date":"2026-04-10T12:18:27","name":"treewide: Cleanup LATCH, CLOCK_TICK_RATE and get_cycles() [ab]use","version":1,"mbox":"http://patchwork.ozlabs.org/series/499451/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221847/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221847/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=uunn/bCq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=roie=cj=vger.kernel.org=linux-ext4+bounces-15746-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.232.135.74 arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=uunn/bCq;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15746-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"uunn/bCq\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsbcs4BqJz1yGb\n\tfor ; Fri, 10 Apr 2026 22:26:05 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fsbcs3kG8z4wJS\n\tfor ; Fri, 10 Apr 2026 22:26:05 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fsbcs3dL6z4wT7; Fri, 10 Apr 2026 22:26:05 +1000 (AEST)","from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fsbcn5kDqz4wJS\n\tfor ; Fri, 10 Apr 2026 22:26:01 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 856D93044982\n\tfor ; Fri, 10 Apr 2026 12:21:25 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id EA0F63D1709;\n\tFri, 10 Apr 2026 12:19:25 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A1B0F3C6A5F;\n\tFri, 10 Apr 2026 12:19:25 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 1A057C2BCB3;\n\tFri, 10 Apr 2026 12:19:24 +0000 (UTC)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775823965; cv=pass;\n\tb=wyqgBfFbqmJ0bOaSyOCJlu6Z+J6AIEtnEd3Le7sRBBA5og/UGZABqKuiWpNjjx7TOjz5PiSnTOWyIaZHnMVS8W6k5Dz3ZP1NIb90kBJaLSlLT+b+CnSQCu8phHnhxgSApVuKI1pfY2eC4cjnNm+wQxBPKY/ybWQYM2Z4qL8gPC575M4xJZ7fu28WQF9vzAu87R5fDI8AST4HL9FVjKdCoYZpk3NTgmcFDZfWh/O8LSLq11zMmApouBSUoVI6JiNUo/SK0xf1siPw1NVUyE9KMwuc+S+qBcx/5vm0rBk73ERMl8RWHqgfXr0RX6WYixAydWZGLNityTIBj0W5v6XXlA==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775823565; cv=none;\n b=khBC9WsQQp4PBB1nP7lNqMcne0HAzWXEi5O1gcXdEeLR0ZhlpN5hMFWt/o1CmLVsckQEogH0ow50GK+/O0c8Wq9Y40bfolcOP9m2unAGdXrcFWeNAhrhGWZKJxhP1oe8+IBtod6MEvW9mW/MkMkG/nMGWr7BB9+RP9YxrZ+sVZg="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775823965; c=relaxed/relaxed;\n\tbh=95Xzu/wrSKdgPqpES5U3P7913oi5C0HtUtRZ8A2JYug=;\n\th=Date:Message-ID:From:To:Subject:References:MIME-Version:\n\t Content-Type:cc;\n b=Q6BdTOpTwJjyT7WUcgOjm4qDBLJ2laNbDSobda7cf+obrKc8W+M8MTmKBWm0pO+ArCAvM0JchH4s2ptSyhU2CU2dbioK/CgvmoqVQUi0Q7YwO38k2zVOLKaqh1jU9sH9FAYvBxZomFrdeVTLCIsBG/JyjJBIPxfYwVA5W+UWA65pjBs8la0K5Z/rVEybsmYI2hU7FP8ZfLfriJaJVRPnAcTg7FRSKmorrYAdnG8L2Cob0dgLxMQ3IgdpD+My2GOaFMtD4W+3mRH3fc/g6w4XRwR0CeQ12uCbC9u9u/bBhaK6I23Wuo2C6e4EsAKdRK866RkQLR5tkPoPKx7XIkeGCg==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775823565; c=relaxed/simple;\n\tbh=tLIpqPCaUi8Lfeqau43+rfn7UZ8vuvPykTPYNUPuuyU=;\n\th=Date:Message-ID:From:To:Subject:References:MIME-Version:\n\t Content-Type:cc;\n b=Jres9KWGihZd5HOXSG0kMYg/4Kndf3yrmtzyIvjR5YFsu6dLX5IaSU3wf8SIcDtfqUKAy+d493f3WHmB60G3yl2Clu7iiM9Dur0GEYVGUHS1Nh5D1erBf4kZRN1ikcJq6ypIDGcNahOSK3yUgwUtC2EOerc+gStYHuNFV3cYUO0="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=uunn/bCq; dkim-atps=neutral;\n spf=pass (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15746-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=uunn/bCq; arc=none smtp.client-ip=10.30.226.201"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775823565;\n\tbh=tLIpqPCaUi8Lfeqau43+rfn7UZ8vuvPykTPYNUPuuyU=;\n\th=Date:From:To:Subject:References:cc:From;\n\tb=uunn/bCqpDYdqH3aqiI0+2U/qm27AeTQwxnXbKYibcvcv2ZEX2J7abPlER3gpmuTw\n\t CBdP5mMh40n2zp7Tno2Q99U//gHXFdOV0IBNQapDNZb3rSYwBD5TySsxa/Td7SLyaZ\n\t p+uL6Iv9jGq9ZtmZnt8i06X/J571L31cWnZuiDLMRsOKbpHdih8iJDMdVxjdr+94oH\n\t +kfrO2pFRZtB2b/jp8TX3WQWaL7ksYC/uaT6tTAybV37imt1fhiAkDjh2EPTnuViku\n\t 1P4aDmEJtrdQSxbhtiFRIYbjrzGEHTE4V2Fb8MxeAUFtdhNoavN7essScQIWwWoRqs\n\t j/BFBM5JmmtDw==","Date":"Fri, 10 Apr 2026 14:19:21 +0200","Message-ID":"<20260410120318.320727701@kernel.org>","User-Agent":"quilt/0.68","From":"Thomas Gleixner ","To":"LKML ","Subject":"[patch 11/38] misc: sgi-gru: Remove get_cycles() [ab]use","References":"<20260410120044.031381086@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","cc":"Arnd Bergmann ,\n x86@kernel.org,\n Lu Baolu ,\n iommu@lists.linux.dev,\n Michael Grzeschik ,\n netdev@vger.kernel.org,\n linux-wireless@vger.kernel.org,\n Herbert Xu ,\n linux-crypto@vger.kernel.org,\n Vlastimil Babka ,\n linux-mm@kvack.org,\n David Woodhouse ,\n Bernie Thompson ,\n linux-fbdev@vger.kernel.org,\n \"Theodore Tso\" ,\n linux-ext4@vger.kernel.org,\n Andrew Morton ,\n Uladzislau Rezki ,\n Marco Elver ,\n Dmitry Vyukov ,\n kasan-dev@googlegroups.com,\n Andrey Ryabinin ,\n Thomas Sailer ,\n linux-hams@vger.kernel.org,\n \"Jason A. Donenfeld\" ,\n Richard Henderson ,\n linux-alpha@vger.kernel.org,\n Russell King ,\n linux-arm-kernel@lists.infradead.org,\n Catalin Marinas ,\n Huacai Chen ,\n loongarch@lists.linux.dev,\n Geert Uytterhoeven ,\n linux-m68k@lists.linux-m68k.org,\n Dinh Nguyen ,\n Jonas Bonn ,\n linux-openrisc@vger.kernel.org,\n Helge Deller ,\n linux-parisc@vger.kernel.org,\n Michael Ellerman ,\n linuxppc-dev@lists.ozlabs.org,\n Paul Walmsley ,\n linux-riscv@lists.infradead.org,\n Heiko Carstens ,\n linux-s390@vger.kernel.org,\n \"David S. Miller\" ,\n sparclinux@vger.kernel.org","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"},"content":"Calculating a timeout from get_cycles() is a historical leftover without\nany functional requirement.\n\nUse ktime_get() instead.\n\nSigned-off-by: Thomas Gleixner \n---\n drivers/misc/sgi-gru/gruhandles.c | 20 ++++++++------------\n drivers/misc/sgi-gru/grukservices.c | 3 ++-\n drivers/misc/sgi-gru/grutlbpurge.c | 5 ++---\n 3 files changed, 12 insertions(+), 16 deletions(-)","diff":"--- a/drivers/misc/sgi-gru/gruhandles.c\n+++ b/drivers/misc/sgi-gru/gruhandles.c\n@@ -6,26 +6,22 @@\n */\n \n #include \n+#include \n #include \"gru.h\"\n #include \"grulib.h\"\n #include \"grutables.h\"\n \n-/* 10 sec */\n #include \n-#include \n-#define GRU_OPERATION_TIMEOUT\t((cycles_t) tsc_khz*10*1000)\n-#define CLKS2NSEC(c)\t\t((c) * 1000000 / tsc_khz)\n+\n+#define GRU_OPERATION_TIMEOUT_NSEC\t(((ktime_t)10 * NSEC_PER_SEC))\n \n /* Extract the status field from a kernel handle */\n #define GET_MSEG_HANDLE_STATUS(h)\t(((*(unsigned long *)(h)) >> 16) & 3)\n \n struct mcs_op_statistic mcs_op_statistics[mcsop_last];\n \n-static void update_mcs_stats(enum mcs_op op, unsigned long clks)\n+static void update_mcs_stats(enum mcs_op op, unsigned long nsec)\n {\n-\tunsigned long nsec;\n-\n-\tnsec = CLKS2NSEC(clks);\n \tatomic_long_inc(&mcs_op_statistics[op].count);\n \tatomic_long_add(nsec, &mcs_op_statistics[op].total);\n \tif (mcs_op_statistics[op].max < nsec)\n@@ -58,21 +54,21 @@ static void report_instruction_timeout(v\n \n static int wait_instruction_complete(void *h, enum mcs_op opc)\n {\n+\tktime_t start_time = ktime_get();\n \tint status;\n-\tunsigned long start_time = get_cycles();\n \n \twhile (1) {\n \t\tcpu_relax();\n \t\tstatus = GET_MSEG_HANDLE_STATUS(h);\n \t\tif (status != CCHSTATUS_ACTIVE)\n \t\t\tbreak;\n-\t\tif (GRU_OPERATION_TIMEOUT < (get_cycles() - start_time)) {\n+\t\tif (GRU_OP_TIMEOUT_NSEC < (ktime_get() - start_time)) {\n \t\t\treport_instruction_timeout(h);\n-\t\t\tstart_time = get_cycles();\n+\t\t\tstart_time = ktime_get();\n \t\t}\n \t}\n \tif (gru_options & OPT_STATS)\n-\t\tupdate_mcs_stats(opc, get_cycles() - start_time);\n+\t\tupdate_mcs_stats(opc, (unsigned long)(ktime_get() - start_time));\n \treturn status;\n }\n \n--- a/drivers/misc/sgi-gru/grukservices.c\n+++ b/drivers/misc/sgi-gru/grukservices.c\n@@ -20,6 +20,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \"gru.h\"\n #include \"grulib.h\"\n@@ -1106,7 +1107,7 @@ static int quicktest3(unsigned long arg)\n \tint ret = 0;\n \n \tmemset(buf2, 0, sizeof(buf2));\n-\tmemset(buf1, get_cycles() & 255, sizeof(buf1));\n+\tmemset(buf1, get_random_u32() & 255, sizeof(buf1));\n \tgru_copy_gpa(uv_gpa(buf2), uv_gpa(buf1), BUFSIZE);\n \tif (memcmp(buf1, buf2, BUFSIZE)) {\n \t\tprintk(KERN_DEBUG \"GRU:%d quicktest3 error\\n\", smp_processor_id());\n--- a/drivers/misc/sgi-gru/grutlbpurge.c\n+++ b/drivers/misc/sgi-gru/grutlbpurge.c\n@@ -22,13 +22,12 @@\n #include \n #include \n #include \n+#include \n #include \n #include \"gru.h\"\n #include \"grutables.h\"\n #include \n \n-#define gru_random()\tget_cycles()\n-\n /* ---------------------------------- TLB Invalidation functions --------\n * get_tgh_handle\n *\n@@ -49,7 +48,7 @@ static inline int get_off_blade_tgh(stru\n \tint n;\n \n \tn = GRU_NUM_TGH - gru->gs_tgh_first_remote;\n-\tn = gru_random() % n;\n+\tn = get_random_u32() % n;\n \tn += gru->gs_tgh_first_remote;\n \treturn n;\n }\n","prefixes":["11/38"]}