{"id":2221781,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221781/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260410112352.23599-5-fw@strlen.de/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.2/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260410112352.23599-5-fw@strlen.de>","list_archive_url":null,"date":"2026-04-10T11:23:45","name":"[net-next,04/11] netfilter: x_physdev: reject empty or not-nul terminated device names","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":true,"hash":"d39c8873651a39b585f084ade9c9c7b3b1191eec","submitter":{"id":1025,"url":"http://patchwork.ozlabs.org/api/1.2/people/1025/?format=json","name":"Florian Westphal","email":"fw@strlen.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260410112352.23599-5-fw@strlen.de/mbox/","series":[{"id":499444,"url":"http://patchwork.ozlabs.org/api/1.2/series/499444/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=499444","date":"2026-04-10T11:23:46","name":"[net-next,01/11] ipvs: show the current conn_tab size to users","version":1,"mbox":"http://patchwork.ozlabs.org/series/499444/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221781/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221781/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11800-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.216.245.30","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsZPQ4291z1yGS\n\tfor ; Fri, 10 Apr 2026 21:31:06 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 1E6C33080186\n\tfor ; Fri, 10 Apr 2026 11:24:18 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 791F139E162;\n\tFri, 10 Apr 2026 11:24:16 +0000 (UTC)","from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc\n [91.216.245.30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 16E61340A57;\n\tFri, 10 Apr 2026 11:24:14 +0000 (UTC)","by Chamillionaire.breakpoint.cc (Postfix, from userid 1003)\n\tid 93B8260490; Fri, 10 Apr 2026 13:24:13 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775820256; cv=none;\n b=ukGrJO6s6/ByyRKBnbDb1PQ34Dx4TzYK54LyCp6+uCAwVHYmT/hkuUrWTuLgkAX3Esww958gEhHuGRfplp9tEnfZp9xgUbJoiK5lcrl2MEU00a4r2fgdjJ+i7JpnHd5hRen4KWDNl/SyuA5Z/Wb2G4C6O+KaT5zG64k0XrkVvgw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775820256; c=relaxed/simple;\n\tbh=4XmxidoOF/y3Pc0J5mnUEYyng5coGfSki2nSQjs+Bjs=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=UL91jIf5opxBnrripWTX4xNjsGia05uqrSndnuH1RYJliIWrGbSGnE+CIDj+dnshywWLajFP0+ZHSwVz6wnzdVHZgghRIvOMk9ejgvL2n7xw20GvciYqKck7/3gXQCMjyVZ4G33ea2atnuP8cJRKkNfYixlr420dhZZhF+O1jAw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc;\n arc=none smtp.client-ip=91.216.245.30","From":"Florian Westphal ","To":"","Cc":"Paolo Abeni ,\n\t\"David S. Miller\" ,\n\tEric Dumazet ,\n\tJakub Kicinski ,\n\t,\n\tpablo@netfilter.org","Subject":"[PATCH net-next 04/11] netfilter: x_physdev: reject empty or not-nul\n terminated device names","Date":"Fri, 10 Apr 2026 13:23:45 +0200","Message-ID":"<20260410112352.23599-5-fw@strlen.de>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260410112352.23599-1-fw@strlen.de>","References":"<20260410112352.23599-1-fw@strlen.de>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Reject names that lack a \\0 character and reject the empty string as\nwell. iptables allows this but it fails to re-parse iptables-save output\nthat contain such rules.\n\nSigned-off-by: Florian Westphal \n---\n net/netfilter/xt_physdev.c | 22 ++++++++++++++++++++++\n 1 file changed, 22 insertions(+)","diff":"diff --git a/net/netfilter/xt_physdev.c b/net/netfilter/xt_physdev.c\nindex 343e65f377d4..53997771013f 100644\n--- a/net/netfilter/xt_physdev.c\n+++ b/net/netfilter/xt_physdev.c\n@@ -107,6 +107,28 @@ static int physdev_mt_check(const struct xt_mtchk_param *par)\n \t\treturn -EINVAL;\n \t}\n \n+#define X(memb) strnlen(info->memb, sizeof(info->memb)) >= sizeof(info->memb)\n+\tif (info->bitmask & XT_PHYSDEV_OP_IN) {\n+\t\tif (info->physindev[0] == '\\0')\n+\t\t\treturn -EINVAL;\n+\t\tif (X(physindev))\n+\t\t\treturn -ENAMETOOLONG;\n+\t}\n+\n+\tif (info->bitmask & XT_PHYSDEV_OP_OUT) {\n+\t\tif (info->physoutdev[0] == '\\0')\n+\t\t\treturn -EINVAL;\n+\n+\t\tif (X(physoutdev))\n+\t\t\treturn -ENAMETOOLONG;\n+\t}\n+\n+\tif (X(in_mask))\n+\t\treturn -ENAMETOOLONG;\n+\tif (X(out_mask))\n+\t\treturn -ENAMETOOLONG;\n+#undef X\n+\n \tif (!brnf_probed) {\n \t\tbrnf_probed = true;\n \t\trequest_module(\"br_netfilter\");\n","prefixes":["net-next","04/11"]}