{"id":2221604,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221604/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260409220547.98528-1-francisco@maestretorreblanca.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.2/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260409220547.98528-1-francisco@maestretorreblanca.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260409220547.98528-1-francisco@maestretorreblanca.com/","date":"2026-04-09T22:05:47","name":"[2/4] macintosh: windfarm_ad7417: fix coding style issues","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"7df20dfce8b510f8d0a0ad23c4253e13f27a962c","submitter":{"id":93109,"url":"http://patchwork.ozlabs.org/api/1.2/people/93109/?format=json","name":"Francisco Maestre","email":"francisco@maestretorreblanca.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260409220547.98528-1-francisco@maestretorreblanca.com/mbox/","series":[{"id":499369,"url":"http://patchwork.ozlabs.org/api/1.2/series/499369/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=499369","date":"2026-04-09T22:05:47","name":null,"version":1,"mbox":"http://patchwork.ozlabs.org/series/499369/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221604/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221604/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=maestretorreblanca.com header.i=@maestretorreblanca.com\n header.a=rsa-sha256 header.s=google header.b=IfEhJqqY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19529-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::e29\"","lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=maestretorreblanca.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=maestretorreblanca.com header.i=@maestretorreblanca.com\n header.a=rsa-sha256 header.s=google header.b=IfEhJqqY;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=maestretorreblanca.com\n (client-ip=2607:f8b0:4864:20::e29; helo=mail-vs1-xe29.google.com;\n envelope-from=francisco@maestretorreblanca.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsGNQ0nzDz1xtJ\n\tfor ; Fri, 10 Apr 2026 09:29:09 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fsGNN41KPz2ydq;\n\tFri, 10 Apr 2026 09:29:08 +1000 (AEST)","from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com\n [IPv6:2607:f8b0:4864:20::e29])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fsDXR0mLfz2x9W\n\tfor ; Fri, 10 Apr 2026 08:05:57 +1000 (AEST)","by mail-vs1-xe29.google.com with SMTP id\n ada2fe7eead31-60580b17793so435787137.1\n for ;\n Thu, 09 Apr 2026 15:05:57 -0700 (PDT)","from localhost.localdomain ([181.199.46.166])\n by smtp.gmail.com with ESMTPSA id\n ada2fe7eead31-609d9285e3csm601039137.6.2026.04.09.15.05.52\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 09 Apr 2026 15:05:53 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775772360;\n\tcv=none;\n b=EQ5Q8CQzfvflJaACobyQ1sg80e4hN197llGlf6sumqpoBGD8ZdESK6fF2ZiaP8xXfGFvDnHIlRsnGA5TK+CjxCrMv5yCWAbbao3V/fl+UDlDfl3zk8a7kaPQR8XjrZYSpsAJDYBWym/Z1tEirttfqcRZhwaGvlLMOOSKCUB1x+LzP4W6a6j++HEb4hOp6oi5Q1EyQXXSLhVu0GbOdT0uCUqtdDnoAHRG1YGUewBcSgED+OS4qwBmxpgKcqVgqMc+GSKXWDD8UYIr8KXLJ1tSNs9nuismuqVuCYxhkz71VwsdeKJ0J4K9f9VT+p+4tDhSQA+axSdxfltCzhFNhbE6Jw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775772360; c=relaxed/relaxed;\n\tbh=a4OMZB2a7xCPpbigXykeThDkTesHby2EnBTmJsd83Nw=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=FJls6ZAXRTjrW3SsU1x7qplrGDDf2g9rfMYCaCxqDHcagJea9ZmrGixiKEZbsBCuh7gIQjdKzKIxOSisoKjB7sDS5Yahki8XJp6pXyeXy/sMZz/LDTzsObd3qWJHQVq/Haox1ERau06XGyvhGqW1r3H/+T1sEdxh4yB4fN2vGtQnPGgKbYOTNEtUY0kgm7BmAx4xLPkZRT4GG+4nl7Rn+g2jtUp4OMAAOF0MCbCeOXWd6TZvsry/FG89uU7E16fQPE1bIUA9MGb+sDjeN88I1WY76M3BxW5nZ3viUEbir2nKyy6x/nVX7enN0G6oHguEwBdM4TYSrZqMY8EpPK9pQQ==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=maestretorreblanca.com;\n dkim=pass (2048-bit key;\n secure) header.d=maestretorreblanca.com header.i=@maestretorreblanca.com\n header.a=rsa-sha256 header.s=google header.b=IfEhJqqY; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::e29; helo=mail-vs1-xe29.google.com;\n envelope-from=francisco@maestretorreblanca.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=maestretorreblanca.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=maestretorreblanca.com; s=google; t=1775772354; x=1776377154;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=a4OMZB2a7xCPpbigXykeThDkTesHby2EnBTmJsd83Nw=;\n b=IfEhJqqYXfBKSdbz0Jqtbz5yCbm+RZbYHIFXqhWVbEV9LPLEZSBpgMkxyp7eUzWkSn\n Tk3yv2jN2kdAbD6epHlXUJjApttAGNmabwZEovMm0P766HKNFaWD70mZk5mnSzYEH3Aa\n m2XLH7Rg22bfbZw/k8Uu5fn192rKvXfMEWZw1VEnVuTA/B5626ivuVDUUQVrIK6M8kMW\n fXcajmoyfeGxW+nIFmf7isyloBFEkYHyXAQHIEi2U96g5J6268Z2c6Cmz5ZfTLWtj1yh\n jGnpJRJreMicFFydD/y91WW6XwNcuLTDcUqiajz7wkeFkA27VRSCXjlYI5fToDRvNzuG\n knVQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775772354; x=1776377154;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=a4OMZB2a7xCPpbigXykeThDkTesHby2EnBTmJsd83Nw=;\n b=GkGJ5vtpxn5A3J9RyX4NLIwyJ8rWkrAGjX6xRfoZwQsM4qMM3P5SSxp7rnagVt8HBS\n n/VVCYUoKVuPRBGy7JIfSdTtHQmH4bGZFktlKARkfJIXfnjhOwgM66LTm+65RdMXr9gf\n CLvnzeX6sJeKC/3dFyS4gqxUz8XCz5pBRTq+eAJBfYOR/NwNHWR/TsvdVRJY3L/qoO2+\n W2wmQ/RCZWyvbjfkc8ehXfIwuKM48zJaa8JcOxRvjPrTEV2DuNuHgcIJQ9v4YH5TPkYs\n woZID6Ms2gGX8Xv/vdPe1NQ2zEi3OGJ5fxloW880Gx+I8z5+1rtsyqjIrkVHsMGry3Gv\n tl2Q==","X-Gm-Message-State":"AOJu0YyPuscYlW9mOYmAG6wGZMRrIh/r1pFDoN9MBnB7Jk0P2Sh2v9w5\n\t9nnG7z1sh6FG3bbY/agEIhah7qRvWbkrrsqoPiDZoUKnmIRFQY+zFOLDoM1kf2RB/ex2PVDEDdX\n\tXAFkROAz1Fw==","X-Gm-Gg":"AeBDiesAS9MI8pN158M5fiZTAB7iR6wQpDkwMBIxOWUrPFbEpN3haaOVgjAT6rdJ/me\n\trkGKbFK8oQCu3VU3fYbrM0yv2GtRXpI04PbgiPawO0lg8ig9ObpmMC8xjQ6KZON/BH98V37SN5d\n\t1aKBTAmyTk4Y2i1H1Xbb0e0E2CCjhT3csyu6gEegWx8yTK3WfaQJcPTbYDX0Y201BP/0W6vnWEZ\n\t9kZbNKi/O/v8Z4FF90bJ4b0Isi2Cju+2VAwO9e6z6nq5aP0QuNhr62OE79jcEXSYI0ZFtLMaNds\n\tGCZxdwOBPF9scPgbTEAH3f3pP4k7ofa4TTC1Pl+hnN9fIAM3+XsWBiQ9MdEvFI/9WLSUzCSVJ0l\n\tdO6+it2TXrFed+lFg96HqufM7OJ37OyouzXRFid0ecw/9R90BPYyM6tihwi/bO1257v5PdDz+jG\n\tVv12eJvmb/m7ASkR0ZxOdFvYmkn+lR9Ee4hMFtNHWNZRYxOLVIeFNVGFvIyUCMblN/R9kUi9fma\n\tOIXGXZlqz0d","X-Received":"by 2002:a05:6102:304b:b0:5ff:fbe4:8a4 with SMTP id\n ada2fe7eead31-60a00629e26mr283413137.21.1775772353725;\n Thu, 09 Apr 2026 15:05:53 -0700 (PDT)","From":"Francisco Maestre ","To":"linuxppc-dev@lists.ozlabs.org","Cc":"linux-kernel@vger.kernel.org,\n\tFrancisco Maestre ","Subject":"[PATCH 2/4] macintosh: windfarm_ad7417: fix coding style issues","Date":"Thu, 9 Apr 2026 17:05:47 -0500","Message-ID":"<20260409220547.98528-1-francisco@maestretorreblanca.com>","X-Mailer":"git-send-email 2.50.1","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Fix several coding style issues detected by checkpatch.pl:\n\n- Add missing space before open parenthesis in switch statement\n- Fix duplicated word 'a' in two comments ('a a' -> 'a')\n- Replace bare -1 return values with proper -EIO error code\n- Fix alignment of dev_dbg() argument continuation line\n- Use !ptr instead of ptr == NULL for NULL pointer check\n\nAssisted-by: Claude:claude-opus-4-5\nSigned-off-by: Francisco Maestre \n---\n drivers/macintosh/windfarm_ad7417_sensor.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/macintosh/windfarm_ad7417_sensor.c b/drivers/macintosh/windfarm_ad7417_sensor.c\nindex 4bae07ca6..733dc711c 100644\n--- a/drivers/macintosh/windfarm_ad7417_sensor.c\n+++ b/drivers/macintosh/windfarm_ad7417_sensor.c\n@@ -52,7 +52,7 @@ static int wf_ad7417_temp_get(struct wf_sensor *sr, s32 *value)\n \tif (rc < 0)\n \t\tgoto error;\n \n-\t/* Read a a 16-bit signed value */\n+\t/* Read a 16-bit signed value */\n \traw = be16_to_cpup((__le16 *)buf);\n \n \t/* Convert 8.8-bit to 16.16 fixed point */\n@@ -63,7 +63,7 @@ static int wf_ad7417_temp_get(struct wf_sensor *sr, s32 *value)\n \n error:\n \tmutex_unlock(&pv->lock);\n-\treturn -1;\n+\treturn -EIO;\n }\n \n /*\n@@ -79,7 +79,7 @@ static int wf_ad7417_temp_get(struct wf_sensor *sr, s32 *value)\n static void wf_ad7417_adc_convert(struct wf_ad7417_priv *pv,\n \t\t\t\t int chan, s32 raw, s32 *value)\n {\n-\tswitch(chan) {\n+\tswitch (chan) {\n \tcase 1: /* Diode */\n \t\t*value = (raw * (s32)pv->mpu->mdiode +\n \t\t\t((s32)pv->mpu->bdiode << 12)) >> 2;\n@@ -128,7 +128,7 @@ static int wf_ad7417_adc_get(struct wf_sensor *sr, s32 *value)\n \t\tif (rc < 0)\n \t\t\tgoto error;\n \n-\t\t/* Read a a 16-bit signed value */\n+\t\t/* Read a 16-bit signed value */\n \t\traw = be16_to_cpup((__le16 *)buf) >> 6;\n \t\twf_ad7417_adc_convert(pv, chan, raw, value);\n \n@@ -141,12 +141,12 @@ static int wf_ad7417_adc_get(struct wf_sensor *sr, s32 *value)\n \n \terror:\n \t\tdev_dbg(&pv->i2c->dev,\n-\t\t\t \"Error reading ADC, try %d...\\n\", i);\n+\t\t\t\"Error reading ADC, try %d...\\n\", i);\n \t\tif (i < 9)\n \t\t\tmsleep(10);\n \t}\n \tmutex_unlock(&pv->lock);\n-\treturn -1;\n+\treturn -EIO;\n }\n \n static void wf_ad7417_release(struct kref *ref)\n@@ -261,7 +261,7 @@ static int wf_ad7417_probe(struct i2c_client *client)\n \t}\n \n \tpv = kzalloc_obj(struct wf_ad7417_priv);\n-\tif (pv == NULL)\n+\tif (!pv)\n \t\treturn -ENODEV;\n \n \tkref_init(&pv->ref);\n","prefixes":["2/4"]}