{"id":2221551,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221551/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260409164440.323405-1-sebasjosue84@gmail.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260409164440.323405-1-sebasjosue84@gmail.com>","list_archive_url":null,"date":"2026-04-09T16:44:40","name":"net: nfs: fix buffer overflow in nfs_readlink_reply()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f70dfd822b7df2626133af7e36614995ab729d81","submitter":{"id":92955,"url":"http://patchwork.ozlabs.org/api/1.2/people/92955/?format=json","name":"Sebastian Alba Vives","email":"sebasjosue84@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260409164440.323405-1-sebasjosue84@gmail.com/mbox/","series":[{"id":499340,"url":"http://patchwork.ozlabs.org/api/1.2/series/499340/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=499340","date":"2026-04-09T16:44:40","name":"net: nfs: fix buffer overflow in nfs_readlink_reply()","version":1,"mbox":"http://patchwork.ozlabs.org/series/499340/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221551/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221551/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=ngQUpEaJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"ngQUpEaJ\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=sebasjosue84@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs7Mx2XFsz1yCv\n\tfor ; Fri, 10 Apr 2026 04:13:17 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 2C36384105;\n\tThu, 9 Apr 2026 20:12:29 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 10AE284099; Thu, 9 Apr 2026 18:44:59 +0200 (CEST)","from mail-vk1-xa2b.google.com (mail-vk1-xa2b.google.com\n [IPv6:2607:f8b0:4864:20::a2b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id EAA8983CF5\n for ; Thu, 9 Apr 2026 18:44:56 +0200 (CEST)","by mail-vk1-xa2b.google.com with SMTP id\n 71dfb90a1353d-56d9c4f7f0bso725533e0c.2\n for ; Thu, 09 Apr 2026 09:44:56 -0700 (PDT)","from localhost.localdomain ([2a09:bac1:76c0:1048::11:163])\n by smtp.gmail.com with ESMTPSA id\n 71dfb90a1353d-56d9bc9b75dsm22740384e0c.12.2026.04.09.09.44.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Apr 2026 09:44:54 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,\n FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775753095; x=1776357895; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=UszRydjgnil6xCBl66k6CnSI51I6E8fv26ecdhZ21os=;\n b=ngQUpEaJpY/WF5D/AWsTV69qXasMiMQMpnFdovbaeED6D+M5A64OJFJNGJGDrDDTYp\n 1Yxy7zc2oqw0oAyad1PfkQKJAZ7u04Ti2prMLvnIKYAugIlNQph79myULd/8kE3FcFQP\n HMt1cy2/H8SdO3TFOd0rO9W8dOT5sxYVqxltserHJaO41YuLEbt8cCEK9UCD/Bvzl5Nu\n xefG5KrRgBO1jj/zrjhQU35UHchVJwq2w/bsryxfX7PKHInCivzpG4FWJV79Rj8Yqjtp\n 62oouMrZoR/hybp+QQviIWBA1sT8twlZYuwh/VgdIzlMWn+gdgIavc6MrldFAag9huRO\n CmQA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775753095; x=1776357895;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=UszRydjgnil6xCBl66k6CnSI51I6E8fv26ecdhZ21os=;\n b=VQyMCvW/RParTZ6WIL9AcamkG9rdazHoksJWHpSzj6Ga3K1K8bjM3fn4pSLu0ftUz4\n +M3xLkdTKQuxyIFy84JlKjTOoGSnJ+j4KSoHfbXxu4gODtEd/u+vq+pvf2irj9K1mEB7\n rTa4KhC+fxPO4vOYwsCx/b8cayqj5CcOIqkm8672R5f5nM/I8i/4+grXRKSxtkg8HGLR\n EjVl5d+C326EpSHL5SqrXmfV+gC+1kZ2H6sDy+FTyJhgXwpJsjebCsDlUJHiml7n/Pt0\n GAg5L0KYqab3ncV9CRgJ583L0sF8XXgRjX/Yfh+vQQcLu2UcBWKTMS2pgB0B7adplt1j\n kmKQ==","X-Gm-Message-State":"AOJu0YxsA2w4XhHImSnUtORM5OMPExgp+WrJtJ3gjHJlrOuvTYupoYq1\n 12LXggSFALR19ix50IE/ehPW6EZdUHS63/EeTvD/T3A4d0aE1xtzmt9sqx+bftqQ","X-Gm-Gg":"AeBDieuv8OqoruChgNwgL4yX/VDbQRkcsdr/B2vR6zjezTKlWygVGDjJX8FjBzoDKt1\n aFP8xyjGsRVHlqogBVYrwG3r5R+ls7W8E+poQWEvWKu3jmQA5oLjJH8Iqp9AWDbunA6zRw1Bdqo\n WFcVSTazx+85R/0QM6hVPHev5qzs3GPaP5heldgA4pkCIx0DGq/fIoSwY2ScExFMNOiXICT2XYN\n 9chKDhaxJKvO7G3dSpoEia4NfGC2mPwNPn0On/hiVRc7Noiqe4ic0pQD5c4Jb20rXiYADpAOlVA\n uLN1sco/BNY2aQDvGvZU/r4T57d/wXrY0nizymt13BRVihD0KX6VF6oQ0t8dHFlftiRHjS/Q0zf\n MtwrWCDPSs7a/eR1ySsyOG9jorshitEtDnZdtsF9hy/Q4Dym+Zx253aOQu7IkB1i3Pq10bmi3W0\n ohj7m1zFYFRuzSxkKtZXitwhkiyg==","X-Received":"by 2002:a05:6122:4d0f:b0:56e:f2cb:190b with SMTP id\n 71dfb90a1353d-56ef2cb2ab1mr8821130e0c.0.1775753095396;\n Thu, 09 Apr 2026 09:44:55 -0700 (PDT)","From":"Sebastian Alba Vives ","To":"u-boot@lists.denx.de","Cc":"trini@konsulko.com, jerome.forissier@linaro.org, stable@vger.kernel.org,\n Sebastian Josue Alba Vives ","Subject":"[PATCH] net: nfs: fix buffer overflow in nfs_readlink_reply()","Date":"Thu, 9 Apr 2026 10:44:40 -0600","Message-ID":"<20260409164440.323405-1-sebasjosue84@gmail.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Approved-At":"Thu, 09 Apr 2026 20:12:28 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"From: Sebastian Josue Alba Vives \n\nnfs_readlink_reply() validates rlen only against the incoming packet\nlength (inherited from CVE-2019-14195), but not against the destination\nbuffer nfs_path_buff[2048]. A malicious NFS server can send a valid\nREADLINK reply where pathlen + rlen exceeds sizeof(nfs_path_buff),\noverflowing the BSS buffer into adjacent memory.\n\nThe recent fix in fd6e3d34097f addressed the same overflow class in\nnet/lwip/nfs.c but left the legacy path in net/nfs-common.c unpatched.\n\nAdd bounds checks before both memcpy calls in nfs_readlink_reply():\n- relative path branch: reject if pathlen + rlen >= sizeof(nfs_path_buff)\n- absolute path branch: reject if rlen >= sizeof(nfs_path_buff)\n\nFixes: cf3a4f1e86 (\"net: nfs: Fix CVE-2019-14195\")\nCc: stable@vger.kernel.org\nSigned-off-by: Sebastian Alba Vives \n---\n net/nfs-common.c | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/net/nfs-common.c b/net/nfs-common.c\nindex 4fbde67a..72d8fd82 100644\n--- a/net/nfs-common.c\n+++ b/net/nfs-common.c\n@@ -674,11 +674,15 @@ static int nfs_readlink_reply(uchar *pkt, unsigned int len)\n \n \t\tstrcat(nfs_path, \"/\");\n \t\tpathlen = strlen(nfs_path);\n+\t\tif (pathlen + rlen >= sizeof(nfs_path_buff))\n+\t\t\treturn -NFS_RPC_DROP;\n \t\tmemcpy(nfs_path + pathlen,\n \t\t (uchar *)&rpc_pkt.u.reply.data[2 + nfsv3_data_offset],\n \t\t rlen);\n \t\tnfs_path[pathlen + rlen] = 0;\n \t} else {\n+\t\tif (rlen >= sizeof(nfs_path_buff))\n+\t\t\treturn -NFS_RPC_DROP;\n \t\tmemcpy(nfs_path,\n \t\t (uchar *)&rpc_pkt.u.reply.data[2 + nfsv3_data_offset],\n \t\t rlen);\n","prefixes":[]}