{"id":2221548,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221548/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409175126.5921-3-armenon@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260409175126.5921-3-armenon@redhat.com>","list_archive_url":null,"date":"2026-04-09T17:51:25","name":"[v2,2/2] ui/vdagent: Use VMSTATE_GBYTEARRAY to safely migrate outbuf","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"12c3a1c0a90a3ac6fbcdbcbaec971e4d5cc6f58b","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/1.2/people/91136/?format=json","name":"Arun Menon","email":"armenon@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409175126.5921-3-armenon@redhat.com/mbox/","series":[{"id":499338,"url":"http://patchwork.ozlabs.org/api/1.2/series/499338/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499338","date":"2026-04-09T17:51:23","name":"migration/vmstate: Add VMState support to safely migrate GByteArray","version":2,"mbox":"http://patchwork.ozlabs.org/series/499338/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221548/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221548/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=bBKZcwTs;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=YtW+B2IZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs6xZ5CcTz1yHG\n\tfor ; Fri, 10 Apr 2026 03:53:54 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAtYR-0007zH-Ms; Thu, 09 Apr 2026 13:52:35 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAtYJ-0007yO-V3\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 13:52:29 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAtYI-0005Mx-9h\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 13:52:27 -0400","from mail-pf1-f199.google.com (mail-pf1-f199.google.com\n [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-391-VYcm7fs6NOG2jOMi3KslXQ-1; Thu, 09 Apr 2026 13:52:22 -0400","by mail-pf1-f199.google.com with SMTP id\n d2e1a72fcca58-82cf8dcd079so740301b3a.1\n for ; Thu, 09 Apr 2026 10:52:22 -0700 (PDT)","from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.110.202])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f0c52cf05sm27736b3a.61.2026.04.09.10.52.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Apr 2026 10:52:20 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775757145;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=LGW6d9MttlD6p2S8pWbgXC+RAAlUoZve1q7FzTGw8jA=;\n b=bBKZcwTssLKOaZvHKbtTof/Yh99hE2vnqfWfImtixCAppTQ+7jrLcw6RiY/Fk2poyEQLpp\n kgM61GX8HuIoOyMvcSjQxGaS57/g5QgrOGKU4ZbP39mjlYFBw2jdm7oG1SxiRX3lI2R1Tr\n Syp4OGI8RcNpZj8ctxH6ByUGlsmw17M=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775757141; x=1776361941; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LGW6d9MttlD6p2S8pWbgXC+RAAlUoZve1q7FzTGw8jA=;\n b=YtW+B2IZLZq6/UfhvixdNxBddnqsBGzIy34ugcSwScDFp8t9Djy1uGTm5lwC6DVpRA\n wOn8Vl/qQYbAPRm4dh3ZTxHHf6rCPbUzz/DG1eKldKFY1vnmvBylW9J1TkwEOjSWV/3Y\n Ue3v+AOj/VYS+MZ4IU2qHiLFt7g5KUiF9qJ0PeiwzYkSMefI7MlsADVfB9HoADusnj7N\n GzMIWKYGCIJTci+hUPhIghMLsShK++pHTTfRbUH7IO8PvMcbUKM1nhlCgKpe4LGfIoh8\n Y++ceH+jPJUUVyDjnQAP3FZqHZIS+j6HaEDmgGDiFsvQKyaiZlgcw33HivzoiBSKnic4\n mPWw=="],"X-MC-Unique":"VYcm7fs6NOG2jOMi3KslXQ-1","X-Mimecast-MFC-AGG-ID":"VYcm7fs6NOG2jOMi3KslXQ_1775757141","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775757141; x=1776361941;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=LGW6d9MttlD6p2S8pWbgXC+RAAlUoZve1q7FzTGw8jA=;\n b=HC+BdgM5TT20Bqc3CHtpcFF5Uu0lr1LhIHQ5pbJIySnpTLvyLxM2emYAh8cwnTqZ4Z\n 3EkQXZsNcKBD88Iusg4YcEGczS8Ep80fhxy6+Qhc+ch6DA1uqKPKnum9gnEkEzu27O1V\n eZp4/Ah9Da/ayuK9uS/A/iXrXivzWuim2fDsvdTSTyMXtKjmyMICKOmv4cVSVLvLzlDJ\n 2HJFTTWvHQzcozojaZWb244sWzgsozqtDWUO8mcD7TB7wxSgLhd6fXQlXUNeeYfj6h/n\n v4Rwsm+kw/BCiOfB/jnMvMTZZlABerW5cFc80Fui6XEoxwFqCSGZ24U7pYTiv4l3dAXa\n pKeA==","X-Gm-Message-State":"AOJu0Yw137L70SDujFbOb/N0P51KVfWMSYRIKhz/OP/7qkgv/VebC3JJ\n 6keTvpxyCbGYgm7D1eQig8veo3TyUeSoyHm3CMph2FNyyIaWp0t+L3xakLyIEEwoAjoQLTOiLRi\n vwWwmlIvf5BrD8pBYY89SJmQarjH+pNP/odWE27py3Hw9v0evp+ef6R8nyYc1zbjQGhrK/FcHUu\n AJXWLeLFz7Wt95V02oUVZHQOQpICe7OIsOBWOnRdo=","X-Gm-Gg":"AeBDietyAkiuJumQs4MFMYIbU/C7ZEv0yDlQzxVMcBI2TS7Bz2lD8L0bUCvyD5xZ2rA\n +ArCyzS4iCy1R3oedm0eXoRwNUXhl6McPNSvoo7F9IQ0sEv/BqOdtaVQ+KCy86rN+AuBxfdLI7y\n l8du/WpfnXMWUce/aMoRg0HJ0aw5GLpMD2uME2qZnd4NszhsfgNwk6yR60kihDFeODmoUkbTK1a\n G4h8YL0ePTXb7E6iwL18R6+C52MENO+TZ2UbHpBOkSHd3mcPTvw8qTM3n+82UON1HLhs/hQoPg9\n XO2GJo7nATCFNejp95p7pzlbOy3b5rlaJLPZXHiB1clgfcQYGIXVdKoxA60mXWNv4P9L6WW4XVz\n HcE/b5Pi6hVEfy95CzoNtMCx3cXZq62eE2YZj3b/jV8F4HZNIcWcRhF/1hnPmnqU=","X-Received":["by 2002:a05:6a00:369b:b0:82c:2468:a163 with SMTP id\n d2e1a72fcca58-82f0c22190cmr148701b3a.34.1775757141094;\n Thu, 09 Apr 2026 10:52:21 -0700 (PDT)","by 2002:a05:6a00:369b:b0:82c:2468:a163 with SMTP id\n d2e1a72fcca58-82f0c22190cmr148667b3a.34.1775757140390;\n Thu, 09 Apr 2026 10:52:20 -0700 (PDT)"],"From":"Arun Menon ","To":"qemu-devel@nongnu.org","Cc":"Fabiano Rosas ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Peter Xu , Arun Menon ","Subject":"[PATCH v2 2/2] ui/vdagent: Use VMSTATE_GBYTEARRAY to safely migrate\n outbuf","Date":"Thu, 9 Apr 2026 23:21:25 +0530","Message-ID":"<20260409175126.5921-3-armenon@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260409175126.5921-1-armenon@redhat.com>","References":"<20260409175126.5921-1-armenon@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Arun Menon \n\nMigrating a GLib GByteArray is now possible directly using the newly\nintroduced VMSTATE_GBYTEARRAY. It uses the standard GLib API calls to\ncreate the array, or resize it.\n\nThis is safer than implementing a C struct and manually updating the\ndata and len fields. This commit uses the VMSTATE_GBYTEARRAY in vdagent\nto store the outbuf variable.\n\nSigned-off-by: Arun Menon \nFix-Suggested-by: Marc-André Lureau \nReviewed-by: Marc-André Lureau \n---\n ui/vdagent.c | 13 +------------\n 1 file changed, 1 insertion(+), 12 deletions(-)","diff":"diff --git a/ui/vdagent.c b/ui/vdagent.c\nindex bb0c4aa14c..9206e47000 100644\n--- a/ui/vdagent.c\n+++ b/ui/vdagent.c\n@@ -967,17 +967,6 @@ static const VMStateDescription vmstate_chunk = {\n }\n };\n \n-static const VMStateDescription vmstate_vdba = {\n- .name = \"vdagent/bytearray\",\n- .version_id = 0,\n- .minimum_version_id = 0,\n- .fields = (const VMStateField[]) {\n- VMSTATE_UINT32(len, GByteArray),\n- VMSTATE_VBUFFER_ALLOC_UINT32(data, GByteArray, 0, 0, len),\n- VMSTATE_END_OF_LIST()\n- }\n-};\n-\n struct CBInfoArray {\n uint32_t n;\n QemuClipboardInfo cbinfo[QEMU_CLIPBOARD_SELECTION__COUNT];\n@@ -1067,7 +1056,7 @@ static const VMStateDescription vmstate_vdagent = {\n VMSTATE_UINT32(xsize, VDAgentChardev),\n VMSTATE_UINT32(xoff, VDAgentChardev),\n VMSTATE_VBUFFER_ALLOC_UINT32(xbuf, VDAgentChardev, 0, 0, xsize),\n- VMSTATE_STRUCT_POINTER(outbuf, VDAgentChardev, vmstate_vdba, GByteArray),\n+ VMSTATE_GBYTEARRAY(outbuf, VDAgentChardev, 0),\n VMSTATE_UINT32(mouse_x, VDAgentChardev),\n VMSTATE_UINT32(mouse_y, VDAgentChardev),\n VMSTATE_UINT32(mouse_btn, VDAgentChardev),\n","prefixes":["v2","2/2"]}