{"id":2221547,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221547/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409175126.5921-2-armenon@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260409175126.5921-2-armenon@redhat.com>","list_archive_url":null,"date":"2026-04-09T17:51:24","name":"[v2,1/2] migration/vmstate: Add VMState support for GByteArray","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fce2322d7ca6bbfc632567c38de719f07d260804","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/1.2/people/91136/?format=json","name":"Arun Menon","email":"armenon@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409175126.5921-2-armenon@redhat.com/mbox/","series":[{"id":499338,"url":"http://patchwork.ozlabs.org/api/1.2/series/499338/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499338","date":"2026-04-09T17:51:23","name":"migration/vmstate: Add VMState support to safely migrate GByteArray","version":2,"mbox":"http://patchwork.ozlabs.org/series/499338/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221547/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221547/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=HMVjA4Bu;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=lIEpnd3v;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs6xT4cF8z1yHG\n\tfor ; Fri, 10 Apr 2026 03:53:49 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAtYM-0007yd-FS; Thu, 09 Apr 2026 13:52:31 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAtYG-0007y4-L3\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 13:52:25 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAtYD-0005IT-7S\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 13:52:24 -0400","from mail-pg1-f198.google.com (mail-pg1-f198.google.com\n [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-212-qS3O6k_vPayOf1zwQI9HmA-1; Thu, 09 Apr 2026 13:52:18 -0400","by mail-pg1-f198.google.com with SMTP id\n 41be03b00d2f7-c76bb22a8ceso1393488a12.2\n for ; Thu, 09 Apr 2026 10:52:18 -0700 (PDT)","from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.110.202])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f0c52cf05sm27736b3a.61.2026.04.09.10.52.13\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Apr 2026 10:52:15 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775757140;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=OpxskO25poCqMwG8Rlk4qDtN3+z26Jd447w2s/nj4gc=;\n b=HMVjA4BuBZzygucCgmFCPxwIZVHI8wxqer3ujsumXtHcJIUW676R0FXHPj/LnmaU18wKIM\n 5PsqwhztTAtl3lugWPPYCRi5L2XjI3CkkfQlqRy63fHltoRRs7EiASuwGNX1RY55kvtv+4\n 8RJF9IuNsGgscEcYqadzPwL3n0dCwzM=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775757137; x=1776361937; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=OpxskO25poCqMwG8Rlk4qDtN3+z26Jd447w2s/nj4gc=;\n b=lIEpnd3vTifVmwEytBijN54/FeEKbJEtElD+PvBdvFRTIXahWNKulHbtaXUeKXXDbu\n lBK9DjcLkNEQb3pOedJyE3pKNYvTg4GCiRi8ZYPc4iVt0PDk123sHUh+HjYbLbKFgvhv\n 5qcIYvvBsKo63IDMlmOKxp0YkOc6mIAA1bQa+zQ0DiPWeZhai6Rf8kAbfTkzalWQefwZ\n vtFRdKVYxcNVcHrmZ/8yLOv2etbfAz9pM9VoQqkMY92c+d36Z5AcU57uziUyZkT3J5RP\n lucfBC7SR2DCh1Xhx6P7wVxJhkSWoi5945ZwHAiSgtk/Wvj38i1QDf7c0aldgwFE92k9\n qUGA=="],"X-MC-Unique":"qS3O6k_vPayOf1zwQI9HmA-1","X-Mimecast-MFC-AGG-ID":"qS3O6k_vPayOf1zwQI9HmA_1775757137","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775757137; x=1776361937;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=OpxskO25poCqMwG8Rlk4qDtN3+z26Jd447w2s/nj4gc=;\n b=ZONFm8AAZPkoEyH0WSMy1lvmb8551ujLDNTlRB/TsOYLtl0G5moNc8IFPtIKk016Cu\n GJ+JAIGxSWlir3TFBTMbb0yG42QNu1gZkHQoEaemQoBb1YiDp6CnkjSdG/mzWMl8RJtD\n TYULZ9mDbz+DaUW8MSvrsjbt7b0a/qS4IRKa40QV33AdbvDbAQ+7WejAB2PZ7TII54yN\n pmt64ylkG5PSdX13yVWQ6bGp+o2qFY5tOAgA04bzRMP8uJH1AU9NSEZZonKXOmDonzS8\n faTOxW0+5d71+mxIsshm+WL4x6hMIE1Z9fXmZHLpFCkxJ2FJxrTYyDOSwZI78qK+9nH5\n c6aw==","X-Gm-Message-State":"AOJu0YwluTGTDimJA63pVSFWbYsOkRr4Uqapo+Qo66Svx4f0JN1E9NtQ\n JO3tu12ihnZC5M9q44vY2Y+r00i5FFO4sNuoYoupjOgTVRNYkhRpRnI3iEO8BOEnzSPj12Bsuuy\n hfCMQ2N+GAAhbuIkAiKg2JgNKh3wRUh2OGDXtXOPorhR1v1R4YHV3AjvxRfFg2Vxa7/Dygii/Er\n POvGvsDqK+ziENyer97W45PNRensF87KPiGF/X81A=","X-Gm-Gg":"AeBDietuUXVLSFNVOYIxb2EJHsxTmwBzhkssWjjLSHofSzXNGmM2F/Eo4U13dxinVGA\n ZKz1iH5pX7m1+8kCKrhR9zSqtRj2RlYVTOLkrej0QlGuAe87HmaevVjqp6WOCmlT+OfdXOgnVb5\n Tr0aWZUteLvRyJ4ULCmE6wbtii1q98m/tA3b63qr+Ck7CW4Mq3FLWSSwuTr08uR5wJY4Ai+dNO3\n iP+GETwLfk/5rcRhWCzdCKPdlYtkGZ7kAko/dAXPibjv/ka9TpokWDcTQ+nPBuB03jDLTDD+F2a\n qlrhgXSeHfLXV7v0Ur66KrUXWABwnYDbF+CaZhHvSR+8iPVmWRBSVZ9lgZY2sjG49B/DgPvjfik\n 3OVcExcMEJudkcLaQFS+pwJkXSHhLcrLGS+zArw1eWyqF0Y0RiWbk5PP1LqMTOfM=","X-Received":["by 2002:a05:6a00:3907:b0:81f:31c3:2e34 with SMTP id\n d2e1a72fcca58-82f0c29fed7mr140580b3a.25.1775757137098;\n Thu, 09 Apr 2026 10:52:17 -0700 (PDT)","by 2002:a05:6a00:3907:b0:81f:31c3:2e34 with SMTP id\n d2e1a72fcca58-82f0c29fed7mr140540b3a.25.1775757136342;\n Thu, 09 Apr 2026 10:52:16 -0700 (PDT)"],"From":"Arun Menon ","To":"qemu-devel@nongnu.org","Cc":"Fabiano Rosas ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Peter Xu , Arun Menon ","Subject":"[PATCH v2 1/2] migration/vmstate: Add VMState support for GByteArray","Date":"Thu, 9 Apr 2026 23:21:24 +0530","Message-ID":"<20260409175126.5921-2-armenon@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260409175126.5921-1-armenon@redhat.com>","References":"<20260409175126.5921-1-armenon@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Arun Menon \n\nIn GLib, GByteArray is an object managed by the library. Currently,\nmigrating a GByteArray requires treating it as a raw C struct and using\nVMSTATE_VBUFFER_ALLOC_UINT32. For example, see vmstate_vdba in\nui/vdagent.c\n\nQEMU cannot pretend that GByteArray is a C struct and simply use\nVMS_ALLOC to g_malloc() the buffer. This is because, VMS_ALLOC blindly\noverwrites the data pointer with a newly allocated buffer, thereby\nleaking the previous memory. Besides, GLib tracks the array's capacity\nin a hidden alloc field. Bypassing GLib APIs leave this capacity out of\nsync with the newly allocated buffer, potentially leading to heap buffer\noverflows during subsequent g_byte_array_append() calls.\n\nThis commit introduces VMSTATE_GBYTEARRAY which uses specific library\nAPI calls (g_byte_array_set_size()) to safely resize and populate the\nbuffer.\n\nSigned-off-by: Arun Menon \nFix-Suggested-by: Marc-André Lureau \nSigned-off-by: Arun Menon \n---\n include/migration/vmstate.h | 10 ++++++++++\n migration/vmstate-types.c | 37 +++++++++++++++++++++++++++++++++++++\n 2 files changed, 47 insertions(+)","diff":"diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h\nindex 62c2abd0c4..f503a40ec0 100644\n--- a/include/migration/vmstate.h\n+++ b/include/migration/vmstate.h\n@@ -265,6 +265,7 @@ extern const VMStateInfo vmstate_info_bitmap;\n extern const VMStateInfo vmstate_info_qtailq;\n extern const VMStateInfo vmstate_info_gtree;\n extern const VMStateInfo vmstate_info_qlist;\n+extern const VMStateInfo vmstate_info_g_byte_array;\n \n #define type_check_2darray(t1,t2,n,m) ((t1(*)[n][m])0 - (t2*)0)\n /*\n@@ -892,6 +893,15 @@ extern const VMStateInfo vmstate_info_qlist;\n .start = offsetof(_type, _next), \\\n }\n \n+#define VMSTATE_GBYTEARRAY(_field, _state, _version) { \\\n+ .name = (stringify(_field)), \\\n+ .version_id = (_version), \\\n+ .size = sizeof(GByteArray), \\\n+ .info = &vmstate_info_g_byte_array, \\\n+ .flags = VMS_SINGLE, \\\n+ .offset = vmstate_offset_pointer(_state, _field, GByteArray), \\\n+}\n+\n /* _f : field name\n _f_n : num of elements field_name\n _n : num of elements\ndiff --git a/migration/vmstate-types.c b/migration/vmstate-types.c\nindex 89cb211472..743c2092e9 100644\n--- a/migration/vmstate-types.c\n+++ b/migration/vmstate-types.c\n@@ -942,3 +942,40 @@ const VMStateInfo vmstate_info_qlist = {\n .get = get_qlist,\n .put = put_qlist,\n };\n+\n+static int get_g_byte_array(QEMUFile *f, void *pv, size_t size,\n+ const VMStateField *field)\n+{\n+ GByteArray **byte_array = (GByteArray **)pv;\n+ uint32_t len = qemu_get_be32(f);\n+\n+ if (*byte_array == NULL) {\n+ *byte_array = g_byte_array_new();\n+ }\n+\n+ g_byte_array_set_size(*byte_array, len);\n+ if (len > 0) {\n+ qemu_get_buffer(f, (*byte_array)->data, len);\n+ }\n+ return 0;\n+}\n+\n+static int put_g_byte_array(QEMUFile *f, void *pv, size_t size,\n+ const VMStateField *field, JSONWriter *vmdesc)\n+{\n+ GByteArray *byte_array = *(GByteArray **)pv;\n+ uint32_t len = byte_array ? byte_array->len : 0;\n+\n+ qemu_put_be32(f, len);\n+ if (len > 0) {\n+ qemu_put_buffer(f, byte_array->data, len);\n+ }\n+\n+ return 0;\n+}\n+\n+const VMStateInfo vmstate_info_g_byte_array = {\n+ .name = \"GByteArray\",\n+ .get = get_g_byte_array,\n+ .put = put_g_byte_array,\n+};\n","prefixes":["v2","1/2"]}