{"id":2221493,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221493/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409142137.58349-5-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260409142137.58349-5-philmd@linaro.org>","list_archive_url":null,"date":"2026-04-09T14:21:36","name":"[PULL,4/4] qemu-keymap: fix altgr modifier lookup for newer xkeyboard-config","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0778c1112d46c7608bd478d9c51fc94d2679736b","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.2/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409142137.58349-5-philmd@linaro.org/mbox/","series":[{"id":499309,"url":"http://patchwork.ozlabs.org/api/1.2/series/499309/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499309","date":"2026-04-09T14:21:32","name":"[PULL,1/4] ati-vga: Fix pitch and offset registers mask","version":1,"mbox":"http://patchwork.ozlabs.org/series/499309/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221493/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221493/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=aV4HDEq9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs2Fr54KCz1xy1\n\tfor ; Fri, 10 Apr 2026 00:22:40 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAqGu-0003Nd-EY; Thu, 09 Apr 2026 10:22:18 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wAqGn-0003Md-Fz\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 10:22:10 -0400","from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wAqGl-0003AS-TV\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 10:22:09 -0400","by mail-wm1-x32c.google.com with SMTP id\n 5b1f17b1804b1-488c21c636dso5748615e9.2\n for ; Thu, 09 Apr 2026 07:22:07 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488cd2492e8sm77222315e9.15.2026.04.09.07.22.05\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 09 Apr 2026 07:22:05 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775744526; x=1776349326; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=L/+7Bj8ldsjqzb2+6rLdLpbTAiNwT8MkgbfOWGkcJ7k=;\n b=aV4HDEq9jxUAQyemc9PIftsbkieqGJkmoelmDA4bkcPR0O3FveP84cHnOQNY4DoUxj\n ARO52QBy3GsHB5ERR1hhG+Al4cOdK5bO48/ezphLOeCu6/Jux0OPcPC0sQFe1RRWCkMr\n 1+wcBU4joIw3vvri95HZUYkmP1E2fVU05EVQt65EABpxsapsgwYkJU6NMajpLF5eR/3j\n Fm+IWbYvxVZGliQpkgYUpX8EfCImCX7AD2sN5TBpnHqInaoH9crLZBcTweRhe8H5WWoQ\n vBArZhzPNdbicNgMh3W4IbWlNrb701GkNgqcVD19rCDnvgDH+dO2BLAI/VCDhlXfMj+d\n lWoA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775744526; x=1776349326;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=L/+7Bj8ldsjqzb2+6rLdLpbTAiNwT8MkgbfOWGkcJ7k=;\n b=HAnKL5hwR5UKEhufH0mOg1sZ9iLAcu0QLiP804r/mASxckKz2tBT7THtIYzM52fbW1\n WnoaFNxjg8gBTRqkECjYn247V4E3Jb66rgCAKV1llIWpMfR3xYu9yTRPUc9GojtCyZp8\n EsiuseGC2E1IrODYPoLlJQOtEihAtS3jK1tR+5uTYICXemDYl2GSbuAkOSFg/8rAppV0\n fkYk6iUEjXz0gpBSl0evnX0W5+8FDKGectzCJd5RPz0pAr+lx1O+sHgw8N9izNbodxe4\n PNQDUebUa6NWp1lRgGTs83VTVBD1hi/9eoRx+vypr2Q50Z11c2XWW8dpNtXtqExCMbjv\n YyyQ==","X-Gm-Message-State":"AOJu0Yyp1QCf2UmBOSXslIkxq9xnvyYk86+FnFo9xKcLEUfc6M+MHYq/\n PFG82rOKJQfZ831aQ3W8BxEHOOFUKMvuD55nrPSCxTISb/RaD7mXGH82ZEjjbvhZFv2YALfQ4+w\n dOVQ2whM=","X-Gm-Gg":"AeBDieuXzpc6LYatezoJn4uelLBtz09H7yT2/XShdch3Rz+qIi2KH106QQVCkoX114a\n 4BFwjK69ViMciPD47xCknUR2a5V57Yl1Jw/k0kRtK7soTr+FN4AF9HLi1zTR5OvcdgZ+KrxIzJ6\n WDOIABj33ipYVWVnt8YUGPQLeM81l1R/y4CNWK7LD6TeLmabNt+HZq/xVzdLXLn27Tx/OawPNYr\n 27DYaCjsGBSz5g/NDNTW8dwKa+iUJZ5aNfwiFb34XXhcSQS+AJi6WYbT0Ivvbg0nCXvDJUnTvM1\n Ky2Z65Rj3HIKSu3xGscgrgqGD4QsB3+UVJ8vxhjVc5AOZ++rjuCULwQ/LF+vimA20EU5EJAnMTs\n 7OZP00cZCAqWYP78WOetJ04S9X77sUu/5U+4efLOkSsR4X9Sy4DW7naRBbqOwCW5QcZ1uL8sv2e\n 5Ne38402je1/slKpeyMXYc7/2TWspTbbfl6TJHYmxiON97CGchAhCxPRJ9EXFtv1GvuuYmaK4j","X-Received":"by 2002:a05:600c:6305:b0:480:690e:f14a with SMTP id\n 5b1f17b1804b1-4889978c561mr345190425e9.14.1775744525849;\n Thu, 09 Apr 2026 07:22:05 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Peter Maydell ","Subject":"[PULL 4/4] qemu-keymap: fix altgr modifier lookup for newer\n xkeyboard-config","Date":"Thu, 9 Apr 2026 16:21:36 +0200","Message-ID":"<20260409142137.58349-5-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260409142137.58349-1-philmd@linaro.org>","References":"<20260409142137.58349-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32c;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Dietmar Maurer \n\nxkeyboard-config 2.37 removed the \"AltGr\" virtual modifier in favor\nof mapping upper groups directly to Mod5. Since then,\nxkb_keymap_mod_get_index(map, \"AltGr\") returns XKB_MOD_INVALID, so\nAltGr-based keysyms were never generated.\n\nSee: https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/commit/473f9bc32f9ba869829cc0d06a75cd1f2560aa60\n\nTry \"AltGr\" first, and fall back to \"Mod5\" for compatibility with\nboth old and new xkeyboard-config versions.\n\nSigned-off-by: Dietmar Maurer \nReviewed-by: Philippe Mathieu-Daudé \nMessage-ID: <20260408091459.4001711-1-dietmar@proxmox.com>\nSigned-off-by: Philippe Mathieu-Daudé \n---\n qemu-keymap.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/qemu-keymap.c b/qemu-keymap.c\nindex 1c081db2870..d4dccf456ef 100644\n--- a/qemu-keymap.c\n+++ b/qemu-keymap.c\n@@ -230,6 +230,9 @@ int main(int argc, char *argv[])\n shift = get_mod(map, \"Shift\");\n ctrl = get_mod(map, \"Control\");\n altgr = get_mod(map, \"AltGr\");\n+ if (!altgr) {\n+ altgr = get_mod(map, \"Mod5\");\n+ }\n numlock = get_mod(map, \"NumLock\");\n \n state = xkb_state_new(map);\n","prefixes":["PULL","4/4"]}