{"id":2221485,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221485/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260409135559.466278-1-tkaminsk@redhat.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.2/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260409135559.466278-1-tkaminsk@redhat.com>","list_archive_url":null,"date":"2026-04-09T13:54:22","name":"libstdc++: Rename views::to_input to views::as_input.","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2ddfc80c8c429b013dea05a55cd0c8089d70a7d3","submitter":{"id":90409,"url":"http://patchwork.ozlabs.org/api/1.2/people/90409/?format=json","name":"Tomasz Kaminski","email":"tkaminsk@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260409135559.466278-1-tkaminsk@redhat.com/mbox/","series":[{"id":499306,"url":"http://patchwork.ozlabs.org/api/1.2/series/499306/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=499306","date":"2026-04-09T13:54:22","name":"libstdc++: Rename views::to_input to views::as_input.","version":1,"mbox":"http://patchwork.ozlabs.org/series/499306/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221485/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221485/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ha5iDFim;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ha5iDFim","sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","sourceware.org; spf=pass smtp.mailfrom=redhat.com","server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.133.124"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs1gn6yL5z1yD3\n\tfor ; Thu, 09 Apr 2026 23:56:36 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 860984BA2E20\n\tfor ; Thu, 9 Apr 2026 13:56:34 +0000 (GMT)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by sourceware.org (Postfix) with ESMTP id 77AC74BA2E04\n for ; Thu, 9 Apr 2026 13:56:04 +0000 (GMT)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-P7faoPh9MAySPimxeAcQKw-1; Thu,\n 09 Apr 2026 09:56:02 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 532B41956095; Thu, 9 Apr 2026 13:56:01 +0000 (UTC)","from localhost (unknown [10.44.33.240])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id A7EA13000C17; Thu, 9 Apr 2026 13:56:00 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 860984BA2E20","OpenDKIM Filter v2.11.0 sourceware.org 77AC74BA2E04"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 77AC74BA2E04","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 77AC74BA2E04","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775742964; cv=none;\n b=eSpmQg6CpG+AyHPz3Ut7OpR7p4afl60lS4LmG1bFcN/kju+JVciw1jR97hdR2igaUdJZvrEilPvhBNU+A/w82jd1h2YeURMvLPb7bCXovfZmC7plwEhklH2WULo7YwxbvWUyyt7gl2MbXzz8iB0OtUar0IFeF3O+Xb0LDfbeVCE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1775742964; c=relaxed/simple;\n bh=7Rwngdkk8QKZPB+slQwkjKIyx2xFgcTFk9jXO+bwr38=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=J3js66mBT3PSv4iXkHJca85gxigBK+EhtErCqklEbkhlDk9Xs8eof8gmbATXCdGrT6HS3oz7DafA/YqwTeWHdly+ChY6v85Vu+fV97xkPn1sh7DZnUbfkaRDdXfvzrw2Tledy+XnEl8oNk4BgXZ8r/2JbeWVPpWvwOBLrnAyTKU=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775742964;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=xFqq3TDdlj16zBPxVHr9ozHbGSmCYns1d6snP8N23eQ=;\n b=ha5iDFim7JVHves/VbYK2ASZ6lJE75URfMsLc9snX1yjs1l6v9m1ILClOoqPOHEzzorx+s\n ScXavGZWV+Eh6zUuHnOAjMMoxIcAgNkUlOoB+QzDyFEhreTvu4cOqUjgXoxrvlFnk0PoQR\n e0DDrtSSbV1Rds1TWn9mC+f6YJ0sZcU=","X-MC-Unique":"P7faoPh9MAySPimxeAcQKw-1","X-Mimecast-MFC-AGG-ID":"P7faoPh9MAySPimxeAcQKw_1775742961","From":"=?utf-8?q?Tomasz_Kami=C5=84ski?= ","To":"libstdc++@gcc.gnu.org,\n\tgcc-patches@gcc.gnu.org","Subject":"[PATCH] libstdc++: Rename views::to_input to views::as_input.","Date":"Thu, 9 Apr 2026 15:54:22 +0200","Message-ID":"<20260409135559.466278-1-tkaminsk@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"5p15JX3eL-EMgHIdvO3E3wKmu1SdGFiUmhGN2qM03gg_1775742961","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"This patch implements P3828R1: Rename the to_input view to as_input.\n\nThe paper suggest renaming the feature test macro without changing the\nvalue and this patch follows.\n\nlibstdc++-v3/ChangeLog:\n\n\t* include/bits/version.def (ranges_to_input): Rename to...\n\t(ranges_as_input): Rename from ranges_as_input.\n\t* include/bits/version.h: Regenerate.\n\t* include/std/ranges (ranges::to_input_view, views::to_input)\n\t(__detail::__can_to_input, views::_ToInput): Rename to...\n\t(ranges::as_input_view, views::as_input, __detail::__can_as_input)\n\t(views::_AsInput): Rename from above...\n\t* src/c++23/std.cc.in: Rename views::to_input and to_input_view\n\texport.\n\t* testsuite/25_algorithms/contains/1.cc: Replace views::to_input\n\twith views::as_input.\n\t* testsuite/std/ranges/adaptors/to_input/1.cc: Move to...\n\t* testsuite/std/ranges/adaptors/as_input/1.cc: ...here, and replace\n\tviews::to_input with views::as_input.\n\ngcc/testsuite/ChangeLog:\n\n\t* g++.dg/reflect/range_args.C: Replace views::to_input with\n\tviews::as_input.\n---\nThe feature test macro situation is fine as is, as user can still\ndifferentiate which name they got.\n\nTested on x86_64-linux locally. Running full test now.\nOK for trunk when all test passes?\n\n gcc/testsuite/g++.dg/reflect/range_args.C | 6 ++--\n libstdc++-v3/include/bits/version.def | 2 +-\n libstdc++-v3/include/bits/version.h | 12 ++++----\n libstdc++-v3/include/std/ranges | 28 +++++++++----------\n libstdc++-v3/src/c++23/std.cc.in | 6 ++--\n .../testsuite/25_algorithms/contains/1.cc | 18 ++++++------\n .../adaptors/{to_input => as_input}/1.cc | 12 ++++----\n 7 files changed, 42 insertions(+), 42 deletions(-)\n rename libstdc++-v3/testsuite/std/ranges/adaptors/{to_input => as_input}/1.cc (78%)","diff":"diff --git a/gcc/testsuite/g++.dg/reflect/range_args.C b/gcc/testsuite/g++.dg/reflect/range_args.C\nindex fa06cf0ebc7..df9b5e42359 100644\n--- a/gcc/testsuite/g++.dg/reflect/range_args.C\n+++ b/gcc/testsuite/g++.dg/reflect/range_args.C\n@@ -45,7 +45,7 @@ test_type_range(Rg&& rg)\n constexpr info vt[] = {^^int, ^^int, ^^float, ^^int, ^^float, ^^double};\n static_assert (test_type_range (vt | std::views::filter (is_integral_type))); // bidirectional\n static_assert (test_type_range (vt | std::views::take_while (is_integral_type))); // non-common\n-static_assert (test_type_range (vt | std::views::to_input)); // input\n+static_assert (test_type_range (vt | std::views::as_input)); // input\n static_assert (test_type_range (vt | std::views::cache_latest)); // input, move-only\n \n template\n@@ -74,7 +74,7 @@ constexpr bool not_digit(char c) {\n \n static_assert (test_value_range (vv | std::views::filter (not_digit))); // bidirectional\n static_assert (test_value_range (vv | std::views::take_while (not_digit))); // non-common\n-static_assert (test_value_range (vv | std::views::to_input)); // input\n+static_assert (test_value_range (vv | std::views::as_input)); // input\n static_assert (test_value_range (vv | std::views::cache_latest)); // input, move-only\n \t\t\t\t\t\t\t\t \n template struct Aggr;\n@@ -91,6 +91,6 @@ consteval bool of_int_type(info dm) {\n consteval {\n define_aggregate (^^Aggr<0>, dmt | std::views::filter (of_int_type)); // bidirectional\n define_aggregate (^^Aggr<1>, dmt | std::views::take_while (of_int_type)); // non-common\n- define_aggregate (^^Aggr<2>, dmt | std::views::to_input); // input\n+ define_aggregate (^^Aggr<2>, dmt | std::views::as_input); // input\n define_aggregate (^^Aggr<3>, dmt | std::views::cache_latest); // input, move-only\n }\ndiff --git a/libstdc++-v3/include/bits/version.def b/libstdc++-v3/include/bits/version.def\nindex cfb90533ce4..51e60afe381 100644\n--- a/libstdc++-v3/include/bits/version.def\n+++ b/libstdc++-v3/include/bits/version.def\n@@ -2196,7 +2196,7 @@ ftms = {\n };\n \n ftms = {\n- name = ranges_to_input;\n+ name = ranges_as_input;\n values = {\n v = 202502;\n cxxmin = 26;\ndiff --git a/libstdc++-v3/include/bits/version.h b/libstdc++-v3/include/bits/version.h\nindex 22dd31b9d32..10348524e4e 100644\n--- a/libstdc++-v3/include/bits/version.h\n+++ b/libstdc++-v3/include/bits/version.h\n@@ -2456,15 +2456,15 @@\n #endif /* !defined(__cpp_lib_ranges_filter) */\n #undef __glibcxx_want_ranges_filter\n \n-#if !defined(__cpp_lib_ranges_to_input)\n+#if !defined(__cpp_lib_ranges_as_input)\n # if (__cplusplus > 202302L)\n-# define __glibcxx_ranges_to_input 202502L\n-# if defined(__glibcxx_want_all) || defined(__glibcxx_want_ranges_to_input)\n-# define __cpp_lib_ranges_to_input 202502L\n+# define __glibcxx_ranges_as_input 202502L\n+# if defined(__glibcxx_want_all) || defined(__glibcxx_want_ranges_as_input)\n+# define __cpp_lib_ranges_as_input 202502L\n # endif\n # endif\n-#endif /* !defined(__cpp_lib_ranges_to_input) */\n-#undef __glibcxx_want_ranges_to_input\n+#endif /* !defined(__cpp_lib_ranges_as_input) */\n+#undef __glibcxx_want_ranges_as_input\n \n #if !defined(__cpp_lib_to_string)\n # if (__cplusplus > 202302L) && _GLIBCXX_HOSTED && (__glibcxx_to_chars)\ndiff --git a/libstdc++-v3/include/std/ranges b/libstdc++-v3/include/std/ranges\nindex 0aa4191e04f..ca91e081ad4 100644\n--- a/libstdc++-v3/include/std/ranges\n+++ b/libstdc++-v3/include/std/ranges\n@@ -72,7 +72,7 @@\n #define __glibcxx_want_ranges_slide\n #define __glibcxx_want_ranges_stride\n #define __glibcxx_want_ranges_to_container\n-#define __glibcxx_want_ranges_to_input\n+#define __glibcxx_want_ranges_as_input\n #define __glibcxx_want_ranges_zip\n #include \n \n@@ -10537,12 +10537,12 @@ namespace ranges\n } // namespace ranges\n #endif // __cpp_lib_ranges_cache_latest\n \n-#if __cpp_lib_ranges_to_input // C++ >= 26\n+#if __cpp_lib_ranges_as_input // C++ >= 26\n namespace ranges\n {\n template\n requires view<_Vp>\n- class to_input_view : public view_interface>\n+ class as_input_view : public view_interface>\n {\n _Vp _M_base = _Vp();\n \n@@ -10550,10 +10550,10 @@ namespace ranges\n class _Iterator;\n \n public:\n- to_input_view() requires default_initializable<_Vp> = default;\n+ as_input_view() requires default_initializable<_Vp> = default;\n \n constexpr explicit\n- to_input_view(_Vp __base)\n+ as_input_view(_Vp __base)\n : _M_base(std::move(__base))\n { }\n \n@@ -10591,12 +10591,12 @@ namespace ranges\n };\n \n template\n- to_input_view(_Range&&) -> to_input_view>;\n+ as_input_view(_Range&&) -> as_input_view>;\n \n template\n requires view<_Vp>\n template\n- class to_input_view<_Vp>::_Iterator\n+ class as_input_view<_Vp>::_Iterator\n {\n using _Base = __maybe_const_t<_Const, _Vp>;\n \n@@ -10607,7 +10607,7 @@ namespace ranges\n : _M_current(std::move(__current))\n { }\n \n- friend to_input_view;\n+ friend as_input_view;\n friend _Iterator;\n \n public:\n@@ -10680,13 +10680,13 @@ namespace ranges\n namespace __detail\n {\n template\n-\tconcept __can_to_input = requires { to_input_view(std::declval<_Tp>()); };\n+\tconcept __can_as_input = requires { as_input_view(std::declval<_Tp>()); };\n }\n \n- struct _ToInput : __adaptor::_RangeAdaptorClosure<_ToInput>\n+ struct _AsInput : __adaptor::_RangeAdaptorClosure<_AsInput>\n {\n template\n-\trequires __detail::__can_to_input<_Range>\n+\trequires __detail::__can_as_input<_Range>\n \tconstexpr auto\n \toperator() [[nodiscard]] (_Range&& __r) const\n \t{\n@@ -10695,16 +10695,16 @@ namespace ranges\n \t\t\t&& !forward_range<_Range>)\n \t return views::all(std::forward<_Range>(__r));\n \t else\n-\t return to_input_view(std::forward<_Range>(__r));\n+\t return as_input_view(std::forward<_Range>(__r));\n \t}\n \n static constexpr bool _S_has_simple_call_op = true;\n };\n \n- inline constexpr _ToInput to_input;\n+ inline constexpr _AsInput as_input;\n }\n } // namespace ranges\n-#endif // __cpp_lib_ranges_to_input\n+#endif // __cpp_lib_ranges_as_input\n \n _GLIBCXX_END_NAMESPACE_VERSION\n } // namespace std\ndiff --git a/libstdc++-v3/src/c++23/std.cc.in b/libstdc++-v3/src/c++23/std.cc.in\nindex 3ac19871692..ad249cb3348 100644\n--- a/libstdc++-v3/src/c++23/std.cc.in\n+++ b/libstdc++-v3/src/c++23/std.cc.in\n@@ -2800,9 +2800,9 @@ export namespace std\n using ranges::cache_latest_view;\n namespace views { using views::cache_latest; }\n #endif\n-#if __glibcxx_ranges_to_input // C++ >= 26\n- using ranges::to_input_view;\n- namespace views { using views::to_input; }\n+#if __glibcxx_ranges_as_input // C++ >= 26\n+ using ranges::as_input_view;\n+ namespace views { using views::as_input; }\n #endif\n #ifdef __cpp_lib_ranges_indices // C++ >= 26\n namespace views { using views::indices; }\ndiff --git a/libstdc++-v3/testsuite/25_algorithms/contains/1.cc b/libstdc++-v3/testsuite/25_algorithms/contains/1.cc\nindex b44c06032e8..aaf81f85a0a 100644\n--- a/libstdc++-v3/testsuite/25_algorithms/contains/1.cc\n+++ b/libstdc++-v3/testsuite/25_algorithms/contains/1.cc\n@@ -14,17 +14,17 @@ void\n test01()\n {\n int x[] = {1,2,3};\n- using to_input = __gnu_test::test_input_range;\n- VERIFY( ranges::contains(to_input(x), 1) );\n- VERIFY( ranges::contains(to_input(x), 2) );\n- VERIFY( ranges::contains(to_input(x), 3) );\n- VERIFY( !ranges::contains(to_input(x), 4) );\n+ using as_input = __gnu_test::test_input_range;\n+ VERIFY( ranges::contains(as_input(x), 1) );\n+ VERIFY( ranges::contains(as_input(x), 2) );\n+ VERIFY( ranges::contains(as_input(x), 3) );\n+ VERIFY( !ranges::contains(as_input(x), 4) );\n VERIFY( !ranges::contains(x, x+2, 3) );\n auto neg = [](int n) { return -n; };\n- VERIFY( ranges::contains(to_input(x), -1, neg) );\n- VERIFY( ranges::contains(to_input(x), -2, neg) );\n- VERIFY( ranges::contains(to_input(x), -3, neg) );\n- VERIFY( !ranges::contains(to_input(x), -4, neg) );\n+ VERIFY( ranges::contains(as_input(x), -1, neg) );\n+ VERIFY( ranges::contains(as_input(x), -2, neg) );\n+ VERIFY( ranges::contains(as_input(x), -3, neg) );\n+ VERIFY( !ranges::contains(as_input(x), -4, neg) );\n \n VERIFY( !ranges::contains(x, x+2, -3, neg) );\n }\ndiff --git a/libstdc++-v3/testsuite/std/ranges/adaptors/to_input/1.cc b/libstdc++-v3/testsuite/std/ranges/adaptors/as_input/1.cc\nsimilarity index 78%\nrename from libstdc++-v3/testsuite/std/ranges/adaptors/to_input/1.cc\nrename to libstdc++-v3/testsuite/std/ranges/adaptors/as_input/1.cc\nindex cde368a2f64..8bd1a82a7b7 100644\n--- a/libstdc++-v3/testsuite/std/ranges/adaptors/to_input/1.cc\n+++ b/libstdc++-v3/testsuite/std/ranges/adaptors/as_input/1.cc\n@@ -2,8 +2,8 @@\n \n #include \n \n-#if __cpp_lib_ranges_to_input != 202502L\n-# error \"Feature-test macro __cpp_lib_ranges_to_input has wrong value in \"\n+#if __cpp_lib_ranges_as_input != 202502L\n+# error \"Feature-test macro __cpp_lib_ranges_as_input has wrong value in \"\n #endif\n \n #include \n@@ -18,7 +18,7 @@ void\n test01()\n {\n std::vector r{1,2,3};\n- auto v = r | views::to_input;\n+ auto v = r | views::as_input;\n using type = decltype(v);\n static_assert( ranges::input_range && !ranges::forward_range );\n \n@@ -45,10 +45,10 @@ test02()\n int x[] = {1,2,3};\n __gnu_test::test_input_range rx(x);\n static_assert( !ranges::common_range );\n- auto v = rx | views::to_input;\n+ auto v = rx | views::as_input;\n static_assert( std::same_as );\n- static_assert( std::same_as );\n+ static_assert( std::same_as );\n }\n \n int\n","prefixes":[]}