{"id":2221482,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221482/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260409133712.64E894BA2E19@sourceware.org/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.2/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260409133712.64E894BA2E19@sourceware.org>","list_archive_url":null,"date":"2026-04-09T13:36:44","name":"[1/2] SLP pattern TLC","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"af11b71d2ef40ac198141f021921b4845722fbca","submitter":{"id":4338,"url":"http://patchwork.ozlabs.org/api/1.2/people/4338/?format=json","name":"Richard Biener","email":"rguenther@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260409133712.64E894BA2E19@sourceware.org/mbox/","series":[{"id":499304,"url":"http://patchwork.ozlabs.org/api/1.2/series/499304/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=499304","date":"2026-04-09T13:36:44","name":"[1/2] SLP pattern TLC","version":1,"mbox":"http://patchwork.ozlabs.org/series/499304/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221482/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221482/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=D6VKqfUm;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=3Q7DqoVG;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=D6VKqfUm;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=3Q7DqoVG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=D6VKqfUm;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=3Q7DqoVG;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=D6VKqfUm;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=3Q7DqoVG","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=suse.de","sourceware.org; spf=pass smtp.mailfrom=suse.de","server2.sourceware.org;\n arc=none smtp.remote-ip=195.135.223.130","smtp-out1.suse.de;\n\tnone"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs1FS2LkJz1xy1\n\tfor ; Thu, 09 Apr 2026 23:37:14 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 64E894BA2E19\n\tfor ; Thu, 9 Apr 2026 13:37:12 +0000 (GMT)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n by sourceware.org (Postfix) with ESMTPS id 401D64BA2E09\n for ; Thu, 9 Apr 2026 13:36:45 +0000 (GMT)","from murzim.nue2.suse.org (unknown [10.168.4.243])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 2E05F6A7C2\n for ; Thu, 9 Apr 2026 13:36:44 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 64E894BA2E19","OpenDKIM Filter v2.11.0 sourceware.org 401D64BA2E09"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 401D64BA2E09","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 401D64BA2E09","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775741805; cv=none;\n b=ZRxUIcdC6iWjsdXWg1/mmhBqLesW/1lsXoTseMeSctj51fBv6QFyy5sMb2BCXcQylM6XDjYI1QIcwRz5RxkljRZgTUp9HEbotD0E/jtfHG3EzzQpFGNwFVFLf8pD146MwwZfhvJbKgIzMS0s8twr/tQKpMNEXsDSt+FaYUpuHFk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1775741805; c=relaxed/simple;\n bh=U5diFgq2LnHA5eAql03HBTGCUkh1cS2mUKWZGDkU0x0=;\n h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date:\n From:To:Subject:MIME-Version;\n b=OoprqU4sJhXjPbxHAhIs9yNBiZ97oX6b4FWei+PGI7PZHW46kYwB9EpXI/D6yu7YdBNMFSYIrJODcPIeqCzfeHjI48pHH7IjazewdtTBVBcS1WnsmhU1qNatD+Jg03Vq2hrohB5ASnXZMFj0KVk7lSZwrDIOS1bdc91lBjZz4aU=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1775741804;\n h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version:\n content-type:content-type; bh=64Ct7Wdk5qK1UO0CxHfMfKCZAvd4WJgKmAp7/nyEILk=;\n b=D6VKqfUmoqXta3c9W031APwa7vscFcHA04YEJb0swTAWvc/NfTjiB9IChB1wBwwWRz5ZJN\n I8Oz2VVirh9ibtTxEWy+mKuCEsJnXqke6ZIfaGr6E7St3cAph+2q2nhIYDXiuCTm5jQqY/\n dMGUD6CDR18JCHcbH9WsDON00jiPQvw=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1775741804;\n h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version:\n content-type:content-type; bh=64Ct7Wdk5qK1UO0CxHfMfKCZAvd4WJgKmAp7/nyEILk=;\n b=3Q7DqoVGwTf04P7nHW9lXxuYNDoBJHaKaU3I9J+rNKMw/ENPWgflsvETyWi3sJaU90y6Jg\n 02wOcWnJuLUdPzCA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1775741804;\n h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version:\n content-type:content-type; bh=64Ct7Wdk5qK1UO0CxHfMfKCZAvd4WJgKmAp7/nyEILk=;\n b=D6VKqfUmoqXta3c9W031APwa7vscFcHA04YEJb0swTAWvc/NfTjiB9IChB1wBwwWRz5ZJN\n I8Oz2VVirh9ibtTxEWy+mKuCEsJnXqke6ZIfaGr6E7St3cAph+2q2nhIYDXiuCTm5jQqY/\n dMGUD6CDR18JCHcbH9WsDON00jiPQvw=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1775741804;\n h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version:\n content-type:content-type; bh=64Ct7Wdk5qK1UO0CxHfMfKCZAvd4WJgKmAp7/nyEILk=;\n b=3Q7DqoVGwTf04P7nHW9lXxuYNDoBJHaKaU3I9J+rNKMw/ENPWgflsvETyWi3sJaU90y6Jg\n 02wOcWnJuLUdPzCA=="],"Date":"Thu, 9 Apr 2026 15:36:44 +0200 (CEST)","From":"Richard Biener ","To":"gcc-patches@gcc.gnu.org","Subject":"[PATCH 1/2] SLP pattern TLC","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","X-Spamd-Result":"default: False [-1.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-1.00)[-0.998];\n NEURAL_HAM_SHORT(-0.20)[-0.984]; MIME_GOOD(-0.10)[text/plain];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1];\n MISSING_XM_UA(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n TO_DN_NONE(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_ZERO(0.00)[0];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org","Message-Id":"<20260409133712.64E894BA2E19@sourceware.org>"},"content":"The following removes setting of STMT_VINFO_REDUC_DEF on pattern\nstmts - those are only ever checked on original scalar stmts now.\nBut for that to work we have to make the related stmt of the new\nSLP pattern stmts the original stmt of a possible pattern.\n\nThe only valid SLP_TREE_CODE are VEC_PERM_EXPR and ERROR_MARK,\ndo not set it to CALL_EXPR.\n\nBootstrapped on x86_64-unknown-linux-gnu, testing in progress.\n\nQueued for stage1.\n\n\t* tree-vect-slp-patterns.cc (complex_pattern::build):\n\tAdd pattern for the original stmt, do not set\n\tSTMT_VINFO_REDUC_DEF.\n\t(addsub_pattern::build): Likewise.\n---\n gcc/tree-vect-slp-patterns.cc | 15 ++++++---------\n 1 file changed, 6 insertions(+), 9 deletions(-)","diff":"diff --git a/gcc/tree-vect-slp-patterns.cc b/gcc/tree-vect-slp-patterns.cc\nindex 0976258a36d..ab4a42d1964 100644\n--- a/gcc/tree-vect-slp-patterns.cc\n+++ b/gcc/tree-vect-slp-patterns.cc\n@@ -549,8 +549,6 @@ complex_pattern::build (vec_info *vinfo)\n {\n /* Calculate the location of the statement in NODE to replace. */\n stmt_info = SLP_TREE_REPRESENTATIVE (node);\n- stmt_vec_info reduc_def\n-\t= STMT_VINFO_REDUC_DEF (vect_orig_stmt (stmt_info));\n gimple* old_stmt = STMT_VINFO_STMT (stmt_info);\n tree lhs_old_stmt = gimple_get_lhs (old_stmt);\n tree type = TREE_TYPE (lhs_old_stmt);\n@@ -572,13 +570,12 @@ complex_pattern::build (vec_info *vinfo)\n \t the nodes as such we need to manually update them. Any changes will be\n \t undone if SLP is cancelled. */\n call_stmt_info\n-\t= vinfo->add_pattern_stmt (call_stmt, stmt_info);\n+\t= vinfo->add_pattern_stmt (call_stmt, vect_orig_stmt (stmt_info));\n \n /* Make sure to mark the representative statement pure_slp and\n \t relevant and transfer reduction info. */\n STMT_VINFO_RELEVANT (call_stmt_info) = vect_used_in_scope;\n STMT_SLP_TYPE (call_stmt_info) = pure_slp;\n- STMT_VINFO_REDUC_DEF (call_stmt_info) = reduc_def;\n \n gimple_set_bb (call_stmt, gimple_bb (stmt_info->stmt));\n STMT_VINFO_VECTYPE (call_stmt_info) = SLP_TREE_VECTYPE (node);\n@@ -589,7 +586,7 @@ complex_pattern::build (vec_info *vinfo)\n \t is created. */\n SLP_TREE_REPRESENTATIVE (node) = call_stmt_info;\n SLP_TREE_LANE_PERMUTATION (node).release ();\n- SLP_TREE_CODE (node) = CALL_EXPR;\n+ SLP_TREE_CODE (node) = ERROR_MARK;\n }\n }\n \n@@ -1622,13 +1619,13 @@ addsub_pattern::build (vec_info *vinfo)\n \t\t\t (TREE_TYPE (gimple_assign_lhs (rep->stmt))));\n \tgimple_call_set_nothrow (call, true);\n \tgimple_set_bb (call, gimple_bb (rep->stmt));\n-\tstmt_vec_info new_rep = vinfo->add_pattern_stmt (call, rep);\n+\tstmt_vec_info new_rep\n+\t = vinfo->add_pattern_stmt (call, vect_orig_stmt (rep));\n \tSLP_TREE_REPRESENTATIVE (node) = new_rep;\n \tSTMT_VINFO_RELEVANT (new_rep) = vect_used_in_scope;\n \tSTMT_SLP_TYPE (new_rep) = pure_slp;\n \tSTMT_VINFO_VECTYPE (new_rep) = SLP_TREE_VECTYPE (node);\n \tSTMT_VINFO_SLP_VECT_ONLY_PATTERN (new_rep) = true;\n-\tSTMT_VINFO_REDUC_DEF (new_rep) = STMT_VINFO_REDUC_DEF (vect_orig_stmt (rep));\n \tSLP_TREE_CODE (node) = ERROR_MARK;\n \tSLP_TREE_LANE_PERMUTATION (node).release ();\n \n@@ -1688,13 +1685,13 @@ addsub_pattern::build (vec_info *vinfo)\n \t\t\t (TREE_TYPE (gimple_get_lhs (srep->stmt))));\n \tgimple_call_set_nothrow (call, true);\n \tgimple_set_bb (call, gimple_bb (srep->stmt));\n-\tstmt_vec_info new_rep = vinfo->add_pattern_stmt (call, srep);\n+\tstmt_vec_info new_rep\n+\t = vinfo->add_pattern_stmt (call, vect_orig_stmt (srep));\n \tSLP_TREE_REPRESENTATIVE (node) = new_rep;\n \tSTMT_VINFO_RELEVANT (new_rep) = vect_used_in_scope;\n \tSTMT_SLP_TYPE (new_rep) = pure_slp;\n \tSTMT_VINFO_VECTYPE (new_rep) = SLP_TREE_VECTYPE (node);\n \tSTMT_VINFO_SLP_VECT_ONLY_PATTERN (new_rep) = true;\n-\tSTMT_VINFO_REDUC_DEF (new_rep) = STMT_VINFO_REDUC_DEF (vect_orig_stmt (srep));\n \tSLP_TREE_CODE (node) = ERROR_MARK;\n \tSLP_TREE_LANE_PERMUTATION (node).release ();\n \n","prefixes":["1/2"]}