{"id":2221461,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221461/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260409131404.1545834-14-aalbersh@kernel.org/","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/1.2/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260409131404.1545834-14-aalbersh@kernel.org>","list_archive_url":null,"date":"2026-04-09T13:13:45","name":"[v7,13/22] xfs: disable direct read path for fs-verity files","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"7341b7348870d68f905cfa604e2324bc63991579","submitter":{"id":92821,"url":"http://patchwork.ozlabs.org/api/1.2/people/92821/?format=json","name":"Andrey Albershteyn","email":"aalbersh@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260409131404.1545834-14-aalbersh@kernel.org/mbox/","series":[{"id":499292,"url":"http://patchwork.ozlabs.org/api/1.2/series/499292/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/list/?series=499292","date":"2026-04-09T13:13:34","name":"fs-verity support for XFS with post EOF merkle tree","version":7,"mbox":"http://patchwork.ozlabs.org/series/499292/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221461/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221461/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n <SRS0=2wEm=CI=vger.kernel.org=linux-ext4+bounces-15710-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=WJ4s8HyY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=2wem=ci=vger.kernel.org=linux-ext4+bounces-15710-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c04:e001:36c::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=WJ4s8HyY;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15710-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"WJ4s8HyY\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs0yY2BCwz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 23:24:21 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fs0yY20Bxz4wLM\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 23:24:21 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fs0yY1vJNz4wd3; Thu, 09 Apr 2026 23:24:21 +1000 (AEST)","from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fs0yT4j1Kz4wLM\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 09 Apr 2026 23:24:17 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 23A043094907\n\tfor <patchwork-incoming@ozlabs.org>; Thu,  9 Apr 2026 13:17:17 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BBB133D75D9;\n\tThu,  9 Apr 2026 13:14:50 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E370B3B7B71;\n\tThu,  9 Apr 2026 13:14:49 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id F3614C4CEF7;\n\tThu,  9 Apr 2026 13:14:46 +0000 (UTC)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775741061; cv=pass;\n\tb=s5B/spJdJlW1taEouBFhu+fyzOgwkRQptbANS5bcMcSi+xP9OBmATGq8G12VNBYjNw8lKnvrHyUuN6HGe2LGbST8jlAVaPIlKxxR02IItqnTqAnAGI4wHgff550Xti0tLzx3T6CEXAtn24DMTYhGxupzX+rSyZeumfGEew9d3f3PSpY4DP+EDprmji6trcdwGj7yt2IymO4DgoBGUR3AymZ2JXjgj3km9JaC7NvhkeSnuUsu7130RSj1izuylseik80fyG3Ff3CVcfEv7q0Ii02XOnK+YXVLgO1+g5aHkGjJ0NY2UsunurET5Mh5hueSL+c64kRP+dpBocELNgf5zw==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775740490; cv=none;\n b=Bv5QwdnsIHHXEJFaoQ9U57MC6bE5gDwE/XlzGDKliIWuzgd97F0GVIaGEQMH0T9NyPW8nwQEKqEFFek0+qaSQce6SMhXYWugiPC1HOImaEFIAudpqUX6YHGTYzet6DzqtrgtgwpfC+cVDQxbUHCdUwqJnCNQZxKWoKSK5nBJIK0="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775741061; c=relaxed/relaxed;\n\tbh=L7lbVMXOwHHcAevnI59LdKxFWewGKSw08vt9Mtg3z1Q=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=DNHqVwpbHds0otwtRmyhboSagXZRQkWnm2cacR8L531ztKp2lWO/rJl17T/b2Zx/cfrYxHKRcamAF9JNEtq3bakbrPtSLQmyWfO8+zFvmfvhQhray5Zob6YxgSXRUkiP/+nQDcAtINbCjtk9mk2Ap4PMf0VGfXcoLkLeqVqPfYPNY1VkhHaaAWChxEmz1+KWv7Uk+akMaxIkV7wCFdZOcqtEnEFRq68wL1m/wjyCQSUsGaoheritOMfRACqqqK8nRqnibQSmwwZXFC7Rotcl6/9bUU2mdOKvfSTKD2iJU1gyXvvk1FEf8Da0nNK5czCa6iCiZfrtJOL1epE4jWbBOg==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775740490; c=relaxed/simple;\n\tbh=l2TuE4Dq3W00QnGqh26ac7WtX/eqBCa3lcQ4ZM8TF1E=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=j59p26ZTNi2Evpxhzcm2dmkzCthjJ+Z47FQv+r33PrKF4VerEG8d5/AGD/OX6/DhtUYIkud+CYmHeIxF8TD2vCbNd1zVvCEz09StYK86YEa/HDHzORFgav7+CbiE8MnxbwtikeFPiewHoK/PgfLJDUKMeL52cbPzdFO1T30yZ6U="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=WJ4s8HyY; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15710-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=WJ4s8HyY; arc=none smtp.client-ip=10.30.226.201"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775740489;\n\tbh=l2TuE4Dq3W00QnGqh26ac7WtX/eqBCa3lcQ4ZM8TF1E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WJ4s8HyYV75KHwcaqCCKhXiuuEKo2ecMsEbRxEAJoqzJJgLXUmg/C9rnLiaPMlj0T\n\t X3ti136pw9u6p0BDwMdQJR++WswgCmum67Diyxknx6PbYLOkFgWE/AtbynCfKjh756\n\t pL3vuuwTzNKRlcEsdb97WvRKU4OMv1AOmw+IPatWEDySXM92rlbYO8mGP79MX39uMC\n\t bE6MyPcGqkUChr3/O30SA0nMgHBh2nuvs/MVWm300RdN0a44MED8JS5wKjObLmwH+m\n\t tJ+XtEfLc6StJB9YSkYZhUGi33LQ0wzfK6QcSj7MZZUjziy9dQvS9VpwxDT3jtnaIn\n\t IJMGeF1fVJnlA==","From":"Andrey Albershteyn <aalbersh@kernel.org>","To":"linux-xfs@vger.kernel.org,\n\tfsverity@lists.linux.dev,\n\tlinux-fsdevel@vger.kernel.org,\n\tebiggers@kernel.org","Cc":"Andrey Albershteyn <aalbersh@kernel.org>,\n\thch@lst.de,\n\tlinux-ext4@vger.kernel.org,\n\tlinux-f2fs-devel@lists.sourceforge.net,\n\tlinux-btrfs@vger.kernel.org,\n\tdjwong@kernel.org","Subject":"[PATCH v7 13/22] xfs: disable direct read path for fs-verity files","Date":"Thu,  9 Apr 2026 15:13:45 +0200","Message-ID":"<20260409131404.1545834-14-aalbersh@kernel.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20260409131404.1545834-1-aalbersh@kernel.org>","References":"<20260409131404.1545834-1-aalbersh@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"},"content":"The direct path is not supported on verity files. Attempts to use direct\nI/O path on such files should fall back to buffered I/O path.\n\nSigned-off-by: Darrick J. Wong <djwong@kernel.org>\nReviewed-by: Christoph Hellwig <hch@lst.de>\nSigned-off-by: Andrey Albershteyn <aalbersh@kernel.org>\n---\n fs/xfs/xfs_file.c | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)","diff":"diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c\nindex a980ac5196a8..6fa9835f9531 100644\n--- a/fs/xfs/xfs_file.c\n+++ b/fs/xfs/xfs_file.c\n@@ -282,7 +282,8 @@ xfs_file_dax_read(\n \tstruct kiocb\t\t*iocb,\n \tstruct iov_iter\t\t*to)\n {\n-\tstruct xfs_inode\t*ip = XFS_I(iocb->ki_filp->f_mapping->host);\n+\tstruct inode\t\t*inode = iocb->ki_filp->f_mapping->host;\n+\tstruct xfs_inode\t*ip = XFS_I(inode);\n \tssize_t\t\t\tret = 0;\n \n \ttrace_xfs_file_dax_read(iocb, to);\n@@ -333,6 +334,14 @@ xfs_file_read_iter(\n \tif (xfs_is_shutdown(mp))\n \t\treturn -EIO;\n \n+\t/*\n+\t * In case fs-verity is enabled, we also fallback to the buffered read\n+\t * from the direct read path. Therefore, IOCB_DIRECT is set and need to\n+\t * be cleared (see generic_file_read_iter())\n+\t */\n+\tif (fsverity_active(inode))\n+\t\tiocb->ki_flags &= ~IOCB_DIRECT;\n+\n \tif (IS_DAX(inode))\n \t\tret = xfs_file_dax_read(iocb, to);\n \telse if (iocb->ki_flags & IOCB_DIRECT)\n","prefixes":["v7","13/22"]}