{"id":2221431,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221431/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260409-boot-fit-fix-8-byte-alignement-for-overlays-v2-1-32a7878e134a@baylibre.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260409-boot-fit-fix-8-byte-alignement-for-overlays-v2-1-32a7878e134a@baylibre.com>","list_archive_url":null,"date":"2026-04-09T13:15:43","name":"[v2] boot/fit: fix misleading comment","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"74520f006c9005ae1388555cfb3561451603046d","submitter":{"id":84831,"url":"http://patchwork.ozlabs.org/api/1.2/people/84831/?format=json","name":"Julien Stephan","email":"jstephan@baylibre.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.2/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260409-boot-fit-fix-8-byte-alignement-for-overlays-v2-1-32a7878e134a@baylibre.com/mbox/","series":[{"id":499293,"url":"http://patchwork.ozlabs.org/api/1.2/series/499293/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=499293","date":"2026-04-09T13:15:43","name":"[v2] boot/fit: fix misleading comment","version":2,"mbox":"http://patchwork.ozlabs.org/series/499293/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221431/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221431/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=lBnn60xI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.b=\"lBnn60xI\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=jstephan@baylibre.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs0md2Ds4z1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 23:15:45 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 76389840B0;\n\tThu,  9 Apr 2026 15:15:42 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 114F384142; Thu,  9 Apr 2026 15:15:42 +0200 (CEST)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n [IPv6:2a00:1450:4864:20::329])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id BC29D83CF5\n for <u-boot@lists.denx.de>; Thu,  9 Apr 2026 15:15:39 +0200 (CEST)","by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-48897fd88ebso9465075e9.2\n for <u-boot@lists.denx.de>; Thu, 09 Apr 2026 06:15:39 -0700 (PDT)","from [192.168.1.100]\n (2a02-842a-d52e-6101-c778-651b-ee6b-086f.rev.sfr.net.\n [2a02:842a:d52e:6101:c778:651b:ee6b:86f])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488cfa5d118sm55034675e9.11.2026.04.09.06.15.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Apr 2026 06:15:38 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775740539;\n x=1776345339;\n darn=lists.denx.de;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:from:to:cc:subject:date:message-id:reply-to;\n bh=mCgZsZZ3zjWYziUMUWWBxi6kutRYPT7usCoWJEIoQGo=;\n b=lBnn60xIL4gkDm3jPLq9NHB5H9D4+CFdXQDxLPiQp6FB7u24ABsE/A8Bj3BUVfcNzZ\n G4xLOeC+eQ7RWJvvf9uqbwe5tqlpZ8MgDDSLMr9q1gn+HY2pPYg6f9aJ8ueU6tUxrJwR\n q2Gf63qG5t6kVhiyiJLFKRFhUfGUHoZZY3TAUQPzqYeyUnhYoPAZbBTr8nC29pYU9Ec5\n EVh+bnHQXqSqL60yiyV98/6RM1w9QBtjmnw9XgVz/DSIHTuGT/MSO2ha15z9vWt4uAfM\n 2togdO2rYB/Vq1PadISge50UDB4ROuOnDc9cZnvFU7IZgd56jKbgpVSYgEvT1RKToOhE\n aNww==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775740539; x=1776345339;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=mCgZsZZ3zjWYziUMUWWBxi6kutRYPT7usCoWJEIoQGo=;\n b=ZXnriGEDHM6ZF7GYDFHv6VvUBASrXOc92+8isoiEd0T4gCUIgHx2n+kU7omb6qrES7\n rEoCQdMBirDSTyzCRPAINZz3RV0ENnLnstrBhSgHBPrdMQKONUQA17A2kaZrASxe9p/p\n jx9YjSyv6mYvstmRirtLDvvsqY3FkLftysxI7mJXTsD+l2SprxwRohkTMQn/GKtbrjdN\n lbXoktKLDeVtcv7XVjDu0vTP02a0uqb2blCqsdN+3t9fCX5mY5YE5NAEewCUfeiY6iJC\n hp/yKCH/sK2HUGM6q2aH4yNRlFj19HJRFMxPLPF1uhTB7uJaFedw6uzMkOy/OA3tL+72\n 4ltg==","X-Gm-Message-State":"AOJu0YxtVMCcZ5nQc3eEY+3mB9/1caQglWDwu9eVf6ng6OLK8GZRxr2U\n MW7M4KI9tahPXkzwLmhvhhp+PUOqdgXizVZsJswjbttogmxSnQpCqApzC9l1s7+5mKM=","X-Gm-Gg":"AeBDievTTy2DMefqmsNSiI5dGstrbQZu6jbIFamTfABbAmnSxpJoree3jMOe5YKPIpB\n onEUU/MFyE4c3Apd+pW7nDAaA7ilAgItOT2UKV6sQL+onLtwygBAg3NsnQJfIRXbizwJp1vEirT\n nfeu/Y13Xqz/FKreFX7yiCefEP4l/tK/BDbWNVYCh2X1TMj5cEknQsCr8oB497NzXPc85BrsJzu\n 9Ze1dIALfCuI9qHx+PfT9pJJdBuGAObATDOLWK/5gK4wyVtlXW04QHWXcWLjmg9P+rqvsoMpRJc\n 0R5oF/KGqjYTDl44r4eqO+qY/2k6hIbXtel0y3YQczApu/PpRxTtPaoXjW5bPVuZVXc02EfvZTL\n Q/tfO0x4M1jtN+1zTu0FhnnaTUPxZqNmzFpf6qIPzayNqYgv8l2QJfOhEuNmPSHfetNpK9f/R5G\n bDlrGhuSwuV3AjLhZUYbRZh/p2zhPJE3LqEJWC8QVwP+QlIg0pH+/UXVtq9gb1stfIfo26V1VfK\n t+aklpeZF1aIjt9y+cL/W3UUvLsn6NZYkRZpMGeXndBqobeeTH+kTFfrhTvIJWVDtZpHpfMWcCE\n ZphOa1A=","X-Received":"by 2002:a05:600c:c0dc:b0:485:3193:6ddb with SMTP id\n 5b1f17b1804b1-488ccf3a0fcmr39485325e9.3.1775740539093;\n Thu, 09 Apr 2026 06:15:39 -0700 (PDT)","From":"Julien Stephan <jstephan@baylibre.com>","Date":"Thu, 09 Apr 2026 15:15:43 +0200","Subject":"[PATCH v2] boot/fit: fix misleading comment","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"\n <20260409-boot-fit-fix-8-byte-alignement-for-overlays-v2-1-32a7878e134a@baylibre.com>","X-B4-Tracking":"v=1; b=H4sIAAAAAAAC/52NQQqDMBBFryJZd4qJVqWr3qO4yOioA5qUJIQG8\n e6NHqGLv3gf/n+78OSYvHgWu3AU2bM1GdStEMOizUzAY2ahStWUlaoBrQ0w8ZkvdIApEOiVZ0M\n bmdxaBzaSW3XyUHUSSy1bnGoS+fHjKK8u27vPvLAP1qVLHuXZ/ueJEiSoR4uyUtjgqF+o08ro6\n D7YTfTHcfwAEPZxRekAAAA=","X-Change-ID":"20260324-boot-fit-fix-8-byte-alignement-for-overlays-381b0a17bf4e","To":"u-boot@lists.denx.de","Cc":"GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,\n Tom Rini <trini@konsulko.com>, Quentin Schulz <quentin.schulz@cherry.de>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n James Hilliard <james.hilliard1@gmail.com>,\n David Lechner <dlechner@baylibre.com>,\n Julien Stephan <jstephan@baylibre.com>","X-Mailer":"b4 0.14.3","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"When load address is specified but set to 0, we ignore it and load in\nplace instead. The current comment is misleading, so update it.\n\nSigned-off-by: Julien Stephan <jstephan@baylibre.com>\n---\nIt turns out that the else is not useless. The comment associated to it,\nwas misleading, so update the comment instead of removing the else\nbranch\n---\nChanges in v2:\n- update comment instead of removing else branch\n- Link to v1: https://lore.kernel.org/r/20260324-boot-fit-fix-8-byte-alignement-for-overlays-v1-1-257b132b6bda@baylibre.com\n---\n boot/image-fit.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\n---\nbase-commit: f0000b4a57e9edf8ff8454b9056d767466dff57f\nchange-id: 20260324-boot-fit-fix-8-byte-alignement-for-overlays-381b0a17bf4e\n\nBest regards,","diff":"diff --git a/boot/image-fit.c b/boot/image-fit.c\nindex 067ad236081..2d2709aa5b1 100644\n--- a/boot/image-fit.c\n+++ b/boot/image-fit.c\n@@ -2282,7 +2282,7 @@ int fit_image_load(struct bootm_headers *images, ulong addr,\n \t\tprintf(\"   Loading %s from 0x%08lx to 0x%08lx\\n\",\n \t\t       prop_name, data, load);\n \t} else {\n-\t\tload = data;\t/* No load address specified */\n+\t\tload = data;\t/* load address specified but set to 0 */\n \t}\n \n \tcomp = IH_COMP_NONE;\n","prefixes":["v2"]}