{"id":2221405,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221405/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260409120003.2719-7-marcin.szycik@linux.intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260409120003.2719-7-marcin.szycik@linux.intel.com>","list_archive_url":null,"date":"2026-04-09T11:59:59","name":"[iwl-next,v2,06/10] ice: use plain alloc/dealloc for ice_ntuple_fltr","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"03e6da74c9e9055e4e952ba1e9987b443d962e4c","submitter":{"id":82782,"url":"http://patchwork.ozlabs.org/api/1.2/people/82782/?format=json","name":"Marcin Szycik","email":"marcin.szycik@linux.intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260409120003.2719-7-marcin.szycik@linux.intel.com/mbox/","series":[{"id":499287,"url":"http://patchwork.ozlabs.org/api/1.2/series/499287/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499287","date":"2026-04-09T11:59:53","name":"Add ACL support","version":2,"mbox":"http://patchwork.ozlabs.org/series/499287/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221405/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221405/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=KSBn/7rE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs0R82M7Yz1yCv\n\tfor ; Thu, 09 Apr 2026 23:00:36 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id BEC4440B5A;\n\tThu, 9 Apr 2026 13:00:34 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Fy2EnIhmZhbi; Thu, 9 Apr 2026 13:00:32 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id A404D41065;\n\tThu, 9 Apr 2026 13:00:32 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id D83461F6\n for ; Thu, 9 Apr 2026 13:00:29 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id D4AAF40127\n for ; Thu, 9 Apr 2026 13:00:28 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id wv7tjozVtVJJ for ;\n Thu, 9 Apr 2026 13:00:28 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.19])\n by smtp2.osuosl.org (Postfix) with ESMTPS id CDE31400F6\n for ; Thu, 9 Apr 2026 13:00:27 +0000 (UTC)","from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Apr 2026 06:00:18 -0700","from irvmail002.ir.intel.com ([10.43.11.120])\n by orviesa002.jf.intel.com with ESMTP; 09 Apr 2026 06:00:16 -0700","from gond.igk.intel.com (gond.igk.intel.com [10.123.220.52])\n by irvmail002.ir.intel.com (Postfix) with ESMTP id A5B2B2FC58;\n Thu, 9 Apr 2026 14:00:15 +0100 (IST)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org A404D41065","OpenDKIM Filter v2.11.0 smtp2.osuosl.org CDE31400F6"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775739632;\n\tbh=LXLM1vLl074uX1RRoOHmrOOgQQQHC6E1pQlOjkEvwp0=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=KSBn/7rEK5IB4bpqkA/wShpfeVI0kIwOCTi+bwd6Z6MAHEZhwIUqnnqrjW3fVOmIc\n\t EebiZddZbsB7S8QAqo35KKhqxGRLR82PsWse7qet7zx+nJ3NWeqh/lx0CsWls8iuly\n\t CQYBWfrXEmX0k0Bx9DLzq8pw4HfHFU/qeTlU+TsUqVFhN/SbJPFdPqxNxxMqi6/5hr\n\t KrQ/36WwwT80dnmpgnxXePfelahRNLDnoZjSwuie43Lj34Q/xOXWGDTBUXO3xu5aDM\n\t O0wxLh8JEB7k7ofM0MA4wxGXf6Ick4nf9TsioP8ijfWY1VsOTsPc8Wvn/ATH0RaERO\n\t VpbG/uJSH+vow==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.19;\n helo=mgamail.intel.com; envelope-from=marcin.szycik@linux.intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org CDE31400F6","X-CSE-ConnectionGUID":["hfp6j3wRQwqaKbyWqjOTUw==","36SONYIFQQGixnFsTayVkQ=="],"X-CSE-MsgGUID":["1ymKjJmGSL6+MKCzt/rQGA==","R2QTIDzeSCyXuiGqqOje3g=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11753\"; a=\"75777526\"","E=Sophos;i=\"6.23,169,1770624000\"; d=\"scan'208\";a=\"75777526\"","E=Sophos;i=\"6.23,169,1770624000\"; d=\"scan'208\";a=\"259208113\""],"X-ExtLoop1":"1","From":"Marcin Szycik ","To":"intel-wired-lan@lists.osuosl.org","Cc":"netdev@vger.kernel.org, sandeep.penigalapati@intel.com,\n ananth.s@intel.com,\n alexander.duyck@gmail.com, Marcin Szycik ,\n Aleksandr Loktionov ","Date":"Thu, 9 Apr 2026 13:59:59 +0200","Message-ID":"<20260409120003.2719-7-marcin.szycik@linux.intel.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20260409120003.2719-1-marcin.szycik@linux.intel.com>","References":"<20260409120003.2719-1-marcin.szycik@linux.intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775739628; x=1807275628;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=bBbnnIzfb8m+qy0omERvBIWpootbQKRVNSRImW14udE=;\n b=ntV6S3AhjS+IFI9cUdeHRO2vN2TWVZf5l9jcEXmUlAQ4Bmr8dEvBm9o3\n HPSlH/2Qmr7JdNoAcBiKg662315f7BM00IL6NrYFaI4MYMxVTOfdW1vIA\n RMWz/9/F1yRR6dPdqsFiDYOWzyYkb4wL3XPm1eBPyUlahmuaYX77Mra8D\n HvdxdoVXOggnoDLdIzQopYhhtlYiEMhOnrpqKOad7tuR/GdyYkaqa3CNv\n XrfHn3qi93NSmWWJFAsqiNviLSO4t9zcRldQH04aWvBawVWMzooKbzGQG\n +hCWX5XyElEYVF3ihsFFxSZJSN/4Z1AzAE1LWUz/lCP7R7PJ2YTNxNw7f\n w==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=ntV6S3Ah"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v2 06/10] ice: use plain\n alloc/dealloc for ice_ntuple_fltr","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Change struct ice_ntuple_fltr allocation from devm_ to plain alloc,\nsince its lifetime is not tied to the device. All such objects are being\nremoved on device remove via ice_deinit_features() -> ice_deinit_fdir()\n-> ice_vsi_manage_fdir() -> ice_fdir_del_all_fltrs()\n\nSigned-off-by: Marcin Szycik \nReviewed-by: Aleksandr Loktionov \n---\nv2:\n* Add this patch\n---\n drivers/net/ethernet/intel/ice/ice_ethtool_ntuple.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool_ntuple.c b/drivers/net/ethernet/intel/ice/ice_ethtool_ntuple.c\nindex eca15cb2665e..b5a841732b58 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool_ntuple.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool_ntuple.c\n@@ -1748,7 +1748,7 @@ void ice_fdir_del_all_fltrs(struct ice_vsi *vsi)\n \t\tice_fdir_update_cntrs(hw, f_rule->flow_type, f_rule->acl_fltr,\n \t\t\t\t false);\n \t\tlist_del(&f_rule->fltr_node);\n-\t\tdevm_kfree(ice_pf_to_dev(pf), f_rule);\n+\t\tkfree(f_rule);\n \t}\n }\n \n@@ -1855,7 +1855,7 @@ ice_ntuple_update_list_entry(struct ice_pf *pf, struct ice_ntuple_fltr *input,\n \t\t\t */\n \t\t\tice_fdir_do_rem_flow(pf, old_fltr->flow_type);\n \t\tlist_del(&old_fltr->fltr_node);\n-\t\tdevm_kfree(ice_hw_to_dev(hw), old_fltr);\n+\t\tkfree(old_fltr);\n \t}\n \tif (!input)\n \t\treturn err;\n@@ -2206,7 +2206,7 @@ int ice_add_ntuple_ethtool(struct ice_vsi *vsi, struct ethtool_rxnfc *cmd)\n \t\treturn -ENOSPC;\n \t}\n \n-\tinput = devm_kzalloc(dev, sizeof(*input), GFP_KERNEL);\n+\tinput = kzalloc_obj(*input);\n \tif (!input)\n \t\treturn -ENOMEM;\n \n@@ -2250,7 +2250,7 @@ int ice_add_ntuple_ethtool(struct ice_vsi *vsi, struct ethtool_rxnfc *cmd)\n \tmutex_unlock(&hw->fdir_fltr_lock);\n free_input:\n \tif (ret)\n-\t\tdevm_kfree(dev, input);\n+\t\tkfree(input);\n \n \treturn ret;\n }\n","prefixes":["iwl-next","v2","06/10"]}