{"id":2221370,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221370/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260409095926.905020-5-rajasimandalos@gmail.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.2/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260409095926.905020-5-rajasimandalos@gmail.com>","list_archive_url":null,"date":"2026-04-09T09:59:22","name":"[5/9] smb: client: sync echo_interval on remount","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"594a7a9f69f254ad33a0c448b26629fe05ca22c1","submitter":{"id":91740,"url":"http://patchwork.ozlabs.org/api/1.2/people/91740/?format=json","name":"Rajasi Mandal","email":"rajasimandalos@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260409095926.905020-5-rajasimandalos@gmail.com/mbox/","series":[{"id":499267,"url":"http://patchwork.ozlabs.org/api/1.2/series/499267/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=499267","date":"2026-04-09T09:59:18","name":"[1/9] smb: client: block non-reconfigurable option changes on remount","version":1,"mbox":"http://patchwork.ozlabs.org/series/499267/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221370/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221370/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=rN3QFEG4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10733-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"rN3QFEG4\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.210.175","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frwc55VHjz1yD3\n\tfor ; Thu, 09 Apr 2026 20:08:05 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id DDE7830A814D\n\tfor ; Thu, 9 Apr 2026 10:01:00 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8A8BC30E0C0;\n\tThu, 9 Apr 2026 10:00:09 +0000 (UTC)","from mail-pf1-f175.google.com (mail-pf1-f175.google.com\n [209.85.210.175])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 594393B9DAD\n\tfor ; Thu, 9 Apr 2026 10:00:06 +0000 (UTC)","by mail-pf1-f175.google.com with SMTP id\n d2e1a72fcca58-82c70e4654eso356368b3a.2\n for ;\n Thu, 09 Apr 2026 03:00:05 -0700 (PDT)","from dev-vm-rm.hzz4ddxqtfeetjrh00qlbgyytb.rx.internal.cloudapp.net\n ([20.197.52.255])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82cf9c6b80dsm29113671b3a.42.2026.04.09.03.00.00\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Apr 2026 03:00:03 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775728809; cv=none;\n b=CllaizTaDeulmi6dsrr9XtTDKZW+Y3vW8GgvnLcEsaOHUCplsTqTt9LN2GIEWTyA69JDynVoUwbcarMvFs/ngNMIBaATaGhxk7UrmK3sBeWmB3WtD0xn80J1/mkmbWama/t2rNdiIBLE9UOdhyPLqWXEPJ5zYKvNnEq3qIyj7b8=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775728809; c=relaxed/simple;\n\tbh=RVmOzj+VrRfnJZI8/LY4J0FhhyKspM50b7uZjuZlr1c=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=cIZeK25zANwCGGXVFrPtZUFu+CJ/mB24rPAhxj+0i70WKU6J2cT4mNEa6JZRHobp8s4O73ccADlcc4bOM5KRjvCrSZ+YrwgUURBLXpNKc4H9uzOF+cEw9Qc77GeA/xJvzYZyH4zHH87PTipLwDwxNM/UdYSRRRIlRHUgVLkz/sg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=rN3QFEG4; arc=none smtp.client-ip=209.85.210.175","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775728804; x=1776333604;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=lUAeJTrTvdEpdggBCNQjpDx1YpSTeG9FOV5VC3SOnkY=;\n b=rN3QFEG4eYZh+zlk3/1x5iNESXaS+LlNzbdC3GjUyODqM+fqaF1liqMAagaUujxry/\n NaiYRlLAPQjLhnH9vkzRKqLfSmNCQ9WLYnec74PlSUG3vcMWHxhvA2jeF8ORKAObDRqS\n /lrvK8Wvqtdg5lqBexbJ9z0GOyOvGgf2+mwbjn08SZN1RJPEu5aIAAd6uamILByHGu+p\n ONtr9wqEJFfv/iiXCSGeck6oiEejPnLgz5GA2Qd6z7Im6EvnoY76FXn5+4uPx+0hY8T2\n JDQU25dn+W29kC5piZxmu7v7ZxhlSIdC5UAG1I/wzyTZrv1frGx5Owtpf0N/dn55DTN7\n 5ABA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775728804; x=1776333604;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=lUAeJTrTvdEpdggBCNQjpDx1YpSTeG9FOV5VC3SOnkY=;\n b=ICg7Z6nfuxh/T3vcNP5JElq6BBqY0qW5ksRvlzRuGHPfKeIhjcMtMfjCuGoAUs1Fr2\n ZtbMXuB4ckk/U+lFK31cjnig9oAdt+So/5gfkxndBqKfI0H/XwSFAIkvW9fGUzih6oLd\n 7LvX13/kbekNySdPuIWZsBg8j7ReUx5StjFMVXn9w78AJg0XxCjFClnSPfOlhzPo8Ova\n cJ0WyWcaE1GOWAGT+wiLauceyy89A8TU99IDRw50gJ4T08UjmWT0iko8xxxwBQqB5Wmn\n SfVO88WO5WH8y51natYAQOmNI8uA1qtL35f0O3uHX0xiuQT8tTaajX+99J7yd4pufWoK\n 8dwQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUq+jNiLy6j+Jdk3VBjxPeT2p4ZY5IxqA19loejf26LyejarJwOnHX2S113tXJyr0xs5aXG1Wi/Q8a8@vger.kernel.org","X-Gm-Message-State":"AOJu0YxHq7PKsqVZI+szGS5WbYI83q148wpxigrFpY6pGUCVtClTXcXv\n\tZL+6IYNVrA9Jl+fWvLPA09o3madmkBeJBdm+iri4s8GOpx/bMtn2o+CU","X-Gm-Gg":"AeBDieuiFJ3g7PxC7kAiamEDtAZI3PA6d/nurLJ6FpAYsNl7snQTMebnQe4Tgr80DOD\n\tDhnSD+O0uqpt4A83YYkjxWE8B4JCy4dxVcBTTtCZXitnQwWaaxgBOCPEbz9MkG9nzvKhOwbvGdX\n\t651LzPiX0yB796AA8UYxybW27Fmrh6kgi3Xj8t60sbSvDGxeEk6MiPbw28QjO2C4+hpnyZJpfrm\n\tZexsAT93INdCZ1iLWRB0fsWKa/q7Nf/6bklBwZzt2qORVT/FsWmSdk9DYz+iJ77lrytG2IGHjJb\n\tllJJtCYFZXrdkXW1j/B6HnE9ypuwDhIeGuIqqYUO5xbohTHZYFn1qT/fWP+g0i0gMRlruSyTbD9\n\tjhqu6Ifx0tDffrNT6E4VdZF2OvHnuU6ciAaTpPSvx4EwkxjodoJMM4g8L/Fb97cgPkozYTnQ9tb\n\tB3jkKsTM1H5Rb1L4r7v7SBG3D83n+is5EUaI48a2QRkYho61JL+qVsUHFKgRUqMrSIsl9PQ8SEJ\n\tta2sNdt0446wPR/IT0a1wI=","X-Received":"by 2002:a05:6a00:f93:b0:82c:6f07:299f with SMTP id\n d2e1a72fcca58-82d0da834c7mr23176308b3a.14.1775728803985;\n Thu, 09 Apr 2026 03:00:03 -0700 (PDT)","From":"rajasimandalos@gmail.com","To":"sfrench@samba.org,\n\tlinux-cifs@vger.kernel.org","Cc":"pc@manguebit.org,\n\tronniesahlberg@gmail.com,\n\tsprasad@microsoft.com,\n\ttom@talpey.com,\n\tmetze@samba.org,\n\tbharathsm@microsoft.com,\n\tsamba-technical@lists.samba.org,\n\tlinux-kernel@vger.kernel.org,\n\tRajasi Mandal ","Subject":"[PATCH 5/9] smb: client: sync echo_interval on remount","Date":"Thu, 9 Apr 2026 09:59:22 +0000","Message-ID":"<20260409095926.905020-5-rajasimandalos@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260409095926.905020-1-rajasimandalos@gmail.com>","References":"<20260409095926.905020-1-rajasimandalos@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Rajasi Mandal \n\nAdd echo_interval handling to smb3_sync_server_opts() so that\nchanging echo_interval via remount actually takes effect on the\nrunning connection.\n\nThe server echo worker fires every server->echo_interval jiffies,\nbut that field was never updated from cifs_sb->ctx on remount.\nConvert the user-supplied seconds value to jiffies and reschedule\nthe echo worker with mod_delayed_work() so the new interval is\npicked up immediately.\n\nThe assignment is guarded (if ctx->echo_interval) so that an\nexplicit echo_interval=0 does not accidentally reset the interval.\n\nSigned-off-by: Rajasi Mandal \n---\n fs/smb/client/fs_context.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)","diff":"diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c\nindex 31b82f8f7ead..5f0637035172 100644\n--- a/fs/smb/client/fs_context.c\n+++ b/fs/smb/client/fs_context.c\n@@ -1338,9 +1338,9 @@ static void smb3_sync_tcon_opts(struct cifs_sb_info *cifs_sb,\n \n /*\n * Synchronize server-level options that are stored on TCP_Server_Info\n- * at mount time. These fields are consulted at runtime (retry logic)\n- * so remount needs to update the live server struct in addition to\n- * cifs_sb->ctx.\n+ * at mount time. These fields are consulted at runtime (echo work,\n+ * retry logic) so remount needs to update the live server struct in\n+ * addition to cifs_sb->ctx.\n */\n static void smb3_sync_server_opts(struct cifs_sb_info *cifs_sb)\n {\n@@ -1349,6 +1349,11 @@ static void smb3_sync_server_opts(struct cifs_sb_info *cifs_sb)\n \n \tif (ctx->retrans)\n \t\tserver->retrans = ctx->retrans;\n+\tif (ctx->echo_interval) {\n+\t\tserver->echo_interval = ctx->echo_interval * HZ;\n+\t\tmod_delayed_work(cifsiod_wq, &server->echo,\n+\t\t\t\t server->echo_interval);\n+\t}\n }\n \n static int smb3_reconfigure(struct fs_context *fc)\n","prefixes":["5/9"]}