{"id":2221362,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221362/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260409093020.3808687-1-aleksandr.loktionov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260409093020.3808687-1-aleksandr.loktionov@intel.com>","list_archive_url":null,"date":"2026-04-09T09:30:20","name":"[net-next,v2] iavf: fix kernel-doc comment style in iavf_ethtool.c","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fd02de569f661215f3e1516a8661d6117f3aaf68","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/1.2/people/75597/?format=json","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260409093020.3808687-1-aleksandr.loktionov@intel.com/mbox/","series":[{"id":499266,"url":"http://patchwork.ozlabs.org/api/1.2/series/499266/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499266","date":"2026-04-09T09:30:20","name":"[net-next,v2] iavf: fix kernel-doc comment style in iavf_ethtool.c","version":2,"mbox":"http://patchwork.ozlabs.org/series/499266/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221362/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221362/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=8ciQIHEr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frvmv6CYbz1xtJ\n\tfor ; Thu, 09 Apr 2026 19:30:39 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 294FE40B30;\n\tThu, 9 Apr 2026 09:30:38 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id MN96DVswP7VY; Thu, 9 Apr 2026 09:30:36 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 64C6940A98;\n\tThu, 9 Apr 2026 09:30:36 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 842AC237\n for ; Thu, 9 Apr 2026 09:30:34 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 617D560D92\n for ; Thu, 9 Apr 2026 09:30:34 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ZxnQwTVWxBow for ;\n Thu, 9 Apr 2026 09:30:33 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.9])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 5E1D36085F\n for ; Thu, 9 Apr 2026 09:30:33 +0000 (UTC)","from fmviesa007.fm.intel.com ([10.60.135.147])\n by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Apr 2026 02:30:23 -0700","from amlin-019-225.igk.intel.com ([10.102.19.225])\n by fmviesa007.fm.intel.com with ESMTP; 09 Apr 2026 02:30:21 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 64C6940A98","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5E1D36085F"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775727036;\n\tbh=FGpOESm4pt7NJBYd807lDoTaH55R9/u8KBIuaHklUtI=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=8ciQIHErSDNC4pjDtDi0/QYyjMvBUX9Upe9RZ23GlZebTPaGLFkBcr1KY1Tj1iGIi\n\t qY1HjXGfOWwYQZ5pGDevmHeEw/GxEfZ1pi37RH/PAzq+qS90PPNd7ywkWjidCD0b3/\n\t 0A42VfD2+qoWK/s1mJzffyBOdj31o3lFLj8UnOwatLUnKAPgQMImU5FM9LldZBjIka\n\t ldEdBKfDuvzyUxwhYnbyeL9xq0fnd1fQ9ox1weHJePkrI+yQOD2RonY+r5E4a71Lzk\n\t 3RJPSePvPJD9JCqMYGixy7+TTTGSkeUjTRPo+9/EOAGXGiGprTVi7IPi/biYkgmdss\n\t AG1naWlZ4GmcA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.9;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 5E1D36085F","X-CSE-ConnectionGUID":["/XjrlIl7S02lbsLdOz251w==","3MAVYzx+SFOalnYUalmgfw=="],"X-CSE-MsgGUID":["q5cRpNs9RdeNjjhxFsGsTA==","amAGPJs1SSmmeKyoKhXqVQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11753\"; a=\"99353990\"","E=Sophos;i=\"6.23,169,1770624000\"; d=\"scan'208\";a=\"99353990\"","E=Sophos;i=\"6.23,169,1770624000\"; d=\"scan'208\";a=\"225557921\""],"X-ExtLoop1":"1","From":"Aleksandr Loktionov ","To":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com","Cc":"netdev@vger.kernel.org,\n\tLeszek Pepiak ","Date":"Thu, 9 Apr 2026 11:30:20 +0200","Message-ID":"<20260409093020.3808687-1-aleksandr.loktionov@intel.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775727034; x=1807263034;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=cZC1cpq3OkYGpFiaUIPpsCrPyX8cmaKcyyjykqFlc08=;\n b=fikXucms1QBfcDhndifIkIHvIjwcUJ1HV4THwksD41Lx/U80Xc17pkJC\n UNFt06HU51zf82hePoSsJp4ZF/3HAeYSUx6Ghy+6noffoTtkYtUL0Vh/K\n Lzz7wrKFls55Fe5X1MWM9DirjxGNjeWCUkFJK3J+TQ+nABokm5sXk4AMn\n uWWP/vTyZW7rnYvRoNMDXcZ4ROXP/NR2YmVbYhAPDegy69wkZKtu5YU5m\n el9Fjg5UVizJvc4cSMCb2CLoe4+OB5zKcOYkjYJzitKuGf4p71g38oSL6\n LySOkCqrgFuIx42ROmmzeWPnL0SZbRxKslf/zp0WW5JM/tTyrfSE/pwxT\n w==;","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=fikXucms"],"Subject":"[Intel-wired-lan] [PATCH net-next v2] iavf: fix kernel-doc comment\n style in iavf_ethtool.c","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"iavf_ethtool.c contains 31 kernel-doc comment blocks using the legacy\n`**/` terminator instead of the correct single `*/`. Two function\nheaders also use a colon separator (`iavf_get_channels:`,\n`iavf_set_channels:`) instead of the ` - ` dash required by kernel-doc.\n\nAdditionally several comments embed their return-value descriptions in\nthe body paragraph, producing `scripts/kernel-doc -Wreturn` warnings.\nVoid functions that incorrectly say \"Returns ...\" are also rephrased.\n\nFix all issues across the full file:\n - Replace every `**/` terminator with `*/`.\n - Change `function_name:` doc headers to `function_name -`.\n - Move inline \"Returns ...\" sentences into dedicated `Return:` sections\n for non-void functions (iavf_get_msglevel, iavf_get_rxnfc,\n iavf_set_channels, iavf_get_rxfh_key_size, iavf_get_rxfh_indir_size,\n iavf_get_rxfh, iavf_set_rxfh).\n - Rephrase body descriptions in void functions that incorrectly said\n \"Returns ...\" (iavf_get_drvinfo, iavf_get_ringparam, iavf_get_coalesce).\n - Remove boilerplate body text for iavf_get_rxfh_key_size and\n iavf_get_rxfh_indir_size; the `Return:` line now conveys the same\n information without the vague \"Returns the table size.\" sentence.\n\nSuggested-by: Anthony L. Nguyen \nSuggested-by: Leszek Pepiak \nSigned-off-by: Aleksandr Loktionov \n---\nv1 -> v2 extending the scope of the changes to whole iavf_ethtool.c file\n---\n drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 103 ++++++++++++------------\n 1 file changed, 53 insertions(+), 50 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c\nindex 1cd1f3f..a615d59 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c\n@@ -32,7 +32,7 @@\n * statistics array. Thus, every statistic string in an array should have the\n * same type and number of format specifiers, to be formatted by variadic\n * arguments to the iavf_add_stat_string() helper function.\n- **/\n+ */\n struct iavf_stats {\n \tchar stat_string[ETH_GSTRING_LEN];\n \tint sizeof_stat;\n@@ -116,7 +116,7 @@ iavf_add_one_ethtool_stat(u64 *data, void *pointer,\n * the next empty location for successive calls to __iavf_add_ethtool_stats.\n * If pointer is null, set the data values to zero and update the pointer to\n * skip these stats.\n- **/\n+ */\n static void\n __iavf_add_ethtool_stats(u64 **data, void *pointer,\n \t\t\t const struct iavf_stats stats[],\n@@ -140,7 +140,7 @@ __iavf_add_ethtool_stats(u64 **data, void *pointer,\n *\n * The parameter @stats is evaluated twice, so parameters with side effects\n * should be avoided.\n- **/\n+ */\n #define iavf_add_ethtool_stats(data, pointer, stats) \\\n \t__iavf_add_ethtool_stats(data, pointer, stats, ARRAY_SIZE(stats))\n \n@@ -157,7 +157,7 @@ __iavf_add_ethtool_stats(u64 **data, void *pointer,\n * buffer and update the data pointer when finished.\n *\n * This function expects to be called while under rcu_read_lock().\n- **/\n+ */\n static void\n iavf_add_queue_stats(u64 **data, struct iavf_ring *ring)\n {\n@@ -189,7 +189,7 @@ iavf_add_queue_stats(u64 **data, struct iavf_ring *ring)\n *\n * Format and copy the strings described by stats into the buffer pointed at\n * by p.\n- **/\n+ */\n static void __iavf_add_stat_strings(u8 **p, const struct iavf_stats stats[],\n \t\t\t\t const unsigned int size, ...)\n {\n@@ -216,7 +216,7 @@ static void __iavf_add_stat_strings(u8 **p, const struct iavf_stats stats[],\n * The parameter @stats is evaluated twice, so parameters with side effects\n * should be avoided. Additionally, stats must be an array such that\n * ARRAY_SIZE can be called on it.\n- **/\n+ */\n #define iavf_add_stat_strings(p, stats, ...) \\\n \t__iavf_add_stat_strings(p, stats, ARRAY_SIZE(stats), ## __VA_ARGS__)\n \n@@ -249,7 +249,7 @@ static const struct iavf_stats iavf_gstrings_stats[] = {\n *\n * Reports speed/duplex settings. Because this is a VF, we don't know what\n * kind of link we really have, so we fake it.\n- **/\n+ */\n static int iavf_get_link_ksettings(struct net_device *netdev,\n \t\t\t\t struct ethtool_link_ksettings *cmd)\n {\n@@ -308,7 +308,7 @@ static int iavf_get_link_ksettings(struct net_device *netdev,\n * @sset: id of string set\n *\n * Reports size of various string tables.\n- **/\n+ */\n static int iavf_get_sset_count(struct net_device *netdev, int sset)\n {\n \t/* Report the maximum number queues, even if not every queue is\n@@ -331,7 +331,7 @@ static int iavf_get_sset_count(struct net_device *netdev, int sset)\n * @data: pointer to data buffer\n *\n * All statistics are added to the data buffer as an array of u64.\n- **/\n+ */\n static void iavf_get_ethtool_stats(struct net_device *netdev,\n \t\t\t\t struct ethtool_stats *stats, u64 *data)\n {\n@@ -367,7 +367,7 @@ static void iavf_get_ethtool_stats(struct net_device *netdev,\n * @data: buffer for string data\n *\n * Builds the statistics string table\n- **/\n+ */\n static void iavf_get_stat_strings(struct net_device *netdev, u8 *data)\n {\n \tunsigned int i;\n@@ -392,7 +392,7 @@ static void iavf_get_stat_strings(struct net_device *netdev, u8 *data)\n * @data: buffer for string data\n *\n * Builds string tables for various string sets\n- **/\n+ */\n static void iavf_get_strings(struct net_device *netdev, u32 sset, u8 *data)\n {\n \tswitch (sset) {\n@@ -408,8 +408,8 @@ static void iavf_get_strings(struct net_device *netdev, u32 sset, u8 *data)\n * iavf_get_msglevel - Get debug message level\n * @netdev: network interface device structure\n *\n- * Returns current debug message level.\n- **/\n+ * Return: current debug message level.\n+ */\n static u32 iavf_get_msglevel(struct net_device *netdev)\n {\n \tstruct iavf_adapter *adapter = netdev_priv(netdev);\n@@ -424,7 +424,7 @@ static u32 iavf_get_msglevel(struct net_device *netdev)\n *\n * Set current debug message level. Higher values cause the driver to\n * be noisier.\n- **/\n+ */\n static void iavf_set_msglevel(struct net_device *netdev, u32 data)\n {\n \tstruct iavf_adapter *adapter = netdev_priv(netdev);\n@@ -439,8 +439,8 @@ static void iavf_set_msglevel(struct net_device *netdev, u32 data)\n * @netdev: network interface device structure\n * @drvinfo: ethool driver info structure\n *\n- * Returns information about the driver and device for display to the user.\n- **/\n+ * Fills @drvinfo with information about the driver and device.\n+ */\n static void iavf_get_drvinfo(struct net_device *netdev,\n \t\t\t struct ethtool_drvinfo *drvinfo)\n {\n@@ -458,9 +458,9 @@ static void iavf_get_drvinfo(struct net_device *netdev,\n * @kernel_ring: ethtool extenal ringparam structure\n * @extack: netlink extended ACK report struct\n *\n- * Returns current ring parameters. TX and RX rings are reported separately,\n- * but the number of rings is not reported.\n- **/\n+ * Fills @ring with current ring parameters. TX and RX rings are reported\n+ * separately, but the number of rings is not reported.\n+ */\n static void iavf_get_ringparam(struct net_device *netdev,\n \t\t\t struct ethtool_ringparam *ring,\n \t\t\t struct kernel_ethtool_ringparam *kernel_ring,\n@@ -483,7 +483,7 @@ static void iavf_get_ringparam(struct net_device *netdev,\n *\n * Sets ring parameters. TX and RX rings are controlled separately, but the\n * number of rings is not specified, so all rings get the same settings.\n- **/\n+ */\n static int iavf_set_ringparam(struct net_device *netdev,\n \t\t\t struct ethtool_ringparam *ring,\n \t\t\t struct kernel_ethtool_ringparam *kernel_ring,\n@@ -551,7 +551,7 @@ static int iavf_set_ringparam(struct net_device *netdev,\n * Gets the per-queue settings for coalescence. Specifically Rx and Tx usecs\n * are per queue. If queue is <0 then we default to queue 0 as the\n * representative value.\n- **/\n+ */\n static int __iavf_get_coalesce(struct net_device *netdev,\n \t\t\t struct ethtool_coalesce *ec, int queue)\n {\n@@ -588,11 +588,11 @@ static int __iavf_get_coalesce(struct net_device *netdev,\n * @kernel_coal: ethtool CQE mode setting structure\n * @extack: extack for reporting error messages\n *\n- * Returns current coalescing settings. This is referred to elsewhere in the\n- * driver as Interrupt Throttle Rate, as this is how the hardware describes\n- * this functionality. Note that if per-queue settings have been modified this\n- * only represents the settings of queue 0.\n- **/\n+ * Fills @ec with current coalescing settings. This is referred to elsewhere\n+ * in the driver as Interrupt Throttle Rate, as this is how the hardware\n+ * describes this functionality. Note that if per-queue settings have been\n+ * modified this only represents the settings of queue 0.\n+ */\n static int iavf_get_coalesce(struct net_device *netdev,\n \t\t\t struct ethtool_coalesce *ec,\n \t\t\t struct kernel_ethtool_coalesce *kernel_coal,\n@@ -608,7 +608,7 @@ static int iavf_get_coalesce(struct net_device *netdev,\n * @queue: the queue to read\n *\n * Read specific queue's coalesce settings.\n- **/\n+ */\n static int iavf_get_per_queue_coalesce(struct net_device *netdev, u32 queue,\n \t\t\t\t struct ethtool_coalesce *ec)\n {\n@@ -622,7 +622,7 @@ static int iavf_get_per_queue_coalesce(struct net_device *netdev, u32 queue,\n * @queue: the queue to modify\n *\n * Change the ITR settings for a specific queue.\n- **/\n+ */\n static int iavf_set_itr_per_queue(struct iavf_adapter *adapter,\n \t\t\t\t struct ethtool_coalesce *ec, int queue)\n {\n@@ -680,7 +680,7 @@ static int iavf_set_itr_per_queue(struct iavf_adapter *adapter,\n * @queue: the queue to change\n *\n * Sets the coalesce settings for a particular queue.\n- **/\n+ */\n static int __iavf_set_coalesce(struct net_device *netdev,\n \t\t\t struct ethtool_coalesce *ec, int queue)\n {\n@@ -722,7 +722,7 @@ static int __iavf_set_coalesce(struct net_device *netdev,\n * @extack: extack for reporting error messages\n *\n * Change current coalescing settings for every queue.\n- **/\n+ */\n static int iavf_set_coalesce(struct net_device *netdev,\n \t\t\t struct ethtool_coalesce *ec,\n \t\t\t struct kernel_ethtool_coalesce *kernel_coal,\n@@ -1639,7 +1639,7 @@ static int iavf_set_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd)\n * @netdev: network interface device structure\n *\n * Return: number of RX rings.\n- **/\n+ */\n static u32 iavf_get_rx_ring_count(struct net_device *netdev)\n {\n \tstruct iavf_adapter *adapter = netdev_priv(netdev);\n@@ -1653,8 +1653,8 @@ static u32 iavf_get_rx_ring_count(struct net_device *netdev)\n * @cmd: ethtool rxnfc command\n * @rule_locs: pointer to store rule locations\n *\n- * Returns Success if the command is supported.\n- **/\n+ * Return: 0 on success, -EOPNOTSUPP if the command is not supported.\n+ */\n static int iavf_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd,\n \t\t\t u32 *rule_locs)\n {\n@@ -1684,13 +1684,13 @@ static int iavf_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd,\n \treturn ret;\n }\n /**\n- * iavf_get_channels: get the number of channels supported by the device\n+ * iavf_get_channels - get the number of channels supported by the device\n * @netdev: network interface device structure\n * @ch: channel information structure\n *\n * For the purposes of our device, we only use combined channels, i.e. a tx/rx\n * queue pair. Report one extra channel to match our \"other\" MSI-X vector.\n- **/\n+ */\n static void iavf_get_channels(struct net_device *netdev,\n \t\t\t struct ethtool_channels *ch)\n {\n@@ -1706,14 +1706,15 @@ static void iavf_get_channels(struct net_device *netdev,\n }\n \n /**\n- * iavf_set_channels: set the new channel count\n+ * iavf_set_channels - set the new channel count\n * @netdev: network interface device structure\n * @ch: channel information structure\n *\n- * Negotiate a new number of channels with the PF then do a reset. During\n- * reset we'll realloc queues and fix the RSS table. Returns 0 on success,\n- * negative on failure.\n- **/\n+ * Negotiate a new number of channels with the PF then do a reset. During\n+ * reset we'll realloc queues and fix the RSS table.\n+ *\n+ * Return: 0 on success, negative on failure.\n+ */\n static int iavf_set_channels(struct net_device *netdev,\n \t\t\t struct ethtool_channels *ch)\n {\n@@ -1750,8 +1751,8 @@ static int iavf_set_channels(struct net_device *netdev,\n * iavf_get_rxfh_key_size - get the RSS hash key size\n * @netdev: network interface device structure\n *\n- * Returns the table size.\n- **/\n+ * Return: the RSS hash key size.\n+ */\n static u32 iavf_get_rxfh_key_size(struct net_device *netdev)\n {\n \tstruct iavf_adapter *adapter = netdev_priv(netdev);\n@@ -1763,8 +1764,8 @@ static u32 iavf_get_rxfh_key_size(struct net_device *netdev)\n * iavf_get_rxfh_indir_size - get the rx flow hash indirection table size\n * @netdev: network interface device structure\n *\n- * Returns the table size.\n- **/\n+ * Return: the indirection table size.\n+ */\n static u32 iavf_get_rxfh_indir_size(struct net_device *netdev)\n {\n \tstruct iavf_adapter *adapter = netdev_priv(netdev);\n@@ -1777,8 +1778,10 @@ static u32 iavf_get_rxfh_indir_size(struct net_device *netdev)\n * @netdev: network interface device structure\n * @rxfh: pointer to param struct (indir, key, hfunc)\n *\n- * Reads the indirection table directly from the hardware. Always returns 0.\n- **/\n+ * Reads the indirection table directly from the hardware.\n+ *\n+ * Return: 0 always.\n+ */\n static int iavf_get_rxfh(struct net_device *netdev,\n \t\t\t struct ethtool_rxfh_param *rxfh)\n {\n@@ -1806,9 +1809,9 @@ static int iavf_get_rxfh(struct net_device *netdev,\n * @rxfh: pointer to param struct (indir, key, hfunc)\n * @extack: extended ACK from the Netlink message\n *\n- * Returns -EINVAL if the table specifies an invalid queue id, otherwise\n- * returns 0 after programming the table.\n- **/\n+ * Return: 0 on success, -EOPNOTSUPP if the hash function is not supported,\n+ * -EINVAL if the table specifies an invalid queue id.\n+ */\n static int iavf_set_rxfh(struct net_device *netdev,\n \t\t\t struct ethtool_rxfh_param *rxfh,\n \t\t\t struct netlink_ext_ack *extack)\n@@ -1885,7 +1888,7 @@ static const struct ethtool_ops iavf_ethtool_ops = {\n *\n * Sets ethtool ops struct in our netdev so that ethtool can call\n * our functions.\n- **/\n+ */\n void iavf_set_ethtool_ops(struct net_device *netdev)\n {\n \tnetdev->ethtool_ops = &iavf_ethtool_ops;\n","prefixes":["net-next","v2"]}