{"id":2221361,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2221361/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260409092022.486-1-fw@strlen.de/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.2/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260409092022.486-1-fw@strlen.de>","list_archive_url":null,"date":"2026-04-09T09:20:19","name":"[nf-next] netfilter: x_physdev: reject empty or not-nul terminated device names","commit_ref":null,"pull_url":null,"state":"under-review","archived":false,"hash":"1a4a042edb1b22bdccb88b9430fde7a5c711ec79","submitter":{"id":1025,"url":"http://patchwork.ozlabs.org/api/1.2/people/1025/?format=json","name":"Florian Westphal","email":"fw@strlen.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260409092022.486-1-fw@strlen.de/mbox/","series":[{"id":499265,"url":"http://patchwork.ozlabs.org/api/1.2/series/499265/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=499265","date":"2026-04-09T09:20:19","name":"[nf-next] netfilter: x_physdev: reject empty or not-nul terminated device names","version":1,"mbox":"http://patchwork.ozlabs.org/series/499265/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221361/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221361/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11752-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.216.245.30","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frvYc4x27z1yCv\n\tfor ; Thu, 09 Apr 2026 19:20:52 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 25D2A3000B2C\n\tfor ; Thu, 9 Apr 2026 09:20:50 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 21D513A9DB3;\n\tThu, 9 Apr 2026 09:20:46 +0000 (UTC)","from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc\n [91.216.245.30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 24BF03AC0D4\n\tfor ; Thu, 9 Apr 2026 09:20:38 +0000 (UTC)","by Chamillionaire.breakpoint.cc (Postfix, from userid 1003)\n\tid A949460344; Thu, 09 Apr 2026 11:20:29 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775726443; cv=none;\n b=iuEtGOQ/WuSlCTvOTtvuVd/rDaE7E6SPsfbOg/T9LULRzZF2Ti7wT8slY2MT+fRJnG7XTZQb6TyduBYt4zRfH1lPErhLx+eLAFVqZXaNAWingQ9v6bOyc+MPEWRDf62jANo1GTF0gNdqqwj13WaZ3zAhU5ZpLtwAg20vVfUfvlE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775726443; c=relaxed/simple;\n\tbh=XqHxoNgdDCyDwUGeqbCFgqx2ZOrydpbC7b4ossIFUkg=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=iUyc+mAaGlGFeTnDFkWglpMMnI0UO/pJVdzGDL+gs9BCuhWOgxdHtMNtD61jB66mKa+rkfxDlJ5Y/zB0YdBlvEihsIze2GERDvhsrLc7OBs0VvKsspZ8hViB5JcxtK3iPy91tMZ3BN7x7K4AxMauABpfEquhHETkEPGkMuRbCDk=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc;\n arc=none smtp.client-ip=91.216.245.30","From":"Florian Westphal ","To":"","Cc":"Florian Westphal ","Subject":"[PATCH nf-next] netfilter: x_physdev: reject empty or not-nul\n terminated device names","Date":"Thu, 9 Apr 2026 11:20:19 +0200","Message-ID":"<20260409092022.486-1-fw@strlen.de>","X-Mailer":"git-send-email 2.52.0","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Reject names that lack a \\0 character and reject the empty string as\nwell. iptables allows this but it fails to re-parse iptables-save output\nthat contain such rules.\n\nSigned-off-by: Florian Westphal \n---\n net/netfilter/xt_physdev.c | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)","diff":"diff --git a/net/netfilter/xt_physdev.c b/net/netfilter/xt_physdev.c\nindex 343e65f377d4..1494259fb518 100644\n--- a/net/netfilter/xt_physdev.c\n+++ b/net/netfilter/xt_physdev.c\n@@ -107,6 +107,21 @@ static int physdev_mt_check(const struct xt_mtchk_param *par)\n \t\treturn -EINVAL;\n \t}\n \n+#define X(memb) strnlen(info->memb , sizeof(info->memb)) >= sizeof(info->memb)\n+\tif (X(physindev))\n+\t\treturn -ENAMETOOLONG;\n+\tif (X(physoutdev))\n+\t\treturn -ENAMETOOLONG;\n+\tif (X(in_mask))\n+\t\treturn -ENAMETOOLONG;\n+\tif (X(out_mask))\n+\t\treturn -ENAMETOOLONG;\n+#undef X\n+\tif (info->bitmask & XT_PHYSDEV_OP_IN && info->physindev[0] == 0)\n+\t\treturn -EINVAL;\n+\tif (info->bitmask & XT_PHYSDEV_OP_OUT && info->physoutdev[0] == 0)\n+\t\treturn -EINVAL;\n+\n \tif (!brnf_probed) {\n \t\tbrnf_probed = true;\n \t\trequest_module(\"br_netfilter\");\n","prefixes":["nf-next"]}