{"id":2220982,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2220982/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260408150201.217942-2-paul.henrys_ext@softathome.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260408150201.217942-2-paul.henrys_ext@softathome.com>","list_archive_url":null,"date":"2026-04-08T15:01:59","name":"[v5,1/3] binman: Generate preload header and sign data only once","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6ff4fb0d52e04fc31a295d55665ceb65db6ddb86","submitter":{"id":83555,"url":"http://patchwork.ozlabs.org/api/1.2/people/83555/?format=json","name":"Paul HENRYS","email":"paul.henrys_ext@softathome.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.2/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260408150201.217942-2-paul.henrys_ext@softathome.com/mbox/","series":[{"id":499152,"url":"http://patchwork.ozlabs.org/api/1.2/series/499152/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=499152","date":"2026-04-08T15:02:01","name":"binman: Fix preload signing with encrypted FIT","version":5,"mbox":"http://patchwork.ozlabs.org/series/499152/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220982/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220982/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector1-softathome1-onmicrosoft-com\n header.b=Ar+AFdWO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=softathome.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.b=\"Ar+AFdWO\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=softathome.com","phobos.denx.de;\n spf=pass smtp.mailfrom=paul.henrys_ext@softathome.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frRBm6876z1yD3\n\tfor ; Thu, 09 Apr 2026 01:02:56 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0839084132;\n\tWed, 8 Apr 2026 17:02:27 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id EB83184105; Wed, 8 Apr 2026 17:02:20 +0200 (CEST)","from PA5P264CU001.outbound.protection.outlook.com\n (mail-francecentralazlp170100000.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c20a::])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E02E3838BB\n for ;\n Wed, 8 Apr 2026 17:02:18 +0200 (CEST)","from MR1P264CA0203.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:57::18)\n by MRZP264MB3132.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:31::24) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.21; Wed, 8 Apr\n 2026 15:02:14 +0000","from MR1PEPF00000D59.FRAP264.PROD.OUTLOOK.COM\n (2603:10a6:501:57:cafe::1c) by MR1P264CA0203.outlook.office365.com\n (2603:10a6:501:57::18) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.37 via Frontend Transport; Wed,\n 8 Apr 2026 15:02:14 +0000","from proxy.softathome.com (149.6.166.170) by\n MR1PEPF00000D59.mail.protection.outlook.com (10.167.241.6) with Microsoft\n SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.17\n via Frontend Transport; Wed, 8 Apr 2026 15:02:13 +0000","from sah2lpt245.. (unknown [192.168.72.183])\n by proxy.softathome.com (Postfix) with ESMTPSA id 1A4322018F;\n Wed, 8 Apr 2026 17:02:09 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,\n SUSPICIOUS_RECIPS autolearn=no autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=m+me/9/t3j+NJtkCLACcG8XHwYJxtxFT2EQujOBAMc4LinTx57V8pptNAhnG7j0wUoYA0kIPpvCmHiktU8ox5/paFa4uqSh3XlYHlI9GlNp3j0bFdJBBakVWdvZYQLoXXVV3EtGwJhe3C7mqTHb0Bx0mRaUHBqdW39Rq5a+hj2BOn1DgCLwYlMFc15HMaQFJ3p4K3Bz0jCi52ihdu/e0N8K9fs2yoLUlpVq2k5xL+BwuHW6u4ekaYXAhTqr/hAqSiVr6+ep0odyFeef/5r1xHj15z/SCPN9DFBWYUe+adUi90oHn9RbUDeJKzGbkdbG9PmboVUVOr4RUnjopPXz+vA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=JQ2Vr/KirKE3RyizwcPezfEYEjd4igtwnXkDmcahszA=;\n b=I2tSis1ytuuwNpq64Vz0QbQWd1P0FL47mnlkX8CGS68p0GpjjcvJT37Fsi+0Nq687PKPjkWmBDvuC/awA8KDon+Q4IrFpHN6h4eoVRHzxluWnGrsa3g/Wz1VR5zJZNmFtLlepL6nMe+GI0v9H8TWFeJZ+rtJd7Ugc9hsvhxM9YDqC+jDgc2ZmhBcM6BvyTy044ouQqI7GYjZ0wQWOf0lp1XnKp8iiatf5YyDKvtdnWjKQO/YVj6DoecsbElEac8THURvVUk68aBMnQTkg/jFFBTuKCLlgl5BxGzj8Rvz2oadwDVEKQZPmiBH91ato4ACnynRisu78PzVxdh6luSGuQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 149.6.166.170) smtp.rcpttodomain=chromium.org smtp.mailfrom=softathome.com;\n dmarc=bestguesspass action=none header.from=softathome.com; dkim=none\n (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=softathome1.onmicrosoft.com; s=selector1-softathome1-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=JQ2Vr/KirKE3RyizwcPezfEYEjd4igtwnXkDmcahszA=;\n b=Ar+AFdWOzwpktkm4OittznKzEimh4nUAPutXTSFSR7wyP72cDeK2VkHa5TNvhiSAre9hunSxzSXCh+cuxbLxTa5BnxQkEn+i/aguj9hDDgoxFsG28lR4WFoQ+dU0ftggvyIQMnkBkvnAEc1mim6LCdX0NKuizEVU+73Jg4vO6COvT4bNKviqHBjF0ANAEl7YoedcKB33piNrRTDcgLuyvqpOt3NjgAfKENLhSCeAIBiGAAEcswM8n89/tfkRdgfJjsxKotvfmgLEekIjk8rj3QnXWo++B6vnagmwrPdI/mpG+AoAUJvvEISIa/EQC5FdpFlo9lp5wcQ0Y8IlwQcckQ==","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 149.6.166.170)\n smtp.mailfrom=softathome.com; dkim=none (message not signed)\n header.d=none;dmarc=bestguesspass action=none header.from=softathome.com;","Received-SPF":"Pass (protection.outlook.com: domain of softathome.com\n designates 149.6.166.170 as permitted sender)\n receiver=protection.outlook.com; client-ip=149.6.166.170;\n helo=proxy.softathome.com; pr=C","From":"Paul HENRYS ","To":"u-boot+nodisclaimer@lists.denx.de","Cc":"sjg+nodisclaimer@chromium.org, trini+nodisclaimer@konsulko.com,\n alpernebiyasak+nodisclaimer@gmail.com,\n philippe.reynes+nodisclaimer@softathome.com,\n Paul HENRYS ","Subject":"[PATCH v5 1/3] binman: Generate preload header and sign data only\n once","Date":"Wed, 8 Apr 2026 17:01:59 +0200","Message-ID":"<20260408150201.217942-2-paul.henrys_ext@softathome.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260408150201.217942-1-paul.henrys_ext@softathome.com>","References":"<20260403075528.1150196-3-paul.henrys_ext@softathome.com>\n <20260408150201.217942-1-paul.henrys_ext@softathome.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"MR1PEPF00000D59:EE_|MRZP264MB3132:EE_","Content-Type":"text/plain","X-MS-Office365-Filtering-Correlation-Id":"8534f785-7ddc-41d9-db16-08de957fd167","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|36860700016|376014|82310400026|22082099003|56012099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n eJCfKfRVgvW6ivRGjPO3I+3zKNslDfMAINvZ2+ZscPi6jHMzC50c7l5vrrAb1gKhSdF79kh7AP8etqD2FsEMNNhxA0WilnQYLIUwZyMG4q9I9dcSD1mzAx/jbUMsSp3rXAq6/Tyar1PDCY07Y/ovyIkTEJtMaectjZvPkrrUxepW9+v34erCVJhDO37GJV5YHdADFlT4gmVKUPZW8xQjaH69HZ6w6NEtolh0t2xLiK8zrhJqi9jvvTfKiiYpM/Z/98XdmlyPrJTQ5ze0eNU9cZEVNL+2yHphh2raG/wUEXHRu89nFF3KNLnCKW4nwm+HRLsMA7kTmEGodasLg9QBR/gm326GYDmDf/FoFkn+Dg0OeGLdM1ifxB65pBAxQsOk+NYzSjZYCCNZastIxqQjWr6qhmzpVxIgx0nSvZL7Qb9D+GBIopgWgAlkU9vTH+UP0KEZ8u4ddgrLr9XUJi32CqQRMRxeWwNc0/SwCvuj0AYqWoTN6UPCFblqqyKWOP1rMiy2OzEVlMdbISdW/dTW/l29it3dsH3Ffq+EgSyMGRDQDP+WKvPe1vaZP8VH5E5+u6hCNUdtWQPyLKSmm/lkUc+C6u8J9e3NFVy6tiDunWmA8fzHukrx3Xdg2DOJap+/JDVn+4ar6haxTMdjPQugX4Tpe3ZfEuOqNinTuUXXi440kKZUnXDUfo8wt+4+2gQ1f/PV7mN5GYTF93WCYSc4pA+gFcRKLI1aB7mIQ9uLheF/YSkLa3qEF2Bjv+ihxjkjtejXfBbVaBpgFuLIAgZ+Zw==","X-Forefront-Antispam-Report":"CIP:149.6.166.170; CTRY:FR; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:proxy.softathome.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230040)(1800799024)(36860700016)(376014)(82310400026)(22082099003)(56012099003)(18002099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n VFQ2jJBq8RuZBRY4YS+5kTfe9UjvskH+06wIzzfcx+1QARuEkR+T0akp4zo8vP9L/+h/aCpNXlAt50m1A5qixp2YUGHsLh6byjozDcxg4KhscIv2Vvgionuzdb5SDrSj6BCG/r5tOlaZnzTkm2Ydacc31PgDUzr+UIBrqBW/QPtaI+mYZYA3zTYRrHvLCVp8aI9SAMdAAh0ePpvj67Kfo3QiHlZgwlM8O7soVf5r3wE8i7y15f7NXTIDDc0FHzEMck2Gkz5P/ySfT03fKST85qNFyksYfRAdOcm+pCoOsKQYoaYopFm7TN6Gcz34v/NNApU7Cg+n6utjCIj3ROrefohhonaPRMTsXVcE8Y6hmb/+fe3zteDzYN+9eR56b5tNFA19VcuSYzSlqFVLMPuj7B1FzTUIU3aUgn+s6DuYc49TDJ3KR21Dii+c8uJKw/IQ","X-OriginatorOrg":"softathome.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"08 Apr 2026 15:02:13.7018 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 8534f785-7ddc-41d9-db16-08de957fd167","X-MS-Exchange-CrossTenant-Id":"aa10e044-e405-4c10-8353-36b4d0cce511","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=aa10e044-e405-4c10-8353-36b4d0cce511; Ip=[149.6.166.170];\n Helo=[proxy.softathome.com]","X-MS-Exchange-CrossTenant-AuthSource":"MR1PEPF00000D59.FRAP264.PROD.OUTLOOK.COM","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MRZP264MB3132","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"To optimize preload generation, generate the header and signatures only\nafter all data has been collected in ProcessContentsUpdate(). This\navoids signing the data multiple times.\n\nSince header_size is known upfront (from __init__), create a placeholder\nin `ObtainContents()` to avoid an extra packing pass when\nProcessContentsUpdate() detects a size change.\n\nThis reduces unnecessary repacking and signing operations.\n\nSigned-off-by: Paul HENRYS \n---\n\nChanges in v5:\n- Generate a placeholder in ObtainContents() to avoid unnecessary repack\n\n tools/binman/etype/pre_load.py | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)","diff":"diff --git a/tools/binman/etype/pre_load.py b/tools/binman/etype/pre_load.py\nindex 00f1a896767..0d953cb258e 100644\n--- a/tools/binman/etype/pre_load.py\n+++ b/tools/binman/etype/pre_load.py\n@@ -152,14 +152,11 @@ class Entry_pre_load(Entry_collection):\n return data + pad\n \n def ObtainContents(self):\n- \"\"\"Obtain a placeholder for the header contents\"\"\"\n- # wait that the image is available\n- self.image = self.GetContents(False)\n- if self.image is None:\n- return False\n- self.SetContents(self._CreateHeader())\n+ \"\"\"Create a placeholder for the header\"\"\"\n+ self.SetContents(tools.get_bytes(0, self.header_size))\n return True\n \n def ProcessContents(self):\n+ self.image = self.GetContents(True)\n data = self._CreateHeader()\n return self.ProcessContentsUpdate(data)\n","prefixes":["v5","1/3"]}