{"id":2220736,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2220736/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260407223447.4956-2-andre.przywara@arm.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260407223447.4956-2-andre.przywara@arm.com>","list_archive_url":null,"date":"2026-04-07T22:34:45","name":"[1/3] sunxi: spl: fix SPL_SUNXI_LED active low configuration","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4a0b084b3d741b00481294c5070aa2867e4fec80","submitter":{"id":61837,"url":"http://patchwork.ozlabs.org/api/1.2/people/61837/?format=json","name":"Andre Przywara","email":"andre.przywara@arm.com"},"delegate":{"id":114289,"url":"http://patchwork.ozlabs.org/api/1.2/users/114289/?format=json","username":"apritzel","first_name":"Andre","last_name":"Przywara","email":"andre.przywara@arm.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260407223447.4956-2-andre.przywara@arm.com/mbox/","series":[{"id":499043,"url":"http://patchwork.ozlabs.org/api/1.2/series/499043/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=499043","date":"2026-04-07T22:34:45","name":"sunxi: Fix and extend SPL power LED support","version":1,"mbox":"http://patchwork.ozlabs.org/series/499043/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220736/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220736/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256\n header.s=foss header.b=krm/eiVa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=fail (p=none dis=none) header.from=arm.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=arm.com header.i=@arm.com header.b=\"krm/eiVa\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=arm.com","phobos.denx.de;\n spf=pass smtp.mailfrom=andre.przywara@arm.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fr1H56h6vz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 08 Apr 2026 08:35:13 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C03F1840BE;\n\tWed,  8 Apr 2026 00:35:05 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id B3E0B84129; Wed,  8 Apr 2026 00:35:04 +0200 (CEST)","from foss.arm.com (foss.arm.com [217.140.110.172])\n by phobos.denx.de (Postfix) with ESMTP id 05AEF80398\n for <u-boot@lists.denx.de>; Wed,  8 Apr 2026 00:35:00 +0200 (CEST)","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 44E0A3549;\n Tue,  7 Apr 2026 15:34:54 -0700 (PDT)","from ryzen.fritz.box (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n C5D8C3F632; Tue,  7 Apr 2026 15:34:58 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss;\n t=1775601300; bh=c9zy5O2WPAHs1EpAo/D3JPndFAwUuQbakGizB9QGLl4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=krm/eiVarYpXPye+fKTVhe5K0LKbcMAqZ76HQNoQV1YUQFZBfBdp/Wvx1vPzEILLE\n Sf0scpcN0RRR6qx8NCdDCZyideKe/+CPBXEvansDZdwMSj7sWCdV6HBfMnuvR0aj+V\n r3MfmLe85rZs/MTzPOuvZ/GiQ8KMTrcn39Ljhshg=","From":"Andre Przywara <andre.przywara@arm.com>","To":"u-boot@lists.denx.de","Cc":"Tom Rini <trini@konsulko.com>, Quentin Schulz <quentin.schulz@cherry.de>,\n Jernej Skrabec <jernej.skrabec@gmail.com>,\n Paul Kocialkowski <contact@paulk.fr>, linux-sunxi@lists.linux.dev","Subject":"[PATCH 1/3] sunxi: spl: fix SPL_SUNXI_LED active low configuration","Date":"Wed,  8 Apr 2026 00:34:45 +0200","Message-ID":"<20260407223447.4956-2-andre.przywara@arm.com>","X-Mailer":"git-send-email 2.46.4","In-Reply-To":"<20260407223447.4956-1-andre.przywara@arm.com>","References":"<20260407223447.4956-1-andre.przywara@arm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"The newly introduced Allwinner SPL LED \"framework\" defined a\nSPL_SUNXI_LED_STATUS_STATE Kconfig symbol, that was supposed to denote\nthe active-low vs. active-high polarity of the LED. However this is\na bool symbol, so it will simply vanish if not defined, and we cannot use\nit directly inside a C statement.\n\nFilter the symbol through the IS_ENABLED() macro, which will return 0 if\nthe symbol is not defined, which is the intended value here.\n\nThis fixes configuring LEDs with active-low polarity.\n\nSigned-off-by: Andre Przywara <andre.przywara@arm.com>\n---\n board/sunxi/board.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/board/sunxi/board.c b/board/sunxi/board.c\nindex d7722d1858a..80dcae9c1a4 100644\n--- a/board/sunxi/board.c\n+++ b/board/sunxi/board.c\n@@ -563,7 +563,7 @@ static void sunxi_spl_store_dram_size(phys_addr_t dram_size)\n static void status_led_init(void)\n {\n #if CONFIG_IS_ENABLED(SUNXI_LED_STATUS)\n-\tunsigned int state = CONFIG_SPL_SUNXI_LED_STATUS_STATE;\n+\tunsigned int state = IS_ENABLED(CONFIG_SPL_SUNXI_LED_STATUS_STATE);\n \tunsigned int gpio = CONFIG_SPL_SUNXI_LED_STATUS_BIT;\n \n \tgpio_request(gpio, \"gpio_led\");\n","prefixes":["1/3"]}