{"id":2220058,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2220058/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260406074830.8480-1-skoyama@ddn.com/","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/1.2/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260406074830.8480-1-skoyama@ddn.com>","list_archive_url":null,"date":"2026-04-06T07:48:30","name":"[v2] ext4: fix missing brelse() in ext4_xattr_inode_dec_ref_all()","commit_ref":null,"pull_url":null,"state":"awaiting-upstream","archived":false,"hash":"66df16ab61d15910874a9210cfb5ba4e5ba41325","submitter":{"id":93012,"url":"http://patchwork.ozlabs.org/api/1.2/people/93012/?format=json","name":null,"email":"skoyama.kernel@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260406074830.8480-1-skoyama@ddn.com/mbox/","series":[{"id":498829,"url":"http://patchwork.ozlabs.org/api/1.2/series/498829/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/list/?series=498829","date":"2026-04-06T07:48:30","name":"[v2] ext4: fix missing brelse() in ext4_xattr_inode_dec_ref_all()","version":2,"mbox":"http://patchwork.ozlabs.org/series/498829/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220058/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220058/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=MtWye16E;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=u1el=cf=vger.kernel.org=linux-ext4+bounces-15650-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c04:e001:36c::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=MtWye16E;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15650-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"MtWye16E\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.180","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fq1jm2RHXz1y2d\n\tfor ; Mon, 06 Apr 2026 17:51:24 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fq1jg07gkz4wB7\n\tfor ; Mon, 06 Apr 2026 17:51:19 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fq1jg02Sxz4wDG; Mon, 06 Apr 2026 17:51:19 +1000 (AEST)","from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fq1jb3FTNz4wB7\n\tfor ; Mon, 06 Apr 2026 17:51:15 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 914433009F3E\n\tfor ; Mon, 6 Apr 2026 07:51:13 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 150CE30B502;\n\tMon, 6 Apr 2026 07:51:11 +0000 (UTC)","from mail-pl1-f180.google.com (mail-pl1-f180.google.com\n [209.85.214.180])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C6DA01A262D\n\tfor ; Mon, 6 Apr 2026 07:51:09 +0000 (UTC)","by mail-pl1-f180.google.com with SMTP id\n d9443c01a7336-2adff872068so16086985ad.1\n for ;\n Mon, 06 Apr 2026 00:51:09 -0700 (PDT)","from localhost.localdomain (hpcs-gw.cs.tsukuba.ac.jp.\n [130.158.42.241])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b27477c54bsm167478635ad.27.2026.04.06.00.51.06\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 06 Apr 2026 00:51:08 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775461878; cv=pass;\n\tb=S1h8Nz4nbz5tLMFP7epOfQ7xMfJLMMxbsjNOdG9oAUDj1+eB0YidiRYBWsxb4+5cbShqsez3pfkmJCA4pcD4H+VAWwpwKFdEVDCMgxvPMr/DxFCGEZH8OKEG2dDjP7pW6ih2cijUEmGeYTqYN0DRUlbqndPk7kg8ym5TtLT4XeGqenlNUzpKqlNsTWTLJKuEYLcwY/2gYP70Yq90aDrOaAjErqXA8X1aGoYepZ154ddFI6E9yVs9ZVJ/Nc/xXZhT7VA96L+k42D7kZVhI6o9Yee0QSa6AOLomASZ2zacNhSfjSICX88Qc0NcF9WWQ6Q1rFDeCdPLwS8IRn9W7ALATA==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775461870; cv=none;\n b=DLMcCt+q4ZJKFFL22o6RZlfNRlll7D4CXgMj76r1PsHj4SzhvFxRYKvJfhSS3qTGyC596FcoZO3kYZApK6KPlv6soXf0EvyK5E6JyWpMYWTMEGmZmrPSDqfx3sFuCWcEEchQdWlnj77WSTU0ZMJXOOdZYmaYR19m87sq5SkY1XM="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775461878; c=relaxed/relaxed;\n\tbh=mfRe07VDdxyeiOp2leNAtv/+o9PcSTvv9BUYN12UeKs=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=cKkKz4ixmK9eI9kU2apzdvn7klDr5AZrUVemiTOGtvZej+dJSMGaC9ky+e3aOexc+tLQmoz8RmSix4SV7SfF8kibJnS12DMElwTW5P928ocWkM2ckCdqfDmjXLAhzyJMoULv6Qi6qON6facxFBk2A0y+xAkpCUDGj70Wxjk+7pIkr2wMtca3IdLEWU6kZhu8GHRGUbESnb2P4Lxx1F7+WCFnE0acZTAa3sfbXp9qMcHTQG7AAIaQzLsUYM0pwWoJCigfXuhZuivaC2sAui+ezGZFMxeUYNufo0JW4ixwdNmjEPRF7j//ScpWehSUKUG1M3KnoEeX2mYsrxnUDfMUGw==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775461870; c=relaxed/simple;\n\tbh=9oLFOPLbcEP5zMFcmtTTYeCP7QRgw3sR2GvdV3mT4NM=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=VKFssZZ0x8rNvmfSKn0C4jPLOpb6AYwwomKuy9a9yPyAMz3KAcwD10wVhRhwbe6vSh9THBsxVmi5seDPjfXEUpIir7zRaV0gP32qxrBt+K4PSRAi0sm0ptNQA9lFtjYy4zapJssDBuvytcEjCqvUTjmOlVQ3Pb0QC81GjbWryeU="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=MtWye16E; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15650-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=MtWye16E; arc=none smtp.client-ip=209.85.214.180"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775461869; x=1776066669;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=mfRe07VDdxyeiOp2leNAtv/+o9PcSTvv9BUYN12UeKs=;\n b=MtWye16Ed97CJdE6B4g9DUmwoav16sZSbS5VL13omwWGz8UR9xCBbtLe+fvsoPOKzT\n 0xIbHD0hRTolPVQ0NemuCngg9AwnZd9/6io5yz6GAC0evOu8Dpys0tlrcnAAKxJGs6Gf\n Du9lk7zI+MNGJqn4BGzCLlWcFxBFCAfd6NSKc+rrD2kK33xaw/FZte+ppO+ECb9roa35\n golq6RMU/DilnxXDm4sQNeg3zfA6K+/GuIawa5gOBDQOd//Wn2rSf45F7exKao+GKHLO\n Fw1YNEdFSohlmfNhW6SjFS/n6pVp19K7P+SgXlXIQRJttAmPs6/aYyAf8VClszuzFw+T\n vb8A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775461869; x=1776066669;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=mfRe07VDdxyeiOp2leNAtv/+o9PcSTvv9BUYN12UeKs=;\n b=BSC/yPbOJspqLzlR3RdvP7gjVpgvt/Jdai16i9qq+Um568W6LdVYexMkjm5VIvsF/3\n Dq/dSpZIRxgN+pSsXZJMptMILc/sYi5lS/OgDqFhHFt5HaAgBNUgPPdGqkdvzB4ro8Ew\n dHIEMiKVie3YV4I1VhAq706onW5m6LjxcoozZrd8Is+wrQ5ZEp3GMoyJf66wjDgMuF13\n HINRAeZVwN43SHlD+Pn1Grb2RXdkL3TwyKdgCvAoh8AgSK/96AtENeYT0H/AnZOfsyt8\n 5h5hdtGgTTgEie6nuP058XnJ/pbei/GVId5akv2iWGvZ+cgtPco3lwSSxnr7AVODCW5H\n 2mrw==","X-Gm-Message-State":"AOJu0YzWnYazA72IVqoPXFIJfTTKIK2Rg/Zp9QxDjAQ9g8lGp6WcNYGZ\n\tuj59AIKAe9+vxC7AHgFJ1iTzSUD5wTEF+FPSQWoyFE1f8Ji53IsxlQp1WbJ/eGrX","X-Gm-Gg":"AeBDieuDn9YII6pShGKE9t3icE0g1JjMw4QbisxjN1505KN/ThQHiK4T7rKTN5daW2p\n\tewE35b29YiKA1yQy+jvWrYCTJjtc2eCt8R07tmS9NQI2c1ikZg3KfWJB4vp5AyRSBDcEX/t0dxK\n\tjI0c9XF/sdtgaYIqyixntGJ4b0qpOdqkQBagzBxt+1CrWve5IB5KmLz3BRyBzeInsDMEAybhrl+\n\tm8ue1B2Mo815bh/XAu5a9Oem0Yk/kVJZkscr4yhSzrvOCjxjgtFMSjMDxBuG0pN/4y70sDxGR7S\n\t5PfaLIB2ioLzvwV0rKTD890QPgtzgSemZzAJf5lMSf+MPZBcSjjbKXHLF2WC25favyFJsRQk10k\n\tbIFN0RT980EZUTbyMcCoCw7TlkigWjAUS0E1JqAueVx0xKwnU2DZ1pfGgKRxG21prMla8vS6cfo\n\tBs1mbh48aV75oUW256ABuuCPmgRSRC1Sg27Nyi6R4cyDYGmpASSgW7qgLDNlW5W0izA2g32g==","X-Received":"by 2002:a17:902:e749:b0:2b0:c106:a42b with SMTP id\n d9443c01a7336-2b2817fb179mr138260415ad.12.1775461869125;\n Mon, 06 Apr 2026 00:51:09 -0700 (PDT)","From":"skoyama.kernel@gmail.com","X-Google-Original-From":"skoyama@ddn.com","To":"linux-ext4@vger.kernel.org","Cc":"tytso@mit.edu,\n\tadilger.kernel@dilger.ca,\n\tlibaokun@linux.alibaba.com,\n\tjack@suse.cz,\n\tojaswin@linux.ibm.com,\n\tritesh.list@gmail.com,\n\tyi.zhang@huawei.com,\n\tbhupesh@igalia.com,\n\tSohei Koyama ,\n\tAndreas Dilger ,\n\tstable@vger.kernel.org","Subject":"[PATCH v2] ext4: fix missing brelse() in\n ext4_xattr_inode_dec_ref_all()","Date":"Mon, 6 Apr 2026 16:48:30 +0900","Message-Id":"<20260406074830.8480-1-skoyama@ddn.com>","X-Mailer":"git-send-email 2.39.3 (Apple Git-146)","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tFREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"},"content":"From: Sohei Koyama \n\nThe commit c8e008b60492 (\"ext4: ignore xattrs past end\")\nintroduced a refcount leak in when block_csum is false.\n\next4_xattr_inode_dec_ref_all() calls ext4_get_inode_loc() to\nget iloc.bh, but never releases it with brelse().\n\nFixes: c8e008b60492 (\"ext4: ignore xattrs past end\")\nSigned-off-by: Sohei Koyama \nReviewed-by: Andreas Dilger \nReviewed-by: Ritesh Harjani (IBM) \nCc: stable@vger.kernel.org\n---\n fs/ext4/xattr.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c\nindex 7bf9ba19a89d..19c72e38fb82 100644\n--- a/fs/ext4/xattr.c\n+++ b/fs/ext4/xattr.c\n@@ -1165,7 +1165,7 @@ ext4_xattr_inode_dec_ref_all(handle_t *handle, struct inode *parent,\n {\n \tstruct inode *ea_inode;\n \tstruct ext4_xattr_entry *entry;\n-\tstruct ext4_iloc iloc;\n+\tstruct ext4_iloc iloc = { .bh = NULL };\n \tbool dirty = false;\n \tunsigned int ea_ino;\n \tint err;\n@@ -1260,6 +1260,8 @@ ext4_xattr_inode_dec_ref_all(handle_t *handle, struct inode *parent,\n \t\t\text4_warning_inode(parent,\n \t\t\t\t\t \"handle dirty metadata err=%d\", err);\n \t}\n+\n+\tbrelse(iloc.bh);\n }\n \n /*\n","prefixes":["v2"]}