{"id":2219908,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2219908/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260405111206.945185-5-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260405111206.945185-5-sjg@chromium.org>","list_archive_url":null,"date":"2026-04-05T11:11:49","name":"[v2,4/8] test: Add a check for a missing kernel","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"121d2111987a108509e2ad9ab8e4badd6b416bc9","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/1.2/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260405111206.945185-5-sjg@chromium.org/mbox/","series":[{"id":498774,"url":"http://patchwork.ozlabs.org/api/1.2/series/498774/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=498774","date":"2026-04-05T11:11:45","name":"test: Refactor FIT test for clarity and extensibility","version":2,"mbox":"http://patchwork.ozlabs.org/series/498774/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219908/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219908/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=lEkdJJkk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"lEkdJJkk\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fpVDn2nlvz1yD3\n\tfor ; Sun, 05 Apr 2026 21:12:57 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 1477184106;\n\tSun, 5 Apr 2026 13:12:37 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 86C8C84105; Sun, 5 Apr 2026 13:12:35 +0200 (CEST)","from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com\n [IPv6:2001:4860:4864:20::2b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B0F2C840ED\n for ; Sun, 5 Apr 2026 13:12:32 +0200 (CEST)","by mail-oa1-x2b.google.com with SMTP id\n 586e51a60fabf-4042fe53946so1258375fac.3\n for ; Sun, 05 Apr 2026 04:12:32 -0700 (PDT)","from chromium.org ([73.34.74.121]) by smtp.gmail.com with ESMTPSA id\n 5614622812f47-46d8d109b69sm6414382b6e.0.2026.04.05.04.12.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 05 Apr 2026 04:12:30 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775387551; x=1775992351; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZP3cEdp5tuFD39RdYbKTOiJH5T0HwxarL8EsOAFcnho=;\n b=lEkdJJkk+xIdXl/Q19TEk5bKnLkJqPNCFeWTUQuKiWesCS36nb2EqtlNRWyTih51fP\n yjsOfWmcLviHRfJFH7qsfUllFtmK+g7DUNl7NXArwcw43OYHbUcfK6WgFkek6nH9gqj+\n u8eAIDPLcRfNKcccpt7ax/sGZsvIhRbCft6G4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775387551; x=1775992351;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ZP3cEdp5tuFD39RdYbKTOiJH5T0HwxarL8EsOAFcnho=;\n b=BpxNbznZaTPR0Sc0My5jz+C4kcaNVSD3r6SljNPISDoKfVX3EZpXxoETuvfTLUedR3\n KTYmsem6rZJLoyCJeOTdIZGz67TI3u7C4rdaJMf8YBKIClLJs1Z54HaznnL9t43HdDll\n KWhh1WVWdZZO9VM5nrDWpaU/bJYRmTEZV0W1Maku3EkJR5/DzEmA/lVQLtRl0llRlV9p\n z+lHCd4MZY2/HKg6CCIfy9L8Gq9M3mDBPwl+cG8asKLwsmpeE7ro+dlTx4LT0Rl3mxNn\n iYiBxa4TzfUlPX4Oe5V+KjjOp7tnfjVnvSpIYTG8bYfrGdd7m8r2ZBetytepxvHA1Iij\n JMgw==","X-Gm-Message-State":"AOJu0Yxm7kXDDNoGxo0NobRvfDCE5guHwwqNUQJi5c268dgnq2ksS2Ag\n /EiIEPOXfDgv+pXoODAjArEezwhQTa1IcDti+LbaRUqx7s3FlfxpWTumawJblP8AuLANYb72H9T\n pQerslw==","X-Gm-Gg":"AeBDiev7qjleecLzLm/aByrR28D/WASGlYJeCCQnxlquV+sOZvKy+QQKt/kK392YqQP\n NxfPFvzDn+vbuPCJCc7+Dg6nHe5MW2ie84wNm4o0bpccTa6A1Fs4U28aS+AOM0xga6w7PGKoXvO\n p8/G71hKyWkTSwe37VIIsiXblZtaR1fi65g+LWBDCruf1vvlswEHoQ2dGfmOFJoE3V3ExyfjSfa\n a3NptOQ6qb3yGHRd9UJ/nOm84Pp0TTYLsU/6Hiu09vkxjKslaeGTndnIFT1PTXpvcQND1Hw0vKQ\n 8Ofg9JCnSxBGvEYWi6sW3rPNOKaGL6293rDrC/niQk9ebWQD1sE6HQosnFd3wkmXDQXJUE05Dts\n 79dTu5LkWFTWodw5Lm44EO5pQgjAwo6yFhFn2FL8ff5QqUCb8F4IVn0H4xEC5ts7jgNUQ3Wr15/\n u7NA8dUZby8hRT/wnA6g==","X-Received":"by 2002:a05:6808:1b23:b0:467:2a6e:adad with SMTP id\n 5614622812f47-46ef4f05067mr4416233b6e.11.1775387550822;\n Sun, 05 Apr 2026 04:12:30 -0700 (PDT)","From":"Simon Glass ","To":"u-boot@lists.denx.de","Cc":"Simon Glass ,\n\tTom Rini ","Subject":"[PATCH v2 4/8] test: Add a check for a missing kernel","Date":"Sun, 5 Apr 2026 05:11:49 -0600","Message-ID":"<20260405111206.945185-5-sjg@chromium.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260405111206.945185-1-sjg@chromium.org>","References":"<20260405111206.945185-1-sjg@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"U-Boot should complain if the kernel is missing, so add a check for this\nin test_fit_base()\n\nSigned-off-by: Simon Glass \n---\n\n(no changes since v1)\n\n test/py/tests/test_fit.py | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)","diff":"diff --git a/test/py/tests/test_fit.py b/test/py/tests/test_fit.py\nindex 4c7d400bc6a..9bfe25c0a51 100755\n--- a/test/py/tests/test_fit.py\n+++ b/test/py/tests/test_fit.py\n@@ -70,7 +70,7 @@ base_its = '''\n configurations {\n default = \"conf-1\";\n conf-1 {\n- kernel = \"kernel-1\";\n+ %(kernel_config)s\n fdt = \"fdt-1\";\n %(ramdisk_config)s\n %(loadables_config)s\n@@ -281,6 +281,7 @@ def test_fit_base(ubman):\n 'kernel_out' : kernel_out,\n 'kernel_addr' : 0x40000,\n 'kernel_size' : filesize(kernel),\n+ 'kernel_config' : 'kernel = \"kernel-1\";',\n \n 'fdt' : fdt,\n 'fdt_out' : fdt_out,\n@@ -389,8 +390,16 @@ def test_fit_base(ubman):\n check_equal(kernel, kernel_out, 'Kernel not loaded')\n check_equal(fdt_data, fdt_out, 'FDT not loaded')\n check_not_equal(ramdisk, ramdisk_out, 'Ramdisk got decompressed?')\n- check_equal(ramdisk + '.gz', ramdisk_out, 'Ramdist not loaded')\n+ check_equal(ramdisk + '.gz', ramdisk_out, 'Ramdisk not loaded')\n \n+ # Try without a kernel\n+ with ubman.log.section('No kernel + FDT'):\n+ params['kernel_config'] = ''\n+ params['ramdisk_config'] = ''\n+ params['ramdisk_load'] = ''\n+ fit = fit_util.make_fit(ubman, mkimage, base_its, params)\n+ output = ubman.run_command_list(cmd.splitlines())\n+ assert \"can't get kernel image!\" in '\\n'.join(output)\n \n mkimage = ubman.config.build_dir + '/tools/mkimage'\n run_fit_test(mkimage)\n","prefixes":["v2","4/8"]}