{"id":2219871,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2219871/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/20260405035323.558335-3-wangrui@loongson.cn/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.2/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260405035323.558335-3-wangrui@loongson.cn>","list_archive_url":null,"date":"2026-04-05T03:53:18","name":"[v8,2/6] elf: Remove redundant _dl_map_segments declaration from dl-load.h","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a1c445377adf98abf3f4c4c752704dc25bcb2755","submitter":{"id":85150,"url":"http://patchwork.ozlabs.org/api/1.2/people/85150/?format=json","name":"WANG Rui","email":"wangrui@loongson.cn"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20260405035323.558335-3-wangrui@loongson.cn/mbox/","series":[{"id":498763,"url":"http://patchwork.ozlabs.org/api/1.2/series/498763/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=498763","date":"2026-04-05T03:53:16","name":"elf: THP-aware load segment alignment","version":8,"mbox":"http://patchwork.ozlabs.org/series/498763/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219871/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219871/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","libc-alpha@sourceware.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","libc-alpha@sourceware.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n dmarc=none (p=none dis=none) header.from=loongson.cn","sourceware.org; spf=pass smtp.mailfrom=loongson.cn","server2.sourceware.org;\n arc=none smtp.remote-ip=114.242.206.163"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fpJW049FBz1xtJ\n\tfor ; Sun, 05 Apr 2026 13:54:31 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 2CB244BA23FC\n\tfor ; Sun, 5 Apr 2026 03:54:29 +0000 (GMT)","from mail.loongson.cn (mail.loongson.cn [114.242.206.163])\n by sourceware.org (Postfix) with ESMTP id 79F8F4BA2E20\n for ; Sun, 5 Apr 2026 03:54:07 +0000 (GMT)","from loongson.cn (unknown [223.64.120.66])\n by gateway (Coremail) with SMTP id _____8DxccDd3NFpixgiAA--.36673S3;\n Sun, 05 Apr 2026 11:54:05 +0800 (CST)","from localhost (unknown [223.64.120.66])\n by front1 (Coremail) with SMTP id qMiowJBxDOHK3NFpP1JlAA--.44692S4;\n Sun, 05 Apr 2026 11:54:02 +0800 (CST)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 2CB244BA23FC","OpenDKIM Filter v2.11.0 sourceware.org 79F8F4BA2E20"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 79F8F4BA2E20","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 79F8F4BA2E20","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775361248; cv=none;\n b=ArWFCGaVqqCw2XS7Y/YpT/qe+fSK0dgwlINR69vf+0AxFELsa5/+6HcmfgGZciybLefUjH0/kADwTShYTswYXIJjUg8SRbUQOPRmSfE867FH6ZzHDT6Eiq2skGf3eZrYpeV79a9zuHBR1lkqYvSyhQkIDygCWJX2gMD6mQV+ijs=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1775361248; c=relaxed/simple;\n bh=5kV+tPN5ipcRFgmNHgXAmm5K+NVaULoBm8ktOeNgHZ4=;\n h=From:To:Subject:Date:Message-ID:MIME-Version;\n b=Zyz0eQdHmiS0XfqN+HCZTw63g6LQJaxjwTaRNDNAcPpRrDU4ZMDGhSqM0dJCfaOlJKGuNK5zsh68DWYK53TOuoFMkJKcbIxT36fmfY1pDc8Pf22zDRMf2u8JFzWXNfmvGUhPKpKeSqx0BEbWk+uFLpwsgq2liVLTTo5dcOC7JZs=","ARC-Authentication-Results":"i=1; server2.sourceware.org","From":"WANG Rui ","To":"libc-alpha@sourceware.org","Cc":"Adhemerval Zanella ,\n Dev Jain , Florian Weimer ,\n Wilco Dijkstra , Xi Ruoyao ,\n WANG Xuerui , caiyinyu ,\n mengqinggang ,\n Huacai Chen , hjl.tools@gmail.com,\n WANG Rui ","Subject":"[PATCH v8 2/6] elf: Remove redundant _dl_map_segments declaration\n from dl-load.h","Date":"Sun, 5 Apr 2026 11:53:18 +0800","Message-ID":"<20260405035323.558335-3-wangrui@loongson.cn>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260405035323.558335-1-wangrui@loongson.cn>","References":"<20260405035323.558335-1-wangrui@loongson.cn>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"qMiowJBxDOHK3NFpP1JlAA--.44692S4","X-CM-SenderInfo":"pzdqw2txl6z05rqj20fqof0/","X-Coremail-Antispam":"1Uk129KBj93XoWxJr4kZry7Jw4kWrW8CFW5XFc_yoW8Cw45pF\n 1Yk34rKFn3Cw4ruayDKa17Ka13Zrn5tw15Wry3W397Xrn7Wr4xXF4fK3WY9a4fJrZ5t3WS\n vF9rKr15ZF4FkrXCm3ZEXasCq-sJn29KB7ZKAUJUUUU7529EdanIXcx71UUUUU7KY7ZEXa\n sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU\n 0xBIdaVrnRJUUUBYb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2\n IYs7xG6rWj6s0DM7CIcVAFz4kK6r1q6r4UM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v\n e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI\n 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_\n Gr0_Gr1UM2kKe7AKxVWUXVWUAwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYI\n kI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUtVWr\n XwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI4\n 8JMxkF7I0En4kS14v26r126r1DMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j\n 6r4UMxCIbckI1I0E14v26r1Y6r17MI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwV\n AFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv2\n 0xvE14v26r4j6ryUMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4\n v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267AK\n xVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU1mii3UUUUU==","X-BeenThere":"libc-alpha@sourceware.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Libc-alpha mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org"},"content":"The function `_dl_map_segments` is defined in ``,\nwhich provides the canonical implementation (optionally overridden\nby sysdeps variants). All call sites include ``\ndirectly, so declaring `_dl_map_segments` in `dl-load.h` is unnecessary.\n\nKeeping a static prototype in `dl-load.h` can trigger\n-Wunused-function errors when the header is included by translation\nunits that do not include `` and do not reference\n`_dl_map_segments`. Since glibc builds with `-Werror`, this results\nin build failures [1].\n\nRemove the redundant declaration from `dl-load.h` to avoid these\nspurious warnings and keep the declaration colocated with the\ndefinition as intended.\n\n[1] https://ci.linaro.org/job/tcwg_glibc_build--master-aarch64-precommit/4624/artifact/artifacts/artifacts.precommit/notify/mail-body.txt\n\nReviewed-by: Wilco Dijkstra \nSigned-off-by: WANG Rui \n---\n elf/dl-load.h | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/elf/dl-load.h b/elf/dl-load.h\nindex dbc29b335e8..897c4034c5e 100644\n--- a/elf/dl-load.h\n+++ b/elf/dl-load.h\n@@ -109,14 +109,15 @@ _dl_postprocess_loadcmd (struct link_map *l, const ElfW(Ehdr) *header,\n \n The file defines this function. The canonical\n implementation in elf/dl-map-segments.h might be replaced by a sysdeps\n- version. */\n+ version.\n+\n static const char *_dl_map_segments (struct link_map *l, int fd,\n const ElfW(Ehdr) *header, int type,\n const struct loadcmd loadcmds[],\n size_t nloadcmds,\n const size_t maplength,\n bool has_holes,\n- struct link_map *loader);\n+ struct link_map *loader); */\n \n /* All the error message strings _dl_map_segments might return are\n listed here so that different implementations in different sysdeps\n","prefixes":["v8","2/6"]}