{"id":2219867,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2219867/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260405034021.12435-1-adeel.m.zahid@gmail.com/","project":{"id":35,"url":"http://patchwork.ozlabs.org/api/1.2/projects/35/?format=json","name":"Linux I2C development","link_name":"linux-i2c","list_id":"linux-i2c.vger.kernel.org","list_email":"linux-i2c@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260405034021.12435-1-adeel.m.zahid@gmail.com>","list_archive_url":null,"date":"2026-04-05T03:40:21","name":"i2c: p2wi: use dev_err_probe() for clock and reset errors","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9ee5a1eab673702987486fdfb7da34bb630908b2","submitter":{"id":93059,"url":"http://patchwork.ozlabs.org/api/1.2/people/93059/?format=json","name":"Adeel Zahid","email":"adeel.m.zahid@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260405034021.12435-1-adeel.m.zahid@gmail.com/mbox/","series":[{"id":498760,"url":"http://patchwork.ozlabs.org/api/1.2/series/498760/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/list/?series=498760","date":"2026-04-05T03:40:21","name":"i2c: p2wi: use dev_err_probe() for clock and reset errors","version":1,"mbox":"http://patchwork.ozlabs.org/series/498760/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219867/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219867/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=OAZb6V9M;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16959-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"OAZb6V9M\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.180","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fpJBz424Hz1yD3\n\tfor ; Sun, 05 Apr 2026 13:40:43 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 5A4433009526\n\tfor ; Sun, 5 Apr 2026 03:40:40 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 00FA45B21A;\n\tSun, 5 Apr 2026 03:40:40 +0000 (UTC)","from mail-pl1-f180.google.com (mail-pl1-f180.google.com\n [209.85.214.180])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 32E19328611\n\tfor ; Sun, 5 Apr 2026 03:40:37 +0000 (UTC)","by mail-pl1-f180.google.com with SMTP id\n d9443c01a7336-2b25cf1b5f0so18333295ad.3\n for ; Sat, 04 Apr 2026 20:40:37 -0700 (PDT)","from adeel-linux.ad.umanitoba.ca\n (nat-243-cc-130-179-243-228.umanitoba.ca. [130.179.243.228])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b27497aeffsm99743195ad.43.2026.04.04.20.40.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 04 Apr 2026 20:40:36 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775360439; cv=none;\n b=EnLshN1UHw6g6xGauR6JD+4tHWbxZm4R7o6Ja9/cW1+NZqboi1rnEsJDOzKOEe5+LVLhyS9/tDeWK7odpH/DnL9Nyvk5AaZiMlSp8kYlLEiKkHxURtklzMlh/EFlAfuvRAMk3fIIPS6cUKWrfjXqnz/UtJGWK9IX5/+5KAB6uNI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775360439; c=relaxed/simple;\n\tbh=QYam+d4n776bCkVM54lnTAL+sqyeNTTk+1AnYmT3twY=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=rwPKmw2vgFNj7GNe/EaO9yqvM0EXncjoHTWQUx1C7MSPod8+IW9sxRDSvkvNodM94dX0nFtco/C2k9HwljRHQkZaDLvIQV1874+ni+lmPwuh6ebH1KrHF9jSNaCS+Clx3mpk0M1BTE/dI1IWP+N3Ussj7x9Gxs5D3t3G0ke9pt8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=OAZb6V9M; arc=none smtp.client-ip=209.85.214.180","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775360436; x=1775965236;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=U/FN5NlH0iS1DMIQZnLtbDssQz5F0UojDeaXB8HEsec=;\n b=OAZb6V9MP9rVPLwvgDvuM5rigo/6pLTg6MMmIXPWtYRD1B/opqo8//RIop4xFAxMAd\n 0PE/PvBzBq4tOgq343QexkCyat+LqtIjdP86Hbv31Tw0FdgMNQGFGGqk5mhSqT0TW6SJ\n O7N3SE007acT3+uUawHozqXonDYxcRdCt3CMEuN5LLrNADesDok/fGhj0NSjFIWwH907\n 5OxGv5UV6ZTl8CbGhykVxST3728WCrKckgAM173VJmdutTJ6v44Mk3EowJ8fb/70gRi1\n 5UyvUs0HAHLr0eZkSkilOo9Mt09rIEaFfdL/jv3HxfmiPERbUrWcRyGu13zzIReNeO4I\n zahA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775360436; x=1775965236;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=U/FN5NlH0iS1DMIQZnLtbDssQz5F0UojDeaXB8HEsec=;\n b=Ywl5lTTN11iI9cgdyOhXl3+m0K+KQpyI3JNIPwKlG9m+n6Fpkqmnk5W6692E03GjQr\n PR+MZGnnqg82R6fQtsT6ENYQ2e6zurgzT3tYjZlip0QyPn54jymxmOyhgpZ/KZDXyo6Y\n 3iCG0Wgmk7f32WhGjfizkLEDGtr70bu0GWVuZ/0E5AcnEJr8aZR2ZDAFa1mlp1M2bIHR\n M5u9YeWdbObXrOL+AQ/5mmc+tiNyyVTICkyOV3MwU0Dgh1/o72wdPC9ZWZDzzlbOhAq2\n nHkIG0uwTWWGkjrc0cX0aORQ0ocG8PEM6upZ7W3uY51afvI4WP5mE/qIjywjQ1mGmmJS\n ZvDw==","X-Gm-Message-State":"AOJu0Yxi49C3JzmDpY2wc0vIyQQz7n70FbievPBDVk6RgVL/JCZDUvtE\n\tl1Vogn6pLFTssrA/tQ+PnhyUbEocz3qpC26fbV7+3neJHevvvU/DVYk2","X-Gm-Gg":"AeBDiesbABSsjwMGfMzwS17KZL1YzntEclR3e77spz141IFRatTOwOS2Qcgt3T7/kVR\n\t/M/He7mhmVuaZMgXlFCNyKstIsbTg876GL2FfcNJ5JVD7xn+gKCbYxw9CSORV+2ZxZE23lLon5p\n\tF/zCxf4F5FRqPKihb3AVF8I9sUyQF2wMNCg7QWOPytuRhzpCtRh4JXSRs8EKxOaESKDLbLoQJh4\n\t+gUMbKVi/4O68G8YtkDnskYERbFWca968rNVW+SgyoHWzsZhAgdsz/JfPVQxCsJBZ28H7hCw6dM\n\tUwIMtkV7z4giip5f98d8SHdCCbX43oOKJemLlDsxgfVZVZuC8klloRjJOROXgKXTwr2DvhhFB9a\n\tc1VY6j2O+LdzsrEmTkOUOO6dmTtgS7gMLEsVlEaaUCM9j10J0DD02adrZu5+++1UOs+Dqpg/I6D\n\tj7XVtlpIDayacek4H8MSMrlZGbbvWCOzg2jNeAHilL382nXg5mI15noLr8j1ObYTZdhfkNbVlkO\n\tdCmrV01yHk++XDLbq/rbTg=","X-Received":"by 2002:a17:903:2c06:b0:2b2:4b4e:e4d8 with SMTP id\n d9443c01a7336-2b28164c3ccmr87459365ad.4.1775360436559;\n Sat, 04 Apr 2026 20:40:36 -0700 (PDT)","From":"Adeel Zahid ","To":"Andi Shyti ,\n\tChen-Yu Tsai ,\n\tJernej Skrabec ,\n\tSamuel Holland ","Cc":"linux-i2c@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-sunxi@lists.linux.dev,\n\tAdeel Zahid ","Subject":"[PATCH] i2c: p2wi: use dev_err_probe() for clock and reset errors","Date":"Sat, 4 Apr 2026 22:40:21 -0500","Message-ID":"<20260405034021.12435-1-adeel.m.zahid@gmail.com>","X-Mailer":"git-send-email 2.43.0","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Replace open-coded error logging and returns with dev_err_probe() when acquiring the clock and reset controller in probe.\n\nThis makes the error handling more concise and correctly handles deferred probe.\n\nSigned-off-by: Adeel Zahid \n---\n drivers/i2c/busses/i2c-sun6i-p2wi.c | 16 ++++++----------\n 1 file changed, 6 insertions(+), 10 deletions(-)","diff":"diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c\nindex fb5280b8cf7f..2be6d50273bd 100644\n--- a/drivers/i2c/busses/i2c-sun6i-p2wi.c\n+++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c\n@@ -245,20 +245,16 @@ static int p2wi_probe(struct platform_device *pdev)\n \t\treturn irq;\n \n \tp2wi->clk = devm_clk_get_enabled(dev, NULL);\n-\tif (IS_ERR(p2wi->clk)) {\n-\t\tret = PTR_ERR(p2wi->clk);\n-\t\tdev_err(dev, \"failed to enable clk: %d\\n\", ret);\n-\t\treturn ret;\n-\t}\n+\tif (IS_ERR(p2wi->clk))\n+\t\treturn dev_err_probe(dev, PTR_ERR(p2wi->clk),\n+\t\t\t\t \"failed to enable clk\\n\");\n \n \tparent_clk_freq = clk_get_rate(p2wi->clk);\n \n \tp2wi->rstc = devm_reset_control_get_exclusive(dev, NULL);\n-\tif (IS_ERR(p2wi->rstc)) {\n-\t\tdev_err(dev, \"failed to retrieve reset controller: %pe\\n\",\n-\t\t\tp2wi->rstc);\n-\t\treturn PTR_ERR(p2wi->rstc);\n-\t}\n+\tif (IS_ERR(p2wi->rstc))\n+\t\treturn dev_err_probe(dev, PTR_ERR(p2wi->rstc),\n+\t\t\t\t \"failed to retrieve reset controller\\n\");\n \n \tret = reset_control_deassert(p2wi->rstc);\n \tif (ret) {\n","prefixes":[]}