{"id":2219860,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2219860/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260405023409.23142-10-mohamed@unpredictable.fr/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260405023409.23142-10-mohamed@unpredictable.fr>","list_archive_url":null,"date":"2026-04-05T02:34:07","name":"[v7,09/11] whpx: i386: use WHvX64RegisterCr8 only when kernel-irqchip=off","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fdf8a7880917f8e1e26cefbbd6846b1aeb98968d","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/1.2/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260405023409.23142-10-mohamed@unpredictable.fr/mbox/","series":[{"id":498757,"url":"http://patchwork.ozlabs.org/api/1.2/series/498757/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498757","date":"2026-04-05T02:34:08","name":"whpx: i386: bug fixes, feature probing and CPUID","version":7,"mbox":"http://patchwork.ozlabs.org/series/498757/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219860/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219860/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=BAIH3juA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fpGm83k6gz1yFs\n\tfor ; Sun, 05 Apr 2026 12:35:52 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w9DJp-0003bK-Q6; Sat, 04 Apr 2026 22:34:33 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w9DJo-0003ap-Eb\n for qemu-devel@nongnu.org; Sat, 04 Apr 2026 22:34:32 -0400","from p-east2-cluster4-host12-snip4-2.eps.apple.com ([57.103.78.183]\n helo=outbound.st.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w9DJm-0008Gh-Ub\n for qemu-devel@nongnu.org; Sat, 04 Apr 2026 22:34:32 -0400","from outbound.st.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-1a-60-percent-10 (Postfix) with ESMTPS id\n 7650F1800144; Sun, 05 Apr 2026 02:34:27 +0000 (UTC)","from localhost.localdomain (unknown [17.42.251.67])\n by p00-icloudmta-asmtp-us-east-1a-60-percent-10 (Postfix) with ESMTPSA id\n 93C35180016A; Sun, 05 Apr 2026 02:34:25 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1775356470; x=1777948470;\n bh=iP6Piv5IE+cZrY5ZT10qnmGENH+bK0UtFOJl7DU/kdg=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=BAIH3juAPWg6h0brCjQYVwCNaltSE7oPJnaOlwU2TYKdgPYX6nic6J/uKncB0qys4LqM8r8Ko1Gnmh30HQBVqBmVOFtqANQYwbRX/z31XSO2xrO53nID9IpBJoKBEq82nVJJ2fD8T8iMWfAaKnshfV3gyyG5e/WlyuzCyYXZeTHWl/3PEMUjPHzMb3jJubaQxqiaLeY5icq/w3LPNmVR3D6w10IyDLEXQJDlW2ZGP7STJk4bTtCJ4W+6pQvhAktL7qY1igBsEHADzcp6Zpkcab/l9KiLDb9S6wJpJGvZ7j943hatU7VMAiFJPElGLzb0AucWVo92owXWMZ/8uoSKxw==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni ","To":"qemu-devel@nongnu.org","Cc":"Pedro Barbuda , Wei Liu ,\n Mohamed Mediouni ,\n Paolo Bonzini , Roman Bolshakov ,\n Phil Dennis-Jordan , Zhao Liu ","Subject":"[PATCH v7 09/11] whpx: i386: use WHvX64RegisterCr8 only when\n kernel-irqchip=off","Date":"Sun, 5 Apr 2026 04:34:07 +0200","Message-ID":"<20260405023409.23142-10-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260405023409.23142-1-mohamed@unpredictable.fr>","References":"<20260405023409.23142-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-ORIG-GUID":"xH6gLu-zr4OiX_mpIhpvZjMkU2kAyqTc","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA1MDAyNCBTYWx0ZWRfX6WKRymWbxnuq\n PV6y/1Qc5BAQpPxUU18yQnxhv7R/Cu/9orLOV0mwEcRGWLTPwGUk6YqkcNvKAom+MuvVv/kYlkW\n IavlUtLk9ioN+T9Apuwyh6wIzmA0rV6I5rrOh/w/gQCvV47yyk2UkVc/B/LxwvLd9B9QnTTur1g\n 02b2yfx33H9IM9mgE/P5FFKfoWV//GfP4xHXqSAjLobXnAYWamdoN1Igp6XRQeyNroIC50HE0OZ\n +PHemQJzUz2apRUOiwIlytKa/ZvfS13sJP1YueJ9ZDIiup+nKpXg0IjKBiatfwVK5FIAbp2qe6Q\n qw87ln7FQdMp2TJE+ZgEDohU3d8al/FYQ2ky5r2gVN1HGrrGvdd1LvDobvMZgo=","X-Authority-Info-Out":"v=2.4 cv=dcqNHHXe c=1 sm=1 tr=0 ts=69d1ca34\n cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117\n a=YrL12D//S6tul8v/L+6tKg==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=4IdwVP5-j8YZXVcKM5MA:9","X-Proofpoint-GUID":"xH6gLu-zr4OiX_mpIhpvZjMkU2kAyqTc","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-05_01,2026-04-03_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 spamscore=0\n malwarescore=0 clxscore=1030 suspectscore=0 phishscore=0 lowpriorityscore=0\n adultscore=0 mlxlogscore=866 bulkscore=0 mlxscore=0 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2604050024","Received-SPF":"pass client-ip=57.103.78.183;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When kernel-irqchip=on, manage TPR as part of the APIC state instead entirely.\n\nThis fixes some failure to set state errors.\n\nSigned-off-by: Mohamed Mediouni \n---\n target/i386/whpx/whpx-all.c | 37 ++++++++++++++++++++++---------------\n 1 file changed, 22 insertions(+), 15 deletions(-)","diff":"diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 11d36e0518..0b0b03864b 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -95,7 +95,6 @@ static const WHV_REGISTER_NAME whpx_register_names[] = {\n WHvX64RegisterCr2,\n WHvX64RegisterCr3,\n WHvX64RegisterCr4,\n- WHvX64RegisterCr8,\n \n /* X64 Debug Registers */\n /*\n@@ -459,8 +458,11 @@ void whpx_set_registers(CPUState *cpu, WHPXStateLevel level)\n vcxt.values[idx++].Reg64 = env->cr[3];\n assert(whpx_register_names[idx] == WHvX64RegisterCr4);\n vcxt.values[idx++].Reg64 = env->cr[4];\n- assert(whpx_register_names[idx] == WHvX64RegisterCr8);\n- vcxt.values[idx++].Reg64 = vcpu->tpr;\n+ /* For kernel-irqchip=on, TPR is managed as part of APIC state */\n+ if (!whpx_irqchip_in_kernel()) {\n+ WHV_REGISTER_VALUE cr8 = {.Reg64 = vcpu->tpr};\n+ whpx_set_reg(cpu, WHvX64RegisterCr8, cr8);\n+ }\n \n /* 8 Debug Registers - Skipped */\n \n@@ -716,11 +718,14 @@ void whpx_get_registers(CPUState *cpu, WHPXStateLevel level)\n env->cr[3] = vcxt.values[idx++].Reg64;\n assert(whpx_register_names[idx] == WHvX64RegisterCr4);\n env->cr[4] = vcxt.values[idx++].Reg64;\n- assert(whpx_register_names[idx] == WHvX64RegisterCr8);\n- tpr = vcxt.values[idx++].Reg64;\n- if (tpr != vcpu->tpr) {\n- vcpu->tpr = tpr;\n- cpu_set_apic_tpr(x86_cpu->apic_state, tpr);\n+\n+ /* For kernel-irqchip=on, TPR is managed as part of APIC state */\n+ if (!whpx_irqchip_in_kernel()) {\n+ tpr = vcpu->exit_ctx.VpContext.Cr8;\n+ if (tpr != vcpu->tpr) {\n+ vcpu->tpr = tpr;\n+ cpu_set_apic_tpr(x86_cpu->apic_state, tpr);\n+ }\n }\n \n /* 8 Debug Registers - Skipped */\n@@ -1660,7 +1665,7 @@ static void whpx_vcpu_pre_run(CPUState *cpu)\n \n /* Sync the TPR to the CR8 if was modified during the intercept */\n tpr = cpu_get_apic_tpr(x86_cpu->apic_state);\n- if (tpr != vcpu->tpr) {\n+ if (!whpx_irqchip_in_kernel() && tpr != vcpu->tpr) {\n vcpu->tpr = tpr;\n reg_values[reg_count].Reg64 = tpr;\n qatomic_set(&cpu->exit_request, true);\n@@ -1702,12 +1707,14 @@ static void whpx_vcpu_post_run(CPUState *cpu)\n \n env->eflags = vcpu->exit_ctx.VpContext.Rflags;\n \n- uint64_t tpr = vcpu->exit_ctx.VpContext.Cr8;\n- if (vcpu->tpr != tpr) {\n- vcpu->tpr = tpr;\n- bql_lock();\n- cpu_set_apic_tpr(x86_cpu->apic_state, vcpu->tpr);\n- bql_unlock();\n+ if (!whpx_irqchip_in_kernel()) {\n+ uint64_t tpr = vcpu->exit_ctx.VpContext.Cr8;\n+ if (vcpu->tpr != tpr) {\n+ vcpu->tpr = tpr;\n+ bql_lock();\n+ cpu_set_apic_tpr(x86_cpu->apic_state, vcpu->tpr);\n+ bql_unlock();\n+ }\n }\n \n vcpu->interruption_pending =\n","prefixes":["v7","09/11"]}