{"id":2219858,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2219858/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260405023409.23142-5-mohamed@unpredictable.fr/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260405023409.23142-5-mohamed@unpredictable.fr>","list_archive_url":null,"date":"2026-04-05T02:34:02","name":"[v7,04/11] whpx: i386: disable TbFlushHypercalls for emulated LAPIC","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c8bc98883e288377ddb601331c7229a335473143","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/1.2/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260405023409.23142-5-mohamed@unpredictable.fr/mbox/","series":[{"id":498757,"url":"http://patchwork.ozlabs.org/api/1.2/series/498757/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498757","date":"2026-04-05T02:34:08","name":"whpx: i386: bug fixes, feature probing and CPUID","version":7,"mbox":"http://patchwork.ozlabs.org/series/498757/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219858/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219858/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=XXO4kLhd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fpGm154Hdz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 05 Apr 2026 12:35:45 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w9DJi-0003Ya-Ix; Sat, 04 Apr 2026 22:34:26 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1w9DJg-0003Y1-Nt\n for qemu-devel@nongnu.org; Sat, 04 Apr 2026 22:34:24 -0400","from p-east2-cluster4-host8-snip4-10.eps.apple.com ([57.103.78.251]\n helo=outbound.st.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1w9DJf-0008Fi-9c\n for qemu-devel@nongnu.org; Sat, 04 Apr 2026 22:34:24 -0400","from outbound.st.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-1a-60-percent-10 (Postfix) with ESMTPS id\n BE70C18000BC; Sun, 05 Apr 2026 02:34:19 +0000 (UTC)","from localhost.localdomain (unknown [17.42.251.67])\n by p00-icloudmta-asmtp-us-east-1a-60-percent-10 (Postfix) with ESMTPSA id\n EA972180014B; Sun, 05 Apr 2026 02:34:17 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1775356462; x=1777948462;\n bh=LeCfULzXVq8eMeXoD4HoazACVFGuCL5m06fQgObX99k=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=XXO4kLhdKBg947EV+SMSox8/GDsPlAdu9O38NEHFMU6fv4LGV8lFn8HP78ms0G+iu8Bqg6dFEsIS7qz8Xf3SE/bQnt8Z4vkFP+mYdw5sSJrjGo3NJ2OhDDyipMr7U3n2rg0u25vhV4E7rLaVMTl5fgwF9lhlUCzA0vAE5UELYjBHpAQptOhANFvfvTcMFtYDXBg9ONUR2pyucii/tQty1quj7nzZrPjJt623ltZXsyooIH3h2dFOqH0YGgXdM9lzJQEla0Haf1PhzkLDP5EglD+6/vT3avG/5QVQa8GU2MTlP4XJz8Ph22iJmtel2S+20Ye9Ao2cgk664SoZ41JOrg==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni <mohamed@unpredictable.fr>","To":"qemu-devel@nongnu.org","Cc":"Pedro Barbuda <pbarbuda@microsoft.com>, Wei Liu <wei.liu@kernel.org>,\n Mohamed Mediouni <mohamed@unpredictable.fr>,\n Paolo Bonzini <pbonzini@redhat.com>, Roman Bolshakov <rbolshakov@ddn.com>,\n Phil Dennis-Jordan <phil@philjordan.eu>, Zhao Liu <zhao1.liu@intel.com>","Subject":"[PATCH v7 04/11] whpx: i386: disable TbFlushHypercalls for emulated\n LAPIC","Date":"Sun,  5 Apr 2026 04:34:02 +0200","Message-ID":"<20260405023409.23142-5-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260405023409.23142-1-mohamed@unpredictable.fr>","References":"<20260405023409.23142-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Authority-Info-Out":"v=2.4 cv=aou/yCZV c=1 sm=1 tr=0 ts=69d1ca2c\n cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117\n a=YrL12D//S6tul8v/L+6tKg==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=Rm0zj2O9plGGl-KjdfMA:9","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA1MDAyNCBTYWx0ZWRfXwSyZQhZvoexU\n 6XrgiYvfpZ6Qoxu+bIdrvjnIZYwjiwOV9E7RMlUboYYxcBGaATikz3BPTaiYJAIgZeaT6fNblc3\n Ia42FB906CaldpviOWWLaTHubB+RKkTX+Kb1UcPWjQPljcN+rOFyGVyPnE446rdHpB4qadkRsDP\n rjFl16TaJK5c1DaTmRc6AiGHkHVOIf+oifm/a2wA3LLDH1Nygtx3AE2XsNKAno5AKqVwwT0QcyD\n rj7FrrF62qli6KGjCDpxUcZ8lT+O0sfyNxESAt18hPAVFq7GW4WntTAggamOQuWiFJG/XEc0mnR\n g3lnU2bRLJ0f5/68KfwTZy93g6SrcDcSMo0l2g0GxRxzLYBamnY61uyYu2MX/I=","X-Proofpoint-GUID":"Y9ZDlTtVY1Jb84bamVnDZbEhE5BTCzOR","X-Proofpoint-ORIG-GUID":"Y9ZDlTtVY1Jb84bamVnDZbEhE5BTCzOR","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-05_01,2026-04-03_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 clxscore=1030\n spamscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=709 adultscore=0\n phishscore=0 malwarescore=0 bulkscore=0 mlxscore=0 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2604050024","Received-SPF":"pass client-ip=57.103.78.251;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"AccessHypercallRegs was present twice so clean that up.\n\nRemove TbFlushHypercalls (and its extended Gva range sub-feature)\nfrom the user-mode LAPIC case as it behaves oddly there.\n\nSigned-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n---\n target/i386/whpx/whpx-all.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)","diff":"diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 2d527b90dd..0908dfd134 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -2489,10 +2489,7 @@ int whpx_accel_init(AccelState *as, MachineState *ms)\n     synthetic_features.Bank0.AccessPartitionReferenceTsc = 1;\n     synthetic_features.Bank0.AccessHypercallRegs = 1;\n     synthetic_features.Bank0.AccessFrequencyRegs = 1;\n-    synthetic_features.Bank0.EnableExtendedGvaRangesForFlushVirtualAddressList = 1;\n     synthetic_features.Bank0.AccessVpIndex = 1;\n-    synthetic_features.Bank0.AccessHypercallRegs = 1;\n-    synthetic_features.Bank0.TbFlushHypercalls = 1;\n \n     if (whpx_irqchip_in_kernel()) {\n         synthetic_features.Bank0.AccessSynicRegs = 1;\n@@ -2500,6 +2497,12 @@ int whpx_accel_init(AccelState *as, MachineState *ms)\n         synthetic_features.Bank0.AccessIntrCtrlRegs = 1;\n         synthetic_features.Bank0.SyntheticClusterIpi = 1;\n         synthetic_features.Bank0.DirectSyntheticTimers = 1;\n+        /*\n+         * These technically work without the Hyper-V LAPIC\n+         * but behave oddly for multi-core VMs.\n+         */\n+        synthetic_features.Bank0.TbFlushHypercalls = 1;\n+        synthetic_features.Bank0.EnableExtendedGvaRangesForFlushVirtualAddressList = 1;\n     }\n \n     if (is_modern_os && whpx->hyperv_enlightenments_allowed) {\n","prefixes":["v7","04/11"]}