{"id":2219815,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2219815/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/f8ffc8de-4b1b-40fd-8807-ee8687fa984f@gmail.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<f8ffc8de-4b1b-40fd-8807-ee8687fa984f@gmail.com>","list_archive_url":null,"date":"2026-04-04T15:19:44","name":"[net] i40e: Cleanup PTP upon probe failure","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bfb47b72076b3c3aea625c40b6d0d5ec2963b2ed","submitter":{"id":92679,"url":"http://patchwork.ozlabs.org/api/1.2/people/92679/?format=json","name":"Matt Vollrath","email":"tactii@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/f8ffc8de-4b1b-40fd-8807-ee8687fa984f@gmail.com/mbox/","series":[{"id":498732,"url":"http://patchwork.ozlabs.org/api/1.2/series/498732/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=498732","date":"2026-04-04T15:19:44","name":"[net] i40e: Cleanup PTP upon probe failure","version":1,"mbox":"http://patchwork.ozlabs.org/series/498732/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219815/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219815/checks/","tags":{},"related":[],"headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=5t08X/PG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnzmK36Slz1yG2\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 05 Apr 2026 02:19:59 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 9E3B360AB4;\n\tSat,  4 Apr 2026 15:19:56 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ue1VHYUJehQ8; Sat,  4 Apr 2026 15:19:55 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id C9C1160616;\n\tSat,  4 Apr 2026 15:19:55 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id DE3D891B\n for <intel-wired-lan@lists.osuosl.org>; Sat,  4 Apr 2026 15:19:54 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id CFFB14043F\n for <intel-wired-lan@lists.osuosl.org>; Sat,  4 Apr 2026 15:19:54 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id K6g0XJLiwvAN for <intel-wired-lan@lists.osuosl.org>;\n Sat,  4 Apr 2026 15:19:54 +0000 (UTC)","from mail-dy1-x132c.google.com (mail-dy1-x132c.google.com\n [IPv6:2607:f8b0:4864:20::132c])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 1383E40426\n for <intel-wired-lan@osuosl.org>; Sat,  4 Apr 2026 15:19:53 +0000 (UTC)","by mail-dy1-x132c.google.com with SMTP id\n 5a478bee46e88-2c15849aa2cso3157807eec.0\n for <intel-wired-lan@osuosl.org>; Sat, 04 Apr 2026 08:19:53 -0700 (PDT)","from ?IPV6:2600:6c5c:6b00:62b::23? ([2600:6c5c:6b00:62b::23])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2cc6e17e0bdsm4378419eec.31.2026.04.04.08.19.50\n for <intel-wired-lan@osuosl.org>\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sat, 04 Apr 2026 08:19:51 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org C9C1160616","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 1383E40426"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775315995;\n\tbh=rkgGr8EsR9RtM9L2b9YguWFCNMs95qhgtRw9JO4XWqU=;\n\th=Date:To:From:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=5t08X/PGVmKFTbI5ZnXlc96RgA5IznchfZdoswD+UkE12oOP9StBmFtTrdpZ0Uwe/\n\t dXqzDxEKWGA4LaavNMfM089RMCrRMXRDbnv0zFSSKs40zv4taU8oogu3OVDNVgXH6e\n\t 1Ztz9YtUeBAwG1rqsGqsGVRgJYimJiA1o//T1zsIhtLeL9pdk/K0w1exlHmoYsoRUW\n\t LeQD6H0sufw0lwL1/jaDiRTEfvjovhMugT4UBDiTK7ZYqEM6R/++oDcjCX0I7Bb9VR\n\t 3rgAkJw5bc+JSmiI8dYki69f9DANI/bjickAt4wZufvorPAAMMDrhoMvUSVwPx0wkH\n\t 64ju3N1Spmpqw==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::132c; helo=mail-dy1-x132c.google.com;\n envelope-from=tactii@gmail.com; receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 1383E40426","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775315992; x=1775920792;\n h=content-transfer-encoding:subject:from:to:content-language\n :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=rkgGr8EsR9RtM9L2b9YguWFCNMs95qhgtRw9JO4XWqU=;\n b=cLkxf4wzhRwZ7P5o6xYxmnI89Ir6CXqQ9k5gQmmrLJBpEkbQTGhvWyikNqv80NUBJG\n XcvFEbMod5OInPSqtP7NRRqT/74XKBs1yTVDqh3rruuBKKXLxyU+TLfcdGacjAAJtkLq\n YzzwZBUwkdK3Z8AIxcWwZ/B/T4tQM8DG8R9RgHE2Aj2Y2jk83ClFnOIX6g4R8ubKRfE9\n QxAJ2m8TsoIqVG69MwPJW0En6WzPnFdjs35ANn0hPdEywwS2xyapxrBt24F6nEeakn3D\n KZ+UWyi5rwHg1fNqziyxF4h+XHL7TAqDHJCRyZ+ZB99ZowoFzIsG3L/Rer0zJJ+yRHWF\n u6RA==","X-Gm-Message-State":"AOJu0YzIy6Z3/bJWI1NLoWRClVoccRm+kEbtm94USaqRO5VREXReHyqj\n InCQ4thwpNYMfv7/IgV6SV0X7nLdI7UOlktkPDepv9TbhViY1QsI5bZcgTB5cw==","X-Gm-Gg":"AeBDiet9h32OQpFqfBRED8f8VX9bOuQCJ9i/e2vQtLrcqqNIrFUKP08Xzbc5zq4VHdM\n rvM1U+vaNwzVDprkQac/n/tURfBaAYGWepwaHEq30fXI20ZFIuCHeBrjFNK5k+kZJGPjKofu8zX\n VZwX23xvssZGm+NDqCxomM15d4FHPL2ByQx/YfunkL3oxqL+UIkySOleHeWo4l3T8Qwv0QPYQG/\n XznoY0h76SOdFvFPX+vWWnjBB5IlDxGi6PujAY4rPdb/Tv9wE0u2InW2CCEVWJgmV0NXWqMQP6A\n kwCi5bPUL3CNbpk1t3VfepIaTs15aAKjrd5bikKM86nimtsgkmshLF93Yqsh9M9834TyWylj3ap\n VuLb2/za7D63QCY3rXBzQeXy7tK680aUiQtUSb/51dBg+nVzWRg+9cbcc5mn6ja2EV8tlGWAzFM\n XKxM/+sFeBdaJhNko7FDdaGfuL","X-Received":"by 2002:a05:7301:9bcc:b0:2c8:fe46:eeb6 with SMTP id\n 5a478bee46e88-2cbfb99005bmr3449573eec.16.1775315991895;\n Sat, 04 Apr 2026 08:19:51 -0700 (PDT)","Message-ID":"<f8ffc8de-4b1b-40fd-8807-ee8687fa984f@gmail.com>","Date":"Sat, 4 Apr 2026 11:19:44 -0400","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Content-Language":"en-US","To":"intel-wired-lan@osuosl.org","From":"Matt Vollrath <tactii@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775315992; x=1775920792; darn=osuosl.org;\n h=content-transfer-encoding:subject:from:to:content-language\n :user-agent:mime-version:date:message-id:from:to:cc:subject:date\n :message-id:reply-to;\n bh=rkgGr8EsR9RtM9L2b9YguWFCNMs95qhgtRw9JO4XWqU=;\n b=X3Evx9+J5GNQHd41221dObUCat+LophjGz+1HtMED0+Y8TmKk5jv8YXLO4aCtSOM5y\n Q4qyVO4zWWK3LK/eV/SHhkIZWjEUmw5bKmLx7S5rKVnk52e7dDcagAs+9hgDSXT8vrCs\n nECkQTzoG6cgJK4VXV+5dFDEGJ5/5v1wIeZcLbZFvkWsUgk0tjDVmgMcZcQafLTHQrkO\n T3BYiIxwkGJ2IBnleaLCOsMFIdpjIWbBtaF26BrHkiqEGwzTNH3vIZIa60sPvmhgigNA\n Lkeq/sQs5/vld3auYjvpNALplKKaXjEZPLmPl1HF4IETKGMB1Yiv7BTYMQ+lDfGgaNZR\n 0UjA==","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=gmail.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=X3Evx9+J"],"Subject":"[Intel-wired-lan] [PATCH net] i40e: Cleanup PTP upon probe failure","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"},"content":"Fix two conditions which would leak PTP registration on probe failure:\n\n1. i40e_setup_pf_switch can encounter an error in\n    i40e_setup_pf_filter_control, call i40e_ptp_init, then return\n    non-zero, sending i40e_probe to err_vsis.\n\n2. i40e_setup_misc_vector can return non-zero, sending i40e_probe to\n    err_vsis.\n\nFound with coccinelle.\n\nSigned-off-by: Matt Vollrath <tactii@gmail.com>\n---\n  drivers/net/ethernet/intel/i40e/i40e_main.c | 1 +\n  1 file changed, 1 insertion(+)","diff":"diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 598739220dfb..dacdf5fad2ea 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -16112,6 +16112,7 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n  \t/* Unwind what we've done if something failed in the setup */\n  err_vsis:\n  \tset_bit(__I40E_DOWN, pf->state);\n+\ti40e_ptp_stop(pf);\n  \ti40e_clear_interrupt_scheme(pf);\n  \tkfree(pf->vsi);\n  err_switch_setup:\n","prefixes":["net"]}