{"id":2216620,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2216620/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/tencent_FED49CF5331CC0C7910618883332A08E2606@qq.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.2/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"","list_archive_url":"https://lore.kernel.org/linuxppc-dev/tencent_FED49CF5331CC0C7910618883332A08E2606@qq.com/","date":"2026-03-27T00:12:25","name":"[v2] soc: fsl: qe: panic on ioremap() failure in qe_reset()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a6fb9c2e6b82250a1760234a2fefa2c29d6f7636","submitter":{"id":92838,"url":"http://patchwork.ozlabs.org/api/1.2/people/92838/?format=json","name":"Wang Jun","email":"1742789905@qq.com"},"delegate":{"id":61610,"url":"http://patchwork.ozlabs.org/api/1.2/users/61610/?format=json","username":"chleroy","first_name":"Christophe","last_name":"Leroy","email":"christophe.leroy@c-s.fr"},"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/tencent_FED49CF5331CC0C7910618883332A08E2606@qq.com/mbox/","series":[{"id":497668,"url":"http://patchwork.ozlabs.org/api/1.2/series/497668/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=497668","date":"2026-03-27T00:12:25","name":"[v2] soc: fsl: qe: panic on ioremap() failure in qe_reset()","version":2,"mbox":"http://patchwork.ozlabs.org/series/497668/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2216620/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2216620/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=qq.com header.i=@qq.com header.a=rsa-sha256\n header.s=s201512 header.b=nzpBQwH3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18841-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=203.205.221.210","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=qq.com","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=qq.com header.i=@qq.com header.a=rsa-sha256\n header.s=s201512 header.b=nzpBQwH3;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=qq.com\n (client-ip=203.205.221.210; helo=out203-205-221-210.mail.qq.com;\n envelope-from=1742789905@qq.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhj1P4Fj4z1yFp\n\tfor ; Fri, 27 Mar 2026 11:58:00 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fhj1M1gxqz2yRl;\n\tFri, 27 Mar 2026 11:57:59 +1100 (AEDT)","from out203-205-221-210.mail.qq.com (out203-205-221-210.mail.qq.com\n [203.205.221.210])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with UTF8SMTPS id 4fhh4n0VHLz2xlP\n\tfor ; Fri, 27 Mar 2026 11:15:52 +1100 (AEDT)","from June.localdomain ([123.121.145.35])\n\tby newxmesmtplogicsvrszb43-0.qq.com (NewEsmtp) with SMTP\n\tid 31B3D40A; Fri, 27 Mar 2026 08:12:27 +0800"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774570556;\n\tcv=none;\n b=iHT0hPSPiAAl0GWZ3gj8dRxQ2y5Mhqccp/F+7Xvfa+XgZNPKk/LxwpAcfEgWsxHaZFOsoA2dtY5xpUBEW6ScZGFX+baZPq4nZrTelTYqNtOlmKFea0rmtYnlURyBcSgsqSA7CtBzTVfmyp8ZC9JpPigIgWbl+nf1L6GyWEiUxl/g1iL3BMrTG2YVrEqPGIwcZYjQ0MdtU01zmD61xS6PpR9Fmz0lA9XhniN0KIwn6zH2R9gr6juVsSeTma8RgabhMyZ/8NhvtaP9RmvSbYWP/3z18e1zTUJ9Zs00u03ypz4wJKi9TO6V0LbGK+Qw3cDJ5bhTeBQIRcIFrW362PM/Mw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774570556; c=relaxed/relaxed;\n\tbh=jF3VGWtFl5+5o0uq4BkVs4561ebEJfqMmvq/lQMWgIo=;\n\th=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References:\n\t MIME-Version;\n b=gL4XVwk1PVpdyBRtc+fVlxsN7gdokowaruRqFR43fklxs7d9uBAp5ACzHkuoKImcSwcGWAxMN19Q5GaW4IY+2P/dB6lQInbEHVfQJzM+IPHCSIVLAhHzm5k16TAHC1NV9N05bH+uNN1nRZ16e+x2O3M8U+1W+Qc74+nnlHX5JYWhEZF8Q8AIH5Vul+FbkA93B3iCP7VzvVdZ5hEnj/XI5gU3Am+8xhvXE35t8SLuz7nJoAbLr7HOuOS6TinvEBBn5bMYXGYstnckpt1iSox8jrLCa0NH64dWh7du1WYJLM0YtxTxSyFhhG43sDK1giiTEJjssP+0avEmzrn08NM8AQ==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=qq.com;\n dkim=pass (1024-bit key;\n unprotected) header.d=qq.com header.i=@qq.com header.a=rsa-sha256\n header.s=s201512 header.b=nzpBQwH3; dkim-atps=neutral;\n spf=pass (client-ip=203.205.221.210; helo=out203-205-221-210.mail.qq.com;\n envelope-from=1742789905@qq.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=qq.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512;\n\tt=1774570549; bh=jF3VGWtFl5+5o0uq4BkVs4561ebEJfqMmvq/lQMWgIo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=nzpBQwH32QyzbCa/dnRSECDHVYxrDsrj2m+iSKxISqwYTMl/UCWhoRGVOV8ermZmB\n\t DC8N41s6uI0xW0/cucjkPinOJmr5O/zE09oTrozy5I0EI6e8QhgCRHDPfgI9JQRWVH\n\t /DfOb/CCGMwuU9QpS+6NV3OEHBcLFU76FyW4Dq/0=","X-QQ-mid":"xmsmtpt1774570347t0b1u0f4c","Message-ID":"","X-QQ-XMAILINFO":"NOcEdvLhLw8TC3ZRP/Ms0StBJXSMyXt0mU2UswUKCWUlYxFjktxm4PCFaA1xS/\n\t EyzMCbbnf0yAdffRpg0L3tinYG7P33cxMV7HET/P46r2gumZSJli6l+weTKjXu4Xz05bnuUZjiq0\n\t pmeNp96t6ySl+iel6n/kLFUQ4jB/oHXJUdtkfa/4GsK1oSi3mE9NcU0/7Sm8GouX218nqxeCKNAe\n\t LwiiNRm1iCtCBsLAz/96ynLKP6QvZ52ne2DDmdgcYgi9GkisNL5EWjuxwkA4c5TsawyE1bNa3DO7\n\t BF7XbJPNNVsa06JylxRz4kLskpVXqmPs09Vwxn6iaK3eANR3IN5vmGDXzw2dA/9nx4UVIfov0F9+\n\t 3FD3ZLQom/kbFJOxCJfcD4ehTLaPG8nbmWOf982IWvOn24PKa5+3owmU1y4w3Pp5eVulVOIKMu+6\n\t zVwphqDXppwIFAD9JKisnxWxKJ4+5Uq23hUJ2U3ZkSX05uxIxwqgEf87bC+SEHkaomIac4p9/3Lg\n\t Jdd6Z5lXAueJyRSQIdrsOYeGy8aTMf61MnSrNMD1y8QJKlKOblGFejXIGN8oaRqLMgvCqOFYr2F6\n\t bGmGgmB6z92I/MWqt+cdi5K0oJl00zBWs2XD1kucFkDnSUD6P2iwgpjMd2Wym5mMlLu1yXkHXK1t\n\t AjaDRV3xkdT+duBWUk6CYiEZTHnHqh4Rox1fC6OWWh7gxV5vGXGKfK+ygKFdaGL7bQHhpo8OsNrh\n\t ILo4L/k6l6CuNO/Un5shA//IrgSSL9zzT+RnjY+ZSWgfEnKoae1MaeBHmgzDi/x9BfGneqNimrwb\n\t OhMBwcNZZ0TX5XskB89pFRAXzg0hm643TXzLnfu02X7O/reQluAWrKdhpBh6A+Nadf0L9IbxRBSi\n\t WZDXm7B5wMHfT0pyXkm8jnvYn4f/aCcEkXwplDrHpumfbOjAd0WoOsHzgZqu6YwwTJpSIRSHlZ+y\n\t bn/YtDozYt7Ua0ncRNxltyxIGiWiRxbsBIdkxiv/qeGhyD8dTE6x+RpXiFCF1H85SAkSvMx6+pkh\n\t MbR+YM2tq39v/Tkg0aQM7b1OV2cDEx3JJo5eTeKpOo2liS2EZfZt4Db4lsRjzANEK2TNxpbQ==","X-QQ-XMRINFO":"MPJ6Tf5t3I/ylTmHUqvI8+Wpn+Gzalws3A==","From":"Wang Jun <1742789905@qq.com>","To":"Qiang Zhao ,\n\tChristophe Leroy ,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-arm-kernel@lists.infradead.org","Cc":"linux-kernel@vger.kernel.org,\n\tgszhai@bjtu.edu.cn,\n\t25125332@bjtu.edu.cn,\n\t25125283@bjtu.edu.cn,\n\t23120469@bjtu.edu.cn,\n\tWang Jun <1742789905@qq.com>,\n\tstable@vger.kernel.org","Subject":"[PATCH v2] soc: fsl: qe: panic on ioremap() failure in qe_reset()","Date":"Fri, 27 Mar 2026 08:12:25 +0800","X-OQ-MSGID":"<20260327001225.23192-1-1742789905@qq.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<780c1ba3-6639-478e-896f-e35ec059b58c@kernel.org>","References":"<780c1ba3-6639-478e-896f-e35ec059b58c@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Flag":"YES","X-Spam-Status":"Yes, score=3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,\n\tHELO_DYNAMIC_IPADDR,RCVD_IN_DNSWL_NONE,RDNS_DYNAMIC,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Report":"\n\t* -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no\n\t* trust\n\t* [203.205.221.210 listed in list.dnswl.org]\n\t* -0.0 SPF_PASS SPF: sender matches SPF record\n\t* 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n\t* -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n\t* envelope-from domain\n\t* 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily\n\t* valid\n\t* -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's\n\t* domain\n\t* -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t* 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in\n\t* digit\n\t* [1742789905(at)qq.com]\n\t* 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider\n\t* [1742789905(at)qq.com]\n\t* 0.4 RDNS_DYNAMIC Delivered to internal network by host with\n\t* dynamic-looking rDNS\n\t* 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr\n\t* 1)","X-Spam-Level":"***","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"When ioremap() fails in qe_reset(), the global pointer qe_immr remains\nNULL, leading to a subsequent NULL pointer dereference when the pointer\nis accessed. Since this happens early in the boot process, a failure to\nmap a few bytes of I/O memory indicates a fatal error from which the\nsystem cannot recover.\n\nFollow the same pattern as qe_sdma_init() and panic immediately when\nioremap() fails. This avoids a silent NULL pointer dereference later\nand makes the error explicit.\n\nFixes: 986585385131 (\"[POWERPC] Add QUICC Engine (QE) infrastructure\")\nCc: stable@vger.kernel.org\nSigned-off-by: Wang Jun <1742789905@qq.com>\n---\n drivers/soc/fsl/qe/qe.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c\nindex 70b6eddb867b..9f6223043ee3 100644\n--- a/drivers/soc/fsl/qe/qe.c\n+++ b/drivers/soc/fsl/qe/qe.c\n@@ -86,8 +86,12 @@ static phys_addr_t get_qe_base(void)\n \n void qe_reset(void)\n {\n-\tif (qe_immr == NULL)\n+\tif (qe_immr == NULL) {\n \t\tqe_immr = ioremap(get_qe_base(), QE_IMMAP_SIZE);\n+\t\tif (qe_immr == NULL) {\n+\t\t\tpanic(\"QE:ioremap failed!\");\n+\t\t}\n+\t}\n \n \tqe_snums_init();\n \n","prefixes":["v2"]}