{"id":2216574,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2216574/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260326201819.3900-1-david.laight.linux@gmail.com/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.2/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260326201819.3900-1-david.laight.linux@gmail.com>","list_archive_url":null,"date":"2026-03-26T20:18:19","name":"[next] netfilter: nf_conntrack_h323: Correct indentation when H323_TRACE defined","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"4b3808a360bda9e42ed6b66f4a0a3f0ac046da5e","submitter":{"id":89989,"url":"http://patchwork.ozlabs.org/api/1.2/people/89989/?format=json","name":"David Laight","email":"david.laight.linux@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260326201819.3900-1-david.laight.linux@gmail.com/mbox/","series":[{"id":497647,"url":"http://patchwork.ozlabs.org/api/1.2/series/497647/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=497647","date":"2026-03-26T20:18:19","name":"[next] netfilter: nf_conntrack_h323: Correct indentation when H323_TRACE defined","version":1,"mbox":"http://patchwork.ozlabs.org/series/497647/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2216574/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2216574/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=blqaZm56;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11460-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"blqaZm56\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.221.45","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhZw96WRSz1y1j\n\tfor ; Fri, 27 Mar 2026 07:23:05 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id ED940304E0F2\n\tfor ; Thu, 26 Mar 2026 20:18:24 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E35CC3A1CEC;\n\tThu, 26 Mar 2026 20:18:23 +0000 (UTC)","from mail-wr1-f45.google.com (mail-wr1-f45.google.com\n [209.85.221.45])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id F10E6224AF2\n\tfor ; Thu, 26 Mar 2026 20:18:21 +0000 (UTC)","by mail-wr1-f45.google.com with SMTP id\n ffacd0b85a97d-43b527ac5d0so773832f8f.2\n for ;\n Thu, 26 Mar 2026 13:18:21 -0700 (PDT)","from snowdrop.snailnet.com (82-69-66-36.dsl.in-addr.zen.co.uk.\n [82.69.66.36])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43b9192e3e8sm11693016f8f.5.2026.03.26.13.18.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 26 Mar 2026 13:18:20 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774556303; cv=none;\n b=eUj8o/cHTwHw6BAmQIGQuSH3diYCcAh1rclCUe1Ic6kJxlYOTfN+4XIOuFky8j7ojMc/qjCm/72NWHiAdxxMQJ0fzPwA7jkTzafh1vvpZRuEn/+zQz8rwBVX+6YMr8wpOUZfsBRdp/kBiyyaHMKjmCq5hdHQbLZ3NLQ4XkdLWJg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774556303; c=relaxed/simple;\n\tbh=JX4vHATIUFWQLbRlq7POOxtY7rKiXSnnAKpkp53Qk4w=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=a80i08aahi+MawCRkzj1f62s1Ue163Gqh3Wr1MkVSqiH8uI2K+RpDgQddmheW62u1qpvBjesvxNfHDWE3jkhaFLtzMcTVdGDlV+Q+RL/KaXaoHTP7P3ZoOg7HcGSa7ZfFSQ7WSCWHgodcbCV4OVv4gIWgZyDLMxY3WeNgD7BYh8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=blqaZm56; arc=none smtp.client-ip=209.85.221.45","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774556300; x=1775161100;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=wTEKVcMeJ2+2gv4frZXSVscFWk19gO1Vh54Xj2RwYEY=;\n b=blqaZm56Pg7xovNIpmBVh3tAUfgT9Wqpu9MfcT0TYYjveYmsdY68H83Hs1z5mg4tQK\n OJuaro/JcZNe/jj/+68toggUdhKd0g7pC5rQAqWc0z+0vX+fuVOe+RSRFvEiLhH00Ko0\n HyFexecWi2FRWcC8DgXv1v+Pb3FrecjRVD4cFFhBqjCjgqxWTL2OqoXwA656nHlnfvEK\n p15Ic2U6J/tfIowzBMxw4hTMwYJMBfine093n1Jqk3Hjmljb7onQJ1ET4ftqCGffQ5wq\n dgaHVxOFHdd2Z3cL/NNkKZW3tB9+i5AXmNtgmnQ8aL9zSfYrc/YlR8YlY0pN6VsezPT4\n qifw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774556300; x=1775161100;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=wTEKVcMeJ2+2gv4frZXSVscFWk19gO1Vh54Xj2RwYEY=;\n b=eOFy0mznJvpyCHmzH912P/zgno/4ldXubx81vpao816XgHnvlvb/U1edEYRWIWFU1r\n m1YqnDAM6dACc6tE9dyBl0s8Hp+6QZPu8HXQxOr3h8Y6PIOjHoYU/E4cK9yG+i+/mWqw\n yy7bGdM0R3ZKJS+tSprD+4c8SuJ9G5GdbBNWqrg1TmqcDq/YCP5vhdRIcwlnP4XuWGcB\n Lx1gUwS/Qo1YqXcPxebk5cALoBFH5Ll8JwYkfxjZ9sMOREakozW7nwi0flAG1yiqUlxV\n AkngiC5/01nAzjo114aO6Y6jb0Ouj/DPSIm3/4Np2CwZ8zEaPVrdRvFLxoc1FMLRcFDJ\n cvpg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXAlm4drzApBEu+XFYUkHY5pfx7P0fke7Lm33xaa8gIglmmFR/7yxuK82k1UUONsxbvBjCLu3d7xnjjRYEpA/g=@vger.kernel.org","X-Gm-Message-State":"AOJu0YzG6c3PrraOHs10VJ748jXQL/OC0GQcv/lYG2+4YOamKz7bEhPl\n\tbYb+5L3ZPnMAk2hGMPrXefsb45bcCc1GEh120HJkHlG03gwmg9MdvHXY","X-Gm-Gg":"ATEYQzxF1xfndOaKigexXbgf/xzmbbO69pXgiqJ4gPEmG8I1Ppu/PShqvbwaU3IwuNm\n\t8KAlX+aoDweWIAtIyM6LqUzwqDnS/SKpmabNRrC2YfIpXqGD5QFZ6I+u/cvtESRe+OuE6cgCrAh\n\t0SSPw219xlO6tSCraycBULbQ+nHYFtv+jhdUX7P1JvKHoNlQRuQdOyCKUoVGelFJs+rvcVa9hjJ\n\tM3SgCJMxCKxEAucraimy7+lWZ23euai8WHFY2Qu2olQyNpAwFZr/RPOSOW7czaiiu7FIlRNN/+g\n\tMsWzDP1e4z1/BzB8JcKreOojv2TBanq0m3qmWcdHaA221+InpeNQGKi5W7lIoBxDwTpB3H89OPz\n\t8dd9bxbmvm/aCW07W4Sp+Sm3XZ4dOIZbncnMHhR3xlrYGNfYvCjFbi5Q8htAtsuZ2eIh9DEuh8H\n\tKwEYFTvZtT7Kmdj9H9wH+fnoBiek11JwO5y5qkAJcsD7xm0ZYJtwicd7TDh7+KSABo3CdLIAbeM\n\tJUklsgkej+G","X-Received":"by 2002:a05:6000:4287:b0:43b:634d:1a9e with SMTP id\n ffacd0b85a97d-43b889c505fmr14390229f8f.15.1774556300321;\n Thu, 26 Mar 2026 13:18:20 -0700 (PDT)","From":"david.laight.linux@gmail.com","To":"Pablo Neira Ayuso ,\n\tFlorian Westphal ,\n\tPhil Sutter ,\n\t\"David S. Miller\" ,\n\tEric Dumazet ,\n\tJakub Kicinski ,\n\tPaolo Abeni ,\n\tSimon Horman ,\n\tnetfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Cc":"David Laight ,\n\tMasami Hiramatsu ,\n\tPetr Mladek ,\n\tRasmus Villemoes ,\n\tAndy Shevchenko ,\n\tSteven Rostedt ,\n\tSergey Senozhatsky ,\n\tAndrew Morton ","Subject":"[PATCH next] netfilter: nf_conntrack_h323: Correct indentation when\n H323_TRACE defined","Date":"Thu, 26 Mar 2026 20:18:19 +0000","Message-Id":"<20260326201819.3900-1-david.laight.linux@gmail.com>","X-Mailer":"git-send-email 2.39.5","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: David Laight \n\nThe trace lines are indented using PRINT(\"%*.s\", xx, \" \").\nUserspace will treat this as \"%*.0s\" and will output no characters\nwhen 'xx' is zero, the kernel treats it as \"%*s\" and will output\na single ' ' - which is probably what is intended.\n\nChange all the formats to \"%*s\" removing the default precision.\nThis gives a single space indent when level is zero.\n\nSigned-off-by: David Laight \n---\n net/netfilter/nf_conntrack_h323_asn1.c | 38 +++++++++++++-------------\n 1 file changed, 19 insertions(+), 19 deletions(-)","diff":"diff --git a/net/netfilter/nf_conntrack_h323_asn1.c b/net/netfilter/nf_conntrack_h323_asn1.c\nindex 7b1497ed97d2..287402428975 100644\n--- a/net/netfilter/nf_conntrack_h323_asn1.c\n+++ b/net/netfilter/nf_conntrack_h323_asn1.c\n@@ -276,7 +276,7 @@ static unsigned int get_uint(struct bitstr *bs, int b)\n static int decode_nul(struct bitstr *bs, const struct field_t *f,\n char *base, int level)\n {\n-\tPRINT(\"%*.s%s\\n\", level * TAB_SIZE, \" \", f->name);\n+\tPRINT(\"%*s%s\\n\", level * TAB_SIZE, \" \", f->name);\n \n \treturn H323_ERROR_NONE;\n }\n@@ -284,7 +284,7 @@ static int decode_nul(struct bitstr *bs, const struct field_t *f,\n static int decode_bool(struct bitstr *bs, const struct field_t *f,\n char *base, int level)\n {\n-\tPRINT(\"%*.s%s\\n\", level * TAB_SIZE, \" \", f->name);\n+\tPRINT(\"%*s%s\\n\", level * TAB_SIZE, \" \", f->name);\n \n \tINC_BIT(bs);\n \tif (nf_h323_error_boundary(bs, 0, 0))\n@@ -297,7 +297,7 @@ static int decode_oid(struct bitstr *bs, const struct field_t *f,\n {\n \tint len;\n \n-\tPRINT(\"%*.s%s\\n\", level * TAB_SIZE, \" \", f->name);\n+\tPRINT(\"%*s%s\\n\", level * TAB_SIZE, \" \", f->name);\n \n \tBYTE_ALIGN(bs);\n \tif (nf_h323_error_boundary(bs, 1, 0))\n@@ -316,7 +316,7 @@ static int decode_int(struct bitstr *bs, const struct field_t *f,\n {\n \tunsigned int len;\n \n-\tPRINT(\"%*.s%s\", level * TAB_SIZE, \" \", f->name);\n+\tPRINT(\"%*s%s\", level * TAB_SIZE, \" \", f->name);\n \n \tswitch (f->sz) {\n \tcase BYTE:\t\t/* Range == 256 */\n@@ -363,7 +363,7 @@ static int decode_int(struct bitstr *bs, const struct field_t *f,\n static int decode_enum(struct bitstr *bs, const struct field_t *f,\n char *base, int level)\n {\n-\tPRINT(\"%*.s%s\\n\", level * TAB_SIZE, \" \", f->name);\n+\tPRINT(\"%*s%s\\n\", level * TAB_SIZE, \" \", f->name);\n \n \tif ((f->attr & EXT) && get_bit(bs)) {\n \t\tINC_BITS(bs, 7);\n@@ -381,7 +381,7 @@ static int decode_bitstr(struct bitstr *bs, const struct field_t *f,\n {\n \tunsigned int len;\n \n-\tPRINT(\"%*.s%s\\n\", level * TAB_SIZE, \" \", f->name);\n+\tPRINT(\"%*s%s\\n\", level * TAB_SIZE, \" \", f->name);\n \n \tBYTE_ALIGN(bs);\n \tswitch (f->sz) {\n@@ -417,7 +417,7 @@ static int decode_numstr(struct bitstr *bs, const struct field_t *f,\n {\n \tunsigned int len;\n \n-\tPRINT(\"%*.s%s\\n\", level * TAB_SIZE, \" \", f->name);\n+\tPRINT(\"%*s%s\\n\", level * TAB_SIZE, \" \", f->name);\n \n \t/* 2 <= Range <= 255 */\n \tif (nf_h323_error_boundary(bs, 0, f->sz))\n@@ -437,7 +437,7 @@ static int decode_octstr(struct bitstr *bs, const struct field_t *f,\n {\n \tunsigned int len;\n \n-\tPRINT(\"%*.s%s\", level * TAB_SIZE, \" \", f->name);\n+\tPRINT(\"%*s%s\", level * TAB_SIZE, \" \", f->name);\n \n \tswitch (f->sz) {\n \tcase FIXD:\t\t/* Range == 1 */\n@@ -490,7 +490,7 @@ static int decode_bmpstr(struct bitstr *bs, const struct field_t *f,\n {\n \tunsigned int len;\n \n-\tPRINT(\"%*.s%s\\n\", level * TAB_SIZE, \" \", f->name);\n+\tPRINT(\"%*s%s\\n\", level * TAB_SIZE, \" \", f->name);\n \n \tswitch (f->sz) {\n \tcase BYTE:\t\t/* Range == 256 */\n@@ -522,7 +522,7 @@ static int decode_seq(struct bitstr *bs, const struct field_t *f,\n \tconst struct field_t *son;\n \tunsigned char *beg = NULL;\n \n-\tPRINT(\"%*.s%s\\n\", level * TAB_SIZE, \" \", f->name);\n+\tPRINT(\"%*s%s\\n\", level * TAB_SIZE, \" \", f->name);\n \n \t/* Decode? */\n \tbase = (base && (f->attr & DECODE)) ? base + f->offset : NULL;\n@@ -544,7 +544,7 @@ static int decode_seq(struct bitstr *bs, const struct field_t *f,\n \t/* Decode the root components */\n \tfor (i = opt = 0, son = f->fields; i < f->lb; i++, son++) {\n \t\tif (son->attr & STOP) {\n-\t\t\tPRINT(\"%*.s%s\\n\", (level + 1) * TAB_SIZE, \" \",\n+\t\t\tPRINT(\"%*s%s\\n\", (level + 1) * TAB_SIZE, \" \",\n \t\t\t son->name);\n \t\t\treturn H323_ERROR_STOP;\n \t\t}\n@@ -562,7 +562,7 @@ static int decode_seq(struct bitstr *bs, const struct field_t *f,\n \t\t\tif (nf_h323_error_boundary(bs, len, 0))\n \t\t\t\treturn H323_ERROR_BOUND;\n \t\t\tif (!base || !(son->attr & DECODE)) {\n-\t\t\t\tPRINT(\"%*.s%s\\n\", (level + 1) * TAB_SIZE,\n+\t\t\t\tPRINT(\"%*s%s\\n\", (level + 1) * TAB_SIZE,\n \t\t\t\t \" \", son->name);\n \t\t\t\tbs->cur += len;\n \t\t\t\tcontinue;\n@@ -615,7 +615,7 @@ static int decode_seq(struct bitstr *bs, const struct field_t *f,\n \t\t}\n \n \t\tif (son->attr & STOP) {\n-\t\t\tPRINT(\"%*.s%s\\n\", (level + 1) * TAB_SIZE, \" \",\n+\t\t\tPRINT(\"%*s%s\\n\", (level + 1) * TAB_SIZE, \" \",\n \t\t\t son->name);\n \t\t\treturn H323_ERROR_STOP;\n \t\t}\n@@ -629,7 +629,7 @@ static int decode_seq(struct bitstr *bs, const struct field_t *f,\n \t\tif (nf_h323_error_boundary(bs, len, 0))\n \t\t\treturn H323_ERROR_BOUND;\n \t\tif (!base || !(son->attr & DECODE)) {\n-\t\t\tPRINT(\"%*.s%s\\n\", (level + 1) * TAB_SIZE, \" \",\n+\t\t\tPRINT(\"%*s%s\\n\", (level + 1) * TAB_SIZE, \" \",\n \t\t\t son->name);\n \t\t\tbs->cur += len;\n \t\t\tcontinue;\n@@ -655,7 +655,7 @@ static int decode_seqof(struct bitstr *bs, const struct field_t *f,\n \tconst struct field_t *son;\n \tunsigned char *beg = NULL;\n \n-\tPRINT(\"%*.s%s\\n\", level * TAB_SIZE, \" \", f->name);\n+\tPRINT(\"%*s%s\\n\", level * TAB_SIZE, \" \", f->name);\n \n \t/* Decode? */\n \tbase = (base && (f->attr & DECODE)) ? base + f->offset : NULL;\n@@ -710,7 +710,7 @@ static int decode_seqof(struct bitstr *bs, const struct field_t *f,\n \t\t\tif (nf_h323_error_boundary(bs, len, 0))\n \t\t\t\treturn H323_ERROR_BOUND;\n \t\t\tif (!base || !(son->attr & DECODE)) {\n-\t\t\t\tPRINT(\"%*.s%s\\n\", (level + 1) * TAB_SIZE,\n+\t\t\t\tPRINT(\"%*s%s\\n\", (level + 1) * TAB_SIZE,\n \t\t\t\t \" \", son->name);\n \t\t\t\tbs->cur += len;\n \t\t\t\tcontinue;\n@@ -751,7 +751,7 @@ static int decode_choice(struct bitstr *bs, const struct field_t *f,\n \tconst struct field_t *son;\n \tunsigned char *beg = NULL;\n \n-\tPRINT(\"%*.s%s\\n\", level * TAB_SIZE, \" \", f->name);\n+\tPRINT(\"%*s%s\\n\", level * TAB_SIZE, \" \", f->name);\n \n \t/* Decode? */\n \tbase = (base && (f->attr & DECODE)) ? base + f->offset : NULL;\n@@ -792,7 +792,7 @@ static int decode_choice(struct bitstr *bs, const struct field_t *f,\n \t/* Transfer to son level */\n \tson = &f->fields[type];\n \tif (son->attr & STOP) {\n-\t\tPRINT(\"%*.s%s\\n\", (level + 1) * TAB_SIZE, \" \", son->name);\n+\t\tPRINT(\"%*s%s\\n\", (level + 1) * TAB_SIZE, \" \", son->name);\n \t\treturn H323_ERROR_STOP;\n \t}\n \n@@ -804,7 +804,7 @@ static int decode_choice(struct bitstr *bs, const struct field_t *f,\n \t\tif (nf_h323_error_boundary(bs, len, 0))\n \t\t\treturn H323_ERROR_BOUND;\n \t\tif (!base || !(son->attr & DECODE)) {\n-\t\t\tPRINT(\"%*.s%s\\n\", (level + 1) * TAB_SIZE, \" \",\n+\t\t\tPRINT(\"%*s%s\\n\", (level + 1) * TAB_SIZE, \" \",\n \t\t\t son->name);\n \t\t\tbs->cur += len;\n \t\t\treturn H323_ERROR_NONE;\n","prefixes":["next"]}