{"id":2215434,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2215434/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260324-boot-fit-fix-8-byte-alignement-for-overlays-v1-1-257b132b6bda@baylibre.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324-boot-fit-fix-8-byte-alignement-for-overlays-v1-1-257b132b6bda@baylibre.com>","list_archive_url":null,"date":"2026-03-24T15:33:45","name":"boot/fit: remove useless else branch","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"02141f8c9dfa2ebc6ff483237fb4106ccedae431","submitter":{"id":84831,"url":"http://patchwork.ozlabs.org/api/1.2/people/84831/?format=json","name":"Julien Stephan","email":"jstephan@baylibre.com"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/1.2/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260324-boot-fit-fix-8-byte-alignement-for-overlays-v1-1-257b132b6bda@baylibre.com/mbox/","series":[{"id":497306,"url":"http://patchwork.ozlabs.org/api/1.2/series/497306/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=497306","date":"2026-03-24T15:33:45","name":"boot/fit: remove useless else branch","version":1,"mbox":"http://patchwork.ozlabs.org/series/497306/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215434/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215434/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20230601.gappssmtp.com\n header.i=@baylibre-com.20230601.gappssmtp.com header.a=rsa-sha256\n header.s=20230601 header.b=3Ewq10Pb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20230601.gappssmtp.com\n header.i=@baylibre-com.20230601.gappssmtp.com header.b=\"3Ewq10Pb\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=jstephan@baylibre.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgDbL1MLgz1xy1\n\tfor ; Wed, 25 Mar 2026 02:33:50 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B9E1180212;\n\tTue, 24 Mar 2026 16:33:46 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id C4EAD80517; Tue, 24 Mar 2026 16:33:45 +0100 (CET)","from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n [IPv6:2a00:1450:4864:20::331])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A359680087\n for ; Tue, 24 Mar 2026 16:33:43 +0100 (CET)","by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-486fd5360d4so16092145e9.1\n for ; Tue, 24 Mar 2026 08:33:43 -0700 (PDT)","from [192.168.1.100]\n (2a02-842a-d52e-6101-b535-6f9c-731f-0b89.rev.sfr.net.\n [2a02:842a:d52e:6101:b535:6f9c:731f:b89])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43b644ae619sm39934003f8f.5.2026.03.24.08.33.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 24 Mar 2026 08:33:41 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1774366423;\n x=1774971223;\n darn=lists.denx.de;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:from:to:cc:subject:date:message-id:reply-to;\n bh=TOiDhle0PnY0wck/VOrs74zYzASRvEfrRyQ8rF9/ZA8=;\n b=3Ewq10PbTnWq2ZvITq6QIBylFhamuxLS5Oj61JEUfVZxhr29ixawOg/PM8In7XBKJe\n 0ieJkz85L96KnsBMDAvOpyEmmyq+/DMrQnVjj5/Sct72LoDo8RiXkjMmyGQECHHs8KKo\n O4jX6vgJiCobvNFRouaPVXW2SsLCZpF91FFuHuM2EwPi4R4C0qGjcuCObdDoJ42GBWrM\n zflYRddehLt+5K/ysRLywXZH9VmNLXLJ8WCekDqRD32FfaAlC5he2ggtEVVFnua8TK8N\n LG4BT9vCtL5rLWEloDcqe6ekZnuPh62OTsqUGybK0kC55xijEhaqu+WC6F7OwUxByvsw\n 9aQw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774366423; x=1774971223;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=TOiDhle0PnY0wck/VOrs74zYzASRvEfrRyQ8rF9/ZA8=;\n b=e7+lX/m0cpU9oftLpW6GlDln0IqG4hCz9QtEXq7vZvQRnQ1YliZEfTTbE0YwV4/gxR\n lPUNZLo8wL6sZzW5QVgzojezZ7zksi83ylA3RgDkwwlbXzX1QAVk98RnTxwE1pvbFNdD\n rrVqd2kv74gN4ATpXqN/VwDmCG3nNlLsVj2BFznQBM4wuvDBNpZPu/5qH6kEWntFT9O8\n D5gzAF1N9j3fTF208ZSxYGNGLjrkDZTIPXy26/yxFtFjMBE9T0s0viGfKhGwCGQkO/pQ\n AfIr2Lq2cf8N9BrBTtHyBdp84bHYp0cyf0PqrvFCC7ygs1OKo+h89V3I/XclcMzpcUQx\n K6Bw==","X-Gm-Message-State":"AOJu0YwR4P/942BRaLtKSa3aMMncVyMmmOgfp6jLNLwEmwBnaBSKpWK9\n k1akCF8KO4hEWT3zoSIUP89Hx8hDhaDtxF7CsYjQLw4JaOBRmmVbPJ3KewEHTbY1+6o=","X-Gm-Gg":"ATEYQzwQJQUmydy52zV+r3RA5sTkB1V0203ir2BCM8CdBdAF7tH9AnSCNGe5POa+1Oi\n IXKdKfQz7jxw+Y37r237PzRc0K8p4I42A+/y+fbBBtZDU8eNkPcwywBl1hHV9elxnYzhRXDHITR\n 3ZBiSFnSTb/wQ3p9t7L9goYEqHj9WbwnevEMoCz6vaTGRNMYtx9PPpS6GQKshJokmWSjbm58nw+\n 2yJ4fOpu6SYwg0EOzoASfIpGcRvvgZv6zOuV33sF/KMbk0wLpRTcXtxzAMOoxycwXeN8wTbcgK5\n r3YpYV6l+bT7hdof6zsl0TVhPuhNwGl6tJa3iFYU8zxFJsG2GR3IdyKlWhsshAu7S5zBVfs9CyL\n lm4Zzbt1VArmkPjWrntdm21iLMN5Vr5ceo63dIZk5ERzza5QhKMd4nAOD1bDNpXcnDPhMYvWAvp\n uZ6K1QSS8s0ha81Td2Qt3/fGdfgkgQ6CFeMdcgktAONYG3WVypJmbkYggirXJzRfJeQYBQ/JsMI\n X/uvxlEtTPRtG2B6qJwNEJlVDEcc/oQ4lmrFoSS7Quei03HMoFShz1f58LXXy0F9iMVygSu/eYr\n WSm1Sk0=","X-Received":"by 2002:a05:600c:1e8f:b0:487:36c:f5ab with SMTP id\n 5b1f17b1804b1-48715fe70f2mr3178925e9.10.1774366422901;\n Tue, 24 Mar 2026 08:33:42 -0700 (PDT)","From":"Julien Stephan ","Date":"Tue, 24 Mar 2026 16:33:45 +0100","Subject":"[PATCH] boot/fit: remove useless else branch","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"\n <20260324-boot-fit-fix-8-byte-alignement-for-overlays-v1-1-257b132b6bda@baylibre.com>","X-B4-Tracking":"v=1; b=H4sIAAAAAAAC/x2NwQrCMBBEf6Xs2YUkLVr8FfGQ6LQu1EQ2pbSU/\n rurhzm8gTezU4UKKl2bnRSLVCnZwJ8aerxiHsHyNKbgwtm1oeNUysyD/LJyz2mbwXGSMeONbG1\n RLgt0ilvltvfJRX9JQweyxY/CrP/b7X4cXx3kQhZ9AAAA","X-Change-ID":"20260324-boot-fit-fix-8-byte-alignement-for-overlays-381b0a17bf4e","To":"u-boot@lists.denx.de","Cc":"GSS_MTK_Uboot_upstream ,\n Tom Rini , Quentin Schulz ,\n Marek Vasut ,\n James Hilliard ,\n David Lechner ,\n Julien Stephan ","X-Mailer":"b4 0.14.3","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"The assignment of load = data is already performed before the\nif–elseif logic, making the additional assignment in the else\nbranch unnecessary.\n\nRemove the redundant statement to simplify\nthe control flow and improve readability.\n\nSigned-off-by: Julien Stephan \n---\nWhile doing some debug on overlay loading, I notice this useless else\nbranch in fit_image_load(). Let's just remove it.\n---\n boot/image-fit.c | 2 --\n 1 file changed, 2 deletions(-)\n\n\n---\nbase-commit: 1ffc541eafc96d5eebcf837ab892dccec3b93568\nchange-id: 20260324-boot-fit-fix-8-byte-alignement-for-overlays-381b0a17bf4e\n\nBest regards,","diff":"diff --git a/boot/image-fit.c b/boot/image-fit.c\nindex e7c7212195f..a0864bd0906 100644\n--- a/boot/image-fit.c\n+++ b/boot/image-fit.c\n@@ -2281,8 +2281,6 @@ int fit_image_load(struct bootm_headers *images, ulong addr,\n \n \t\tprintf(\" Loading %s from 0x%08lx to 0x%08lx\\n\",\n \t\t prop_name, data, load);\n-\t} else {\n-\t\tload = data;\t/* No load address specified */\n \t}\n \n \tcomp = IH_COMP_NONE;\n","prefixes":[]}