{"id":2212659,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2212659/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260318133840.1334-1-fw@strlen.de/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.2/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260318133840.1334-1-fw@strlen.de>","list_archive_url":null,"date":"2026-03-18T13:38:34","name":"[nf-next] netfilter: nft_set_pipapo: increment data in one step","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"18a65e469c867dc36abc050b1ae10d25442bd8f6","submitter":{"id":1025,"url":"http://patchwork.ozlabs.org/api/1.2/people/1025/?format=json","name":"Florian Westphal","email":"fw@strlen.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260318133840.1334-1-fw@strlen.de/mbox/","series":[{"id":496465,"url":"http://patchwork.ozlabs.org/api/1.2/series/496465/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=496465","date":"2026-03-18T13:38:34","name":"[nf-next] netfilter: nft_set_pipapo: increment data in one step","version":1,"mbox":"http://patchwork.ozlabs.org/series/496465/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2212659/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2212659/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11270-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.216.245.30","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fbVLF4qdDz1xyt\n\tfor ; Thu, 19 Mar 2026 00:39:33 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id C2667304CCC9\n\tfor ; Wed, 18 Mar 2026 13:38:57 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 498623D88F4;\n\tWed, 18 Mar 2026 13:38:57 +0000 (UTC)","from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc\n [91.216.245.30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B41CF31353B\n\tfor ; Wed, 18 Mar 2026 13:38:55 +0000 (UTC)","by Chamillionaire.breakpoint.cc (Postfix, from userid 1003)\n\tid 7D54A605C3; Wed, 18 Mar 2026 14:38:53 +0100 (CET)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1773841137; cv=none;\n b=iPtKx3wZsxJzJxTM37h4Ud962a/4vXeFgQgh54obkGqB8P8tf3EfyJdlIhStMLfVI/EEwbRS4VnvmMK1GxUqWMLckc5YUU1ZtgouJj4ZbE/5UmtSVQUQlJodApgrPGuKexw+9AJxffKAeV6x5/OEYnQSepavTYlxqYR3ZxJxCf8=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1773841137; c=relaxed/simple;\n\tbh=EJuP/OxzZQ5hmNNJ4qM0cHEavix/d8zMB/GPo11ntsU=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=lz2CDKdLiLoOfgPMk1b1VeAcBotdZD2aKTYfRGg50TEhhXz32n3gvOl+y3GzTcy1wsK1wbKgQjJmkbEToM1z4Hdc/3AI7aulIdYKQro2zKlooD6h+mGHquenSW8F284JHLrZdVfQ70igrrZ1s9XeJ2Wa4aOcKyMtgpDF+S24vXg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc;\n arc=none smtp.client-ip=91.216.245.30","From":"Florian Westphal ","To":"","Cc":"Stefano Brivio ,\n\tFlorian Westphal ","Subject":"[PATCH nf-next] netfilter: nft_set_pipapo: increment data in one step","Date":"Wed, 18 Mar 2026 14:38:34 +0100","Message-ID":"<20260318133840.1334-1-fw@strlen.de>","X-Mailer":"git-send-email 2.52.0","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"For unkown reason the C version increments the data pointer in two steps.\nSwitch to a single invocation of NFT_PIPAPO_GROUPS_PADDED_SIZE() helper,\nlike the avx2 implementation.\n\nSigned-off-by: Florian Westphal \n---\n net/netfilter/nft_set_pipapo.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/net/netfilter/nft_set_pipapo.c b/net/netfilter/nft_set_pipapo.c\nindex 7fd24e0cc428..50d4a4f04309 100644\n--- a/net/netfilter/nft_set_pipapo.c\n+++ b/net/netfilter/nft_set_pipapo.c\n@@ -452,8 +452,6 @@ static struct nft_pipapo_elem *pipapo_get_slow(const struct nft_pipapo_match *m,\n \t\t\tpipapo_and_field_buckets_4bit(f, res_map, data);\n \t\tNFT_PIPAPO_GROUP_BITS_ARE_8_OR_4;\n \n-\t\tdata += f->groups / NFT_PIPAPO_GROUPS_PER_BYTE(f);\n-\n \t\t/* Now populate the bitmap for the next field, unless this is\n \t\t * the last field, in which case return the matched 'ext'\n \t\t * pointer if any.\n@@ -498,7 +496,7 @@ static struct nft_pipapo_elem *pipapo_get_slow(const struct nft_pipapo_match *m,\n \t\tmap_index = !map_index;\n \t\tswap(res_map, fill_map);\n \n-\t\tdata += NFT_PIPAPO_GROUPS_PADDING(f);\n+\t\tdata += NFT_PIPAPO_GROUPS_PADDED_SIZE(f);\n \t}\n \n \t__local_unlock_nested_bh(&scratch->bh_lock);\n","prefixes":["nf-next"]}