{"id":2211747,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2211747/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260317084624.457185-3-me@linux.beauty/","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/1.2/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260317084624.457185-3-me@linux.beauty>","list_archive_url":null,"date":"2026-03-17T08:46:17","name":"[RFC,v5,2/7] ext4: lockdep: handle i_data_sem subclassing for special inodes","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5d684ead445116215d627590765107565a8360d8","submitter":{"id":84264,"url":"http://patchwork.ozlabs.org/api/1.2/people/84264/?format=json","name":"Li Chen","email":"me@linux.beauty"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260317084624.457185-3-me@linux.beauty/mbox/","series":[{"id":496215,"url":"http://patchwork.ozlabs.org/api/1.2/series/496215/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/list/?series=496215","date":"2026-03-17T08:46:15","name":"ext4: fast commit: snapshot inode state for FC log","version":5,"mbox":"http://patchwork.ozlabs.org/series/496215/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2211747/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2211747/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.beauty header.i=me@linux.beauty\n header.a=rsa-sha256 header.s=zmail header.b=h3slt7MN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=mcvq=br=vger.kernel.org=linux-ext4+bounces-15099-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c0a:e001:db::12fc:5321\"\n arc.chain=\"subspace.kernel.org:zohomail.com\"","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.beauty","gandalf.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.beauty header.i=me@linux.beauty\n header.a=rsa-sha256 header.s=zmail header.b=h3slt7MN;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15099-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=linux.beauty header.i=me@linux.beauty\n header.b=\"h3slt7MN\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=136.143.188.15","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.beauty","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.beauty"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fZm0V3sBqz1y1P\n\tfor ; Tue, 17 Mar 2026 19:51:38 +1100 (AEDT)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fZm0V2xkRz4w93\n\tfor ; Tue, 17 Mar 2026 19:51:38 +1100 (AEDT)","by gandalf.ozlabs.org (Postfix)\n\tid 4fZm0V2sWcz4w9k; Tue, 17 Mar 2026 19:51:38 +1100 (AEDT)","from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fZm0R0F39z4w93\n\tfor ; Tue, 17 Mar 2026 19:51:35 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 9F22B30642FB\n\tfor ; Tue, 17 Mar 2026 08:49:35 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6FC1934DB4B;\n\tTue, 17 Mar 2026 08:49:34 +0000 (UTC)","from sender4-op-o15.zoho.com (sender4-op-o15.zoho.com\n [136.143.188.15])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 08B82347523;\n\tTue, 17 Mar 2026 08:49:33 +0000 (UTC)","by mx.zohomail.com with SMTPS id 17737372049957.253615372300146;\n\tTue, 17 Mar 2026 01:46:44 -0700 (PDT)"],"ARC-Seal":["i=3; a=rsa-sha256; d=ozlabs.org; s=201707; t=1773737498; cv=pass;\n\tb=xFjPYREfXZEWI3ILtlUZUk9b2r06vidIXciOV0NEldKA+EEYrIvZqm5+q20dkXQKbOQq3pzVUrGJ7AiACknIGLudw+oshKl5a1PTJGpGXef0GyuWQWiN9n+4lcphsox5uvUHvEXXtUdpN36OWK6kKMBjD2YFuzMZLUPIWYM3kkz5w+hseT7h+qCxRIjAUWZIDOmBOn0c0C13rHsmTrscs6I9UoiqWpHjtSA6Cmg/2ivLU4ZtArUhvW1H6JMXmZFRHgWQlc0LALwjH8IecCBMKwfABqWTl1URJPJd+RBqNOM3MWBGdecnVCdUtlqHrU85yaIDVbonRZdd4SVptg0jSw==","i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1773737374; cv=pass;\n b=cNRogjq3ifPWTaIwMckDH5b+S1yBfQYlhR8oFSkDhPyJiYLEi8IIsPeRQZ0a6osBRATB1XUf4zPQ6CxFm9noRuuXbB4G7gu1kLZOw0v1rZYx8vawslgmGNthACY/nswe301KoGodiKaBjiADVEYycnalLPS3eg53xFf5zmY+VJ8=","i=1; a=rsa-sha256; t=1773737207; cv=none;\n\td=zohomail.com; s=zohoarc;\n\tb=fryVqFhxzvVeMHpI/nWxveNM4UdB+jJhipE1ePCuTQyHACojZ0DS3oErYr2pOk3hWwzMHlHDlpkSLYcMoLyh+TJHE/rqewN63q61yV7QT/G4iz1qX0X387anNI/fMlLVTpzlE4R88VOqn+DytRKi+A0YvAjoI+lOv5gy9G5mUFI="],"ARC-Message-Signature":["i=3; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1773737498; c=relaxed/relaxed;\n\tbh=rDK5gClFMcbUS8LdYCJMAjdOkGkFNx9hD8v2sQ0+bsw=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=CEdtlLm7nKFCg4F9khhWOJUZWBg8EnZqrVDhkZms/4l2c7/RTeKQsXbQZv3CyiuP/LPYcDRFgsjUSouvxUvEBwxZqU8/0qbyrOAF5qdmZnp+lUjHpJerWvlm8ntrFbO5nOXZqVu5Ev6iH+egmAcoV5hmi9wLL5uigt4UhRwiMUG4n+MrDSflAlvLDidRW/OeqVlPj0MT1PMy4ZAHrPozZGNr2BBQ/JvQdXllB3i1kxzHw0ArfT2gTghvbaTEWW2WeU+r9ZQ7+Z3Mo8We3embKWSnlB1RnOf/UkEjtr+jtn0gAVIoCg1ux7LNd1pZkR4YmCmUHhZQR6Rv5ZdCcm5AfQ==","i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1773737374; c=relaxed/simple;\n\tbh=2T1XEP+0MbcGvf5V4jkWy/jAlUceMp6GSTuQIhUYAm8=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=IxxXHAxcdZTO55Vf+AySKQgEIv3ccU1h3b5GeWtzHgfccnPRu0rXE6h6BXiLKUDPuS/g5gtJHUUUIyiMcHNv3ckl4bXRtNlTT+Gvq1/SClz1bEhszqo9isszkahvl9XwIg/LXBz9pk4cvxDtv/2dyKvmsBDmcmS2s+f1MgfwdY4=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc;\n\tt=1773737207;\n h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=rDK5gClFMcbUS8LdYCJMAjdOkGkFNx9hD8v2sQ0+bsw=;\n\tb=MzEBrYqHbnMXc7c9pM320X2sF3OtJ2FENNxzowq//tVclDjVWwtwmB321Gcq6PxL1QrNiO222vtwwIQ/HsHkC6UNo4E7OXHg0poorJ2q9YmTGLHu1XgF8h69GoiC9e0jGOXL5pZFa+tmYDFxD42HxxWgvA+0Tpxa2wbfPVzarIo="],"ARC-Authentication-Results":["i=3; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.beauty;\n dkim=pass (1024-bit key;\n unprotected) header.d=linux.beauty header.i=me@linux.beauty\n header.a=rsa-sha256 header.s=zmail header.b=h3slt7MN; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15099-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.beauty;\n spf=pass smtp.mailfrom=linux.beauty;\n dkim=pass (1024-bit key) header.d=linux.beauty header.i=me@linux.beauty\n header.b=h3slt7MN; arc=pass smtp.client-ip=136.143.188.15","i=1; mx.zohomail.com;\n\tdkim=pass header.i=linux.beauty;\n\tspf=pass smtp.mailfrom=me@linux.beauty;\n\tdmarc=pass header.from="],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1773737207;\n\ts=zmail; d=linux.beauty; i=me@linux.beauty;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=rDK5gClFMcbUS8LdYCJMAjdOkGkFNx9hD8v2sQ0+bsw=;\n\tb=h3slt7MNz0BCbeMG3aQcwjhRcN25E2QM/XlfDGlzfDn3M/MDBhvPq6KRNlEV1nSL\n\td6nYzBtpdZ2INluGW654jdtEAEdEm22lwoclgMY82ai2cmEQ7/t3Eck2t/sYTXrtrIZ\n\t+1FHhZW5HPKlR962DvXfTEu6unOhOAh+JIXDhnC4=","From":"Li Chen ","To":"Zhang Yi ,\n\tTheodore Ts'o ,\n\tAndreas Dilger ,\n\tlinux-ext4@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Cc":"Steven Rostedt ,\n\tMasami Hiramatsu ,\n\tMathieu Desnoyers ,\n\tlinux-trace-kernel@vger.kernel.org,\n\tLi Chen ","Subject":"[RFC v5 2/7] ext4: lockdep: handle i_data_sem subclassing for special\n inodes","Date":"Tue, 17 Mar 2026 16:46:17 +0800","Message-ID":"<20260317084624.457185-3-me@linux.beauty>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260317084624.457185-1-me@linux.beauty>","References":"<20260317084624.457185-1-me@linux.beauty>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-ZohoMailClient":"External","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tHEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"},"content":"Fast commit can hold s_fc_lock while writing journal blocks. Mapping the\njournal inode can take its i_data_sem. Normal inode update paths can take a\ndata inode i_data_sem and then s_fc_lock, which makes lockdep report a\ncircular dependency.\n\nlockdep treats all i_data_sem instances as one lock class and cannot\ndistinguish the journal inode i_data_sem from a regular inode i_data_sem.\nThe journal inode is not tracked by fast commit and no FC waiters ever\ndepend on it, so this is not a real ABBA deadlock. Assign the journal inode\na dedicated i_data_sem lockdep subclass to avoid the false positive.\n\nInode cache objects can be recycled, so also reset i_data_sem to\nI_DATA_SEM_NORMAL when allocating an ext4 inode. Otherwise a new inode may\ninherit an old subclass (journal/quota/ea) and trigger lockdep warnings.\n\nSigned-off-by: Li Chen \n---\n fs/ext4/ext4.h | 4 +++-\n fs/ext4/super.c | 8 ++++++++\n 2 files changed, 11 insertions(+), 1 deletion(-)","diff":"diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h\nindex bd30c24d4f948..2e1681057196a 100644\n--- a/fs/ext4/ext4.h\n+++ b/fs/ext4/ext4.h\n@@ -1025,12 +1025,14 @@ do {\t\t\t\t\t\t\t\t\t\t\\\n *\t\t\t than the first\n * I_DATA_SEM_QUOTA - Used for quota inodes only\n * I_DATA_SEM_EA - Used for ea_inodes only\n+ * I_DATA_SEM_JOURNAL - Used for journal inode only\n */\n enum {\n \tI_DATA_SEM_NORMAL = 0,\n \tI_DATA_SEM_OTHER,\n \tI_DATA_SEM_QUOTA,\n-\tI_DATA_SEM_EA\n+\tI_DATA_SEM_EA,\n+\tI_DATA_SEM_JOURNAL\n };\n \n struct ext4_fc_inode_snap;\ndiff --git a/fs/ext4/super.c b/fs/ext4/super.c\nindex 79762c3e0dff3..4f5f0c21d436f 100644\n--- a/fs/ext4/super.c\n+++ b/fs/ext4/super.c\n@@ -1423,6 +1423,9 @@ static struct inode *ext4_alloc_inode(struct super_block *sb)\n \tINIT_WORK(&ei->i_rsv_conversion_work, ext4_end_io_rsv_work);\n \text4_fc_init_inode(&ei->vfs_inode);\n \tspin_lock_init(&ei->i_fc_lock);\n+#ifdef CONFIG_LOCKDEP\n+\tlockdep_set_subclass(&ei->i_data_sem, I_DATA_SEM_NORMAL);\n+#endif\n \treturn &ei->vfs_inode;\n }\n \n@@ -5863,6 +5866,11 @@ static struct inode *ext4_get_journal_inode(struct super_block *sb,\n \t\treturn ERR_PTR(-EFSCORRUPTED);\n \t}\n \n+#ifdef CONFIG_LOCKDEP\n+\tlockdep_set_subclass(&EXT4_I(journal_inode)->i_data_sem,\n+\t\t\t I_DATA_SEM_JOURNAL);\n+#endif\n+\n \text4_debug(\"Journal inode found at %p: %lld bytes\\n\",\n \t\t journal_inode, journal_inode->i_size);\n \treturn journal_inode;\n","prefixes":["RFC","v5","2/7"]}