{"id":2209931,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2209931/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260312175542.27060-1-fw@strlen.de/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.2/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260312175542.27060-1-fw@strlen.de>","list_archive_url":null,"date":"2026-03-12T17:55:39","name":"[nf-next] netfilter: nf_conntrack_h323: remove unreliable debug code in decode_octstr","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"125973c93d5071bf2d36c25fcd419f8c3d861abd","submitter":{"id":1025,"url":"http://patchwork.ozlabs.org/api/1.2/people/1025/?format=json","name":"Florian Westphal","email":"fw@strlen.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260312175542.27060-1-fw@strlen.de/mbox/","series":[{"id":495662,"url":"http://patchwork.ozlabs.org/api/1.2/series/495662/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=495662","date":"2026-03-12T17:55:39","name":"[nf-next] netfilter: nf_conntrack_h323: remove unreliable debug code in decode_octstr","version":1,"mbox":"http://patchwork.ozlabs.org/series/495662/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2209931/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2209931/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11159-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.216.245.30","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fWwPL6yfNz1xy3\n\tfor ; Fri, 13 Mar 2026 04:59:50 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id EF7093096055\n\tfor ; Thu, 12 Mar 2026 17:55:55 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 5953A3FE37F;\n\tThu, 12 Mar 2026 17:55:55 +0000 (UTC)","from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc\n [91.216.245.30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 94FDA38B131\n\tfor ; Thu, 12 Mar 2026 17:55:53 +0000 (UTC)","by Chamillionaire.breakpoint.cc (Postfix, from userid 1003)\n\tid 0AD5F60345; Thu, 12 Mar 2026 18:55:46 +0100 (CET)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1773338155; cv=none;\n b=BrbejVjqHLzvU1lvmK/0C+h9dCXZwL8zotsSer2nN8ba57D4bv+akKfxJ+oZpN9RKftcwFYjK3HpYzHSab+4Gw4hSOHPcQVMywH4uIq0wqAwhcCnRIYoG0+XeMNzvbdG+L5ahf57NpeDxPQsBTvsF8GPIFKYN1dOXa8kOxkdF4k=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1773338155; c=relaxed/simple;\n\tbh=x8bZifU574GNn4vOFRNq5xmMcpNPVqtuE0ezyi19iJo=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=bAsDSthZhcLHlqzuusWUpItRiWg267fIQpoJLaH0qVPxQ0s0hnz3AWYeiJp7xN2GG8AbZTK2I6PHKdqOlhD7QKVgF91Ktk1Vx9MMqVJKHEIRLPFz5Q8uGC0/SDnjtHSTv4u8osnykUQghMQPGeByAU1JJ4YVmcmtohuVeRyHyRQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc;\n arc=none smtp.client-ip=91.216.245.30","From":"Florian Westphal ","To":"","Cc":"Florian Westphal ","Subject":"[PATCH nf-next] netfilter: nf_conntrack_h323: remove unreliable debug\n code in decode_octstr","Date":"Thu, 12 Mar 2026 18:55:39 +0100","Message-ID":"<20260312175542.27060-1-fw@strlen.de>","X-Mailer":"git-send-email 2.52.0","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"The debug code (not enabled in any build) reads up to 6 octets of\nthe inpt buffer, but does so without bound checks. Zap this.\n\nSigned-off-by: Florian Westphal \n---\n net/netfilter/nf_conntrack_h323_asn1.c | 7 -------\n 1 file changed, 7 deletions(-)","diff":"diff --git a/net/netfilter/nf_conntrack_h323_asn1.c b/net/netfilter/nf_conntrack_h323_asn1.c\nindex 62aa22a07876..50a4ef54e301 100644\n--- a/net/netfilter/nf_conntrack_h323_asn1.c\n+++ b/net/netfilter/nf_conntrack_h323_asn1.c\n@@ -21,7 +21,6 @@\n \n #if H323_TRACE\n #define TAB_SIZE 4\n-#define IFTHEN(cond, act) if(cond){act;}\n #ifdef __KERNEL__\n #define PRINT printk\n #else\n@@ -29,7 +28,6 @@\n #endif\n #define FNAME(name) name,\n #else\n-#define IFTHEN(cond, act)\n #define PRINT(fmt, args...)\n #define FNAME(name)\n #endif\n@@ -443,11 +441,6 @@ static int decode_octstr(struct bitstr *bs, const struct field_t *f,\n \t\t\tBYTE_ALIGN(bs);\n \t\t\tif (base && (f->attr & DECODE)) {\n \t\t\t\t/* The IP Address */\n-\t\t\t\tIFTHEN(f->lb == 4,\n-\t\t\t\t PRINT(\" = %d.%d.%d.%d:%d\",\n-\t\t\t\t\t bs->cur[0], bs->cur[1],\n-\t\t\t\t\t bs->cur[2], bs->cur[3],\n-\t\t\t\t\t bs->cur[4] * 256 + bs->cur[5]));\n \t\t\t\t*((unsigned int *)(base + f->offset)) =\n \t\t\t\t bs->cur - bs->buf;\n \t\t\t}\n","prefixes":["nf-next"]}