{"id":2207812,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2207812/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260310-qe_ports_ic-v1-1-608293026561@gmail.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.2/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260310-qe_ports_ic-v1-1-608293026561@gmail.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260310-qe_ports_ic-v1-1-608293026561@gmail.com/","date":"2026-03-09T16:25:30","name":"soc: fsl: qe_ports_ic: Add missing cleanup on device removal","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1d9ad3639d0eea52d1f92f59d3267b6c0306e489","submitter":{"id":92491,"url":"http://patchwork.ozlabs.org/api/1.2/people/92491/?format=json","name":"Felix Gu","email":"ustc.gu@gmail.com"},"delegate":{"id":61610,"url":"http://patchwork.ozlabs.org/api/1.2/users/61610/?format=json","username":"chleroy","first_name":"Christophe","last_name":"Leroy","email":"christophe.leroy@c-s.fr"},"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260310-qe_ports_ic-v1-1-608293026561@gmail.com/mbox/","series":[{"id":495105,"url":"http://patchwork.ozlabs.org/api/1.2/series/495105/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=495105","date":"2026-03-09T16:25:30","name":"soc: fsl: qe_ports_ic: Add missing cleanup on device removal","version":1,"mbox":"http://patchwork.ozlabs.org/series/495105/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2207812/comments/","check":"fail","checks":"http://patchwork.ozlabs.org/api/patches/2207812/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=DOceSecZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-17938-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::1034\"","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=DOceSecZ;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2607:f8b0:4864:20::1034; helo=mail-pj1-x1034.google.com;\n envelope-from=ustc.gu@gmail.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fVC0g08nhz1y04\n\tfor ; Tue, 10 Mar 2026 09:50:59 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fVC0f4wQZz3c9D;\n\tTue, 10 Mar 2026 09:50:58 +1100 (AEDT)","from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com\n [IPv6:2607:f8b0:4864:20::1034])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fV2S15j4hz3c9l\n\tfor ; Tue, 10 Mar 2026 03:25:36 +1100 (AEDT)","by mail-pj1-x1034.google.com with SMTP id\n 98e67ed59e1d1-3598b2318c2so4977620a91.3\n for ;\n Mon, 09 Mar 2026 09:25:36 -0700 (PDT)","from junjungu-PC.localdomain\n ([2408:820c:9009:3f2:a816:d74a:dc19:1ab8])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-359f05ee51csm93198a91.1.2026.03.09.09.25.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 09 Mar 2026 09:25:33 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1773073539;\n\tcv=none;\n b=Nxp2xFxxZQCRGEkeqQ//g1lz0/JkbDq96AL9QAYw8w/WdoBk4Ku0zYueKt/FiQRfxeEiTIQC3Ry7BuAyqNDuJNfCZ+J7TVq7ylnCWPs542XbOBW2JNrep/trodrNbvkd9LbTh/M2Kj4wj1uMgyDXENIcjS7LmSSjTbe5tfQYJIG/8t/2F3WHYaaj2qHVl/HOZteUSGAttz9NbD4gZ58CPeJjIhwNZbahlCkf4PMdSsVM/3D6OEIyDHo0CxZ257zhhRkTEAUHqHbkOiRGfD4Kky0LxfNtVdGHGEv2bO3/Oka2uNVxGCsALO0Qtd2HLnzNfKr2f5Y6T29SFbd/Dh2yuQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1773073539; c=relaxed/relaxed;\n\tbh=amj6Vi3JmO2oRqniQL19eS7V9c7NrB8GmPrszxzYH5Q=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc;\n b=LTz3LfFRIfYeTLuGrcTqnxQN1wVWd+DLdwekpzUfws/+rc+Ay8zqXVYpA04AR+0PDmtNvtDKlCbpJxGNToQuarIOEP2E9UOSycCeEBfhElHtu4wzZ/eiJNcUE1um5RWyMdzA1FJII/dcY6mo03Ifqc/PDDcaIw5i3JnCycRNsRzfpj6LoDkw9jHqaSgwWedmAWYKSp5W6kT8vfNr1wp/S+ThOFfsh0O0I3Kx7OAnse9oE6bl/1XVJ5LOk5In7Rq39+E3nd6NY3gYdkm5wvZ6SJbIYx6zzC0WHlaCzLRbnActSuxYQy/f7zEw04mHzNluvH3ogIt/TBOLpMRZkaWwJg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=DOceSecZ; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::1034; helo=mail-pj1-x1034.google.com;\n envelope-from=ustc.gu@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1773073534; x=1773678334;\n darn=lists.ozlabs.org;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:from:to:cc:subject:date:message-id:reply-to;\n bh=amj6Vi3JmO2oRqniQL19eS7V9c7NrB8GmPrszxzYH5Q=;\n b=DOceSecZC5AKX4OOvt4HSneRjKgXc9gC0K6jMhrF+0Bp5qQKxXex2DbGitCzF+yuri\n W8MDKKZQ9Fpws77sglu5VycPmF4xZXxViiqr9ZUd6JYwDF9JHJbBUz5k+0FihHML92sy\n DySr5EQDvIaxgbKRuQPYgvGBqqeE4cz3PzRw3xex0k7Fyqte3IEI43ELaoQnkTOzqBDd\n EJMStIShNAhlSpUyfvuzWaWPZOZW66HZw1rJUwf/ZPJcBWWHRooejvZ8t3AThGEVOI2G\n +n2xmX11YZFgTICl6tv80Nq3rcoJhKH91so9hqtPAhB37yE4k/84hkTDZd+E9sRLD2S0\n B4Ew==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1773073534; x=1773678334;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=amj6Vi3JmO2oRqniQL19eS7V9c7NrB8GmPrszxzYH5Q=;\n b=U4uL40p4o70TyIdmmdy5vKJhT+10tBAyqkYfX6IE/3DJSdA+5V5Rl+lPS02DhD1wRB\n u1lIdMDX1Q9GewhqwVRItQ5Rtn+FRxI2DQ1fAREDzTpLUEr0R8YiBJa9gudbwt1dbqMR\n IUswFQPi0O5Kr+DPmE/6LKfgQbneR7XRwIViopGbkDR+PygtVVNvJvkUrK2xgEWyXE9U\n Ye7Wm06QcmBQbynA8pp0lIuYOKcN2f0VSSnmNBRvKtYO7kWLaVrzbm85UrxAWEvyvbab\n 9k7cC0svrILh++tPc+nx+HFDJsJlzcUR9SHxaNeM+VEa4lxcYJfjDOswu0yqoPfgqTs3\n Ld8Q==","X-Gm-Message-State":"AOJu0YwdGElKD/OA8KWV8MaEyQAJv1Kf0mwZ5K4yNFWPijWB1RKAhBtY\n\tS914GNjJVdjPKYPfr/JVOfC2ig0zT9vOLdVa4AOLgkfaH5fzkKuIHlxF","X-Gm-Gg":"ATEYQzxicniTJ9ua0I5Ne7v1rHeEzwNCw5phMltEpSTpjCnGRk15TqlYMWz+79p2j3G\n\tcX3LL3K2UiyawtCbMN9kJFZ+L5p9JUJY8zpOd2utgoNjchrScdD8bRURGk5HQrRgIhUjhoiIWIo\n\thN9iHys3qmleyKD0b3+gxwHBNenktwXVaAPpFoKWpe6V/F6PZCpfUqBwS34tGog0NeD/BrVddUS\n\tGJfmkyVAV5+VMyqdvFpDJ4j/m1fTl51HtaqrO0jpZx+mYk+cvv1QawtBzMTtyoVBVcR5V3cGrM8\n\tHRfuzGtTtad45PD/wdPa9xdl9nd4Dn3acnK+iJd9bvqhNQnf/rFMNs/o0PUblBa79OiH9SefV2p\n\tcS9HRKhW8PSrxmM18xuPzM7sZQFPppJT08iJ5U9uYKeUO0t0lcbev97FALkh3TE0Or8UkacXs/a\n\tJSAvUxWmTzu3I59PFIKi44AtOMXmPOS16C35LC","X-Received":"by 2002:a17:90b:184c:b0:336:b60f:3936 with SMTP id\n 98e67ed59e1d1-359be2bfbfdmr10994814a91.12.1773073533488;\n Mon, 09 Mar 2026 09:25:33 -0700 (PDT)","From":"Felix Gu ","Date":"Tue, 10 Mar 2026 00:25:30 +0800","Subject":"[PATCH] soc: fsl: qe_ports_ic: Add missing cleanup on device\n removal","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260310-qe_ports_ic-v1-1-608293026561@gmail.com>","X-B4-Tracking":"v=1; b=H4sIAHn0rmkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE\n vPSU3UzU4B8JSMDIzMDY0MD3cLU+IL8opLi+Mxk3eREk2RLi6QUw2STNCWgjoKi1LTMCrBp0bG\n 1tQBw1Lw+XQAAAA==","X-Change-ID":"20260310-qe_ports_ic-ca4c98bd1c4f","To":"Qiang Zhao ,\n \"Christophe Leroy (CS GROUP)\" ","Cc":"linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,\n linux-kernel@vger.kernel.org, Felix Gu ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1773073531; l=2073;\n i=ustc.gu@gmail.com; h=from:subject:message-id;\n bh=f/RO7d/NYBpPJNaikZKFHoe0PWI37oNS5SAvFGmT8u8=;\n b=rQOMzyC4PngOHoIqO/7Df48MEyWpk4Oq7n+UJMoMvx/yCaEy1QVE4QxtLf/8M0dTWTRlNeTre\n OBK6HibNoz9BSdq5rxEWpjidNyO7PJHufEyodw+dTqpnS22U+VATvl+","X-Developer-Key":"i=ustc.gu@gmail.com; a=ed25519;\n pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw=","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Add a devm action handler to properly clean up the irq_domain and\nchained handler when the device is removed.\n\nFixes: f0bcd784e1b7 (\"soc: fsl: qe: Add an interrupt controller for QUICC Engine Ports\")\nSigned-off-by: Felix Gu \n---\n drivers/soc/fsl/qe/qe_ports_ic.c | 21 +++++++++++++++------\n 1 file changed, 15 insertions(+), 6 deletions(-)\n\n\n---\nbase-commit: a0ae2a256046c0c5d3778d1a194ff2e171f16e5f\nchange-id: 20260310-qe_ports_ic-ca4c98bd1c4f\n\nBest regards,","diff":"diff --git a/drivers/soc/fsl/qe/qe_ports_ic.c b/drivers/soc/fsl/qe/qe_ports_ic.c\nindex 8e2107e2cde5..5e3fae19f314 100644\n--- a/drivers/soc/fsl/qe/qe_ports_ic.c\n+++ b/drivers/soc/fsl/qe/qe_ports_ic.c\n@@ -17,6 +17,7 @@\n struct qepic_data {\n \tvoid __iomem *reg;\n \tstruct irq_domain *host;\n+\tint irq;\n };\n \n static void qepic_mask(struct irq_data *d)\n@@ -92,11 +93,18 @@ static const struct irq_domain_ops qepic_host_ops = {\n \t.map = qepic_host_map,\n };\n \n+static void qepic_remove(void *res)\n+{\n+\tstruct qepic_data *data = res;\n+\n+\tirq_set_chained_handler_and_data(data->irq, NULL, NULL);\n+\tirq_domain_remove(data->host);\n+}\n+\n static int qepic_probe(struct platform_device *pdev)\n {\n \tstruct device *dev = &pdev->dev;\n \tstruct qepic_data *data;\n-\tint irq;\n \n \tdata = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);\n \tif (!data)\n@@ -106,17 +114,18 @@ static int qepic_probe(struct platform_device *pdev)\n \tif (IS_ERR(data->reg))\n \t\treturn PTR_ERR(data->reg);\n \n-\tirq = platform_get_irq(pdev, 0);\n-\tif (irq < 0)\n-\t\treturn irq;\n+\tdata->irq = platform_get_irq(pdev, 0);\n+\tif (data->irq < 0)\n+\t\treturn data->irq;\n \n \tdata->host = irq_domain_add_linear(dev->of_node, 32, &qepic_host_ops, data);\n \tif (!data->host)\n \t\treturn -ENODEV;\n \n-\tirq_set_chained_handler_and_data(irq, qepic_cascade, data);\n+\tirq_set_chained_handler_and_data(data->irq, qepic_cascade, data);\n+\n+\treturn devm_add_action_or_reset(dev, qepic_remove, data);\n \n-\treturn 0;\n }\n \n static const struct of_device_id qepic_match[] = {\n","prefixes":[]}