{"id":949182,"url":"http://patchwork.ozlabs.org/api/1.2/covers/949182/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/cover/20180725133152.30898-1-miquel.raynal@bootlin.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/1.2/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20180725133152.30898-1-miquel.raynal@bootlin.com>","list_archive_url":null,"date":"2018-07-25T13:31:35","name":"[v5,00/17] Allow dynamic allocations during NAND chip identification phase","submitter":{"id":73368,"url":"http://patchwork.ozlabs.org/api/1.2/people/73368/?format=json","name":"Miquel Raynal","email":"miquel.raynal@bootlin.com"},"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/cover/20180725133152.30898-1-miquel.raynal@bootlin.com/mbox/","series":[{"id":57526,"url":"http://patchwork.ozlabs.org/api/1.2/series/57526/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=57526","date":"2018-07-25T13:31:36","name":"Allow dynamic allocations during NAND chip identification phase","version":5,"mbox":"http://patchwork.ozlabs.org/series/57526/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/949182/comments/","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org\n\t(client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=bootlin.com","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"cH2GP65U\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[IPv6:2607:7c80:54:e::133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41bGPN1X6pz9s3x\n\tfor ;\n\tWed, 25 Jul 2018 23:32:40 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiJu3-0000TZ-Hz; Wed, 25 Jul 2018 13:32:31 +0000","from mail.bootlin.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiJtr-0000Iv-Df\n\tfor linux-mtd@lists.infradead.org; Wed, 25 Jul 2018 13:32:22 +0000","by mail.bootlin.com (Postfix, from userid 110)\n\tid DACA42097A; Wed, 25 Jul 2018 15:32:06 +0200 (CEST)","from localhost.localdomain\n\t(AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr [90.88.20.122])\n\tby mail.bootlin.com (Postfix) with ESMTPSA id 86C38203EC;\n\tWed, 25 Jul 2018 15:31:56 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To\n\t:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=EJTvU78T41LRb5L9L0rO6naOG2PqnWluVSkAl326NHI=;\n\tb=cH2GP65Unvj7t4\n\tD7+YT1XWJWZroVbo2j3yMWz/snII8QEEWVS4bMG1pH1gDHbZYakR7Oxj9URy+QKnhD0O3Y55dq5ia\n\t+u7cWFE1QrOOvcimOQ3uzopYzqS92vHnetFeOIswTYZ6i7sxfzsro1NJv1ieu+xcFw5KhKvKstuxa\n\tndj37aE3iJ2FOQHuXhOwZhg0EOknlAf5a+sWOWTPW85TRMhMvUw0VlBaX/ZeMearBXCtl7sSPNEGx\n\twShR+v0Ti/8sAs5yDor4E+YGMWK7U0y12aNk0ZYV591PsDxvaKXmiLl3bLyIkUtjcdJ7a7r5sXa9b\n\tsdzl14qA1tw9kX6LcgyA==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","From":"Miquel Raynal ","To":"Boris Brezillon ,\n\tRichard Weinberger ,\n\tDavid Woodhouse , \n\tBrian Norris ,\n\tMarek Vasut ","Subject":"[PATCH v5 00/17] Allow dynamic allocations during NAND chip\n\tidentification phase","Date":"Wed, 25 Jul 2018 15:31:35 +0200","Message-Id":"<20180725133152.30898-1-miquel.raynal@bootlin.com>","X-Mailer":"git-send-email 2.14.1","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20180725_063219_758127_F15D04E7 ","X-CRM114-Status":"GOOD ( 19.46 )","X-Spam-Score":"-0.0 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [62.4.15.54 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Lucas Stach , Wenyou Yang ,\n\tJosh Wu , Stefan Agner ,\n\tlinux-mtd@lists.infradead.org, Miquel Raynal ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"Hello,\n\nThis series make a quite deep change in the NAND framework. Until now,\nthe NAND chip identification phase could be done in two manners from the\ncontroller driver perspective:\n\n1/ Call nand_scan()\n\n or\n\n1/ Call nand_scan_ident()\n2/ Do some controller-dependent configuration\n3/ Call nand_scan_tail().\n\nThe fact that the identifaction could be split in two operations\ninvolved that in the NAND framework, it was not possible to do any\ndynamic allocation without risking a memory leak. What if the core\nallocates a structure, then the driver between nand_scan_ident() and\nnand_scan_tail() decides it cannot handle the chip and errors out?\nThe structure allocated by the core is lost: it is a memory leak. One\nsolution could have been to add a nand_scan_ident_cleanup() function,\nbut that would mean patching all the drivers anyway to make them call\nthis function when something fails between nand_scan_ident() and\nnand_scan_tail().\n\nTo avoid this situation, we migrate all drivers to use nand_scan() in\nconjuction with the recently added hooks ->attach_chip() and\n->detach_chip() that are part of the nand_controller structure\noperations. Drivers that need to tweak their configuration after\nnand_scan_ident() should implement it. Any dynamically allocated space\nin ->attach_chip() must be freed in the second hook: ->detach_chip().\n\nThe ->detach_chip() does not have to be called upon error in the\ncontroller driver probe function. The nand_cleanup() helper already\nexists for that and will do the call if needed. Of course, this helper\nmust be called on error after a successful nand_scan(), just like\nbefore.\n\nOnce all drivers not using nand_scan() are migrated, nand_scan_ident()\nand nand_scan_tail() are unexported and only available internally.\n\nA previous work [1] removed the ONFI/JEDEC parameter pages and instead\nallocated a nand_parameters structure in nand_chip, embedding both\ngeneric entries and ONFI-related ones. The deal was, once dynamic\nallocation possible, allocate in nand_scan_ident() the ONFI strcuture\nonly if actually needed. This is done in the last patches.\n\nThis series applies on top of nand/next.\n\nThank you,\nMiquèl\n\n[1] http://lists.infradead.org/pipermail/linux-mtd/2018-March/079456.html\n\nChanges since v4:\n=================\n* Applied patches have been trimmed out of the series.\n* Commit logs have been reworded a bit as suggested by Boris (done as\n well with applied commits).\n* Always assigned the controller operations where the controller\n structure was initialized.\n* brcmnand: moved the whole chunk between _ident() and _tail() in\n brcmnand_attach_chip().\n* cafe: fixed the use of the useddma module parameter.\n* denali: removed kfree(denali->buf) from denali_remove() as it is\n already done in ->detach_chip().\n* lpc32xx_mlc: moved the IRQ handling out of the ->attach_chip()\n callback.\n* txx9ndfmc: moved the block about ecc.size/bytes in\n txx9ndfmc_nand_scan() for more clarity.\n* atmel: moved all the code in atmel_nand_register() directly in\n atmel_nand_controller_add_nand() + renamed atmel_nand_unregister()\n into atmel_nand_controller_remove_nand().\n* nand_scan_ident: move the check on maxchips in nand_scan_with_ids()\n and the comment about it in the kernel doc (will no run\n nand_scan_ident() if zero).\n* docg4: added a ->detach_chip() to fee the allocated BCH context.\n* jz4740: fixed the error path and added a patch to clarify the\n transition to nand_scan(). Also removed unneeded curly braces\n and removed useless pdev parameters from the driver private\n structure (added in this series).\n* core: moved the definition of nand_release() close to nand_cleanup()\n in rawnand.h while updating the comments.\n* micron: only check for the ->onfi pointer to be present, not the\n vendor revision which is redundant.\n\nChanges since v3:\n=================\n* Constified all the nand_controller_ops structure definitions.\n* Fixed a build issue in fsl_elbc.\n* Added a patch in the core to prevent executing nand_scan_ident if\n maxchips is NULL.\n* Fixed the regression around the model name.\n* Used kstrdup to allocate the model.\n* The migration from char model[] to const char *model is done in a\n separate patch.\n\nChanges since v2:\n=================\n* Rebased on top of nand/next.\n* Adapted all drivers to declare statically a nand_controller_ops\n structure and assign it in the probe().\n* Added the migration of the tegra_nand.c driver.\n* Moved brcmnand controller ops affectation in the probe().\n\nChanges since v1:\n=================\n* Rebased on top of nand/next.\n* Light rewording of the cover letter about the possibility to have a\n nand_scan_ident_cleanup() function (just as example of how this series\n could have been done differently).\n* Changed the hooks to reside in the nand_hw_ctrl structure instead of\n being part of nand_ecc_ctrl as these hooks are more\n controller-related.\n\n\nMiquel Raynal (17):\n mtd: rawnand: brcmnand: convert driver to nand_scan()\n mtd: rawnand: cafe: convert driver to nand_scan()\n mtd: rawnand: lpc32xx_mlc: convert driver to nand_scan()\n mtd: rawnand: omap2: convert driver to nand_scan()\n mtd: rawnand: atmel: clarify NAND addition/removal paths\n mtd: rawnand: atmel: convert driver to nand_scan()\n mtd: rawnand: do not execute nand_scan_ident() if maxchips is zero\n mtd: rawnand: docg4: convert driver to nand_scan()\n mtd: rawnand: jz4740: fix probe function error path\n mtd: rawnand: jz4740: group nand_scan_{ident,tail} calls\n mtd: rawnand: jz4740: convert driver to nand_scan()\n mtd: rawnand: tegra: convert driver to nand_scan()\n mtd: rawnand: txx9ndfmc: clarify ECC parameters assignation\n mtd: rawnand: txx9ndfmc: convert driver to nand_scan()\n mtd: rawnand: do not export nand_scan_[ident|tail]() anymore\n mtd: rawnand: allocate model parameter dynamically\n mtd: rawnand: allocate dynamically ONFI parameters during detection\n\n drivers/mtd/nand/raw/atmel/nand-controller.c | 149 ++++----\n drivers/mtd/nand/raw/brcmnand/brcmnand.c | 63 ++--\n drivers/mtd/nand/raw/cafe_nand.c | 135 ++++---\n drivers/mtd/nand/raw/docg4.c | 70 ++--\n drivers/mtd/nand/raw/jz4740_nand.c | 40 +-\n drivers/mtd/nand/raw/lpc32xx_mlc.c | 61 +--\n drivers/mtd/nand/raw/nand_base.c | 134 ++++---\n drivers/mtd/nand/raw/nand_micron.c | 6 +-\n drivers/mtd/nand/raw/nand_timings.c | 12 +-\n drivers/mtd/nand/raw/omap2.c | 533 +++++++++++++--------------\n drivers/mtd/nand/raw/tegra_nand.c | 162 ++++----\n drivers/mtd/nand/raw/txx9ndfmc.c | 32 +-\n include/linux/mtd/rawnand.h | 26 +-\n 13 files changed, 762 insertions(+), 661 deletions(-)"}