{"id":831187,"url":"http://patchwork.ozlabs.org/api/1.2/covers/831187/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/cover/20171027104037.8319-1-eblake@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20171027104037.8319-1-eblake@redhat.com>","list_archive_url":null,"date":"2017-10-27T10:40:25","name":"[v6,00/12] nbd minimal structured read","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/1.2/people/6591/?format=json","name":"Eric Blake","email":"eblake@redhat.com"},"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/cover/20171027104037.8319-1-eblake@redhat.com/mbox/","series":[{"id":10552,"url":"http://patchwork.ozlabs.org/api/1.2/series/10552/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=10552","date":"2017-10-27T10:40:27","name":"nbd minimal structured read","version":6,"mbox":"http://patchwork.ozlabs.org/series/10552/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/831187/comments/","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yNgSd3Bgmz9t30\n\tfor ;\n\tFri, 27 Oct 2017 21:42:57 +1100 (AEDT)","from localhost ([::1]:56550 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e826J-0002Sx-Gl\n\tfor incoming@patchwork.ozlabs.org; Fri, 27 Oct 2017 06:42:55 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57127)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e824G-00017V-Tz\n\tfor qemu-devel@nongnu.org; Fri, 27 Oct 2017 06:40:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e824G-0005Ua-14\n\tfor qemu-devel@nongnu.org; Fri, 27 Oct 2017 06:40:48 -0400","from mx1.redhat.com ([209.132.183.28]:57212)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e824B-0005Oq-9G; Fri, 27 Oct 2017 06:40:43 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 10D0861BB2;\n\tFri, 27 Oct 2017 10:40:42 +0000 (UTC)","from red.redhat.com (ovpn-120-166.rdu2.redhat.com [10.10.120.166])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id AB92D5C885;\n\tFri, 27 Oct 2017 10:40:40 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 10D0861BB2","From":"Eric Blake ","To":"qemu-devel@nongnu.org","Date":"Fri, 27 Oct 2017 12:40:25 +0200","Message-Id":"<20171027104037.8319-1-eblake@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tFri, 27 Oct 2017 10:40:42 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v6 00/12] nbd minimal structured read","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, vsementsov@virtuozzo.com, qemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"I've incorporated a few more tweaks since v5, addressing the various\nbugs I pointed out there:\nhttps://lists.gnu.org/archive/html/qemu-devel/2017-10/msg04817.html\n- make sure iotests pass\n- split a large patch\n- consistently use absolute offsets\n- clean up awkward logic in handling option requests\n\nI plan to send a pull request before Tuesday's freeze deadline; with a\nplan to do lots of interoperability testing (including validation of\nbehavior against a server that sends more than one chunk for a read),\nand with any resulting bug fixes trying to land as soon as possible\nduring the freeze.\n\nI'm also a bit disappointed that iotest 83 is more verbose. I'll post a\nfollow RFC that undoes the verbosity regression, as evidence that we\nshould probably be tracing things instead; such a cleanup would count\nas a bug fix, even if my pull request includes this series as-is.\n\n001/12:[----] [--] 'nbd: Include error names in trace messages'\n002/12:[----] [--] 'nbd: Move nbd_errno_to_system_errno() to public header'\n003/12:[----] [--] 'nbd: Expose constants and structs for structured read'\n004/12:[----] [--] 'nbd/server: Report error for write to read-only export'\n005/12:[down] 'nbd/server: Simplify nbd_negotiate_options loop'\n006/12:[0066] [FC] 'nbd/server: Refactor zero-length option check'\n007/12:[0007] [FC] 'nbd: Minimal structured read for server'\n008/12:[----] [--] 'nbd/server: Include human-readable message in structured errors'\n009/12:[0004] [FC] 'nbd/client: refactor nbd_receive_starttls'\n010/12:[----] [--] 'nbd/client: prepare nbd_receive_reply for structured reply'\n011/12:[----] [--] 'nbd: Move nbd_read() to common header'\n012/12:[0055] [FC] 'nbd: Minimal structured read for client'\n\nEric Blake (8):\n nbd: Include error names in trace messages\n nbd: Move nbd_errno_to_system_errno() to public header\n nbd: Expose constants and structs for structured read\n nbd/server: Report error for write to read-only export\n nbd/server: Simplify nbd_negotiate_options loop\n nbd/server: Refactor zero-length option check\n nbd/server: Include human-readable message in structured errors\n nbd: Move nbd_read() to common header\n\nVladimir Sementsov-Ogievskiy (4):\n nbd: Minimal structured read for server\n nbd/client: refactor nbd_receive_starttls\n nbd/client: prepare nbd_receive_reply for structured reply\n nbd: Minimal structured read for client\n\n block/nbd-client.h | 1 +\n include/block/nbd.h | 106 +++++++++-\n nbd/nbd-internal.h | 23 +--\n block/nbd-client.c | 492 ++++++++++++++++++++++++++++++++++++++++++---\n nbd/client.c | 217 +++++++++++++-------\n nbd/common.c | 84 ++++++++\n nbd/server.c | 209 ++++++++++++++-----\n nbd/trace-events | 15 +-\n tests/qemu-iotests/083.out | 15 ++\n 9 files changed, 968 insertions(+), 194 deletions(-)"}