{"id":2234726,"url":"http://patchwork.ozlabs.org/api/1.2/covers/2234726/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20260508031226.3601800-1-aleksandr.loktionov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260508031226.3601800-1-aleksandr.loktionov@intel.com>","list_archive_url":null,"date":"2026-05-08T03:12:18","name":"[iwl-next,0/8] ixgbe: small cleanups and improvements","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/1.2/people/75597/?format=json","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20260508031226.3601800-1-aleksandr.loktionov@intel.com/mbox/","series":[{"id":503311,"url":"http://patchwork.ozlabs.org/api/1.2/series/503311/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=503311","date":"2026-05-08T03:12:18","name":"ixgbe: small cleanups and improvements","version":1,"mbox":"http://patchwork.ozlabs.org/series/503311/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/2234726/comments/","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=u/cZyG80;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBZ1K01l7z1yJq\n\tfor ; Fri, 08 May 2026 13:12:36 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id EE53741453;\n\tFri, 8 May 2026 03:12:33 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id JFPBzV5ujAwB; Fri, 8 May 2026 03:12:32 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 70D3E4144B;\n\tFri, 8 May 2026 03:12:32 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 36A9A272\n for ; Fri, 8 May 2026 03:12:31 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 1C7FD409B5\n for ; Fri, 8 May 2026 03:12:31 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id WH_IuqgPGNJE for ;\n Fri, 8 May 2026 03:12:30 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.17])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 03B8D4030E\n for ; Fri, 8 May 2026 03:12:29 +0000 (UTC)","from fmviesa005.fm.intel.com ([10.60.135.145])\n by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 May 2026 20:12:29 -0700","from amlin-019-225.igk.intel.com ([10.102.19.225])\n by fmviesa005.fm.intel.com with ESMTP; 07 May 2026 20:12:28 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 70D3E4144B","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 03B8D4030E"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1778209952;\n\tbh=egTsxxbjWn8zGicnnWKNrK8Zm/PI2q3+DJgwsDjNA8c=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=u/cZyG80FiBoSJQljvSEGsinfm4f78oPt/YUpNXxcdQL0SzlHXIoGkIzaTFn6+Bm8\n\t 7TFUlrKw0EFoEWzgvSBWhGNbUvtvWJT5xcs6cClboibLhRs+LqBhsm3XqCE0EhonAH\n\t OuSnMsnmNXgl+n5V3OGHCXpKSUsBNYf1O1mKoeI6PDf6/K3JpDus8Cu/aWtxKKwFKB\n\t PLI5tCuinsmw1LFAXeLpHpnY8NZlQtxlSxlcIix0AY3wYbQnwC5iACFLUlYC2OjLug\n\t 6U2voZo79ubbM6HgMyhtz7qYsCAddP64050T5oiQAMdU8+aejCeU1ezWez7mnyO022\n\t FNb+4Y5gVzsLg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.17;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 03B8D4030E","X-CSE-ConnectionGUID":["XebH2Ii7SiyUPhjiE3JnFw==","BmjWfNWDQcWypu3CAzhaYw=="],"X-CSE-MsgGUID":["LWxIzmZDTmmnb9XYBybXRw==","2RtA3QfuQIi8gEegXE6y+A=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11779\"; a=\"79027479\"","E=Sophos;i=\"6.23,222,1770624000\"; d=\"scan'208\";a=\"79027479\"","E=Sophos;i=\"6.23,222,1770624000\"; d=\"scan'208\";a=\"241623170\""],"X-ExtLoop1":"1","From":"Aleksandr Loktionov ","To":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com","Cc":"netdev@vger.kernel.org","Date":"Fri, 8 May 2026 05:12:18 +0200","Message-ID":"<20260508031226.3601800-1-aleksandr.loktionov@intel.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1778209950; x=1809745950;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=5syTiBGIJkTfSWeQklIrIr7jq5li2r8OQfmkyePbRFQ=;\n b=jbix+BuYZv4aM0MREo3SfUXbY3eAeS3Ql1nfBg4E2Ht1PyY3oXIwpnR4\n c9/ghvpaWFXDIfjNCay2HLn0IxRIKs19GQdd5qR6yShaqEiQs7WcW3txt\n XZuRn7I3H6kGVBGOYGxNB6NgdNwyBjPcgjaoli9wjK/mNeBveW933OXYl\n 6RzSLVHXCjGQ8ryRiDnLdUWPQOnxGayCx0/bw9pDnDAxFG7lRVw5pQE72\n XVYziPl1CyA5p/FvfGB/IwmTJLAbr8zf/kd1iY2GjQMm9lar1Yx55yx7E\n uja08yvrhmgbXboSbzbaq50immzRe8jV3a4FXGvTNMHPPe8IcoQGPfMtx\n A==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=jbix+BuY"],"Subject":"[Intel-wired-lan] [PATCH iwl-next 0/8] ixgbe: small cleanups and\n improvements","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Eight independent cleanups and improvements for the ixgbe driver,\ngrouped by theme:\n\nNaming / type hygiene (patches 1-2):\n Patch 1 renames ixgbe_q_vector::numa_node to ::node. The field name\n shadows the struct device numa_node accessor, causing a sparse warning.\n The rename aligns with other Intel drivers (ice, igc).\n\n Patch 2 changes local error-code variables from u32 to int in six\n functions across ixgbe_main.c, ixgbe_phy.c and ixgbe_x550.c. Storing\n a signed errno in an unsigned type works by accident for truthiness\n checks but breaks exact comparisons and proper propagation.\n\nBug fix (patch 3):\n Patch 3 rejects duplicate FDIR perfect-filter rules before programming\n hardware. The same 5-tuple with a different sw_idx would silently\n consume a second scarce FDIR slot and confuse rule deletion.\n Returns -EEXIST to userspace on duplicate rather than -EINVAL.\n\nPerformance (patch 4):\n Patch 4 replaces the busy-wait udelay(1000) in the SECRX_RDY poll\n loop with usleep_range(10, 20) and raises the iteration count from\n 40 to 4000. Because usleep_range(min, max) is guaranteed to sleep\n at least 'min' us, 4000 * 10 us preserves the original 40 ms\n minimum-wait-before-timeout; worst-case grows to ~80 ms (acceptable\n since SECRX_RDY failing to assert is non-fatal and only logged).\n Typical stall on fast hardware drops from up to ~1 ms per iteration\n to ~10-20 us.\n\nCode quality (patches 5-8):\n Patch 5 replaces ktime_to_ns(ktime_get_real()) with the direct\n ktime_get_real_ns() helper.\n\n Patch 6 factors the three-line autoneg-restart sequence duplicated in\n ixgbe_setup_phy_link_generic() and ixgbe_setup_phy_link_tnx() into a\n static helper ixgbe_restart_auto_neg(). The helper checks the return\n value of read_reg() and returns early on error to avoid writing\n uninitialized data to the PHY register.\n\n Patches 7-8 improve the adaptive-ITR algorithm in two steps:\n 7/8: Limit ITR decrease in latency mode to at most\n IXGBE_ITR_ADAPTIVE_MIN_INC (2 us) per step so that ACK-driven\n workloads do not overdrive interrupt rate. Uses max_t() to\n ensure the clamp never drives ITR below the algorithm's own\n computation.\n 8/8: Add IXGBE_ITR_ADAPTIVE_MASK_USECS (= IXGBE_ITR_ADAPTIVE_LATENCY\n - 1) to replace the open-coded ~IXGBE_ITR_ADAPTIVE_LATENCY\n mask in ixgbe_set_itr() with the cleaner AND form.\n\nAleksandr Loktionov (1):\n ixgbe: use int instead of u32 for error code variables\n\nAlexander Duyck (2):\n ixgbe: limit ITR decrease in latency mode to prevent ACK overdrive\n ixgbe: add IXGBE_ITR_ADAPTIVE_MASK_USECS constant\n\nJacob Keller (2):\n ixgbe: rename numa_node to node in struct ixgbe_q_vector\n ixgbe: use ktime_get_real_ns() in ixgbe_ptp_reset()\n\nJakub Chylkowski (1):\n ixgbe: extract ixgbe_restart_auto_neg() to avoid code duplication\n\nMaciej Rabeda (1):\n ixgbe: increase SECRX_RDY polling frequency in\n ixgbe_disable_rx_buff_generic\n\nPiotr Skajewski (1):\n ixgbe: prevent adding duplicate FDIR perfect filter rules\n\n drivers/net/ethernet/intel/ixgbe/ixgbe.h | 3 +-\n .../net/ethernet/intel/ixgbe/ixgbe_common.c | 5 +--\n .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 27 +++++++++++-\n drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c | 2 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 19 ++++++++--\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 42 +++++++++++--------\n drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 2 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 12 +++---\n 8 files changed, 77 insertions(+), 35 deletions(-)"}