{"id":2234237,"url":"http://patchwork.ozlabs.org/api/1.2/covers/2234237/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/cover/20260507131541.2331771-1-houminxi@gmail.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.2/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260507131541.2331771-1-houminxi@gmail.com>","list_archive_url":null,"date":"2026-05-07T13:15:39","name":"[ovs-dev,net-next,v7,0/2] selftests: openvswitch: add pop_vlan test","submitter":{"id":93141,"url":"http://patchwork.ozlabs.org/api/1.2/people/93141/?format=json","name":"Minxi Hou","email":"houminxi@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/openvswitch/cover/20260507131541.2331771-1-houminxi@gmail.com/mbox/","series":[{"id":503180,"url":"http://patchwork.ozlabs.org/api/1.2/series/503180/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=503180","date":"2026-05-07T13:15:39","name":"selftests: openvswitch: add pop_vlan test","version":7,"mbox":"http://patchwork.ozlabs.org/series/503180/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/2234237/comments/","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=R3uB2EzG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=R3uB2EzG","smtp1.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp1.osuosl.org; dkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=R3uB2EzG"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBCS544vnz1y04\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 07 May 2026 23:16:05 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id B664641120;\n\tThu,  7 May 2026 13:16:03 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id MMU-dvy89-KA; Thu,  7 May 2026 13:16:02 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id CECD341102;\n\tThu,  7 May 2026 13:16:02 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id A7147C04EB;\n\tThu,  7 May 2026 13:16:02 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists.linuxfoundation.org (Postfix) with ESMTP id CD0EDC04E7\n for <dev@openvswitch.org>; Thu,  7 May 2026 13:15:59 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id BF1B883B94\n for <dev@openvswitch.org>; Thu,  7 May 2026 13:15:59 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id pxoRMK2hAd4M for <dev@openvswitch.org>;\n Thu,  7 May 2026 13:15:59 +0000 (UTC)","from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com\n [IPv6:2607:f8b0:4864:20::32c])\n by smtp1.osuosl.org (Postfix) with ESMTPS id CEEF383B93\n for <dev@openvswitch.org>; Thu,  7 May 2026 13:15:58 +0000 (UTC)","by mail-ot1-x32c.google.com with SMTP id\n 46e09a7af769-7dcd689829eso731954a34.3\n for <dev@openvswitch.org>; Thu, 07 May 2026 06:15:58 -0700 (PDT)","from houminxi ([72.244.37.221]) by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7deca826dbesm14047117a34.12.2026.05.07.06.15.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 07 May 2026 06:15:56 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org CECD341102","OpenDKIM Filter v2.11.0 smtp1.osuosl.org CEEF383B93"],"Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::32c; helo=mail-ot1-x32c.google.com;\n envelope-from=houminxi@gmail.com; receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org CEEF383B93","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1778159757; x=1778764557; darn=openvswitch.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=TRvWNkmel+YHvL5LZc0SrAVa4019euEI2glulSMITOg=;\n b=R3uB2EzGQ6Xnw0Gf0uDfouNgybieIgwE+iMYh0xMQhTmn6JQYIo8wFQqKuUT/gYMxB\n yGt9tKD1DQITY1yRErBPRDGBeUSxsmeL7pW2LekPMh68YzAiFR6U4OMT27fYpWU0pbpA\n 84bZN/Mavy5Vg5TdUC2F88GptdWwGPQGFur5s334tsplVA24+NiNV33jnlOuyw8LWBF4\n ZQzEanQfskFR2Xhvb5rl1c86VyhNyu1HDe5muspHhDgiyfoBABOrjbYAyi+I1fs41/7+\n MLEuJ16lpxEWjzBJVxsT1YKNW4tZWfsc3Fl+ifnu/rn6gO3o7lc7ELVdXnKo6vKsZAIi\n NOsg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778159757; x=1778764557;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=TRvWNkmel+YHvL5LZc0SrAVa4019euEI2glulSMITOg=;\n b=W88XtzJCBXHz3Efdh7FNfrUT0H6dr7nqm8uPjRZSIkXKSKBFvrUGiDebO0IpGk1vc6\n oiG2xPpk9FBl0antIJuHdGTlhq9a0t5URk2rRWDfZn5s5Goi+1jYo42LOvR4tKU4P7Xr\n faJ1Xltf/jn8rkroEtlxm/QzSTo7tDLFvYzCReQODV0P9O3fifHV5SyVDg6LpaZSYJ0U\n oKiVwsBKnOE9lk5DOQUj1UXimHRJ3/7QktEgVmoTJKifwQyF6i+AYqcBlvhKvQQi0+g6\n 0ZVJ01mjw70TEHN4tDIcdIgQQA5tFW/puVzn2vc7IS4iiSbxXDTWJqfipshgjYrMrquq\n wmHA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ83WQyzxDi8AfB4e9xfetxZUWLb04n8vNje2yOrL75pF2KtaCFNA6VTwDigWm4kofP/FEk=@openvswitch.org","X-Gm-Message-State":"AOJu0Yw57BU1sZdkCpXGCWd42t848Fz/03ZJVmDewpn1O8YldFiZFOnb\n 2nm9u6yTCrxDAnOVXG+q6taOFQO40BileL0pUlCMcF0hKrsJrxcO1gmW","X-Gm-Gg":"AeBDieui5gYFNliftWc4Jomrch9EDrunZ15UlufYKf7CFChOGhY8pMMcqR3TW+F2xCq\n xO0L2GmZiIA0mVNGELm6JsAj51rWchwtmQi0nDRYGOfyGgrvax8coSwUTzJn9X8YFL0+uOTBKA8\n ARqIceJ0RE4PQCLYZ+RUAEAslWm2rZu5FnLAhWnVlqmGGNcVEJfmvEmX4CY5NpumuK+dkVRvbKg\n wHgPOWseynxGnxeL1vBh62sZQjamwgkSi45B4/fSKoAX1ED9sLSefVQmTNNNQy6kNCpcVB6OJ6y\n yb6bfF0nSHoE8bY0Z0Qc5swhsNuz23VNfhs+mnmyE16e/gI7F+xk9Z3v/AWubiLj4ljpnO9Adny\n kZLydzo0Wdm9pJzzLjrUCvU8fv1bvmn3Rj9UhtpKUBE68u4K3Sj56TRuumUswZMs03ec0+Yq1iN\n zc+RhrhNHh1agnbHpliR2igiGaxYLwqIg+79dD","X-Received":"by 2002:a05:6830:6a88:b0:7d7:d524:bc8a with SMTP id\n 46e09a7af769-7e1def078b1mr4464120a34.9.1778159757284;\n Thu, 07 May 2026 06:15:57 -0700 (PDT)","From":"Minxi Hou <houminxi@gmail.com>","To":"netdev@vger.kernel.org","Date":"Thu,  7 May 2026 21:15:39 +0800","Message-ID":"<20260507131541.2331771-1-houminxi@gmail.com>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","Subject":"[ovs-dev] [PATCH net-next v7 0/2] selftests: openvswitch: add\n pop_vlan test","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Cc":"dev@openvswitch.org, linux-kselftest@vger.kernel.org,\n Minxi Hou <houminxi@gmail.com>, linux-kernel@vger.kernel.org,\n i.maximets@ovn.org, edumazet@google.com, horms@kernel.org, kuba@kernel.org,\n pabeni@redhat.com, shuah@kernel.org, davem@davemloft.net","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" <ovs-dev-bounces@openvswitch.org>"},"content":"Add test_pop_vlan() to verify OVS kernel datapath pop_vlan action\ncorrectly strips 802.1Q VLAN tags from frames.\n\nPatch 1 extends ovs-dpctl.py with vlan(vid=X,pcp=Y,cfi=Z) formatting\nand parsing, plus an encap_ovskey subclass for safe ENCAP NLA decoding.\nIt changes OVS_KEY_ATTR_VLAN type from uint16 to be16 to match\nthe kernel __be16 wire format.\nIt also adds push_vlan action support (parse/format with range\nvalidation) and removes the unnecessary MAX_ENCAP_DEPTH limit.\nPatch 2 adds the selftest using purely ping-based verification with\na push_vlan return flow for symmetric bidirectional testing.\n\nTested with vng on x86_64, all OVS selftests pass (including new\ntest_pop_vlan).\n\nv7:\n  - remove slot number comments from encap_ovskey nla_map, keep\n    only comments explaining differences from base ovskey class\n  - remove explicit modprobe 8021q pre-flight check (ip link add\n    type vlan auto-loads the module)\nv6: https://lore.kernel.org/netdev/20260506131218.1880852-1-houminxi@gmail.com/\n  - fix non-ASCII characters (em dashes) in comments and commit\n    messages\nv5: https://lore.kernel.org/netdev/20260505124957.1239812-1-houminxi@gmail.com/\n  - add push_vlan action class, dpstr format and parse with range\n    validation (vid 0-4095, pcp 0-7, tpid 0-0xFFFF, CFI forced to 1)\n  - remove MAX_ENCAP_DEPTH constant and depth tracking (bracket-depth\n    counter in encap parser already handles nesting)\n  - remove start_capture/stop_capture helpers and tcpdump/pcap\n    verification -- use ping success/failure instead\n  - remove modprobe/netns pre-flight checks (other tests don't do this)\n  - remove ethtool VLAN offload disable (unnecessary for veth)\n  - add push_vlan return flow for symmetric bidirectional ping\n  - use ovs_sbx wrapper for ping commands (consistent with siblings)\nv4: https://lore.kernel.org/netdev/20260504123713.555461-1-houminxi@gmail.com/\n  - fix all checkpatch line-length warnings in new code\n  - fix pylint W0707: use explicit exception chaining (from exc)\nv3: https://lore.kernel.org/netdev/20260503120946.51869-1-houminxi@gmail.com/\n  - encap_ovskey: MPLS type \"ovs_key_mpls\" -> \"array(ovs_key_mpls)\"\n  - encap_ovskey: PRIORITY/IN_PORT set to \"none\" (metadata, not in ENCAP)\n  - _vlan_dpstr: cfi=0 falls back to tci=0x%04x for round-trip safety\n  - encap parse(): check return value for unrecognized trailing content\n  - vlan parser: boundary check + raise-from for exception chaining\n  - start_capture: || return $? to propagate ksft_skip correctly\n  - on_exit: moved after resource creation, not before\n  - ping success: changed from NOTE to FAIL + return 1\n  - VLAN interface creation: added || return 1 error propagation\n  - netns probe: distinguish EEXIST from missing CONFIG_NET_NS\n  - sbx_add: || return $ksft_skip -> || return $? (match sibling tests)\nv2: https://lore.kernel.org/netdev/20260501133924.3100680-1-houminxi@gmail.com/\n\nMinxi Hou (2):\n  selftests: openvswitch: add vlan() and encap() flow string parsing\n  selftests: openvswitch: add pop_vlan test\n\n .../selftests/net/openvswitch/openvswitch.sh  |  73 ++++\n .../selftests/net/openvswitch/ovs-dpctl.py    | 322 +++++++++++++++++-\n 2 files changed, 385 insertions(+), 10 deletions(-)"}