{"id":2227956,"url":"http://patchwork.ozlabs.org/api/1.2/covers/2227956/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/cover/20260424154205.364268-1-berrange@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260424154205.364268-1-berrange@redhat.com>","list_archive_url":null,"date":"2026-04-24T15:41:48","name":"[00/16] tests: do more testing of block drivers","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/1.2/people/2694/?format=json","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/cover/20260424154205.364268-1-berrange@redhat.com/mbox/","series":[{"id":501385,"url":"http://patchwork.ozlabs.org/api/1.2/series/501385/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501385","date":"2026-04-24T15:41:48","name":"tests: do more testing of block drivers","version":1,"mbox":"http://patchwork.ozlabs.org/series/501385/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/2227956/comments/","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Cnm+TDVE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2HKJ3vkhz1y2d\n\tfor ; Sat, 25 Apr 2026 01:42:42 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGIfg-0002ma-L7; Fri, 24 Apr 2026 11:42:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGIfc-0002mM-4x\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 11:42:20 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGIfa-0007JK-AK\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 11:42:19 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-10--rJ2dx5zOxSdVkD57CfH1g-1; Fri,\n 24 Apr 2026 11:42:12 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B514E1800640; Fri, 24 Apr 2026 15:42:10 +0000 (UTC)","from thinkbook.redhat.com (unknown [10.44.32.213])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C2F8D180047F; Fri, 24 Apr 2026 15:42:06 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777045336;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=AMI3pdPMOvHRyhLZJiX0BY3AhLZPCz+TZtDD3iLebtQ=;\n b=Cnm+TDVEmPxml1a92F7c7JwIFBsDR6woypk/hmT8Rf3+lgTV2ehlDUGp37NpdnuGL9kIGo\n GC68lz5zQrFxVUF4j7OMHmfFKxJ44XgeFV3JJl4rTUc23ZztmyqtyLAOELiXeQ225ZzQzW\n qEdD3vU8USuYbFA6yws4mHa5CztMZEA=","X-MC-Unique":"-rJ2dx5zOxSdVkD57CfH1g-1","X-Mimecast-MFC-AGG-ID":"-rJ2dx5zOxSdVkD57CfH1g_1777045331","From":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Hanna Reitz ,\n Pierrick Bouvier , =?utf-8?q?Alex_Benn?=\n\t=?utf-8?q?=C3=A9e?= , qemu-block@nongnu.org,\n Cleber Rosa , Kevin Wolf ,\n John Snow , Paolo Bonzini ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Dani?=\n\t=?utf-8?q?el_P=2E_Berrang=C3=A9?= ","Subject":"[PATCH 00/16] tests: do more testing of block drivers","Date":"Fri, 24 Apr 2026 16:41:48 +0100","Message-ID":"<20260424154205.364268-1-berrange@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"v1: https://lists.nongnu.org/archive/html/qemu-devel/2025-10/msg01650.html\n v2: https://lists.nongnu.org/archive/html/qemu-devel/2026-01/msg02083.html\n v3: https://lists.nongnu.org/archive/html/qemu-devel/2026-01/msg02939.html\n v4: https://lists.nongnu.org/archive/html/qemu-devel/2026-02/msg03245.html\n v5: https://lists.nongnu.org/archive/html/qemu-devel/2026-03/msg01252.html\n\nThe recent (at the time of v1) set of regressions identified in the LUKS\nblock driver re-inforced that despite having a hugely useful set of I/O\ntests, our CI coverage is still letting through too many bugs.\n\nThe core goals of this series were/are:\n\n * Add LUKS and NBD to the tested formats/protocols\n integrated into \"make check-block SPEED=thorough\"\n\n * Ensure that all qcow2 tests can be run with \"SPEED=slow\",\n not staying limited to only the 'auto' group used by the\n 'make check-block' target in its default 'quick' mode\n\n * Add 'make check-block-$FORMAT' to expose a standalone\n target for running all tests for a given format (or\n equivalently a protocol)\n\n * Add GitLab CI jobs for exercising tests for all formats\n\nA sample pipeline for this is\n\n https://gitlab.com/berrange/qemu/-/pipelines/2258731804/\n\nShowing the 'block-FORMAT' jobs which test the 10 block formats/protocols\ncurrently enabled.\n\nThis series fixes a couple of bugs\n\n * Test 128 check for device mapper usage doesn't work\n sufficiently well to detect gitlab's containe env\n can't do dynamic devfs\n\n * Test 185 is reliably failing on gitlab\n\n * Two tests fail when run on CentOS 9 because they trigger\n python deprecation warnings. This will be fixed when the\n python-qemu-qmp module is next released.\n\nTesting of pipelines throughout development of v1-v5 postings does not\nexhibit any non-deterministic failures with the shared runners. Hopefully\nthat will apply to QEMU's private runners used forthe staging tree too.\n\nAt this point it is a chicken & egg problem though.\n\nIf we don't bite the bullet and enable block I/O tests in GitLab CI for\neveryone, we'll never find out if they're truely stable enough to rely\non.\n\nAs a mitigation against instability a patch in this series adds a new\nQEMU_TEST_IO_SKIP env variable that we are able to set as a GitLab CI\nenv variable. This lets us skip broken tests dynamically without waiting\nfor a git commit to disable them in the buildtest.yml config that we\nuse for disabling the 3 known broken tests currently.\n\nChanged in v6:\n\n - Drop redundant change from gitlab yml config\n - Pull in rebase for qemu.qmp to 0.6.0 to fix two tests\n by avoiding deprecation warnings\n\nChanged in v5:\n\n - Adapt for python-qemu-qmp being spun off, by temp disabling\n tests that are broken by it, that we formerly fixed in-tree.\n\nChanged in v4:\n\n - Remove tests from build-tcg-disabled job\n\nChanged in v3:\n\n - Test whether dmsetup create device appeared or not, instead\n of unconditionally skipping test 128 in GitLab\n - Use 'driver' term instead of 'format' or 'protocol'\n - Fix misc typos & rephrasing\n\nDaniel P. Berrangé (15):\n gitlab: ensure all meson jobs capture build/meson-logs by default\n tests: print reason when I/O test is skipped in TAP mode\n tests: remove redundant meson suite for iotests\n tests: ensure all qcow2 I/O tests are able to be run via make\n scripts/mtest2make: ensure output has stable sorting\n scripts/mtest2make: support optional tests grouping\n tests: add a meson suite / make target per block I/O tests format\n docs/devel/testing: expand documentation for 'make check-block'\n tests: add nbd and luks to the I/O test suites\n tests: use 'driver' as collective term for either format or protocol\n tests: validate dmsetup result in test 128\n tests: fix check for sudo access in LUKS I/O test\n tests: add QEMU_TEST_IO_SKIP for skipping I/O tests\n gitlab: add jobs for thorough block tests\n gitlab: remove I/O tests from build-tcg-disabled job\n\nJohn Snow (1):\n python: bump qemu.qmp to v0.0.6\n\n .gitlab-ci.d/buildtest-template.yml | 30 +++--\n .gitlab-ci.d/buildtest.yml | 107 ++++++++++++++++--\n docs/devel/testing/main.rst | 33 +++++-\n python/scripts/vendor.py | 4 +-\n ...ny.whl => qemu_qmp-0.0.6-py3-none-any.whl} | Bin 72263 -> 72379 bytes\n pythondeps.toml | 2 +-\n scripts/mtest2make.py | 30 +++--\n tests/Makefile.include | 3 +-\n tests/qemu-iotests/128 | 6 +\n tests/qemu-iotests/149 | 13 ++-\n tests/qemu-iotests/meson.build | 59 ++++++++--\n tests/qemu-iotests/testrunner.py | 18 ++-\n 12 files changed, 254 insertions(+), 51 deletions(-)\n rename python/wheels/{qemu_qmp-0.0.5-py3-none-any.whl => qemu_qmp-0.0.6-py3-none-any.whl} (64%)"}