{"id":259,"url":"http://patchwork.ozlabs.org/api/1.1/patches/259/?format=json","web_url":"http://patchwork.ozlabs.org/project/cbe-oss-dev/patch/200809112038.24950.adetsch@br.ibm.com/","project":{"id":1,"url":"http://patchwork.ozlabs.org/api/1.1/projects/1/?format=json","name":"Cell Broadband Engine development","link_name":"cbe-oss-dev","list_id":"cbe-oss-dev.ozlabs.org","list_email":"cbe-oss-dev@ozlabs.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<200809112038.24950.adetsch@br.ibm.com>","date":"2008-09-11T23:38:24","name":"powerpc/spufs: Fix gang->mutex locking in spu_forget","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"42daebd1b7dbef7a290f2b877f70a083a56ac245","submitter":{"id":93,"url":"http://patchwork.ozlabs.org/api/1.1/people/93/?format=json","name":"Andre Detsch","email":"adetsch@br.ibm.com"},"delegate":{"id":1,"url":"http://patchwork.ozlabs.org/api/1.1/users/1/?format=json","username":"jk","first_name":"Jeremy","last_name":"Kerr","email":"jk@ozlabs.org"},"mbox":"http://patchwork.ozlabs.org/project/cbe-oss-dev/patch/200809112038.24950.adetsch@br.ibm.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/259/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/259/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["patchwork@ozlabs.org","cbe-oss-dev@ozlabs.org"],"Delivered-To":["patchwork@ozlabs.org","cbe-oss-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 36E7CDEC72\n\tfor ; Fri, 12 Sep 2008 09:40:48 +1000 (EST)","from igw2.br.ibm.com (igw2.br.ibm.com [32.104.18.25])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client CN \"mailgw2.br.ibm.com\", Issuer \"Equifax\" (not verified))\n\tby ozlabs.org (Postfix) with ESMTPS id CA282DE035;\n\tFri, 12 Sep 2008 09:39:19 +1000 (EST)","from mailhub1.br.ibm.com (mailhub1 [9.18.232.109])\n\tby igw2.br.ibm.com (Postfix) with ESMTP id 01D0B17F41C;\n\tThu, 11 Sep 2008 20:23:56 -0300 (BRT)","from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47])\n\tby mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id\n\tm8BNdDdR2478290; Thu, 11 Sep 2008 20:39:13 -0300","from d24av02.br.ibm.com (loopback [127.0.0.1])\n\tby d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id\n\tm8BNd6p7030166; Thu, 11 Sep 2008 20:39:06 -0300","from [9.8.10.86] ([9.8.10.86])\n\tby d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id\n\tm8BNd55C030162; Thu, 11 Sep 2008 20:39:06 -0300"],"From":"Andre Detsch ","To":"cbe-oss-dev@ozlabs.org","Date":"Thu, 11 Sep 2008 20:38:24 -0300","User-Agent":"KMail/1.9.6","References":"<200809111955.28780.adetsch@br.ibm.com>","In-Reply-To":"<200809111955.28780.adetsch@br.ibm.com>","MIME-Version":"1.0","Content-Disposition":"inline","Message-Id":"<200809112038.24950.adetsch@br.ibm.com>","Cc":"LukeBrowning@us.ibm.com, Jeremy Kerr ","Subject":"[Cbe-oss-dev] [PATCH 10/11] powerpc/spufs: Fix gang->mutex locking\n\tin spu_forget","X-BeenThere":"cbe-oss-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Discussion about Open Source Software for the Cell Broadband Engine\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"cbe-oss-dev-bounces+patchwork=ozlabs.org@ozlabs.org","Errors-To":"cbe-oss-dev-bounces+patchwork=ozlabs.org@ozlabs.org"},"content":"gang->mutex was being hold when mmput(ctx->owner) was called.\nHowever, the same lock is taken inside destroy_spu_context, which\nwas leading to a program hang.\n\nSigned-off-by: Andre Detsch ","diff":"diff --git a/arch/powerpc/platforms/cell/spufs/context.c \nb/arch/powerpc/platforms/cell/spufs/context.c\nindex 7ca787e..9475d1b 100644\n--- a/arch/powerpc/platforms/cell/spufs/context.c\n+++ b/arch/powerpc/platforms/cell/spufs/context.c\n@@ -173,8 +173,8 @@ void spu_forget(struct spu_context *ctx)\n \tspu_deactivate(gang);\n \tmm = ctx->owner;\n \tctx->owner = NULL;\n-\tmmput(mm);\n \tmutex_unlock(&gang->mutex);\n+\tmmput(mm);\n }\n \n void spu_unmap_mappings(struct spu_context *ctx)\n","prefixes":[]}