{"id":255,"url":"http://patchwork.ozlabs.org/api/1.1/patches/255/?format=json","web_url":"http://patchwork.ozlabs.org/project/cbe-oss-dev/patch/200809112038.14473.adetsch@br.ibm.com/","project":{"id":1,"url":"http://patchwork.ozlabs.org/api/1.1/projects/1/?format=json","name":"Cell Broadband Engine development","link_name":"cbe-oss-dev","list_id":"cbe-oss-dev.ozlabs.org","list_email":"cbe-oss-dev@ozlabs.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<200809112038.14473.adetsch@br.ibm.com>","date":"2008-09-11T23:38:14","name":"powerpc/spufs: Time slice lazily loaded contexts.","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"78bc0ad296f2071bed4549ad8ea0118bed2c2af5","submitter":{"id":93,"url":"http://patchwork.ozlabs.org/api/1.1/people/93/?format=json","name":"Andre Detsch","email":"adetsch@br.ibm.com"},"delegate":{"id":1,"url":"http://patchwork.ozlabs.org/api/1.1/users/1/?format=json","username":"jk","first_name":"Jeremy","last_name":"Kerr","email":"jk@ozlabs.org"},"mbox":"http://patchwork.ozlabs.org/project/cbe-oss-dev/patch/200809112038.14473.adetsch@br.ibm.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/255/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/255/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["patchwork@ozlabs.org","cbe-oss-dev@ozlabs.org"],"Delivered-To":["patchwork@ozlabs.org","cbe-oss-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id A2875DE1DD\n\tfor ; Fri, 12 Sep 2008 09:40:18 +1000 (EST)","from igw2.br.ibm.com (igw2.br.ibm.com [32.104.18.25])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client CN \"mailgw2.br.ibm.com\", Issuer \"Equifax\" (not verified))\n\tby ozlabs.org (Postfix) with ESMTPS id 56031DE017;\n\tFri, 12 Sep 2008 09:39:07 +1000 (EST)","from mailhub1.br.ibm.com (mailhub1 [9.18.232.109])\n\tby igw2.br.ibm.com (Postfix) with ESMTP id F0AA417F485;\n\tThu, 11 Sep 2008 20:23:44 -0300 (BRT)","from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47])\n\tby mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id\n\tm8BNd2es1855906; Thu, 11 Sep 2008 20:39:02 -0300","from d24av02.br.ibm.com (loopback [127.0.0.1])\n\tby d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id\n\tm8BNctBf030039; Thu, 11 Sep 2008 20:38:55 -0300","from [9.8.10.86] ([9.8.10.86])\n\tby d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id\n\tm8BNctIX030034; Thu, 11 Sep 2008 20:38:55 -0300"],"From":"Andre Detsch ","To":"cbe-oss-dev@ozlabs.org","Date":"Thu, 11 Sep 2008 20:38:14 -0300","User-Agent":"KMail/1.9.6","References":"<200809111955.28780.adetsch@br.ibm.com>","In-Reply-To":"<200809111955.28780.adetsch@br.ibm.com>","MIME-Version":"1.0","Content-Disposition":"inline","Message-Id":"<200809112038.14473.adetsch@br.ibm.com>","Cc":"LukeBrowning@us.ibm.com, Jeremy Kerr ","Subject":"[Cbe-oss-dev] [PATCH 06/11] powerpc/spufs: Time slice lazily loaded\n\tcontexts.","X-BeenThere":"cbe-oss-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Discussion about Open Source Software for the Cell Broadband Engine\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"cbe-oss-dev-bounces+patchwork=ozlabs.org@ozlabs.org","Errors-To":"cbe-oss-dev-bounces+patchwork=ozlabs.org@ozlabs.org"},"content":"All SPUs are stopped. All contexts are either executing library\ncode or they have major faulted in spu_run.\n\nSigned-off-by: Luke Browning \nSigned-off-by: Andre Detsch ","diff":"diff --git a/arch/powerpc/platforms/cell/spufs/sched.c \nb/arch/powerpc/platforms/cell/spufs/sched.c\nindex c0cc876..f3dee8d 100644\n--- a/arch/powerpc/platforms/cell/spufs/sched.c\n+++ b/arch/powerpc/platforms/cell/spufs/sched.c\n@@ -1230,9 +1230,13 @@ static noinline int spusched_tick(struct spu_gang \n*gang,\n \t\tgoto out;\n \n \t/*\n-\t * If nrunnable is zero, then all of the contexts are in user mode.\n+\t * If nrunnable is zero, then all of the contexts are in user mode\n+\t * and by definition nfaulting is equal to zero. Otherwise if they\n+\t * are equal, all of the contexts in spu_run have faulted. In both\n+\t * cases, all spus are stopped and we should yield assuming there\n+\t * is another gang on the runqueue.\n \t */\n-\tyield = !atomic_read(&gang->nrunnable);\n+\tyield = atomic_read(&gang->nrunnable) == atomic_read(&gang->nfaulting);\n \n \tif (yield || ((ctx->policy != SCHED_FIFO) && (!--ctx->time_slice))) {\n","prefixes":[]}