{"id":2234107,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2234107/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260507092014.17981-1-fw@strlen.de/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260507092014.17981-1-fw@strlen.de>","date":"2026-05-07T09:19:22","name":"[v3,nf,9/8] netfilter: bridge: eb_tables: close module init race","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"32c0f887362d635f4193dd7b23fb034e3e109998","submitter":{"id":1025,"url":"http://patchwork.ozlabs.org/api/1.1/people/1025/?format=json","name":"Florian Westphal","email":"fw@strlen.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260507092014.17981-1-fw@strlen.de/mbox/","series":[{"id":502948,"url":"http://patchwork.ozlabs.org/api/1.1/series/502948/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=502948","date":"2026-05-06T10:07:14","name":"netfilter: xtables: fix module load and teardown races","version":3,"mbox":"http://patchwork.ozlabs.org/series/502948/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234107/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2234107/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12477-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.216.245.30","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gB6Tm2Bdcz1yCg\n\tfor ; Thu, 07 May 2026 19:32:12 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 57E113081CCE\n\tfor ; Thu, 7 May 2026 09:20:38 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A467A3BE16A;\n\tThu, 7 May 2026 09:20:37 +0000 (UTC)","from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc\n [91.216.245.30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 579A6370D6D\n\tfor ; Thu, 7 May 2026 09:20:29 +0000 (UTC)","by Chamillionaire.breakpoint.cc (Postfix, from userid 1003)\n\tid D805C60D41; Thu, 07 May 2026 11:20:19 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778145633; cv=none;\n b=gviH40aWKaQ+JTZdt5nMW2QYqW3D9dV1zPKdB6q2pNWbRlspqinC8DlKduRKYwvERrZ1oTnDxiKvk8YTa/OgSMKIpHI6nxCyVHjsu2GKmy0X4t0NOqGIdziFzugACMkzuRnhcPIhIZRGilRDScPk/AquPXhp1HPMvVN1UG6+VpA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778145633; c=relaxed/simple;\n\tbh=9DSXW2TUYZRK98JxZIrLyW9X1ajP6NS+2E1LfDjeb50=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=gOwu+TD2z1Qh7nAooS8eri7qMrlWcDTPEUNOzm+a60doHNnpmsOZoH4Txm1GlKkFAQ3g8ybO69Zl9YTDHZRHCR3DyxB/MRagm969fRoCkDv2fr7WPL5qvpf32Bpnew7VdVnFVNKltHOpeNEINr90++jE5+RKPKUJmqFcN+vPdy4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc;\n arc=none smtp.client-ip=91.216.245.30","From":"Florian Westphal ","To":"","Cc":"Florian Westphal ","Subject":"[PATCH v3 nf 9/8] netfilter: bridge: eb_tables: close module init\n race","Date":"Thu, 7 May 2026 11:19:22 +0200","Message-ID":"<20260507092014.17981-1-fw@strlen.de>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260506100728.2664-1-fw@strlen.de>","References":"<20260506100728.2664-1-fw@strlen.de>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"sashiko reports for unrelated patch:\n Does the core ebtables initialization in ebtables.c suffer from a similar race?\n Once nf_register_sockopt() completes, the sockopts are exposed globally.\n\nsockopt has to be registered last, just like in ip/ip6/arptables.\n\nFixes: 5b53951cfc85 (\"netfilter: ebtables: use net_generic infra\")\nSigned-off-by: Florian Westphal \n---\n net/bridge/netfilter/ebtables.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)","diff":"diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c\nindex 3578ffbc14ae..b9f4daac09af 100644\n--- a/net/bridge/netfilter/ebtables.c\n+++ b/net/bridge/netfilter/ebtables.c\n@@ -2583,19 +2583,20 @@ static int __init ebtables_init(void)\n {\n \tint ret;\n \n-\tret = xt_register_target(&ebt_standard_target);\n+\tret = register_pernet_subsys(&ebt_net_ops);\n \tif (ret < 0)\n \t\treturn ret;\n-\tret = nf_register_sockopt(&ebt_sockopts);\n+\n+\tret = xt_register_target(&ebt_standard_target);\n \tif (ret < 0) {\n-\t\txt_unregister_target(&ebt_standard_target);\n+\t\tunregister_pernet_subsys(&ebt_net_ops);\n \t\treturn ret;\n \t}\n \n-\tret = register_pernet_subsys(&ebt_net_ops);\n+\tret = nf_register_sockopt(&ebt_sockopts);\n \tif (ret < 0) {\n-\t\tnf_unregister_sockopt(&ebt_sockopts);\n \t\txt_unregister_target(&ebt_standard_target);\n+\t\tunregister_pernet_subsys(&ebt_net_ops);\n \t\treturn ret;\n \t}\n \n","prefixes":["v3","nf","9/8"]}