{"id":2233434,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2233434/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260506123637.1077421-5-mscardovi95@gmail.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.1/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260506123637.1077421-5-mscardovi95@gmail.com>","date":"2026-05-06T12:35:36","name":"[v2,3/3,3/3] gpio: acpi: modernize resource management using cleanup.h","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"649576377b988328d4f70b955d982891161140db","submitter":{"id":93312,"url":"http://patchwork.ozlabs.org/api/1.1/people/93312/?format=json","name":"Marco Scardovi","email":"mscardovi95@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260506123637.1077421-5-mscardovi95@gmail.com/mbox/","series":[{"id":502978,"url":"http://patchwork.ozlabs.org/api/1.1/series/502978/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=502978","date":"2026-05-06T12:34:21","name":"gpio: acpi: modernize resource management using cleanup.h","version":2,"mbox":"http://patchwork.ozlabs.org/series/502978/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233434/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233434/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=YE5oi6+B;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-36286-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"YE5oi6+B\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.41","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9ZkY0skjz1yJV\n\tfor ; Wed, 06 May 2026 22:41:25 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 586593053DC9\n\tfor ; Wed, 6 May 2026 12:37:11 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9DB6F44D02F;\n\tWed, 6 May 2026 12:37:07 +0000 (UTC)","from mail-wm1-f41.google.com (mail-wm1-f41.google.com\n [209.85.128.41])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A26744CF5F\n\tfor ; Wed, 6 May 2026 12:37:01 +0000 (UTC)","by mail-wm1-f41.google.com with SMTP id\n 5b1f17b1804b1-488ff90d6c7so60566285e9.2\n for ;\n Wed, 06 May 2026 05:37:00 -0700 (PDT)","from ROG ([2a01:e11:202b:40:68b1:8d59:e348:c16e])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48e530cf964sm31767485e9.1.2026.05.06.05.36.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 06 May 2026 05:36:59 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778071025; cv=none;\n b=QNM+MXCgayRzEBkh46OMjLs5YwHacUecmNi5HuwPzL+pujZkzVj3oJVEXnI2IIi8y8xOYLgmcTcGYrjJbaetvtJTJVX1S5CUxnIWwvJkiub/66fIwQxIvt1ORzumerlzqblTlWPq0vBnc8yXYc0ImnVRAHAnmrXPv7CPspTxBtY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778071025; c=relaxed/simple;\n\tbh=MtVKX0+/RgsoWzLc/ouyVcU1ubZM16+m3j5A53wkB4s=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=LhLd5dDYpt8gEiBGrykoNYIJvCksFVdnZ6Y2+hdPmRE8J5de9RO/3JNZ99Y0ez+TMTvEyGhiqCROxnKel2VHfwwaWit0/5ghWEJSmbKUO5kObL+PkEaY6ydHY6Ie4/TAfDVh5naQY+v3dtIan/kxVj/ncmZHxIipBsKVUBlIotY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=YE5oi6+B; arc=none smtp.client-ip=209.85.128.41","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1778071019; x=1778675819;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=y4fhAWXiUtHh50/c6yGRrCeHmG4RlLuqrhdgBtX1yOM=;\n b=YE5oi6+BFzVcPSzvAXmQoMtRJwmvQRMxm8sLZABSCNP4N3+paiXPrVGdVySgfsrmtZ\n vsMNDtpi+nShPImkP2m76/OdvbEdfCZZ3Z1dK09N1d6FauV6tvzfNl0low6bqF0kWlWb\n vxX13sywOv6HmXC+qY9CAXWFcu4fxQLBuCu+qzHYK5WVFt9tdqFja9x7HVQSywGVLpo0\n 6ua2A+yygYoLti8+3uwzWbNOzpsEcaW0WY3d6GbpaUoYwEoNyA63gVq0Z5zDTPPf//8W\n KS4P9xOBfFRmwstC2AE/woS8spwQFFZWzRBaQS9wCUyP3cfk337jJcyAUUuwYTluVM7E\n qWVw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778071019; x=1778675819;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=y4fhAWXiUtHh50/c6yGRrCeHmG4RlLuqrhdgBtX1yOM=;\n b=fyOWibdwX9xWa0mI1J4EXK87x1MI4d+ktvGpAwrW6vCUxwJx1dURL75fAX5tzllFxx\n Xa7M3Pp+oh8YMbfwCA4YSQtwpOusJsDgvDfolvJOn72hiIcskK8HIJADtt/y88wH1E+W\n 7CB/w69Fa2eBSo636vG/bk9yE/E3ieiag8+d08aRwkQuCecDWNtyueU3RlIZoR5zFEgR\n AFvOvjoa1g0v4HET6+Wp8nJES1Jy9HiH+1IvoGfpB/xQBej4QkzXtPh91qOVpmGQBCrr\n i5Mcx7m6cRTf7c63hLz7h0GUUZVeCvAm9wiq+T0WRhPXy8ddJVOAobx29kUMyV5v6WgJ\n Ykgg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ82taiDhhMIu0C4rYlik3/UDxOs0ed+ZoLLJZW8YGXO4PV7ekjC+JgmdZVw6u0AtAbjpnJiJLtjsS3o@vger.kernel.org","X-Gm-Message-State":"AOJu0Yyjw/VvC9gFUMY+gIbzqPHK25pVqBuUUrQC2UKzTQG+PDWKCsAk\n\tL3DFqnIA77IqPxZ+5g2x6JtJsL3ku68Ek+dnxcAcjr4j+Yr5VcLJ4syX","X-Gm-Gg":"AeBDiesYHkVGr3KK2juQ3xCTt5juzADZuzCT80yy0VcE58bm0NrSU+hn8fZfpVwBhMX\n\tsbMKgUDxEDReOyrfiIL0UUrdd8d3HZuBjZQlHSKkzWhCTAZO73RScaKJSJNqqX8FmA8QT5J9KDt\n\tVpoSx8gY0+OHleWpjQk8cOIMezdZVt5Iu3B1/lFB15bekelJki/4wDviQeFRx26E+ly9P25KKk+\n\tJywKYp26xAMUZc4EJnQveLhWrS42XBQSDN0dFfBSfF+avQHFQPKtQ5GCvWdMZi8uEDUHfVpjUuy\n\t2bDoWRD6+X1QrZrIFCmhe8HoHkxQEsgyewWUgzwhO/YbcefEBnfJvrj9tpqZrWMU4rP+jUuUp0W\n\tYBJng9aGkUH4eIZHSaYl1nApPyVQeD06RjcljafhK7vatnqCtACFAJVvtkQZ/I3pFZyKCdoLXp8\n\t8wmYHtFm2TPkQ79koPPpjyfLwblw==","X-Received":"by 2002:a05:600c:8485:b0:488:af7f:775f with SMTP id\n 5b1f17b1804b1-48e51f32a64mr60865175e9.18.1778071019394;\n Wed, 06 May 2026 05:36:59 -0700 (PDT)","From":"Marco Scardovi ","To":"mika.westerberg@intel.com","Cc":"mathias.nyman@intel.com,\n\tandriy.shevchenko@intel.com,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-acpi@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tMarco Scardovi ","Subject":"[PATCH v2 3/3] [PATCH 3/3] gpio: acpi: modernize resource management\n using cleanup.h","Date":"Wed, 6 May 2026 14:35:36 +0200","Message-ID":"<20260506123637.1077421-5-mscardovi95@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260506123637.1077421-1-mscardovi95@gmail.com>","References":"<20260506113215.GK6785@://intel.com>\n <20260506123637.1077421-1-mscardovi95@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"---\n drivers/gpio/gpiolib-acpi-core.c | 12 +++---------\n 1 file changed, 3 insertions(+), 9 deletions(-)","diff":"diff --git a/drivers/gpio/gpiolib-acpi-core.c b/drivers/gpio/gpiolib-acpi-core.c\nindex b6accbaba04d..7b6476b90f13 100644\n--- a/drivers/gpio/gpiolib-acpi-core.c\n+++ b/drivers/gpio/gpiolib-acpi-core.c\n@@ -1126,7 +1126,7 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,\n \t\tu16 word, shift;\n \t\tbool found;\n \n-\t\tmutex_lock(&achip->conn_lock);\n+\t\tguard(mutex)(&achip->conn_lock);\n \n \t\tfound = false;\n \t\tlist_for_each_entry(conn, &achip->conns, node) {\n@@ -1158,17 +1158,15 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,\n \t\tif (!found) {\n \t\t\tdesc = acpi_request_own_gpiod(chip, agpio, i, \"ACPI:OpRegion\");\n \t\t\tif (IS_ERR(desc)) {\n-\t\t\t\tmutex_unlock(&achip->conn_lock);\n \t\t\t\tstatus = AE_ERROR;\n-\t\t\t\tgoto out;\n+\t\t\t\tbreak;\n \t\t\t}\n \n \t\t\tconn = kzalloc_obj(*conn);\n \t\t\tif (!conn) {\n \t\t\t\tgpiochip_free_own_desc(desc);\n-\t\t\t\tmutex_unlock(&achip->conn_lock);\n \t\t\t\tstatus = AE_NO_MEMORY;\n-\t\t\t\tgoto out;\n+\t\t\t\tbreak;\n \t\t\t}\n \n \t\t\tconn->pin = pin;\n@@ -1176,8 +1174,6 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,\n \t\t\tlist_add_tail(&conn->node, &achip->conns);\n \t\t}\n \n-\t\tmutex_unlock(&achip->conn_lock);\n-\n \t\t/*\n \t\t * For the cases when OperationRegion() consists of more than\n \t\t * 64 bits calculate the word and bit shift to use that one to\n@@ -1196,8 +1192,6 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,\n \t\t}\n \t}\n \n-out:\n-\tACPI_FREE(ares);\n \treturn status;\n }\n \n","prefixes":["v2","3/3","3/3"]}