{"id":2233410,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2233410/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260506121618.578443-2-lixiasong1@huawei.com/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260506121618.578443-2-lixiasong1@huawei.com>","date":"2026-05-06T12:16:17","name":"[nft,1/2] netfilter: nf_conntrack_sip: fix missing expect put in REGISTER path","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"4f969f5c7c075b285304d2fb015117f2a98d1373","submitter":{"id":93343,"url":"http://patchwork.ozlabs.org/api/1.1/people/93343/?format=json","name":"Li Xiasong","email":"lixiasong1@huawei.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260506121618.578443-2-lixiasong1@huawei.com/mbox/","series":[{"id":502974,"url":"http://patchwork.ozlabs.org/api/1.1/series/502974/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=502974","date":"2026-05-06T12:16:16","name":"netfilter: fix nf_ct_expect_alloc() reference leaks","version":1,"mbox":"http://patchwork.ozlabs.org/series/502974/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233410/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233410/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256\n header.s=dkim header.b=vNJUxrlp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12461-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com\n header.b=\"vNJUxrlp\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=113.46.200.222","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=huawei.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=huawei.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9Ycb4zvYz1yJx\n\tfor ; Wed, 06 May 2026 21:51:11 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 6F20B3011599\n\tfor ; Wed, 6 May 2026 11:51:02 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id CBB2443CEE7;\n\tWed, 6 May 2026 11:51:00 +0000 (UTC)","from canpmsgout07.his.huawei.com (canpmsgout07.his.huawei.com\n [113.46.200.222])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B57E633D6EE;\n\tWed, 6 May 2026 11:50:57 +0000 (UTC)","from mail.maildlp.com (unknown [172.19.162.92])\n\tby canpmsgout07.his.huawei.com (SkyGuard) with ESMTPS id 4g9YRZ301LzLlTq;\n\tWed, 6 May 2026 19:43:22 +0800 (CST)","from kwepemj500018.china.huawei.com (unknown [7.202.194.48])\n\tby mail.maildlp.com (Postfix) with ESMTPS id D0C0640565;\n\tWed, 6 May 2026 19:50:54 +0800 (CST)","from huawei.com (10.50.85.128) by kwepemj500018.china.huawei.com\n (7.202.194.48) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 6 May\n 2026 19:50:54 +0800"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778068260; cv=none;\n b=Q6cqr4SQk3LIOP8jbp9HiJCrSlN2oFuRI00Xl8AJUjzLSeewe7u/BS76h5j24inXSWyesV26ONOnbMVRJOK5Oc7ycFRB3dQt82ND5OauzPEBOA/w/x2bg/UFxTWKb954bVE1nZ3jYUfJjqzY+ZfpzgR5aj38SZjVyjY8CAZ5Frk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778068260; c=relaxed/simple;\n\tbh=dVCC6nplAGCvCLgD2wqYm7/VvRoe1Qxe1i/PFRj/fEM=;\n\th=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=cS3pNaJ6TgaI1FpK3kX3yDl9K0wUeWGBF+HiyCaMTAqAiy8zRHlB7un9UAZohoUMRu83lPr6Ze+/k08tM7yO0AnzD9fedNLA8miRpnspuoGoZlq7XzaAT9f4+oboFPjfZyQmCGfyQYyKMFIVMtwjlhHey4V5WJ1CSmODT/VKJjE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=huawei.com;\n spf=pass smtp.mailfrom=huawei.com;\n dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com\n header.b=vNJUxrlp; arc=none smtp.client-ip=113.46.200.222","dkim-signature":"v=1; a=rsa-sha256; d=huawei.com; s=dkim;\n\tc=relaxed/relaxed; q=dns/txt;\n\th=From;\n\tbh=t4mZah63AmKiaytxu5xDKCCL10cJNC4I6R1HIeajBhM=;\n\tb=vNJUxrlpYRqBDaf0yug8sNo4AiChGUYm/uXhk5dWm3Gn/JkYkF6AKBqNZegMZ5aj9FYMruukS\n\tkwxwUzESJCMxUgRQVytX8qeMKVy/AOF8RsSiTQCzRTh81DXZbQWN8b9hFxV6NzuVs1OrxnVvyB6\n\toyavX2Y+lXxliO95dbkctD0=","From":"Li Xiasong ","To":"","CC":", Pablo Neira Ayuso , Florian\n Westphal , Phil Sutter , ,\n\t, ,\n\t","Subject":"[PATCH nft 1/2] netfilter: nf_conntrack_sip: fix missing expect put\n in REGISTER path","Date":"Wed, 6 May 2026 20:16:17 +0800","Message-ID":"<20260506121618.578443-2-lixiasong1@huawei.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260506121618.578443-1-lixiasong1@huawei.com>","References":"<20260506121618.578443-1-lixiasong1@huawei.com>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-ClientProxiedBy":"kwepems100002.china.huawei.com (7.221.188.206) To\n kwepemj500018.china.huawei.com (7.202.194.48)"},"content":"process_register_request() allocates an expectation, but the !helper\nerror path returns NF_DROP without nf_ct_expect_put(exp).\n\nAdd the missing put to balance nf_ct_expect_alloc() on this path.\n\nFixes: e14575fa7529 (\"netfilter: nf_conntrack: use rcu accessors where needed\")\nCc: stable@vger.kernel.org\nSigned-off-by: Li Xiasong \n---\n net/netfilter/nf_conntrack_sip.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/net/netfilter/nf_conntrack_sip.c b/net/netfilter/nf_conntrack_sip.c\nindex 1eb55907d470..a895bc836e1b 100644\n--- a/net/netfilter/nf_conntrack_sip.c\n+++ b/net/netfilter/nf_conntrack_sip.c\n@@ -1377,8 +1377,10 @@ static int process_register_request(struct sk_buff *skb, unsigned int protoff,\n \t\tsaddr = &ct->tuplehash[!dir].tuple.src.u3;\n \n \thelper = rcu_dereference(nfct_help(ct)->helper);\n-\tif (!helper)\n+\tif (!helper) {\n+\t\tnf_ct_expect_put(exp);\n \t\treturn NF_DROP;\n+\t}\n \n \tnf_ct_expect_init(exp, SIP_EXPECT_SIGNALLING, nf_ct_l3num(ct),\n \t\t\t saddr, &daddr, proto, NULL, &port);\n","prefixes":["nft","1/2"]}