{"id":2233403,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2233403/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260506111529.2919079-1-holger.brunck@hitachienergy.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.1/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<20260506111529.2919079-1-holger.brunck@hitachienergy.com>","date":"2026-05-06T11:15:29","name":"[v2,net] net: wan: fsl_ucc_hdlc: free tx_skbuff in uhdlc_memclean","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3ed8531c97d76005bc9634a119d6f142efa5f242","submitter":{"id":82682,"url":"http://patchwork.ozlabs.org/api/1.1/people/82682/?format=json","name":"Holger Brunck","email":"holger.brunck@hitachienergy.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260506111529.2919079-1-holger.brunck@hitachienergy.com/mbox/","series":[{"id":502971,"url":"http://patchwork.ozlabs.org/api/1.1/series/502971/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=502971","date":"2026-05-06T11:15:29","name":"[v2,net] net: wan: fsl_ucc_hdlc: free tx_skbuff in uhdlc_memclean","version":2,"mbox":"http://patchwork.ozlabs.org/series/502971/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233403/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2233403/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=duo-1630306886989-947ac67a header.b=G42llmsp;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org\n header.a=rsa-sha256 header.s=dkim-high header.b=kWq8w9ns;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20518-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=18.158.144.38","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=duo-1630306886989-947ac67a header.b=G42llmsp;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org\n header.a=rsa-sha256 header.s=dkim-high header.b=kWq8w9ns;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=hitachienergy.com\n (client-ip=18.158.144.38; helo=out-ip0052.fra.mailhop.org;\n envelope-from=holger.brunck@hitachienergy.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9Xs22Zd6z1y04\n\tfor ; Wed, 06 May 2026 21:16:53 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g9Xs04qYLz30RN;\n\tWed, 06 May 2026 21:16:52 +1000 (AEST)","from out-ip0052.fra.mailhop.org (out-ip0052.fra.mailhop.org\n [18.158.144.38])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g9Xrx5dbDz30DX\n\tfor ; Wed, 06 May 2026 21:16:48 +1000 (AEST)","from HPG0000000426.corp.hitachi-powergrids.com (unknown\n [20.82.50.241])\n\tby outbound3.eu.mailhop.org (Halon) with ESMTPSA\n\tid e4f9875c-493c-11f1-8f51-f54febe22707;\n\tWed, 06 May 2026 11:15:32 +0000 (UTC)","from gitsiv.hitachienergy.com (unknown [10.54.139.14])\n\tby HPG0000000426.corp.hitachi-powergrids.com (Postfix) with ESMTP id\n 47A9F80525F;\n\tWed, 6 May 2026 11:15:31 +0000 (UTC)","from chbrn3-p-dev015.keymile.net (chbrn3-p-dev015.keymile.net\n [172.31.41.201])\n\tby gitsiv.hitachienergy.com (Postfix) with ESMTP id 19A6B60B7D47;\n\tWed, 6 May 2026 13:15:31 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778066212;\n\tcv=none;\n b=J1rrAfC4bOlfhMN7CNvD6p1aTuJMkXV/UbyMxn7YbSjBUpE4pYsokUBrxdxs5/LxsDjqK5R2el6ykn9jxN7OSNPjabJRwFG+1O7jqHxyQlksOZAxDDDEFg0xe9DvVo0jPfr86A8rOxrjmU5OwTKJx90HRZLjpNeEt8LWxGYRCKF4xsKX4VqYpOqM5Ce3uRWZtfP20Jbfniw4bzJJRRrwiB/Jz4G58Gyyg9nLNMAT6Mtt46XbJFurHDvCl6sk78RtyZ9BcFjmbkFlEPuOXl9oae1MKoARTTkwCZDlbMYE4vkPR9n5XlhOeRIcK2ZmFeGcMelA90dZUJ+OTqdoIp5wGg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778066212; c=relaxed/relaxed;\n\tbh=mzUCgE4R9ZBXTM/Zus2HFTCm9+5cChUmtqF1FgPd4FU=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=ZM1m1jI7Eyoni8Vh6jBEv6QG85dVHgVLEjJuWKRTq8VHU30zXLs61JY1SkBRFzKGHsV7C4t8ZE5InvQufKcRsuSos2lmu1u2jcwvu621OEtogj+8XFrqWCetXpi4R055qnocr6BaCYVRtfB0r9C2V7TcA554+JzHI+1v6czTDN8t1KaE52NpXLTMdRfWiU0Li0L4fpdHcNNk1yDaEThDkNQN5sTFuAjriZTG66SIXPsD5ak+8amTn9zForv5KzCmEAs4e/Ke660CtTuCOcrwbYgYCpNJpv07vA9rFi7+MSyi2/0UEV7eUPhERbsDEvRNEAb9TnX5oplJ1+crRwsbYA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com;\n dkim=pass (1024-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=duo-1630306886989-947ac67a header.b=G42llmsp;\n dkim=pass (2048-bit key;\n unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org\n header.a=rsa-sha256 header.s=dkim-high header.b=kWq8w9ns; dkim-atps=neutral;\n spf=pass (client-ip=18.158.144.38; helo=out-ip0052.fra.mailhop.org;\n envelope-from=holger.brunck@hitachienergy.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=hitachienergy.com","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=hitachienergy.com; s=duo-1630306886989-947ac67a;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc:to:from:\n\t cfbl-address:cfbl-feedback-id:from;\n\tbh=mzUCgE4R9ZBXTM/Zus2HFTCm9+5cChUmtqF1FgPd4FU=;\n\tb=G42llmspsz5W53eBNTiq/ZpZ0nrMBEnsLDD3u+l1US/9WqbUmJ+tjxr5NP4VJFz9q4slVg7Osaclw\n\t hOuHNHJyYvlqzfWX6FqZNaZCuRwSgnF70NXW3Zyhg5fwyGBY9SaY+NfhhrzI+bESUAuNWcBKyxW5tu\n\t 8VwT4XqI8UgGwht4=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=outbound.mailhop.org; s=dkim-high;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc:to:from:\n\t cfbl-address:cfbl-feedback-id:from;\n\tbh=mzUCgE4R9ZBXTM/Zus2HFTCm9+5cChUmtqF1FgPd4FU=;\n\tb=kWq8w9nsR2RvVSHinNFmMiGQ9zzmppV3xQmNrHJJr/caTLPlJ8NJcvqj+245KMGmN5/cuc+Crks61\n\t Gc033LyF7O21pxmsWEZmeVOFn8Jn7dMlxWYZ3D5oPveaFAzAk3YWYGeja5H75lqZX8zVynLaHh8zqC\n\t T5T6A/J+R2QLSobbCFdc9IJbqT/exQ8+rl6CVLtAmZjSI7ltqJL1PxHXx1USg99May3/4PNrNQy2EE\n\t AEaRs/gJI3Yu1UZ8xgcj5teKvx+NCRPq9o3Sy9ISqEYZ8SRH4OA6c2Ivtpt9hu5MZusI9s0VsX2ONE\n\t Qm62MjHasVn0f4YWlkEWKFKfZsCr9Qw=="],"X-Originating-IP":"20.82.50.241","X-MHO-RoutePath":"aGVkY3NtdHA=","X-MHO-User":"e4f9875c-493c-11f1-8f51-f54febe22707","X-Report-Abuse-To":"\n https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information","X-Mail-Handler":"DuoCircle Outbound SMTP","CFBL-Feedback-ID":"e4f9875c-493c-11f1-8f51-f54febe22707:9","CFBL-Address":"prvs=058643e936=abuse@outbound.mailhop.org; report=arf","From":"Holger Brunck ","To":"netdev@vger.kernel.org","Cc":"linuxppc-dev@lists.ozlabs.org,\n\tandrew+netdev@lunn.ch,\n\tchleroy@kernel.org,\n\tqiang.zhao@nxp.com,\n\thorms@kernel.org,\n\tkuba@kernel.org,\n\tHolger Brunck ","Subject":"[PATCH v2 net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","Date":"Wed, 6 May 2026 13:15:29 +0200","Message-ID":"<20260506111529.2919079-1-holger.brunck@hitachienergy.com>","X-Mailer":"git-send-email 2.52.0.120.gb31ab939fe","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"When the device is removed all allocated resources should be freed.\nIn uhdlc_memclean the netdev transmit queue was already stopped. But at\nthis point we may have pending skb in the transmit queue which must be\nfreed. Therefore iterate over the tx_skbuff pointers and free all\npending skb. The issue was discovered by sashiko.\n\nhttps://sashiko.dev/#/patchset/20260429114208.941011-1-holger.brunck%40hitachienergy.com\nFixes: c19b6d246a35 (\"drivers/net: support hdlc function for QE-UCC\")\nSigned-off-by: Holger Brunck \n---\nv2: - use dev_kfree_skb instead of kfree\n - improve commit message\n - add missing paramter in for statement\nv1: https://lore.kernel.org/linuxppc-dev/20260504161145.2217950-1-holger.brunck@hitachienergy.com/\n\n drivers/net/wan/fsl_ucc_hdlc.c | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c\nindex bc7c2e9e6554..417e8e4c111f 100644\n--- a/drivers/net/wan/fsl_ucc_hdlc.c\n+++ b/drivers/net/wan/fsl_ucc_hdlc.c\n@@ -739,6 +739,8 @@ static int uhdlc_open(struct net_device *dev)\n \n static void uhdlc_memclean(struct ucc_hdlc_private *priv)\n {\n+\tint i;\n+\n \tqe_muram_free(ioread16be(&priv->ucc_pram->riptr));\n \tqe_muram_free(ioread16be(&priv->ucc_pram->tiptr));\n \n@@ -769,6 +771,11 @@ static void uhdlc_memclean(struct ucc_hdlc_private *priv)\n \tkfree(priv->rx_skbuff);\n \tpriv->rx_skbuff = NULL;\n \n+\tfor (i = 0; i < TX_BD_RING_LEN; i++) {\n+\t\tdev_kfree_skb(priv->tx_skbuff[i]);\n+\t\tpriv->tx_skbuff[i] = NULL;\n+\t}\n+\n \tkfree(priv->tx_skbuff);\n \tpriv->tx_skbuff = NULL;\n \n","prefixes":["v2","net"]}