{"id":2233402,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2233402/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/20260506110309.1599633-1-ubizjak@gmail.com/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.1/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260506110309.1599633-1-ubizjak@gmail.com>","date":"2026-05-06T11:03:03","name":"stdbit: Fix builtin name used in __glibc_has_builtin check for rotate_right","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"664fe2692cd285809bb106c69f7b8680cb07533c","submitter":{"id":808,"url":"http://patchwork.ozlabs.org/api/1.1/people/808/?format=json","name":"Uros Bizjak","email":"ubizjak@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20260506110309.1599633-1-ubizjak@gmail.com/mbox/","series":[{"id":502970,"url":"http://patchwork.ozlabs.org/api/1.1/series/502970/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=502970","date":"2026-05-06T11:03:03","name":"stdbit: Fix builtin name used in __glibc_has_builtin check for rotate_right","version":1,"mbox":"http://patchwork.ozlabs.org/series/502970/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233402/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233402/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","libc-alpha@sourceware.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","libc-alpha@sourceware.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=FRHXU+3y;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=FRHXU+3y","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","sourceware.org;\n arc=none smtp.remote-ip=2a00:1450:4864:20::32e"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9XZD6LL7z1y04\n\tfor ; Wed, 06 May 2026 21:04:04 +1000 (AEST)","from vm01.sourceware.org (localhost [IPv6:::1])\n\tby sourceware.org (Postfix) with ESMTP id E4E984BA798E\n\tfor ; Wed, 6 May 2026 11:04:02 +0000 (GMT)","from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n [IPv6:2a00:1450:4864:20::32e])\n by sourceware.org (Postfix) with ESMTPS id 5D70E4BA2E33\n for ; Wed, 6 May 2026 11:03:22 +0000 (GMT)","by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-488b0e1b870so97116215e9.2\n for ; Wed, 06 May 2026 04:03:22 -0700 (PDT)","from fedora ([193.77.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48e530fdc50sm21841005e9.5.2026.05.06.04.03.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 06 May 2026 04:03:19 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org E4E984BA798E","OpenDKIM Filter v2.11.0 sourceware.org 5D70E4BA2E33"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 5D70E4BA2E33","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 5D70E4BA2E33","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778065402; cv=none;\n b=CCnSz/fm93YoReydQ7x1h0sRm3AVcIKpsIci4AgGt3tKKpIdePYLiM5g9bajDVJ1jXak+IFvzubWE1jwJS69hlfUcZ3R29EXFuHV73O074U2ccjhu7FmLaSy+ApAnVNisTMPPqbynhEFIowzs9T4S9yjbm8YHlRTq/dZPZbYTRo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1778065402; c=relaxed/simple;\n bh=v1RJcu8LtJ2qep/SSy0tD2LsQ6/zYAxIivYRyKrVego=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=ZrtcCXVzXBlqDk/U2GjngbViPjrWaIbBTpSiKxKPKR6gRHAjDaQ2EF9ptBZYR6+LVvZ3+G+Cw9IVK0tloEHfCmoeqeSsHXzIsF1BbIYDTz+ro7c09ktnXHH8ZeEfoQH190gUWKRNCj64VwQSS2FSUuJf2FB2w2YcIFarVt6ljHA=","ARC-Authentication-Results":"i=1; sourceware.org;\n dkim=pass (2048-bit key, unprotected)\n header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104\n header.b=FRHXU+3y","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1778065401; x=1778670201; darn=sourceware.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=cUWOB464B51JWzgS0wu9s3s5sDEUcOh6ArKkuvDGdTU=;\n b=FRHXU+3yL9bUyna+QqAjQ64ABIaC02DwNOr8SptI7MMMABptpdLEE74QODPfidKJW4\n 5q9fpGcxvKX5Fa9RrlwHz4NDSA2dVzKN3kds77EC5JhbPS6rLBHH+uspTPKGRCPCd3ca\n Afus93FJUCbuwdqqNkiekwreCJ392sMuEvugwwkNEeAPxT/pgZCMQd7wa+t/lUiP2FbR\n 5ea+rOgT39gxG8t/bDPnCVv7hgyrbB/T4v0nxiVKQKuhLJyAmEoZeXfY+Brf/RJU6SGt\n jLedKFeEqfqCFNAvXugjAwqAPVEh9Oq2q7pZfkks3K3xa/zo5KwzQFHeIh4RC2OJjbKs\n XSKQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778065401; x=1778670201;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=cUWOB464B51JWzgS0wu9s3s5sDEUcOh6ArKkuvDGdTU=;\n b=OnSM08w/qcLxrWHMxPA9hFlgQ7QMKz3seVzIfPTKHMgPO6pdqCUx/z4WHJOYY3Vrwi\n V21NsGClR/D4A22C1z3WE6ebxrbvW1uazQoikdiz+ZI+kdh70+HnDRJpYU7poeXwcQ7o\n ftfBNk/zum8XamfkF4UDcHOlVvZ5CUHS8EFd0cBEiCG+rDOJlNvdvhoEPXXDF488id/1\n 3LMFKP/Yq5OogqkUTmawQUFRBDVYcprt/pTVTSZBbPbmORkRdwMdiZphDteslf3zOl23\n MGzS6J8Ypiy0CU3DLPGQpgUb5FVSHdJFXPXatg4ChIIW7hneDOSbrhmltalPbHz7xMYU\n DYCQ==","X-Gm-Message-State":"AOJu0Yya1lXGBlp+6Z8xHifGhwUqwh/ykEaqBricuWlMVTF51WEKLOPa\n anM6bb5GYqEg4gGCUPejueX132UqKVxj+dylXL+ofndwahC0sko9cfTRYVlSvw8A","X-Gm-Gg":"AeBDieuMokTd+uM/iKhzbubGsVV+PughpdD7yrgI2AgW+nnUkc7C+TUDbPQnA2d69el\n 4c6EHTXV6DHc7L8BPH6EXTvkvTqTea6b9/WKYJfiwjkwQhQCQqROBWeOozUVCdUxDVCaSuRsH1a\n MskMQBgaGuK3U2mVKP+tPPDCJiYXfNE1ny4FkhwrMoi97xvKkyDLN9vxvWcobRi+q7HZ3b2w041\n B5Z0RgFDS3YlwliWb7yAB42i3AOUTG56kbDLMJdjM/bI4v9zS+hy5ZjNZ+F/5TeZ7wc0BxKeFzR\n aGtYIEFOc02EM219GTdQgKlFq99nySslNBaZ29e9GJNWuBMl92jwmmTY+ATLitxgRSOXK+3jCw3\n cmYdBwmQpW/WVw7kTzr9IXb4EZwpJB+clhZsk/NWpQFg0bfrvvuwOlX9j6yN6HosY4kGzQqCA1W\n b2Qevqwewmp8AqNkvC7466apFTftdf6gWg7s5Pz/Ks1FQ1L4Sl/nKrW5I1kIRB8JQ1zs9jNSo/3\n D46fkeF7qb4uVD1lxYI7gaa2h793ll4glw3ga5CZNoomrgBmlB7VtY=","X-Received":"by 2002:a05:600c:47d3:b0:48d:c0a:3813 with SMTP id\n 5b1f17b1804b1-48e51e0bb62mr31700715e9.3.1778065400614;\n Wed, 06 May 2026 04:03:20 -0700 (PDT)","From":"Uros Bizjak ","To":"libc-alpha@sourceware.org","Cc":"Uros Bizjak ,\n Adhemerval Zanella ","Subject":"[PATCH] stdbit: Fix builtin name used in __glibc_has_builtin check\n for rotate_right","Date":"Wed, 6 May 2026 13:03:03 +0200","Message-ID":"<20260506110309.1599633-1-ubizjak@gmail.com>","X-Mailer":"git-send-email 2.54.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libc-alpha@sourceware.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Libc-alpha mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org"},"content":"The __glibc_has_builtin check in include/stdbit.h incorrectly refers to\n___builtin_stdc_rotate_right (with three leading underscores) instead of the\ncorrect __builtin_stdc_rotate_right (two leading underscores). As a result,\nthe builtin is not detected even when supported by the compiler.\n\nFix the spelling to use __builtin_stdc_rotate_right consistently in both the\nfeature test and the corresponding comment.\n\nFixes: 4adae8550a7a (\"stdlib: Add internal stdc_rotate_right implementation\")\nCc: Adhemerval Zanella \nSigned-off-by: Uros Bizjak \n---\n include/stdbit.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/include/stdbit.h b/include/stdbit.h\nindex 5be19b882e..863b0f8383 100644\n--- a/include/stdbit.h\n+++ b/include/stdbit.h\n@@ -5,8 +5,8 @@\n #ifndef _ISOMAC\n # include \n \n-# if __glibc_has_builtin (___builtin_stdc_rotate_right)\n-# define stdc_rotate_right(__x, __n) (___builtin_stdc_rotate_right (__x, __n))\n+# if __glibc_has_builtin (__builtin_stdc_rotate_right)\n+# define stdc_rotate_right(__x, __n) (__builtin_stdc_rotate_right (__x, __n))\n # define stdc_rotate_right_uc(__x, __n) (stdc_rotate_right (__x, __n))\n # define stdc_rotate_right_us(__x, __n) (stdc_rotate_right (__x, __n))\n # define stdc_rotate_right_ui(__x, __n) (stdc_rotate_right (__x, __n))\n@@ -62,7 +62,7 @@ __ror64_inline (uint64_t __x, unsigned int __n)\n # define stdc_rotate_right_ul(__x, __n) (__ror32_inline (__x, __n))\n # endif\n # define stdc_rotate_right_ull(__x, __n) (__ror64_inline (__x, __n))\n-# endif /* __glibc_has_builtin (___builtin_stdc_rotate_right) */\n+# endif /* __glibc_has_builtin (__builtin_stdc_rotate_right) */\n \n # endif /* _ISOMAC */\n \n","prefixes":[]}