{"id":2233395,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2233395/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260506105421.2461117-3-armbru@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260506105421.2461117-3-armbru@redhat.com>","date":"2026-05-06T10:54:19","name":"[2/4] qapi/net: Wean passt off QAPI type String to improve documentation","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e7a85e80ad99e3a8e758702d8e35b4f2ca91bd32","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/1.1/people/2645/?format=json","name":"Markus Armbruster","email":"armbru@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260506105421.2461117-3-armbru@redhat.com/mbox/","series":[{"id":502966,"url":"http://patchwork.ozlabs.org/api/1.1/series/502966/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502966","date":"2026-05-06T10:54:18","name":"qapi/net: Some doc improvement and cleanup","version":1,"mbox":"http://patchwork.ozlabs.org/series/502966/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233395/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233395/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=XKrFZK2N;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9XMb2v4Dz1yJV\n\tfor ; Wed, 06 May 2026 20:54:51 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKZtg-0006H3-SY; Wed, 06 May 2026 06:54:32 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wKZtf-0006Fu-KN\n for qemu-devel@nongnu.org; Wed, 06 May 2026 06:54:31 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wKZtd-0001ti-6m\n for qemu-devel@nongnu.org; Wed, 06 May 2026 06:54:31 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-BBw0piW9M0uNCPCfp4eE8Q-1; Wed,\n 06 May 2026 06:54:25 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 40AF6180056E; Wed, 6 May 2026 10:54:24 +0000 (UTC)","from blackfin.pond.sub.org (unknown [10.44.22.2])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id DB36B3002D2D; Wed, 6 May 2026 10:54:23 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n id 6E55A21E6A03; Wed, 06 May 2026 12:54:21 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1778064868;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=kP2BTTbO8J+G4Db6gps/2LWhFXSixwowFlBRgG0qrRI=;\n b=XKrFZK2NCHBYXaU3vcCyg2T4cFpTHN/qXXzm5x2GeeiDUKSUlie8R/k3H1uN5Suu7FWIKj\n 7Q6K/FSJBEZvvcHddDDiXDiOJ3dFbAG+4mfXQZ3oivj1mjlnDZfgmWIMrqL5yjjtUceW/E\n D3KHxkdKhWzF32PDmT/Jl//54dnsezg=","X-MC-Unique":"BBw0piW9M0uNCPCfp4eE8Q-1","X-Mimecast-MFC-AGG-ID":"BBw0piW9M0uNCPCfp4eE8Q_1778064864","From":"Markus Armbruster ","To":"qemu-devel@nongnu.org","Cc":"jasowang@redhat.com, lvivier@redhat.com, sbrivio@redhat.com,\n samuel.thibault@ens-lyon.org, marcandre.lureau@redhat.com","Subject":"[PATCH 2/4] qapi/net: Wean passt off QAPI type String to improve\n documentation","Date":"Wed, 6 May 2026 12:54:19 +0200","Message-ID":"<20260506105421.2461117-3-armbru@redhat.com>","In-Reply-To":"<20260506105421.2461117-1-armbru@redhat.com>","References":"<20260506105421.2461117-1-armbru@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.443,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"String's doc comment is useless. Replace its use in\nNetDevPasstOptions by identical types with hopefully useful\ndocumentation.\n\nSigned-off-by: Markus Armbruster \n---\n qapi/net.json | 43 +++++++++++++++++++++++++++++++++++++++----\n net/passt.c | 8 ++++----\n 2 files changed, 43 insertions(+), 8 deletions(-)","diff":"diff --git a/qapi/net.json b/qapi/net.json\nindex 8ed51b665c..45ee7ac7ff 100644\n--- a/qapi/net.json\n+++ b/qapi/net.json\n@@ -114,6 +114,41 @@\n 'data': {\n 'str': 'str' } }\n \n+##\n+# @PasstSearch:\n+#\n+# @str: DNS domain name suffix for host name lookup, or \"none\". See\n+# passt(1) option --search.\n+#\n+# Since: 1.2\n+##\n+{ 'struct': 'PasstSearch',\n+ 'data': {\n+ 'str': 'str' } }\n+\n+##\n+# @PasstPortForward:\n+#\n+# @str: passt port forwarding specification, see passt(1) option\n+# --tcp-ports and --udp-ports.\n+#\n+# Since: 10.1\n+##\n+{ 'struct': 'PasstPortForward',\n+ 'data': {\n+ 'str': 'str' } }\n+\n+##\n+# @PasstParameter:\n+#\n+# @str: Additional arguments for the passt executable, see passt(1)\n+#\n+# Since: 10.1\n+##\n+{ 'struct': 'PasstParameter',\n+ 'data': {\n+ 'str': 'str' } }\n+\n ##\n # @NetdevPasstOptions:\n #\n@@ -206,7 +241,7 @@\n '*outbound-if4': 'str',\n '*outbound-if6': 'str',\n '*dns': 'str',\n- '*search': ['String'],\n+ '*search': ['PasstSearch'],\n '*fqdn': 'str',\n '*dhcp-dns': 'bool',\n '*dhcp-search': 'bool',\n@@ -224,9 +259,9 @@\n '*freebind': 'bool',\n '*ipv4': 'bool',\n '*ipv6': 'bool',\n- '*tcp-ports': ['String'],\n- '*udp-ports': ['String'],\n- '*param': ['String'] },\n+ '*tcp-ports': ['PasstPortForward'],\n+ '*udp-ports': ['PasstPortForward'],\n+ '*param': ['PasstParameter'] },\n 'if': 'CONFIG_PASST' }\n \n ##\ndiff --git a/net/passt.c b/net/passt.c\nindex f1f59d50c4..53e0a4f444 100644\n--- a/net/passt.c\n+++ b/net/passt.c\n@@ -641,7 +641,7 @@ static GPtrArray *net_passt_decode_args(const NetdevPasstOptions *passt,\n }\n \n if (passt->has_search && passt->search) {\n- const StringList *list = passt->search;\n+ const PasstSearchList *list = passt->search;\n GString *domains = g_string_new(list->value->str);\n \n list = list->next;\n@@ -656,7 +656,7 @@ static GPtrArray *net_passt_decode_args(const NetdevPasstOptions *passt,\n }\n \n if (passt->has_tcp_ports && passt->tcp_ports) {\n- const StringList *list = passt->tcp_ports;\n+ const PasstPortForwardList *list = passt->tcp_ports;\n GString *tcp_ports = g_string_new(list->value->str);\n \n list = list->next;\n@@ -671,7 +671,7 @@ static GPtrArray *net_passt_decode_args(const NetdevPasstOptions *passt,\n }\n \n if (passt->has_udp_ports && passt->udp_ports) {\n- const StringList *list = passt->udp_ports;\n+ const PasstPortForwardList *list = passt->udp_ports;\n GString *udp_ports = g_string_new(list->value->str);\n \n list = list->next;\n@@ -686,7 +686,7 @@ static GPtrArray *net_passt_decode_args(const NetdevPasstOptions *passt,\n }\n \n if (passt->has_param && passt->param) {\n- const StringList *list = passt->param;\n+ const PasstParameterList *list = passt->param;\n \n while (list) {\n g_ptr_array_add(args, g_strdup(list->value->str));\n","prefixes":["2/4"]}