{"id":2233364,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2233364/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260506-backtalk-pregnant-ff4cbd27b4d0@spud/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.1/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260506-backtalk-pregnant-ff4cbd27b4d0@spud>","date":"2026-05-06T09:57:41","name":"[RFC,v1,3/4] pinctrl: spacemit: delete check_power()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a7b2dab5d009b785245c22d45de20cc11238a2e4","submitter":{"id":84372,"url":"http://patchwork.ozlabs.org/api/1.1/people/84372/?format=json","name":"Conor Dooley","email":"conor@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260506-backtalk-pregnant-ff4cbd27b4d0@spud/mbox/","series":[{"id":502949,"url":"http://patchwork.ozlabs.org/api/1.1/series/502949/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=502949","date":"2026-05-06T09:57:38","name":"generic pinmux dt_node_to_map implementation","version":1,"mbox":"http://patchwork.ozlabs.org/series/502949/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233364/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233364/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=sr9dxcpK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-36277-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"sr9dxcpK\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9WLr5MWqz1yJx\n\tfor ; Wed, 06 May 2026 20:09:08 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 23179306F17E\n\tfor ; Wed, 6 May 2026 09:59:42 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 882B541B34C;\n\tWed, 6 May 2026 09:58:17 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B14CA3FAE0C;\n\tWed, 6 May 2026 09:58:15 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 33148C2BCB8;\n\tWed, 6 May 2026 09:58:13 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778061495; cv=none;\n b=J5zS/R0/G20CA6puxC3QsZa/E13AaJPo4HcpA7o2A4Ej58UbN7Ge244JhPDsntN0ZsfcwShP8wyNXfB9XdPRiPRPEXYqSK1wcXhHDyAOH8eEfudcugjM/ToJsS/pTndIbG6jd4UOfA34mxWbSGHTO0tXy7dpfV3tJonZ6+pitK4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778061495; c=relaxed/simple;\n\tbh=swaIO29uhHgaslA4Hb1JIgdHX4IRPVdujCyvQCSGJPk=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=RMz1Wh33e+43cWUharXJQCd7625d11thbMeBnbiEoVY2KAOejDYsMkaZNhmdPSxI4giEhjgjcFwBJNHZ9Xd4oCvtCb7koOEDdFIMmtHjiibjab+IqMIkpD5dZ4cW6OIy5F+5XZin2BcaZ/K651/oOqAdcgdSDLyjLqXjbov0Nrs=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=sr9dxcpK; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778061495;\n\tbh=swaIO29uhHgaslA4Hb1JIgdHX4IRPVdujCyvQCSGJPk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=sr9dxcpKbkrPjay+PbxV7TxKARgnQeSvNiWdxHqqwTNyrWnN71FmZ69sBQgaLvVQf\n\t jfhZGtsQFIsRLl9k9OgRgPasiztvdv+jBiqTq/tE3N++VVFnbEA0A/ScgMxM5z2sl5\n\t Lp8N0kf+l218jEg7tFKPLbxLeN61EcUyvtV+ayG0qiG5LVUkhIwpdaCzCbcLJGqAFP\n\t SfwNY73hVH75Kab2ugZt3wkdwD5h2+LvAyOO2IeTRnNiuanHljXzrPGtD8GjTDZsqk\n\t 4WzHdhqekeI1A3CusbSWknRQ0nbkXvEVrWedGSn0fPEpinzyGbRdKeJBzY9aWjdpLa\n\t 1LlIf1TfxLL8Q==","From":"Conor Dooley ","To":"Linus Walleij ","Cc":"conor@kernel.org,\n\tConor Dooley ,\n\tYixun Lan ,\n\tTroy Mitchell ,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tlinux-riscv@lists.infradead.org,\n\tspacemit@lists.linux.dev","Subject":"[RFC v1 3/4] pinctrl: spacemit: delete check_power()","Date":"Wed, 6 May 2026 10:57:41 +0100","Message-ID":"<20260506-backtalk-pregnant-ff4cbd27b4d0@spud>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260506-energize-dramatize-051909e54256@spud>","References":"<20260506-energize-dramatize-051909e54256@spud>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2013;\n i=conor.dooley@microchip.com; h=from:subject:message-id;\n bh=f33zeKL5li7qyIF7zuSgaFGlrhBhLaxwN0tJ5RiB2fs=;\n b=owGbwMvMwCVWscWwfUFT0iXG02pJDJm/BSa/fc7zKjvqntBa9fW+u13t5l559yMkpVm8yHaN2\n g3T7R9CO0pZGMS4GGTFFFkSb/e1SK3/47LDuectzBxWJpAhDFycAjCRUl9Ghkb7K6GySfZHrVbE\n +nLKtcfcW7eaP9Uu1v5jRfmelg1TrBkZvodaMm5n71KetaAucPcL7fz3XefyfAtz+vpX7zLwdzf\n kBQA=","X-Developer-Key":"i=conor.dooley@microchip.com; a=openpgp;\n fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C","Content-Transfer-Encoding":"8bit"},"content":"From: Conor Dooley \n\nAFAICT, this is pointless because generate_config performs this check\ntoo.\n\nSigned-off-by: Conor Dooley \n---\n drivers/pinctrl/spacemit/pinctrl-k1.c | 37 ---------------------------\n 1 file changed, 37 deletions(-)","diff":"diff --git a/drivers/pinctrl/spacemit/pinctrl-k1.c b/drivers/pinctrl/spacemit/pinctrl-k1.c\nindex 62cab6f6cd0a8..41d8a34bc386b 100644\n--- a/drivers/pinctrl/spacemit/pinctrl-k1.c\n+++ b/drivers/pinctrl/spacemit/pinctrl-k1.c\n@@ -409,38 +409,6 @@ static inline u32 spacemit_get_drive_strength_mA(enum spacemit_pin_io_type type,\n \t}\n }\n \n-static int spacemit_pctrl_check_power(struct pinctrl_dev *pctldev,\n-\t\t\t\t struct device_node *dn,\n-\t\t\t\t struct spacemit_pin_mux_config *pinmuxs,\n-\t\t\t\t int num_pins, const char *grpname)\n-{\n-\tstruct spacemit_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);\n-\tstruct device *dev = pctrl->dev;\n-\tenum spacemit_pin_io_type type;\n-\tu32 power = 0, i;\n-\n-\tof_property_read_u32(dn, \"power-source\", &power);\n-\n-\tfor (i = 0; i < num_pins; i++) {\n-\t\ttype = spacemit_to_pin_io_type(pinmuxs[i].pin);\n-\n-\t\tif (type != IO_TYPE_EXTERNAL)\n-\t\t\tcontinue;\n-\n-\t\tswitch (power) {\n-\t\tcase PIN_POWER_STATE_1V8:\n-\t\tcase PIN_POWER_STATE_3V3:\n-\t\t\tbreak;\n-\t\tdefault:\n-\t\t\tdev_err(dev, \"group %s has unsupported power\\n\",\n-\t\t\t\tgrpname);\n-\t\t\treturn -ENOTSUPP;\n-\t\t}\n-\t}\n-\n-\treturn 0;\n-}\n-\n static void spacemit_set_io_pwr_domain(struct spacemit_pinctrl *pctrl,\n \t\t\t\t const struct spacemit_pin *spin,\n \t\t\t\t const enum spacemit_pin_io_type type)\n@@ -548,11 +516,6 @@ static int spacemit_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev,\n \t\t\t\treturn dev_err_probe(dev, -ENODEV, \"failed to get pin %d\\n\", pins[i]);\n \t\t}\n \n-\t\tret = spacemit_pctrl_check_power(pctldev, child, pinmuxs,\n-\t\t\t\t\t\t npins, grpname);\n-\t\tif (ret < 0)\n-\t\t\treturn ret;\n-\n \t\tmap[nmaps].type = PIN_MAP_TYPE_MUX_GROUP;\n \t\tmap[nmaps].data.mux.function = np->name;\n \t\tmap[nmaps].data.mux.group = grpname;\n","prefixes":["RFC","v1","3/4"]}