{"id":2233339,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2233339/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260506090508.2109034-5-elibr@nvidia.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.1/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs"},"msgid":"<20260506090508.2109034-5-elibr@nvidia.com>","date":"2026-05-06T09:05:08","name":"[ovs-dev,v1,4/4] tests: Fix VF name restore.","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f1a7ea29b9e8e0a3f943a5b32ac39993ef0ed8b7","submitter":{"id":79848,"url":"http://patchwork.ozlabs.org/api/1.1/people/79848/?format=json","name":"Eli Britstein","email":"elibr@nvidia.com"},"delegate":{"id":75123,"url":"http://patchwork.ozlabs.org/api/1.1/users/75123/?format=json","username":"echaudron","first_name":"Eelco","last_name":"Chaudron","email":"echaudro@redhat.com"},"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260506090508.2109034-5-elibr@nvidia.com/mbox/","series":[{"id":502941,"url":"http://patchwork.ozlabs.org/api/1.1/series/502941/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=502941","date":"2026-05-06T09:05:05","name":"Robust dpdk-offload tests.","version":1,"mbox":"http://patchwork.ozlabs.org/series/502941/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233339/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2233339/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=eHw6DYQs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp1.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key,\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=eHw6DYQs","smtp1.osuosl.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9TyQ2Vtzz1yJx\n\tfor ; Wed, 06 May 2026 19:06:22 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id E950C82372;\n\tWed, 6 May 2026 09:06:19 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id sy-I-bSk7Zd8; Wed, 6 May 2026 09:06:19 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id ECBB882328;\n\tWed, 6 May 2026 09:06:18 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id D6907C04EB;\n\tWed, 6 May 2026 09:06:18 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 4E60AC04EB\n for ; Wed, 6 May 2026 09:06:18 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 0E00F82328\n for ; Wed, 6 May 2026 09:06:04 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id iTJXQZ2BLA_q for ;\n Wed, 6 May 2026 09:06:03 +0000 (UTC)","from PH0PR06CU001.outbound.protection.outlook.com\n (mail-westus3azlp170110003.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c107::3])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 826BD8235C\n for ; Wed, 6 May 2026 09:06:02 +0000 (UTC)","from BL1P223CA0002.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:2c4::7)\n by LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.15; Wed, 6 May\n 2026 09:05:55 +0000","from BN1PEPF00006002.namprd05.prod.outlook.com\n (2603:10b6:208:2c4:cafe::f9) by BL1P223CA0002.outlook.office365.com\n (2603:10b6:208:2c4::7) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9870.25 via Frontend Transport; Wed,\n 6 May 2026 09:05:55 +0000","from mail.nvidia.com (216.228.117.161) by\n BN1PEPF00006002.mail.protection.outlook.com (10.167.243.234) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9891.9 via Frontend Transport; Wed, 6 May 2026 09:05:55 +0000","from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 6 May\n 2026 02:05:37 -0700","from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 6 May\n 2026 02:05:35 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org ECBB882328","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 826BD8235C"],"Received-SPF":["Pass (mailfrom) identity=mailfrom;\n client-ip=2a01:111:f403:c107::3;\n helo=ph0pr06cu001.outbound.protection.outlook.com;\n envelope-from=elibr@nvidia.com; receiver=","Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 826BD8235C","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=nc8OejbLPCv6T3u2yndhZ9rceG6Y84Ak+Alyx+xhS8GBbJNc1iQUrmqIKT2b/knhbx1xp34H993uAcpAT2IZHDH9MyWoNV+8lWiqMihXoNcmzNwiqvi5XJlEJ5GrTGXOqJY0Ll4PAO9LxrN2YuP+4TAcJxzwPwVJ+6MW+okSN/6gCUs7v/B+8iX5X7XocLaheNOzqJSE4qQdNUqOGTi7pIFZDMIIEVL9ZPC3ReBRo9cFWXbpxX9RkKKVXOJY8Ydhgv5RFTXddyvVu1m6s++ppoFlTkdSniUR5oF0iA/l0lzHiHr0aItSRru06NtbDKno1m7Sqi5PoKuZtmCb0WlLeA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=iTVF7EVTSq6FdbD69sMOXOS6cfBQL8DT1QXGq/X/br0=;\n b=bRRyCSd7P5OhpublI/LOsGTHBPF8VvdOWne2Aaz6BAQu+EUDxUPKYASmWedmDkIfQDyGZxp72F/aGx5WOajStsNZKeKOszp1X+bW1ONZ6DDRs96mDgvoQVWL9RgEa5z7dJwH3TFtsiUM9UAGnJXLajX/L7wbkcFoC/Oj50B4/vNJZw4h04WrGihvEfqcF40o6oJjX+LVSGz6kC4F5eMW9Mbp9ViY/EzAX5qxIqlQjAM2Wengt0mS5bkN37QDVf+8FUBLxjZbuP01TmGtbLXDDT9qnx4D3F43IN0TdCMcT8dMpA2CPpi4FfXp6QulmlOzp0wgU2B3OdNfb3d5dKmJUQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=iTVF7EVTSq6FdbD69sMOXOS6cfBQL8DT1QXGq/X/br0=;\n b=eHw6DYQs+OOACRHdVJASOQawiQlSUML9THipOfEdZ8wFNGRfthkXSTW+8ZoUxev4FP2lV2amZq2XtpmmTkogCusl4Crj0KU0N+6jTJoX2F06r3c9TcUR9Z2lxLhYItAEecvd2Q5MxVkhs+1F/9tG9Sa2mT25aT+sPTQGErQs3m+zz4crgLTFfoqTKExxkbnm4umkZSJ1hyH6mrcOYTTVhzyj14nmCFiCDRxnU3dKKWv2RJ5Fel0D5oOkO+fWj/0suGdq1U0UNyabbN9uw2/2NvDWIbwuHj38K4G2lcMFkbdNMyU/MS37bYx30wR3IB5GTu5ikAilafkfDCegFvrGZQ==","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;","From":"Eli Britstein ","To":", Eelco Chaudron ","Date":"Wed, 6 May 2026 12:05:08 +0300","Message-ID":"<20260506090508.2109034-5-elibr@nvidia.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260506090508.2109034-1-elibr@nvidia.com>","References":"<20260506090508.2109034-1-elibr@nvidia.com>","MIME-Version":"1.0","X-Originating-IP":"[10.126.231.37]","X-ClientProxiedBy":"rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"BN1PEPF00006002:EE_|LV8PR12MB9620:EE_","X-MS-Office365-Filtering-Correlation-Id":"f238711f-7ca2-4349-2f13-08deab4eae94","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|376014|82310400026|36860700016|1800799024|56012099003|18002099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n Re/aHfUFs9S1DpkaxGoMi36lr+GSTmxmlTQXJYEpwX8MrDtoCtpivAzkBviZjBb0rodcL08T2aXoY7GTlYOYt9hd4joZKed/9b+lhVy117QeoKT5DyxJkDdouXAFRXbXmMG5dJYhI94dBtxppdoK7U6I9zwTpVlWS1mBG5kPU5y0kcWdhJCgOPONLsGVHF9x31hlEcc3nSDRPTKmTRoZBgBfZQCdpJ99bvRyHNbhVjo2KVWR19CmZgyKGORjJpiJLftGRHhhi7sJpHZ45M1XHwp6wVC6uEt0HVJEb0cXhuKOsooHjNY1+LO8dPjBFkJ64o90KyENts0sU8b0DCLcsrZsTEvWGRISHc3Wg73qP52wKMCH15rElVGXOOx2Pz59i7WGk9lV5yyeT/XCAcSbtg1/IXdKsJ/Mw6Ar9rpfhRJG6JPvuOr3ETRSsOnsziEgnbhcmpvsdpXxdatIBeszDisQMy/keTVw128+3EtP5xoi2Eau1l6rP5dDbwIw5jsrI0+f9tE3F3PVO0xBDcF6voTOz2It4laRmAIjS6SG4JMFChHMTVtgw+ux385tAkLFSA6J3soV4a7s4F63X8oZ/wfqwym7oKNAnGSV+tViz2050q6I1zmL+b//3++kK6R1zsgXf66ZwxNJKAh9KJu5fmumQmJWakZ9Yt2/SdBPEPcmSZBIVFmyteGxVCo4dow+VUu4/I3MUjN37vK2Kr4lkIb71L2Ovce7vw7Nl54e9q8=","X-Forefront-Antispam-Report":"CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230040)(376014)(82310400026)(36860700016)(1800799024)(56012099003)(18002099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n QCm6FnGVajDT27YWFJMcNc8QdXZAwv+AKGmHbteaeTWKBadVPlRvbFJxFo6KfyjHT7uIRjUMx0o3TnynAn/JzqIkS1l7aXjnQAYne/2UE06pi62owCFTX8TcAPTnirttaAbM1aYhmWh+Xerry/H2FXioZqFsM91fxtDaEsz8hmBXuCcRxSqUTsHGWNUHclOBY5tLtJ8gr6YJP/B04E1LvGpkJfQrqqVOmD4IIUC54lcVQZ4ofDhyiKxtyRyYngpCLFiLp3VtrALn5/P6CFf7/hyp6gz4cc54kD69HLQoWeaOCs4OX97NREcJBwsEMP/F0OyX2ZeNi5aT3HMw0perW2k2MQ/Ho82obyRkyeeeUirA72ASe122whyWRpl86WoAdtShdJIHRcwFXsgfvhH0agoPMJXrkOhM1Ne/7mzzv+y8R746r7E6/4Z2un9Blor8","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"06 May 2026 09:05:55.6057 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n f238711f-7ca2-4349-2f13-08deab4eae94","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n BN1PEPF00006002.namprd05.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"LV8PR12MB9620","Subject":"[ovs-dev] [PATCH v1 4/4] tests: Fix VF name restore.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Eli\n Britstein , Maor Dickman ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"ADD_VF is invoked N times, each time $VF is overwritten.\nThe restore of the first N-1 VF devices is incorrect. To fix it, keep\nthe original name in ORIG_ file, and use it for the restore.\n\nHarden tear-down with stderr discarded and `|| true` so missing objects or races\nduring cleanup do not fail the suite under `set -e`.\n\nFixes: 289e9f6baa7c (\"tests: Add a simple DPDK rte_flow test framework.\")\nSigned-off-by: Eli Britstein \n---\n tests/system-dpdk-offloads-macros.at | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)","diff":"diff --git a/tests/system-dpdk-offloads-macros.at b/tests/system-dpdk-offloads-macros.at\nindex 2a4591ced..c6a9ed053 100644\n--- a/tests/system-dpdk-offloads-macros.at\n+++ b/tests/system-dpdk-offloads-macros.at\n@@ -118,7 +118,7 @@ m4_define([ADD_VF],\n AT_CHECK([ip link set $VF down])\n dnl If a prior run left $1 as an altname, rename fails with \"File exists\".\n AT_CHECK([ip link property del dev $VF altname $1 2>/dev/null || true])\n- AT_CHECK([ip link set $VF name $1])\n+ AT_CHECK([ip link set $VF name $1 && printf '%s\\n' \"$VF\" > ORIG_$1])\n AT_CHECK([ip link set $1 netns $2])\n AT_CHECK([ovs-vsctl add-port $3 ovs-$1 -- \\\n set interface ovs-$1 external-ids:iface-id=\"$1\" -- \\\n@@ -136,9 +136,15 @@ m4_define([ADD_VF],\n if test -n \"$6\"; then\n NS_CHECK_EXEC([$2], [ip route add default via $6])\n fi\n- on_exit \"ip netns exec $2 ip link set $1 netns 1; \\\n- ip link property del dev $1 altname $VF; \\\n- ip link set $1 name $VF\"\n+ on_exit \"orig=\\$(cat ORIG_$1 2>/dev/null); \\\n+ rm -f ORIG_$1 2>/dev/null || true; \\\n+ ip netns exec $2 ip link set $1 netns 1 2>/dev/null || true; \\\n+ ip link property del dev \\\"\\$orig\\\" altname $1 2>/dev/null || true; \\\n+ ip link property del dev $1 altname \\\"\\$orig\\\" 2>/dev/null || true; \\\n+ ip link set $1 down 2>/dev/null || true; \\\n+ if test \\\"\\$orig\\\"; then \\\n+ ip link set $1 name \\\"\\$orig\\\" 2>/dev/null || true; \\\n+ fi\"\n ]\n )\n m4_define([ADD_VETH], [ADD_VF($@)])\n","prefixes":["ovs-dev","v1","4/4"]}