{"id":2233241,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2233241/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260504062257.77460-1-devnexen@gmail.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260504062257.77460-1-devnexen@gmail.com>","date":"2026-05-04T06:22:57","name":"ixgbe: E610: do not fill EEE lp_advertised from local PHY caps","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0d5e31fe695ed1209a118c99e76f65d9924e965e","submitter":{"id":76714,"url":"http://patchwork.ozlabs.org/api/1.1/people/76714/?format=json","name":"David Carlier","email":"devnexen@gmail.com"},"delegate":{"id":109701,"url":"http://patchwork.ozlabs.org/api/1.1/users/109701/?format=json","username":"anguy11","first_name":"Anthony","last_name":"Nguyen","email":"anthony.l.nguyen@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260504062257.77460-1-devnexen@gmail.com/mbox/","series":[{"id":502904,"url":"http://patchwork.ozlabs.org/api/1.1/series/502904/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=502904","date":"2026-05-04T06:22:57","name":"ixgbe: E610: do not fill EEE lp_advertised from local PHY caps","version":1,"mbox":"http://patchwork.ozlabs.org/series/502904/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233241/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233241/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=1eAPeCHQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9D500qFvz1yJx\n\tfor ; Wed, 06 May 2026 08:41:05 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 63E6640C3C;\n\tTue, 5 May 2026 22:41:03 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id yybySLaqI6gt; Tue, 5 May 2026 22:41:02 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id D5F8E40C41;\n\tTue, 5 May 2026 22:41:02 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 714CA204\n for ; Mon, 4 May 2026 06:23:04 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 5C27C416E5\n for ; Mon, 4 May 2026 06:23:04 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Di6tBzi-UEQT for ;\n Mon, 4 May 2026 06:23:03 +0000 (UTC)","from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n [IPv6:2a00:1450:4864:20::333])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 7C505416D2\n for ; Mon, 4 May 2026 06:23:03 +0000 (UTC)","by mail-wm1-x333.google.com with SMTP id\n 5b1f17b1804b1-48896199cbaso32710965e9.1\n for ; Sun, 03 May 2026 23:23:03 -0700 (PDT)","from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a81b99127sm297500385e9.0.2026.05.03.23.22.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 03 May 2026 23:23:00 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org D5F8E40C41","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7C505416D2"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1778020862;\n\tbh=SsKY674gEcmVloxh8QcPPtKruXs8CJmiJS+7itrX6N0=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=1eAPeCHQwGKWonckF62WH5sEe6x+YuIOX4xLzcoXsD+w6ZIRy7q+Mdq0KrnjFipGL\n\t MkuW5ycLXc6RDwSqlClWFecwop2HMXrJoNzkXTzeV3fBdwVAgZzQD6jdnVZA3pS0QP\n\t tcbVr3aMhXoqUOI6ir97MLnkQ0BJOSvCVAA6McVf1sOOpyN3QiBVEL/xGWuI1ZbQLh\n\t TLBLRl7/FUovgViwLp4N+YXP6E3WkGoF+9gAQMWDWMpIv975uDu3kRvtByXPkrJ4OK\n\t gvP0rB+foKEIrbC+86R0EoQjMYmUJqKZ2XUh1jaEs1hxh4Y3vf0CgXeEzF7HM9uJOO\n\t e+vSSDUQ3ys3A==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2a00:1450:4864:20::333; helo=mail-wm1-x333.google.com;\n envelope-from=devnexen@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 7C505416D2","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777875781; x=1778480581;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=SsKY674gEcmVloxh8QcPPtKruXs8CJmiJS+7itrX6N0=;\n b=kiCzc70mzSgrkk20WEDcAv4Uf5XXUWdKs+ezfzmJW4YXVX3/HIzJZVNV6F+yPQDrXV\n Sixqn5RjFXptsucHCOxUykM/NxLuhRQxt1kh6cT2Ces0jxF0w7tfgTZNeFoetq60e0BM\n f2WmrO0WKZASrPvB6p6+P8/TJUG7orqg+xX3EPLaAc96fpd5jcYgDE3q+w52ubvjQJqs\n sxJF14zzZ1f0XRx6m9f84KiKM0D/HpB3MJXsC57JFkDhDBZPjOZZUwJ0eVsLgrm5Knps\n k3P7wzJtcg1Z+1W5yCrHXznYNtgbeOlidxSaLvAcQc2518DdsFQ8IvkUhh4IUyNNk/rJ\n lPFA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8IqsIOsTwliOmWhCPhIYlK7uPekAuBRClVIVGzZns8GgEkdY7iq1hyLZuqZ4aHDQi2L4Y320oMvN++6ADyYLI=@lists.osuosl.org","X-Gm-Message-State":"AOJu0YwumEsIXiojY1fN/mPssgqSGIk8Z9A2RftKESKA9fbzZ+ufs+Mj\n Fl+HKcSkPmDTiuiSfzLYmx1XBnsRkR6TXTxQtT/JGAnxFMST/ekGgvpu","X-Gm-Gg":"AeBDiesbOaxFUfHz/yB472/UIk/UXHzFqiKmyPbGLNlOtWzDmf3Z+4b8yXVXzgI1gKG\n 1Ho2bQWpkMjnQswZWAHENzEH6Ka9w038nZ1UMfz10htIm4j0/0EqzF6/SdgnNCpXOHLiQ4cd89z\n QDZGTmXpkGWjQfDV6UmvhdtzqVEwQLI0am3wpG/wKpmXR5j1pJiNLPnxA+0WlZN7zEPcfYh1aFD\n ixCRjty6zLgr5S0RTCkE9FRTKsMPAbTlJkA2lQzRtkiHF/SlfREOWh6bqYaqZe3fLc1s1G3Czub\n vlwsWNmysi10XrAC7MM0OHaVMpBTtpWmxcrEq5NjkeRD1gWmlIjirGtQbU1zF6iVN669eoKKo/j\n MWeEGbXIjGzh+zuHzYww9qaJaKoXu2s6qQJIIX6DmPabc5/RlI1uTBTOY0vfk6y8xrCJgnQcHn4\n XLGPlxS5yf6TwmsQcUHBSpyThS005M377VEo0VHoav0yyTpZ/YiyFiCJJ8e/QxRaFAjybervz20\n wIlBG7YXXGFlzEGvFL+3w==","X-Received":"by 2002:a05:600c:8590:b0:489:1f3e:5f6f with SMTP id\n 5b1f17b1804b1-48a98636c00mr95678385e9.12.1777875780935;\n Sun, 03 May 2026 23:23:00 -0700 (PDT)","From":"David Carlier ","To":"Tony Nguyen ,\n Przemek Kitszel ,\n Andrew Lunn ,\n \"David S. Miller\" ,\n Eric Dumazet , Jakub Kicinski ,\n Paolo Abeni ,\n Jedrzej Jagielski ,\n Aleksandr Loktionov ,\n Jacob Keller , intel-wired-lan@lists.osuosl.org,\n netdev@vger.kernel.org, linux-kernel@vger.kernel.org","Cc":"David Carlier ","Date":"Mon, 4 May 2026 07:22:57 +0100","Message-ID":"<20260504062257.77460-1-devnexen@gmail.com>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Approved-At":"Tue, 05 May 2026 22:41:01 +0000","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777875781; x=1778480581; darn=lists.osuosl.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=SsKY674gEcmVloxh8QcPPtKruXs8CJmiJS+7itrX6N0=;\n b=J3Zo3Z8NAL5K1VSV8VFHdAtvOr/b886p1ho0ETqdU3E6EyLbLTDfBLRe6ipQI3dGJ+\n GG6ufyBbwRcDhnCdju0UjL3gvHRXo+oMcnxBSPsNVO+K9ju5PZ66/OykklmW69CvLJqh\n gZGFxH0VVqpKW1B4JFrtnKxYX2p0Xa/RXQV7LhxYdaEq8DQavP59tGJb5dKZLCSzBc0s\n V3o89OpW5W9OPamYL9G72HNqiSx67NGWlXKCCXI5QniNFYPa7YSztx9dMnMLixt4CUNw\n MSyCNw+mwKzTj+iQ70/au80c3Ehw5LFl3YWeeh+jgtlBdgEjnpTWA4kiZ64QI456GfNc\n Rqqg==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=gmail.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=J3Zo3Z8N"],"Subject":"[Intel-wired-lan] [PATCH] ixgbe: E610: do not fill EEE\n lp_advertised from local PHY caps","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"ixgbe_get_eee_e610() fills kedata->lp_advertised from pcaps.eee_cap\nreturned by ixgbe_aci_get_phy_caps() with IXGBE_ACI_REPORT_ACTIVE_CFG.\nThat report mode (and the other IXGBE_ACI_REPORT_* modes) describe the\nlocal PHY only, not the link partner. The X550 path uses a separate\nFW_PHY_ACT_UD_2 activity for partner data; the E610 ACI has no\nequivalent.\n\nLeave lp_advertised zeroed via the existing linkmode_zero() and drop\nthe now-unused ixgbe_eee_cap_map[]. eee_active/eee_enabled are\nunaffected (sourced from link.eee_status).\n\nFixes: b61dbdeff3a9 (\"ixgbe: E610: add EEE support\")\nSigned-off-by: David Carlier \n---\n .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 20 -------------------\n 1 file changed, 20 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\nindex 6990fe53f049..36e43b5e88d1 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n@@ -3558,17 +3558,6 @@ static const struct {\n \t{ FW_PHY_ACT_UD_2_10G_KR_EEE, ETHTOOL_LINK_MODE_10000baseKR_Full_BIT},\n };\n \n-static const struct {\n-\tu16 eee_cap_bit;\n-\tu32 link_mode;\n-} ixgbe_eee_cap_map[] = {\n-\t{ IXGBE_ACI_PHY_EEE_EN_100BASE_TX, ETHTOOL_LINK_MODE_100baseT_Full_BIT },\n-\t{ IXGBE_ACI_PHY_EEE_EN_1000BASE_T, ETHTOOL_LINK_MODE_1000baseT_Full_BIT },\n-\t{ IXGBE_ACI_PHY_EEE_EN_10GBASE_T, ETHTOOL_LINK_MODE_10000baseT_Full_BIT },\n-\t{ IXGBE_ACI_PHY_EEE_EN_5GBASE_T, ETHTOOL_LINK_MODE_5000baseT_Full_BIT },\n-\t{ IXGBE_ACI_PHY_EEE_EN_2_5GBASE_T, ETHTOOL_LINK_MODE_2500baseT_Full_BIT },\n-};\n-\n static int ixgbe_validate_keee(struct net_device *netdev,\n \t\t\t struct ethtool_keee *keee_requested)\n {\n@@ -3645,7 +3634,6 @@ static int ixgbe_get_eee_e610(struct net_device *netdev,\n \tstruct ixgbe_aci_cmd_get_phy_caps_data pcaps;\n \tstruct ixgbe_hw *hw = &adapter->hw;\n \tstruct ixgbe_link_status link;\n-\tu16 eee_cap;\n \tint err;\n \n \tlinkmode_zero(kedata->lp_advertised);\n@@ -3670,14 +3658,6 @@ static int ixgbe_get_eee_e610(struct net_device *netdev,\n \tif (kedata->eee_enabled)\n \t\tkedata->tx_lpi_timer = le16_to_cpu(pcaps.eee_entry_delay);\n \n-\teee_cap = le16_to_cpu(pcaps.eee_cap);\n-\n-\tfor (int i = 0; i < ARRAY_SIZE(ixgbe_eee_cap_map); i++) {\n-\t\tif (eee_cap & ixgbe_eee_cap_map[i].eee_cap_bit)\n-\t\t\tlinkmode_set_bit(ixgbe_eee_cap_map[i].link_mode,\n-\t\t\t\t\t kedata->lp_advertised);\n-\t}\n-\n \tfor (int i = 0; i < ARRAY_SIZE(ixgbe_ls_map); i++) {\n \t\tif (hw->phy.eee_speeds_supported &\n \t\t ixgbe_ls_map[i].mac_speed)\n","prefixes":[]}