{"id":2232524,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2232524/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260504161145.2217950-1-holger.brunck@hitachienergy.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.1/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<20260504161145.2217950-1-holger.brunck@hitachienergy.com>","date":"2026-05-04T16:11:45","name":"[net] net: wan: fsl_ucc_hdlc: free tx_skbuff in uhdlc_memclean","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ef62a157e771923b39d855047b85d8dd3b0da242","submitter":{"id":82682,"url":"http://patchwork.ozlabs.org/api/1.1/people/82682/?format=json","name":"Holger Brunck","email":"holger.brunck@hitachienergy.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260504161145.2217950-1-holger.brunck@hitachienergy.com/mbox/","series":[{"id":502694,"url":"http://patchwork.ozlabs.org/api/1.1/series/502694/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=502694","date":"2026-05-04T16:11:45","name":"[net] net: wan: fsl_ucc_hdlc: free tx_skbuff in uhdlc_memclean","version":1,"mbox":"http://patchwork.ozlabs.org/series/502694/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232524/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2232524/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=duo-1630306886989-947ac67a header.b=L4rVJzon;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org\n header.a=rsa-sha256 header.s=dkim-high header.b=nhwwqAIS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20428-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=18.158.144.38","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=duo-1630306886989-947ac67a header.b=L4rVJzon;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org\n header.a=rsa-sha256 header.s=dkim-high header.b=nhwwqAIS;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=hitachienergy.com\n (client-ip=18.158.144.38; helo=out-ip0052.fra.mailhop.org;\n envelope-from=holger.brunck@hitachienergy.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8RWk6wSCz1yJV\n\tfor ; Tue, 05 May 2026 02:13:06 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g8RWj6kpWz2yZ6;\n\tTue, 05 May 2026 02:13:05 +1000 (AEST)","from out-ip0052.fra.mailhop.org (out-ip0052.fra.mailhop.org\n [18.158.144.38])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g8RWj0n7Rz2xS2\n\tfor ; Tue, 05 May 2026 02:13:04 +1000 (AEST)","from HPG0000000548.corp.hitachi-powergrids.com (unknown\n [20.62.140.138])\n\tby outbound3.eu.mailhop.org (Halon) with ESMTPSA\n\tid f42d5b33-47d3-11f1-8ef4-f54febe22707;\n\tMon, 04 May 2026 16:11:49 +0000 (UTC)","from gitsiv.hitachienergy.com (unknown [10.54.139.14])\n\tby HPG0000000548.corp.hitachi-powergrids.com (Postfix) with ESMTP id\n 22E611359;\n\tMon, 4 May 2026 16:11:48 +0000 (UTC)","from chbrn3-p-dev015.keymile.net (chbrn3-p-dev015.keymile.net\n [172.31.41.201])\n\tby gitsiv.hitachienergy.com (Postfix) with ESMTP id 9A24960B7D47;\n\tMon, 4 May 2026 18:11:47 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777911185;\n\tcv=none;\n b=imxke7GdeKr3sIlEZ1YCe3QAkQeaP3oZn40bf4HZu/NZIkCzHOwJBpdS5GZAcGw4TMAV7fc2hpjkKid/Yqg7cQKWz91AN/Mo+ROeY9np3Z+d79Ho/nn7kDQbyTfLnOclbPR7V8r2R57FmHZn2xoD7mtu72sJ8BFdjSoj77DBX357Pv6vAvMBr61YY4M7UNqV/eB74RGrA01oVQTfkbvMw+PRTmiyfoaVoYwdjPpOakR8e6Tf7MJ6hpDGmPJyhnEmohhEZtscvyJkDRdP1k/V5KaBDJYF508WyqtdJQn618lmZV3J86E60QVwtPzrzGT/3ibLly0dFoDxXfTfWHNcSQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777911185; c=relaxed/relaxed;\n\tbh=9orVYHdnXQuOz2avZekPiqkyjnG9PMJehPUQET09zII=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=N9zvveST9pufDmJGWVeuGSWR4W4DZfaMBv76NXWVW935p18oQwy3eSGV9KpJysnNJzsHRpdfhQzgYMu+8CwpMidOb0gBf08IfalM5RUMr55UWs60KXshK3fe+ly+AZyhW0/witaGlid3CLq++gbIsOS8ZeISh/TfQ9bIjts8AxPoKTSBVEGvFO3rLDx/JTCoHaM/fTki3EuO8HcpZbMQbMmSpm4GdXoZgrkR+J2y+lNj0uYOIXIvET4sYrhbQi6DlpeSyOJZkZSg8tcoCTdSpbgm0iv9KqwcbvFoq0P1qA/M7WbKIXyjn1spY+nhD82m8tBn/B8UCcAzfMZWRDerZg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com;\n dkim=pass (1024-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=duo-1630306886989-947ac67a header.b=L4rVJzon;\n dkim=pass (2048-bit key;\n unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org\n header.a=rsa-sha256 header.s=dkim-high header.b=nhwwqAIS; dkim-atps=neutral;\n spf=pass (client-ip=18.158.144.38; helo=out-ip0052.fra.mailhop.org;\n envelope-from=holger.brunck@hitachienergy.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=hitachienergy.com","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=hitachienergy.com; s=duo-1630306886989-947ac67a;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc:to:from:\n\t cfbl-address:cfbl-feedback-id:from;\n\tbh=9orVYHdnXQuOz2avZekPiqkyjnG9PMJehPUQET09zII=;\n\tb=L4rVJzonX/wd7VGUtHCwS3CXy6fXgi1BAQ9HfkXgyoegw0jJQg9qZZFEG7SJg0advoY2ORJA/1tvb\n\t Lyq0zhfhnerx2LrcNATSvNMqhiwu0oH6425fg4jeMoJtN41UZTF+IbkFmuryx+n9q49oYdTomtUE/r\n\t 4N89RKUlfEpB6rYs=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=outbound.mailhop.org; s=dkim-high;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc:to:from:\n\t cfbl-address:cfbl-feedback-id:from;\n\tbh=9orVYHdnXQuOz2avZekPiqkyjnG9PMJehPUQET09zII=;\n\tb=nhwwqAIS/lTWLBZ0NcvrdoMYI7ZZ6Uf7IotFc/lzK0bTlkVfZEGyWnfgvS0nPTkx5KcePzaid7Pa3\n\t C/TR+sfg6qr9aASz1RwpAbMNR/JsdMosIVinGjbCpD5Ujxkes50ri0h4Xj9cn+VXGY3KlBhSb2a8wF\n\t TZKmyWTysuVpg5dpDPcYqS+0CF+Jzycsco3ZM7S3k6F5pLbM7iLQVhXE1sUz48PUTjiADzSFR0etr3\n\t FPvOuji0weLyFlRDi81qvESxdqY6ILI0q31FYXDNmOI4neqkXQEeCvvwxIv5Y9LnJ9sme0p0hqHA8y\n\t uETHDiIPObaMxFLOAw99MVr4UEP5DIQ=="],"X-Originating-IP":"20.62.140.138","X-MHO-RoutePath":"aGVkY3NtdHA=","X-MHO-User":"f42d5b33-47d3-11f1-8ef4-f54febe22707","X-Report-Abuse-To":"\n https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information","X-Mail-Handler":"DuoCircle Outbound SMTP","CFBL-Feedback-ID":"f42d5b33-47d3-11f1-8ef4-f54febe22707:7","CFBL-Address":"prvs=058485b737=abuse@outbound.mailhop.org; report=arf","From":"Holger Brunck ","To":"netdev@vger.kernel.org","Cc":"linuxppc-dev@lists.ozlabs.org,\n\tandrew+netdev@lunn.ch,\n\tchleroy@kernel.org,\n\tqiang.zhao@nxp.com,\n\thorms@kernel.org,\n\tHolger Brunck ","Subject":"[PATCH net] net: wan: fsl_ucc_hdlc: free tx_skbuff in uhdlc_memclean","Date":"Mon, 4 May 2026 18:11:45 +0200","Message-ID":"<20260504161145.2217950-1-holger.brunck@hitachienergy.com>","X-Mailer":"git-send-email 2.52.0.120.gb31ab939fe","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"When cleaning up the resources we need to iterate over the\ntx_skbuf array to free pending TX messages.\n\nFixes: c19b6d246a35 (\"drivers/net: support hdlc function for QE-UCC\")\nSigned-off-by: Holger Brunck \n---\n drivers/net/wan/fsl_ucc_hdlc.c | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c\nindex adf3863463f5..68f78aeabdc3 100644\n--- a/drivers/net/wan/fsl_ucc_hdlc.c\n+++ b/drivers/net/wan/fsl_ucc_hdlc.c\n@@ -739,6 +739,8 @@ static int uhdlc_open(struct net_device *dev)\n \n static void uhdlc_memclean(struct ucc_hdlc_private *priv)\n {\n+\tint i;\n+\n \tqe_muram_free(ioread16be(&priv->ucc_pram->riptr));\n \tqe_muram_free(ioread16be(&priv->ucc_pram->tiptr));\n \n@@ -769,6 +771,11 @@ static void uhdlc_memclean(struct ucc_hdlc_private *priv)\n \tkfree(priv->rx_skbuff);\n \tpriv->rx_skbuff = NULL;\n \n+\tfor (i = 0; i < TX_BD_RING_LEN) {\n+\t\tkfree(priv->tx_skbuff[i]);\n+\t\tpriv->tx_skbuff[i] = NULL;\n+\t}\n+\n \tkfree(priv->tx_skbuff);\n \tpriv->tx_skbuff = NULL;\n \n","prefixes":["net"]}